[PATCH v2 25/29] tests/acceptance/virtio_check_params: Require a virtio-scsi-pci device

Philippe Mathieu-Daudé posted 29 patches 6 years ago
Only 28 patches received!
[PATCH v2 25/29] tests/acceptance/virtio_check_params: Require a virtio-scsi-pci device
Posted by Philippe Mathieu-Daudé 6 years ago
When running this test with QEMU configured using
--without-default-devices, we get:

  ERROR: qemu-system-s390x: -device virtio-scsi-pci,id=scsi0: 'virtio-scsi-pci' is not a valid device model name

To be able to run the acceptance tests with a binary built using
--without-default-devices, add a 'device' tag. The Test::setUp()
method will verify the device is available, else cancel (skip)
the test.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/virtio_check_params.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py
index 3466aa5b32..95a9048786 100755
--- a/tests/acceptance/virtio_check_params.py
+++ b/tests/acceptance/virtio_check_params.py
@@ -44,6 +44,9 @@ VM_DEV_PARAMS = {'virtio-scsi-pci': ['-device', 'virtio-scsi-pci,id=scsi0'],
 
 
 class VirtioMaxSegSettingsCheck(Test):
+    """
+    :avocado: tags=device:virtio-scsi-pci
+    """
     @staticmethod
     def make_pattern(props):
         pattern_items = ['{0} = \w+'.format(prop) for prop in props]
-- 
2.21.1