On 1/29/20 10:23 PM, Philippe Mathieu-Daudé wrote:
> Add logging for easier debugging of failures:
>
> $ avocado --show=machine run tests/acceptance/virtio_check_params.py
> (1/1) tests/acceptance/virtio_check_params.py:VirtioMaxSegSettingsCheck.test_machine_types:
> machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
> machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
> machine: {'name': 'pc-q35-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
> machine: {'name': 'pc-i440fx-2.5', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
> machine: {'name': 'pc-i440fx-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
> ...
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/virtio_check_params.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/virtio_check_params.py b/tests/acceptance/virtio_check_params.py
> index 51a2dd76e8..f679b0eec7 100755
> --- a/tests/acceptance/virtio_check_params.py
> +++ b/tests/acceptance/virtio_check_params.py
> @@ -21,6 +21,7 @@
> import sys
> import os
> import re
> +import logging
>
> sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
> from qemu.machine import QEMUMachine
> @@ -73,6 +74,9 @@ class VirtioMaxSegSettingsCheck(Test):
> return query_ok, props, error
>
> def check_mt(self, mt, dev_type_name):
> + mt['device'] = dev_type_name # Only for the debug() call.
> + logger = logging.getLogger('machine')
> + logger.debug(mt)
> with QEMUMachine(self.qemu_bin) as vm:
> vm.set_machine(mt["name"])
> for s in VM_DEV_PARAMS[dev_type_name]:
>
Thanks, applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next