hw/hppa/Kconfig: LASI chipset requires PARALLEL port

[PATCH] hw/hppa/Kconfig: LASI chipset requires PARALLEL port

Philippe Mathieu-Daudé posted 1 patch 5 years, 9 months ago

Download mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200129192350.27143-1-philmd@redhat.com

Maintainers: Richard Henderson <rth@twiddle.net>, Helge Deller <deller@gmx.de>

hw/hppa/Kconfig | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/hppa/Kconfig: LASI chipset requires PARALLEL port

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

The PARISC Lasi chipset emulation requires some of the common parallel
support and fails to build on a --without-default-devices:

    LINK    hppa-softmmu/qemu-system-hppa
  /usr/bin/ld: hw/hppa/lasi.o: in function `lasi_init':
  hw/hppa/lasi.c:324: undefined reference to `parallel_mm_init'
  collect2: error: ld returned 1 exit status
  make[1]: *** [Makefile:206: qemu-system-hppa] Error 1

Fixes: 376b851909d
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/hppa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index 82178c7dcb..22948db025 100644
--- a/hw/hppa/Kconfig
+++ b/hw/hppa/Kconfig
@@ -12,4 +12,5 @@ config DINO
     select LSI_SCSI_PCI
     select LASI_82596
     select LASIPS2
+    select PARALLEL
     select ARTIST
-- 
2.21.1

Re: [PATCH] hw/hppa/Kconfig: LASI chipset requires PARALLEL port

Posted by Helge Deller 5 years, 9 months ago

On 29.01.20 20:23, Philippe Mathieu-Daudé wrote:
> The PARISC Lasi chipset emulation requires some of the common parallel
> support and fails to build on a --without-default-devices:
>
>     LINK    hppa-softmmu/qemu-system-hppa
>   /usr/bin/ld: hw/hppa/lasi.o: in function `lasi_init':
>   hw/hppa/lasi.c:324: undefined reference to `parallel_mm_init'
>   collect2: error: ld returned 1 exit status
>   make[1]: *** [Makefile:206: qemu-system-hppa] Error 1
>
> Fixes: 376b851909d
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Acked-by: Helge Deller <deller@gmx.de>

> ---
>  hw/hppa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
> index 82178c7dcb..22948db025 100644
> --- a/hw/hppa/Kconfig
> +++ b/hw/hppa/Kconfig
> @@ -12,4 +12,5 @@ config DINO
>      select LSI_SCSI_PCI
>      select LASI_82596
>      select LASIPS2
> +    select PARALLEL
>      select ARTIST
>