default-configs: add CONFIG_PARALLEL to hppa-softmmu

[PATCH] default-configs: add CONFIG_PARALLEL to hppa-softmmu

Alex Bennée posted 1 patch 5 years, 9 months ago

Download mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200129182804.19284-1-alex.bennee@linaro.org

default-configs/hppa-softmmu.mak | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] default-configs: add CONFIG_PARALLEL to hppa-softmmu

Posted by Alex Bennée 5 years, 9 months ago

The PARISC Lasi chipset emulation requires some of the common parallel
support and fails to build on a --without-default-devices. I am
assuming the chipset emulation is non-optional for the HPPA case.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 default-configs/hppa-softmmu.mak | 1 +
 1 file changed, 1 insertion(+)

diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak
index b64c5eb3ff..9083ce8634 100644
--- a/default-configs/hppa-softmmu.mak
+++ b/default-configs/hppa-softmmu.mak
@@ -3,6 +3,7 @@
 # Uncomment the following lines to disable these optional devices:
 #
 #CONFIG_PCI_DEVICES=n
+CONFIG_PARALLEL=y
 
 # Boards:
 #
-- 
2.20.1

Re: [PATCH] default-configs: add CONFIG_PARALLEL to hppa-softmmu

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

Hi Alex,

On 1/29/20 7:28 PM, Alex Bennée wrote:
> The PARISC Lasi chipset emulation requires some of the common parallel
> support and fails to build on a --without-default-devices. I am
> assuming the chipset emulation is non-optional for the HPPA case.
 >

Fixes: 376b851909d

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   default-configs/hppa-softmmu.mak | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak
> index b64c5eb3ff..9083ce8634 100644
> --- a/default-configs/hppa-softmmu.mak
> +++ b/default-configs/hppa-softmmu.mak
> @@ -3,6 +3,7 @@
>   # Uncomment the following lines to disable these optional devices:
>   #
>   #CONFIG_PCI_DEVICES=n
> +CONFIG_PARALLEL=y

We now use Kconfig :)

CONFIG_DINO=y pulls from hw/hppa/Kconfig:

config DINO
     bool
     imply PCI_DEVICES
     imply E1000_PCI
     imply VIRTIO_VGA
     select PCI
     select SERIAL
     select ISA_BUS
     select I8259
     select IDE_CMD646
     select MC146818RTC
     select LSI_SCSI_PCI
     select LASI_82596
     select LASIPS2
     select ARTIST

The fix is:

-- >8 --
diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index 82178c7dcb..22948db025 100644
--- a/hw/hppa/Kconfig
+++ b/hw/hppa/Kconfig
@@ -12,4 +12,5 @@ config DINO
      select LSI_SCSI_PCI
      select LASI_82596
      select LASIPS2
+    select PARALLEL
      select ARTIST
---

Btw I suggested Sven to use a different config for LASI:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg667945.html