[PATCH v1 0/4] Increase default virtqueue size to improve performance

Denis Plotnikov posted 4 patches 5 years, 9 months ago
Only 3 patches received!
hw/block/virtio-blk.c                         |  6 ++--
hw/core/machine.c                             |  3 ++
hw/scsi/virtio-scsi.c                         |  5 +--
include/hw/virtio/virtio.h                    |  1 +
...g_max_adjust.py => virtio_check_params.py} | 33 ++++++++++++-------
5 files changed, 32 insertions(+), 16 deletions(-)
rename tests/acceptance/{virtio_seg_max_adjust.py => virtio_check_params.py} (79%)
[PATCH v1 0/4] Increase default virtqueue size to improve performance
Posted by Denis Plotnikov 5 years, 9 months ago
The goal is to increase the performance of the block layer on
1M reads/writes up to 4% by reducing the amount of requests issued by a guest
using virtio-scsi or virtio-blk devices.

Original problem description:
https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html


Denis Plotnikov (4):
  virtio: introduce VIRTQUEUE_DEFUALT_SIZE instead of hardcoded
    constants
  virtio: increase virtuqueue size for virtio-scsi and virtio-blk
  tests: add virtuqueue size checking to virtio_seg_max_adjust test
  tests: rename virtio_seg_max_adjust to virtio_check_params

 hw/block/virtio-blk.c                         |  6 ++--
 hw/core/machine.c                             |  3 ++
 hw/scsi/virtio-scsi.c                         |  5 +--
 include/hw/virtio/virtio.h                    |  1 +
 ...g_max_adjust.py => virtio_check_params.py} | 33 ++++++++++++-------
 5 files changed, 32 insertions(+), 16 deletions(-)
 rename tests/acceptance/{virtio_seg_max_adjust.py => virtio_check_params.py} (79%)

-- 
2.17.0


[PATCH v1 4/4] tests: rename virtio_seg_max_adjust to virtio_check_params
Posted by Denis Plotnikov 5 years, 9 months ago
Since, virtio_seg_max_adjust checks not only seg_max, but also
virtqueue_size parameter, let's make the test more general and
add new parameters to be checked there in the future.

Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
 .../{virtio_seg_max_adjust.py => virtio_check_params.py}          | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tests/acceptance/{virtio_seg_max_adjust.py => virtio_check_params.py} (100%)

diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_check_params.py
similarity index 100%
rename from tests/acceptance/virtio_seg_max_adjust.py
rename to tests/acceptance/virtio_check_params.py
-- 
2.17.0


Re: [PATCH v1 4/4] tests: rename virtio_seg_max_adjust to virtio_check_params
Posted by Philippe Mathieu-Daudé 4 years, 2 months ago
On 1/29/20 3:07 PM, Denis Plotnikov wrote:
> Since, virtio_seg_max_adjust checks not only seg_max, but also
> virtqueue_size parameter, let's make the test more general and
> add new parameters to be checked there in the future.
> 
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
> ---
>  .../{virtio_seg_max_adjust.py => virtio_check_params.py}          | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tests/acceptance/{virtio_seg_max_adjust.py => virtio_check_params.py} (100%)

Old one... reminds me of
https://lore.kernel.org/qemu-devel/20200129212345.20547-1-philmd@redhat.com/
:~(

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>