[v3] monitor: Refactoring in preparation for qemu-storage-daemon

[PATCH v3 0/4] monitor: Refactoring in preparation for qemu-storage-daemon

Kevin Wolf posted 4 patches 4 years, 3 months ago

Diff against v1 v2
Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200129102239.31435-1-kwolf@redhat.com

Maintainers: Michael Roth <mdroth@linux.vnet.ibm.com>, Laurent Vivier <lvivier@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Thomas Huth <thuth@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Eric Blake <eblake@redhat.com>

qapi/control.json          | 218 +++++++++++++++++++++++++++++++++++++
qapi/misc.json             | 212 ------------------------------------
qapi/qapi-schema.json      |   1 +
include/monitor/monitor.h  |   3 +
include/sysemu/sysemu.h    |   1 -
monitor/monitor-internal.h |   4 +
monitor/hmp-cmds.c         |   1 +
monitor/misc.c             | 127 +--------------------
monitor/monitor.c          |  48 ++++++++
monitor/qmp-cmds-control.c | 169 ++++++++++++++++++++++++++++
monitor/qmp-cmds.c         |  15 +--
monitor/qmp.c              |   2 +-
tests/qtest/qmp-test.c     |   2 +-
ui/gtk.c                   |   1 +
vl.c                       |  45 +-------
monitor/Makefile.objs      |   3 +-
qapi/Makefile.objs         |   6 +-
17 files changed, 455 insertions(+), 403 deletions(-)
create mode 100644 qapi/control.json
create mode 100644 monitor/qmp-cmds-control.c

Expand all Fold all

[PATCH v3 0/4] monitor: Refactoring in preparation for qemu-storage-daemon

Posted by Kevin Wolf 4 years, 3 months ago

This series creates a QAPI module 'control' that can be used from tools
outside the system emulator and moves some monitor initialisation code
from vl.c to monitor code.

It is split from the series to introduce qemu-storage-daemon because
these refactorings make sense on their own as cleanups.

v3:
- Cleaned up #include [Markus]
- Changed schema documenttion headline [Markus]
- Changes comments according to review [Markus]

v2:
- Removed allow_hmp parameter from monitor_init_opts() [Markus]
- Renamed monitor.json to control.json [Markus]

Kevin Wolf (4):
  monitor: Move monitor option parsing to monitor/monitor.c
  qapi: Create module 'control'
  monitor: Create monitor/qmp-cmds-control.c
  monitor: Move qmp_query_qmp_schema to qmp-cmds-control.c

 qapi/control.json          | 218 +++++++++++++++++++++++++++++++++++++
 qapi/misc.json             | 212 ------------------------------------
 qapi/qapi-schema.json      |   1 +
 include/monitor/monitor.h  |   3 +
 include/sysemu/sysemu.h    |   1 -
 monitor/monitor-internal.h |   4 +
 monitor/hmp-cmds.c         |   1 +
 monitor/misc.c             | 127 +--------------------
 monitor/monitor.c          |  48 ++++++++
 monitor/qmp-cmds-control.c | 169 ++++++++++++++++++++++++++++
 monitor/qmp-cmds.c         |  15 +--
 monitor/qmp.c              |   2 +-
 tests/qtest/qmp-test.c     |   2 +-
 ui/gtk.c                   |   1 +
 vl.c                       |  45 +-------
 monitor/Makefile.objs      |   3 +-
 qapi/Makefile.objs         |   6 +-
 17 files changed, 455 insertions(+), 403 deletions(-)
 create mode 100644 qapi/control.json
 create mode 100644 monitor/qmp-cmds-control.c

-- 
2.20.1