target/s390x: Do not leak stack address in translate_one

[PATCH 0/5] target/s390x: Do not leak stack address in translate_one

Richard Henderson posted 5 patches 5 years, 9 months ago

Download series mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200123232248.1800-1-richard.henderson@linaro.org

Maintainers: Richard Henderson <rth@twiddle.net>, Cornelia Huck <cohuck@redhat.com>, David Hildenbrand <david@redhat.com>

target/s390x/translate.c        | 982 ++++++++++++++++----------------
target/s390x/translate_vx.inc.c | 649 +++++++++++----------
2 files changed, 813 insertions(+), 818 deletions(-)

Expand all Fold all

[PATCH 0/5] target/s390x: Do not leak stack address in translate_one

Posted by Richard Henderson 5 years, 9 months ago

Thomas' patch avoids the leak, but I think we can do a bit more to
cleaning in this area, and move the structure inline to DisasContext.


r~


Richard Henderson (5):
  target/s390x: Move struct DisasFields definition earlier
  target/s390x: Remove DisasFields argument from callbacks
  target/s390x: Pass DisasContext to get_field and have_field
  target/s390x: Move DisasFields into DisasContext
  target/s390x: Remove DisasFields argument from extract_insn

 target/s390x/translate.c        | 982 ++++++++++++++++----------------
 target/s390x/translate_vx.inc.c | 649 +++++++++++----------
 2 files changed, 813 insertions(+), 818 deletions(-)

-- 
2.20.1

Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one

Posted by Cornelia Huck 5 years, 9 months ago

On Thu, 23 Jan 2020 13:22:43 -1000
Richard Henderson <richard.henderson@linaro.org> wrote:

> Thomas' patch avoids the leak, but I think we can do a bit more to
> cleaning in this area, and move the structure inline to DisasContext.
> 
> 
> r~
> 
> 
> Richard Henderson (5):
>   target/s390x: Move struct DisasFields definition earlier
>   target/s390x: Remove DisasFields argument from callbacks
>   target/s390x: Pass DisasContext to get_field and have_field
>   target/s390x: Move DisasFields into DisasContext
>   target/s390x: Remove DisasFields argument from extract_insn
> 
>  target/s390x/translate.c        | 982 ++++++++++++++++----------------
>  target/s390x/translate_vx.inc.c | 649 +++++++++++----------
>  2 files changed, 813 insertions(+), 818 deletions(-)
> 

Thanks, applied.

Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one

Posted by Thomas Huth 5 years, 9 months ago

On 24/01/2020 00.22, Richard Henderson wrote:
> Thomas' patch avoids the leak, but I think we can do a bit more to
> cleaning in this area, and move the structure inline to DisasContext.
>
Sounds like a good idea to me. Cornelia, could you please replace my
patch with Richard's series?

 Thanks,
  Thomas

Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one

Posted by Cornelia Huck 5 years, 9 months ago

On Fri, 24 Jan 2020 10:43:32 +0100
Thomas Huth <thuth@redhat.com> wrote:

> On 24/01/2020 00.22, Richard Henderson wrote:
> > Thomas' patch avoids the leak, but I think we can do a bit more to
> > cleaning in this area, and move the structure inline to DisasContext.
> >  
> Sounds like a good idea to me. Cornelia, could you please replace my
> patch with Richard's series?

Yes, that sounds good. Dropped your patch in favour of this series.