stm32f4xx_syscfg: remove redundant code to fix coverity warning

[PATCH] stm32f4xx_syscfg: remove redundant code to fix coverity warning

pannengyuan@huawei.com posted 1 patch 4 years, 3 months ago

Download mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200123023845.20980-1-pannengyuan@huawei.com

Maintainers: Alistair Francis <alistair@alistair23.me>, Peter Maydell <peter.maydell@linaro.org>

hw/misc/stm32f4xx_syscfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] stm32f4xx_syscfg: remove redundant code to fix coverity warning

Posted by pannengyuan@huawei.com 4 years, 3 months ago

From: Pan Nengyuan <pannengyuan@huawei.com>

Fixes the coverity warning:
    CID 91708242: (EVALUATION_ORDER)
    50. write_write_typo: In "config = config = irq / 16", "config" is written twice with the same value.
    50    uint8_t config = config = irq / 16;

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
 hw/misc/stm32f4xx_syscfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
index dbcdca59f8..f960e4ea1e 100644
--- a/hw/misc/stm32f4xx_syscfg.c
+++ b/hw/misc/stm32f4xx_syscfg.c
@@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
     STM32F4xxSyscfgState *s = opaque;
     int icrreg = irq / 4;
     int startbit = (irq & 3) * 4;
-    uint8_t config = config = irq / 16;
+    uint8_t config = irq / 16;
 
     trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
 
-- 
2.21.0.windows.1

Re: [PATCH] stm32f4xx_syscfg: remove redundant code to fix coverity warning

Posted by Thomas Huth 4 years, 3 months ago

On 23/01/2020 03.38, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
> 
> Fixes the coverity warning:
>     CID 91708242: (EVALUATION_ORDER)
>     50. write_write_typo: In "config = config = irq / 16", "config" is written twice with the same value.
>     50    uint8_t config = config = irq / 16;
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
>  hw/misc/stm32f4xx_syscfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
>      STM32F4xxSyscfgState *s = opaque;
>      int icrreg = irq / 4;
>      int startbit = (irq & 3) * 4;
> -    uint8_t config = config = irq / 16;
> +    uint8_t config = irq / 16;

Thanks, but Philippe already posted a patch for this :

https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04823.html

 Thomas