[PATCH v4 0/6] Fix multifd + cancel + multifd

Juan Quintela posted 6 patches 4 years, 3 months ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200122111517.33223-1-quintela@redhat.com
Maintainers: Juan Quintela <quintela@redhat.com>, Laurent Vivier <lvivier@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
migration/migration.c        |  29 +++++++--
migration/migration.h        |   1 +
migration/qemu-file.c        |  22 ++++++-
migration/ram.c              |  23 ++++---
migration/savevm.c           |   4 +-
tests/qtest/migration-test.c | 114 ++++++++++++++++++++++++++++++++++-
6 files changed, 173 insertions(+), 20 deletions(-)
[PATCH v4 0/6] Fix multifd + cancel + multifd
Posted by Juan Quintela 4 years, 3 months ago
Hi

In the v4 series:
* Updated to latest pull request
* redo the check for active migration at the end of the iteration stage
* testing/testing/testing it now passes the test for multifd + cancel
  hundred of times in a row
* Use g_free consistently

Please review, Juan.

In the v3 series:
- Add back the ->shutdown fix
  Dave found the problem, we need to setup an error if we do shutdown.
- Make iotests to work back (we need to setup ->active for savevm)
- So postcopy/recovery is fixed again.

Please review, if there are not outstanding issues, I plan to push it.

Thanks, Juan

In the v2 series:
- get the multifd test patch
- drop the ->shutdown fix
  it break postcopy recovery test.  Still trying to determine if the
  problem is inside the recover test or the recover code.
- upgrade the migrate_cancel test

Please review.

[v1]
This series:
- create a test that does:
  launch multifd on target
  migrate to target
  cancel on source
  create another target
  migrate again

- And fixes the cases that made it fail:
* Make sure that we don't try ever IO after shutdown/error

Please, review.

Juan Quintela (6):
  migration-test: Use g_free() instead of free()
  multifd: Make sure that we don't do any IO after an error
  qemu-file: Don't do IO after shutdown
  migration-test: Make sure that multifd and cancel works
  migration: Create migration_is_running()
  migration: Don't send data if we have stopped

 migration/migration.c        |  29 +++++++--
 migration/migration.h        |   1 +
 migration/qemu-file.c        |  22 ++++++-
 migration/ram.c              |  23 ++++---
 migration/savevm.c           |   4 +-
 tests/qtest/migration-test.c | 114 ++++++++++++++++++++++++++++++++++-
 6 files changed, 173 insertions(+), 20 deletions(-)

-- 
2.24.1