1. Patchew
  2. QEMU
  3. View series

[PATCH] vhost: coding style fix

Michael S. Tsirkin posted 1 patch 6 years ago
Failed in applying to current master (apply log)
hw/virtio/vhost.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] vhost: coding style fix
Posted by Michael S. Tsirkin 6 years ago 
Drop a trailing whitespace. Make line shorter.

Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/vhost.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 25fd469179..9edfadc81d 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
     trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
                                    mrs_host);
 
-    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   
+    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
         /* Round the section to it's page size */
         /* First align the start down to a page boundary */
         size_t mrs_page = qemu_ram_pagesize(mrs_rb);
@@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
         if (alignage) {
             mrs_size += mrs_page - alignage;
         }
-        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
-                                               mrs_host);
+        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
+                                               mrs_size, mrs_host);
     }
 
     if (dev->n_tmp_sections) {
-- 
MST
Re: [PATCH] vhost: coding style fix
Posted by Dr. David Alan Gilbert 6 years ago 
* Michael S. Tsirkin (mst@redhat.com) wrote:
> Drop a trailing whitespace. Make line shorter.
> 
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Oops apologies for that.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hw/virtio/vhost.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>      trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
>                                     mrs_host);
>  
> -    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
>          /* Round the section to it's page size */
>          /* First align the start down to a page boundary */
>          size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>          if (alignage) {
>              mrs_size += mrs_page - alignage;
>          }
> -        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> -                                               mrs_host);
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> +                                               mrs_size, mrs_host);
>      }
>  
>      if (dev->n_tmp_sections) {
> -- 
> MST
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Re: [PATCH] vhost: coding style fix
Posted by Wainer dos Santos Moschetta 6 years ago 
On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> Drop a trailing whitespace. Make line shorter.


hmmm... wondering why Patchew didn't catch that. Any idea?

- Wainer

>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   hw/virtio/vhost.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>       trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
>                                      mrs_host);
>   
> -    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
>           /* Round the section to it's page size */
>           /* First align the start down to a page boundary */
>           size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>           if (alignage) {
>               mrs_size += mrs_page - alignage;
>           }
> -        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> -                                               mrs_host);
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> +                                               mrs_size, mrs_host);
>       }
>   
>       if (dev->n_tmp_sections) {
Re: [PATCH] vhost: coding style fix
Posted by Michael S. Tsirkin 6 years ago 
On Wed, Jan 22, 2020 at 11:06:53AM -0200, Wainer dos Santos Moschetta wrote:
> 
> On 1/22/20 6:08 AM, Michael S. Tsirkin wrote:
> > Drop a trailing whitespace. Make line shorter.
> 
> 
> hmmm... wondering why Patchew didn't catch that. Any idea?
> 
> - Wainer

It did.

> > 
> > Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   hw/virtio/vhost.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 25fd469179..9edfadc81d 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> >       trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
> >                                      mrs_host);
> > -    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> > +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
> >           /* Round the section to it's page size */
> >           /* First align the start down to a page boundary */
> >           size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> > @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
> >           if (alignage) {
> >               mrs_size += mrs_page - alignage;
> >           }
> > -        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> > -                                               mrs_host);
> > +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> > +                                               mrs_size, mrs_host);
> >       }
> >       if (dev->n_tmp_sections) {
Re: [PATCH] vhost: coding style fix
Posted by Stefan Hajnoczi 6 years ago 
On Wed, Jan 22, 2020 at 03:08:49AM -0500, Michael S. Tsirkin wrote:
> Drop a trailing whitespace. Make line shorter.
> 
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/virtio/vhost.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Re: [PATCH] vhost: coding style fix
Posted by Alex Bennée 6 years ago 
Michael S. Tsirkin <mst@redhat.com> writes:

> Drop a trailing whitespace. Make line shorter.
>
> Fixes: 76525114736e8 ("vhost: Only align sections for vhost-user")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  hw/virtio/vhost.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 25fd469179..9edfadc81d 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -551,7 +551,7 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>      trace_vhost_region_add_section(section->mr->name, mrs_gpa, mrs_size,
>                                     mrs_host);
>  
> -    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {
>          /* Round the section to it's page size */
>          /* First align the start down to a page boundary */
>          size_t mrs_page = qemu_ram_pagesize(mrs_rb);
> @@ -566,8 +566,8 @@ static void vhost_region_add_section(struct vhost_dev *dev,
>          if (alignage) {
>              mrs_size += mrs_page - alignage;
>          }
> -        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
> -                                               mrs_host);
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa,
> +                                               mrs_size, mrs_host);
>      }
>  
>      if (dev->n_tmp_sections) {


-- 
Alex Bennée

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.