qemu-img: Fix convert -n -B for backing-less targets

[PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

Max Reitz posted 2 patches 6 years ago

Download series mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200121155915.98232-1-mreitz@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

qemu-img.c                 |  2 +-
tests/qemu-iotests/122     | 14 ++++++++++++++
tests/qemu-iotests/122.out |  5 +++++
3 files changed, 20 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

Posted by Max Reitz 6 years ago

Hi,

When reviewing David’s series to add --target-is-zero convert, I looked
for a case to show that the current implementation will crash if
-n --target-is-zero is used together with -B.  It then turned out that
-B will always crash when combined with -n and the target image does not
have a backing file set in its image header.

This series fixes that.


Max Reitz (2):
  qemu-img: Fix convert -n -B for backing-less targets
  iotests: Test convert -n -B to backing-less target

 qemu-img.c                 |  2 +-
 tests/qemu-iotests/122     | 14 ++++++++++++++
 tests/qemu-iotests/122.out |  5 +++++
 3 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.24.1

Re: [PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

Posted by John Snow 6 years ago


On 1/21/20 10:59 AM, Max Reitz wrote:
> Hi,
> 
> When reviewing David’s series to add --target-is-zero convert, I looked
> for a case to show that the current implementation will crash if
> -n --target-is-zero is used together with -B.  It then turned out that
> -B will always crash when combined with -n and the target image does not
> have a backing file set in its image header.
> 
> This series fixes that.
> 
> 
> Max Reitz (2):
>   qemu-img: Fix convert -n -B for backing-less targets
>   iotests: Test convert -n -B to backing-less target
> 
>  qemu-img.c                 |  2 +-
>  tests/qemu-iotests/122     | 14 ++++++++++++++
>  tests/qemu-iotests/122.out |  5 +++++
>  3 files changed, 20 insertions(+), 1 deletion(-)
> 

Hello.
Makes sense to me.

Reviewed-by: John Snow <jsnow@redhat.com>

(My brain had an awfully tumultuous 35 seconds comprehending that
"is_new" was not a synonym for "-n was provided", but actually means the
opposite.)

Re: [PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

Posted by Max Reitz 5 years, 11 months ago

On 21.01.20 16:59, Max Reitz wrote:
> Hi,
> 
> When reviewing David’s series to add --target-is-zero convert, I looked
> for a case to show that the current implementation will crash if
> -n --target-is-zero is used together with -B.  It then turned out that
> -B will always crash when combined with -n and the target image does not
> have a backing file set in its image header.
> 
> This series fixes that.

Thanks for the review, applied to my block branch.

Max