[PATCH v2 00/10] Cleanups around the 'current_machine' global variable

Philippe Mathieu-Daudé posted 10 patches 4 years, 3 months ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200121110349.25842-1-philmd@redhat.com
Maintainers: David Gibson <david@gibson.dropbear.id.au>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Cornelia Huck <cohuck@redhat.com>, David Hildenbrand <david@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>
include/sysemu/accel.h     | 2 ++
accel/accel.c              | 5 +++++
accel/kvm/kvm-all.c        | 4 ++--
accel/tcg/tcg-all.c        | 8 ++++----
hw/core/qdev.c             | 1 +
hw/ppc/spapr_rtas.c        | 9 ++++-----
memory.c                   | 2 +-
qom/object.c               | 6 +++++-
target/arm/kvm.c           | 4 +---
target/arm/kvm64.c         | 5 ++---
target/i386/kvm.c          | 2 +-
target/ppc/kvm.c           | 2 +-
target/s390x/excp_helper.c | 7 +++----
vl.c                       | 2 +-
14 files changed, 33 insertions(+), 26 deletions(-)
[PATCH v2 00/10] Cleanups around the 'current_machine' global variable
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
v1 was "Replace current_machine by qdev_get_machine()":
https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html

But Markus objected, see:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html
and older discussion:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html

This series salvage patches from v1, and add other trivial cleanups.

Can the ARM/PPC/S390 patches could go via their own tree, and the
rest via Paolo's 'misc' tree?

Supersedes: <20200109152133.23649-1-philmd@redhat.com>

Philippe Mathieu-Daudé (10):
  hw/ppc/spapr_rtas: Use local MachineState variable
  hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument
  hw/ppc/spapr_rtas: Remove local variable
  target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported()
  target/s390x: Remove duplicated ifdef macro
  qom/object: Display more helpful message when a parent is missing
  qdev: Abort if the root machine container is missing
  accel: Introduce the current_accel() wrapper
  accel: Replace current_machine->accelerator by current_accel() wrapper
  accel/tcg: Sanitize include path

 include/sysemu/accel.h     | 2 ++
 accel/accel.c              | 5 +++++
 accel/kvm/kvm-all.c        | 4 ++--
 accel/tcg/tcg-all.c        | 8 ++++----
 hw/core/qdev.c             | 1 +
 hw/ppc/spapr_rtas.c        | 9 ++++-----
 memory.c                   | 2 +-
 qom/object.c               | 6 +++++-
 target/arm/kvm.c           | 4 +---
 target/arm/kvm64.c         | 5 ++---
 target/i386/kvm.c          | 2 +-
 target/ppc/kvm.c           | 2 +-
 target/s390x/excp_helper.c | 7 +++----
 vl.c                       | 2 +-
 14 files changed, 33 insertions(+), 26 deletions(-)

-- 
2.21.1


Re: [PATCH v2 00/10] Cleanups around the 'current_machine' global variable
Posted by Markus Armbruster 4 years, 3 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> v1 was "Replace current_machine by qdev_get_machine()":
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html
>
> But Markus objected, see:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html
> and older discussion:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html
>
> This series salvage patches from v1, and add other trivial cleanups.
>
> Can the ARM/PPC/S390 patches could go via their own tree, and the
> rest via Paolo's 'misc' tree?
>
> Supersedes: <20200109152133.23649-1-philmd@redhat.com>

Separating off uncontroversial patches is always a good idea.  These all
look okay to me on first glance, with one minor remark on PATCH 7.  I
think you got or are likely to get competent review for all of them.  If
you need me to have a closer look, just ask.

Thanks!


Re: [PATCH v2 00/10] Cleanups around the 'current_machine' global variable
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
On 1/21/20 1:47 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
>> v1 was "Replace current_machine by qdev_get_machine()":
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html
>>
>> But Markus objected, see:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html
>> and older discussion:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html
>>
>> This series salvage patches from v1, and add other trivial cleanups.
>>
>> Can the ARM/PPC/S390 patches could go via their own tree, and the
>> rest via Paolo's 'misc' tree?
>>
>> Supersedes: <20200109152133.23649-1-philmd@redhat.com>
> 
> Separating off uncontroversial patches is always a good idea.  These all
> look okay to me on first glance, with one minor remark on PATCH 7.  I
> think you got or are likely to get competent review for all of them.  If
> you need me to have a closer look, just ask.

Good :) Thanks!


Re: [PATCH v2 00/10] Cleanups around the 'current_machine' global variable
Posted by Paolo Bonzini 4 years, 3 months ago
On 21/01/20 12:03, Philippe Mathieu-Daudé wrote:
> v1 was "Replace current_machine by qdev_get_machine()":
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html
> 
> But Markus objected, see:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html
> and older discussion:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html
> 
> This series salvage patches from v1, and add other trivial cleanups.
> 
> Can the ARM/PPC/S390 patches could go via their own tree, and the
> rest via Paolo's 'misc' tree?

I think they're trivial enough so (with the exception of patch 7) I have
queued them.

Paolo


Re: [PATCH v2 00/10] Cleanups around the 'current_machine' global variable
Posted by Cornelia Huck 4 years, 3 months ago
On Tue, 21 Jan 2020 17:27:09 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 21/01/20 12:03, Philippe Mathieu-Daudé wrote:
> > v1 was "Replace current_machine by qdev_get_machine()":
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html
> > 
> > But Markus objected, see:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html
> > and older discussion:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html
> > 
> > This series salvage patches from v1, and add other trivial cleanups.
> > 
> > Can the ARM/PPC/S390 patches could go via their own tree, and the
> > rest via Paolo's 'misc' tree?  
> 
> I think they're trivial enough so (with the exception of patch 7) I have
> queued them.

I had already queued the s390 patch; let's just see who gets their pull
req out first, I can also unqueue it again.