1 | Latest arm queue, a mixed bag of features and bug fixes. | 1 | Small pile of bug fixes for rc1. I've included my patches to get |
---|---|---|---|
2 | our docs building with Sphinx 3, just for convenience... | ||
2 | 3 | ||
3 | thanks | ||
4 | -- PMM | 4 | -- PMM |
5 | 5 | ||
6 | The following changes since commit cbf01142b2aef0c0b4e995cecd7e79d342bbc47e: | 6 | The following changes since commit b149dea55cce97cb226683d06af61984a1c11e96: |
7 | 7 | ||
8 | Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20200115' into staging (2020-01-17 12:13:17 +0000) | 8 | Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20201102' into staging (2020-11-02 10:57:48 +0000) |
9 | 9 | ||
10 | are available in the Git repository at: | 10 | are available in the Git repository at: |
11 | 11 | ||
12 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200117-1 | 12 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201102 |
13 | 13 | ||
14 | for you to fetch changes up to 1a1fbc6cbb34c26d43d8360c66c1d21681af14a9: | 14 | for you to fetch changes up to ffb4fbf90a2f63c9cb33e4bb9f854c79bf04ca4a: |
15 | 15 | ||
16 | target/arm: Set ISSIs16Bit in make_issinfo (2020-01-17 14:27:16 +0000) | 16 | tests/qtest/npcm7xx_rng-test: Disable randomness tests (2020-11-02 16:52:18 +0000) |
17 | 17 | ||
18 | ---------------------------------------------------------------- | 18 | ---------------------------------------------------------------- |
19 | Add model of the Netduino Plus 2 board | 19 | target-arm queue: |
20 | Some allwinner-a10 code cleanup | 20 | * target/arm: Fix Neon emulation bugs on big-endian hosts |
21 | New test cases for cubieboard | 21 | * target/arm: fix handling of HCR.FB |
22 | target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle | 22 | * target/arm: fix LORID_EL1 access check |
23 | i.MX: add an emulation for RNGC device | 23 | * disas/capstone: Fix monitor disassembly of >32 bytes |
24 | target/arm: adjust program counter for wfi exception in AArch32 | 24 | * hw/arm/smmuv3: Fix potential integer overflow (CID 1432363) |
25 | arm/gicv3: update virtual irq state after IAR register read | 25 | * hw/arm/boot: fix SVE for EL3 direct kernel boot |
26 | Set IL bit correctly for syndrome information for data aborts | 26 | * hw/display/omap_lcdc: Fix potential NULL pointer dereference |
27 | * hw/display/exynos4210_fimd: Fix potential NULL pointer dereference | ||
28 | * target/arm: Get correct MMU index for other-security-state | ||
29 | * configure: Test that gio libs from pkg-config work | ||
30 | * hw/intc/arm_gicv3_cpuif: Make GIC maintenance interrupts work | ||
31 | * docs: Fix building with Sphinx 3 | ||
32 | * tests/qtest/npcm7xx_rng-test: Disable randomness tests | ||
27 | 33 | ||
28 | ---------------------------------------------------------------- | 34 | ---------------------------------------------------------------- |
29 | Alistair Francis (4): | 35 | AlexChen (2): |
30 | hw/misc: Add the STM32F4xx Sysconfig device | 36 | hw/display/omap_lcdc: Fix potential NULL pointer dereference |
31 | hw/misc: Add the STM32F4xx EXTI device | 37 | hw/display/exynos4210_fimd: Fix potential NULL pointer dereference |
32 | hw/arm: Add the STM32F4xx SoC | ||
33 | hw/arm: Add the Netduino Plus 2 | ||
34 | 38 | ||
35 | Jeff Kubascik (3): | 39 | Peter Maydell (9): |
36 | target/arm: adjust program counter for wfi exception in AArch32 | 40 | target/arm: Fix float16 pairwise Neon ops on big-endian hosts |
37 | arm/gicv3: update virtual irq state after IAR register read | 41 | target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts |
38 | target/arm: Return correct IL bit in merge_syn_data_abort | 42 | disas/capstone: Fix monitor disassembly of >32 bytes |
43 | target/arm: Get correct MMU index for other-security-state | ||
44 | configure: Test that gio libs from pkg-config work | ||
45 | hw/intc/arm_gicv3_cpuif: Make GIC maintenance interrupts work | ||
46 | scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments | ||
47 | qemu-option-trace.rst.inc: Don't use option:: markup | ||
48 | tests/qtest/npcm7xx_rng-test: Disable randomness tests | ||
39 | 49 | ||
40 | Martin Kaiser (1): | 50 | Philippe Mathieu-Daudé (1): |
41 | i.MX: add an emulation for RNGC | 51 | hw/arm/smmuv3: Fix potential integer overflow (CID 1432363) |
42 | 52 | ||
43 | Masahiro Yamada (1): | 53 | Richard Henderson (11): |
44 | target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle | 54 | target/arm: Introduce neon_full_reg_offset |
55 | target/arm: Move neon_element_offset to translate.c | ||
56 | target/arm: Use neon_element_offset in neon_load/store_reg | ||
57 | target/arm: Use neon_element_offset in vfp_reg_offset | ||
58 | target/arm: Add read/write_neon_element32 | ||
59 | target/arm: Expand read/write_neon_element32 to all MemOp | ||
60 | target/arm: Rename neon_load_reg32 to vfp_load_reg32 | ||
61 | target/arm: Add read/write_neon_element64 | ||
62 | target/arm: Rename neon_load_reg64 to vfp_load_reg64 | ||
63 | target/arm: Simplify do_long_3d and do_2scalar_long | ||
64 | target/arm: Improve do_prewiden_3d | ||
45 | 65 | ||
46 | Philippe Mathieu-Daudé (5): | 66 | Rémi Denis-Courmont (3): |
47 | tests/boot_linux_console: Add initrd test for the CubieBoard | 67 | target/arm: fix handling of HCR.FB |
48 | tests/boot_linux_console: Add a SD card test for the CubieBoard | 68 | target/arm: fix LORID_EL1 access check |
49 | hw/arm/allwinner-a10: Move SoC definitions out of header | 69 | hw/arm/boot: fix SVE for EL3 direct kernel boot |
50 | hw/arm/allwinner-a10: Simplify by passing IRQs with qdev_pass_gpios() | ||
51 | hw/arm/allwinner-a10: Remove local qemu_irq variables | ||
52 | 70 | ||
53 | Richard Henderson (1): | 71 | docs/qemu-option-trace.rst.inc | 6 +- |
54 | target/arm: Set ISSIs16Bit in make_issinfo | 72 | configure | 10 +- |
73 | include/hw/intc/arm_gicv3_common.h | 1 - | ||
74 | disas/capstone.c | 2 +- | ||
75 | hw/arm/boot.c | 3 + | ||
76 | hw/arm/smmuv3.c | 3 +- | ||
77 | hw/display/exynos4210_fimd.c | 4 +- | ||
78 | hw/display/omap_lcdc.c | 10 +- | ||
79 | hw/intc/arm_gicv3_cpuif.c | 5 +- | ||
80 | target/arm/helper.c | 24 +- | ||
81 | target/arm/m_helper.c | 3 +- | ||
82 | target/arm/translate.c | 153 +++++++++--- | ||
83 | target/arm/vec_helper.c | 12 +- | ||
84 | tests/qtest/npcm7xx_rng-test.c | 14 +- | ||
85 | scripts/kernel-doc | 18 +- | ||
86 | target/arm/translate-neon.c.inc | 472 ++++++++++++++++++++----------------- | ||
87 | target/arm/translate-vfp.c.inc | 341 +++++++++++---------------- | ||
88 | 17 files changed, 588 insertions(+), 493 deletions(-) | ||
55 | 89 | ||
56 | hw/arm/Makefile.objs | 2 + | ||
57 | hw/misc/Makefile.objs | 3 + | ||
58 | include/hw/arm/allwinner-a10.h | 7 - | ||
59 | include/hw/arm/fsl-imx25.h | 5 + | ||
60 | include/hw/arm/stm32f405_soc.h | 73 ++++++++ | ||
61 | include/hw/misc/imx_rngc.h | 35 ++++ | ||
62 | include/hw/misc/stm32f4xx_exti.h | 60 +++++++ | ||
63 | include/hw/misc/stm32f4xx_syscfg.h | 61 +++++++ | ||
64 | hw/arm/allwinner-a10.c | 39 +++-- | ||
65 | hw/arm/fsl-imx25.c | 11 ++ | ||
66 | hw/arm/netduinoplus2.c | 52 ++++++ | ||
67 | hw/arm/stm32f405_soc.c | 302 +++++++++++++++++++++++++++++++++ | ||
68 | hw/intc/arm_gicv3_cpuif.c | 3 + | ||
69 | hw/misc/imx_rngc.c | 278 ++++++++++++++++++++++++++++++ | ||
70 | hw/misc/stm32f4xx_exti.c | 188 ++++++++++++++++++++ | ||
71 | hw/misc/stm32f4xx_syscfg.c | 171 +++++++++++++++++++ | ||
72 | target/arm/arm-semi.c | 5 +- | ||
73 | target/arm/op_helper.c | 7 +- | ||
74 | target/arm/tlb_helper.c | 2 +- | ||
75 | target/arm/translate.c | 3 + | ||
76 | MAINTAINERS | 14 ++ | ||
77 | default-configs/arm-softmmu.mak | 1 + | ||
78 | hw/arm/Kconfig | 10 ++ | ||
79 | hw/misc/Kconfig | 6 + | ||
80 | hw/misc/trace-events | 11 ++ | ||
81 | tests/acceptance/boot_linux_console.py | 85 ++++++++++ | ||
82 | 26 files changed, 1405 insertions(+), 29 deletions(-) | ||
83 | create mode 100644 include/hw/arm/stm32f405_soc.h | ||
84 | create mode 100644 include/hw/misc/imx_rngc.h | ||
85 | create mode 100644 include/hw/misc/stm32f4xx_exti.h | ||
86 | create mode 100644 include/hw/misc/stm32f4xx_syscfg.h | ||
87 | create mode 100644 hw/arm/netduinoplus2.c | ||
88 | create mode 100644 hw/arm/stm32f405_soc.c | ||
89 | create mode 100644 hw/misc/imx_rngc.c | ||
90 | create mode 100644 hw/misc/stm32f4xx_exti.c | ||
91 | create mode 100644 hw/misc/stm32f4xx_syscfg.c | ||
92 | diff view generated by jsdifflib |
1 | From: Alistair Francis <alistair@alistair23.me> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Alistair Francis <alistair@alistair23.me> | 3 | This function makes it clear that we're talking about the whole |
4 | register, and not the 32-bit piece at index 0. This fixes a bug | ||
5 | when running on a big-endian host. | ||
6 | |||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
8 | Message-id: 20201030022618.785675-2-richard.henderson@linaro.org | ||
4 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Message-id: ef941d59fd8658589d34ed432e1d6dfdcf7fb1d0.1576658572.git.alistair@alistair23.me | ||
6 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
8 | --- | 11 | --- |
9 | hw/misc/Makefile.objs | 1 + | 12 | target/arm/translate.c | 8 ++++++ |
10 | include/hw/misc/stm32f4xx_exti.h | 60 ++++++++++ | 13 | target/arm/translate-neon.c.inc | 44 ++++++++++++++++----------------- |
11 | hw/misc/stm32f4xx_exti.c | 188 +++++++++++++++++++++++++++++++ | 14 | target/arm/translate-vfp.c.inc | 2 +- |
12 | hw/arm/Kconfig | 1 + | 15 | 3 files changed, 31 insertions(+), 23 deletions(-) |
13 | hw/misc/Kconfig | 3 + | ||
14 | hw/misc/trace-events | 5 + | ||
15 | 6 files changed, 258 insertions(+) | ||
16 | create mode 100644 include/hw/misc/stm32f4xx_exti.h | ||
17 | create mode 100644 hw/misc/stm32f4xx_exti.c | ||
18 | 16 | ||
19 | diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs | 17 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
20 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
21 | --- a/hw/misc/Makefile.objs | 19 | --- a/target/arm/translate.c |
22 | +++ b/hw/misc/Makefile.objs | 20 | +++ b/target/arm/translate.c |
23 | @@ -XXX,XX +XXX,XX @@ common-obj-$(CONFIG_ZYNQ) += zynq_slcr.o | 21 | @@ -XXX,XX +XXX,XX @@ static inline void gen_hlt(DisasContext *s, int imm) |
24 | common-obj-$(CONFIG_ZYNQ) += zynq-xadc.o | 22 | unallocated_encoding(s); |
25 | common-obj-$(CONFIG_STM32F2XX_SYSCFG) += stm32f2xx_syscfg.o | 23 | } |
26 | common-obj-$(CONFIG_STM32F4XX_SYSCFG) += stm32f4xx_syscfg.o | 24 | |
27 | +common-obj-$(CONFIG_STM32F4XX_EXTI) += stm32f4xx_exti.o | ||
28 | obj-$(CONFIG_MIPS_CPS) += mips_cmgcr.o | ||
29 | obj-$(CONFIG_MIPS_CPS) += mips_cpc.o | ||
30 | obj-$(CONFIG_MIPS_ITU) += mips_itu.o | ||
31 | diff --git a/include/hw/misc/stm32f4xx_exti.h b/include/hw/misc/stm32f4xx_exti.h | ||
32 | new file mode 100644 | ||
33 | index XXXXXXX..XXXXXXX | ||
34 | --- /dev/null | ||
35 | +++ b/include/hw/misc/stm32f4xx_exti.h | ||
36 | @@ -XXX,XX +XXX,XX @@ | ||
37 | +/* | 25 | +/* |
38 | + * STM32F4XX EXTI | 26 | + * Return the offset of a "full" NEON Dreg. |
39 | + * | ||
40 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
41 | + * | ||
42 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
43 | + * of this software and associated documentation files (the "Software"), to deal | ||
44 | + * in the Software without restriction, including without limitation the rights | ||
45 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
46 | + * copies of the Software, and to permit persons to whom the Software is | ||
47 | + * furnished to do so, subject to the following conditions: | ||
48 | + * | ||
49 | + * The above copyright notice and this permission notice shall be included in | ||
50 | + * all copies or substantial portions of the Software. | ||
51 | + * | ||
52 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
53 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
54 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
55 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
56 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
57 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
58 | + * THE SOFTWARE. | ||
59 | + */ | 27 | + */ |
60 | + | 28 | +static long neon_full_reg_offset(unsigned reg) |
61 | +#ifndef HW_STM_EXTI_H | ||
62 | +#define HW_STM_EXTI_H | ||
63 | + | ||
64 | +#include "hw/sysbus.h" | ||
65 | +#include "hw/hw.h" | ||
66 | + | ||
67 | +#define EXTI_IMR 0x00 | ||
68 | +#define EXTI_EMR 0x04 | ||
69 | +#define EXTI_RTSR 0x08 | ||
70 | +#define EXTI_FTSR 0x0C | ||
71 | +#define EXTI_SWIER 0x10 | ||
72 | +#define EXTI_PR 0x14 | ||
73 | + | ||
74 | +#define TYPE_STM32F4XX_EXTI "stm32f4xx-exti" | ||
75 | +#define STM32F4XX_EXTI(obj) \ | ||
76 | + OBJECT_CHECK(STM32F4xxExtiState, (obj), TYPE_STM32F4XX_EXTI) | ||
77 | + | ||
78 | +#define NUM_GPIO_EVENT_IN_LINES 16 | ||
79 | +#define NUM_INTERRUPT_OUT_LINES 16 | ||
80 | + | ||
81 | +typedef struct { | ||
82 | + SysBusDevice parent_obj; | ||
83 | + | ||
84 | + MemoryRegion mmio; | ||
85 | + | ||
86 | + uint32_t exti_imr; | ||
87 | + uint32_t exti_emr; | ||
88 | + uint32_t exti_rtsr; | ||
89 | + uint32_t exti_ftsr; | ||
90 | + uint32_t exti_swier; | ||
91 | + uint32_t exti_pr; | ||
92 | + | ||
93 | + qemu_irq irq[NUM_INTERRUPT_OUT_LINES]; | ||
94 | +} STM32F4xxExtiState; | ||
95 | + | ||
96 | +#endif | ||
97 | diff --git a/hw/misc/stm32f4xx_exti.c b/hw/misc/stm32f4xx_exti.c | ||
98 | new file mode 100644 | ||
99 | index XXXXXXX..XXXXXXX | ||
100 | --- /dev/null | ||
101 | +++ b/hw/misc/stm32f4xx_exti.c | ||
102 | @@ -XXX,XX +XXX,XX @@ | ||
103 | +/* | ||
104 | + * STM32F4XX EXTI | ||
105 | + * | ||
106 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
107 | + * | ||
108 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
109 | + * of this software and associated documentation files (the "Software"), to deal | ||
110 | + * in the Software without restriction, including without limitation the rights | ||
111 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
112 | + * copies of the Software, and to permit persons to whom the Software is | ||
113 | + * furnished to do so, subject to the following conditions: | ||
114 | + * | ||
115 | + * The above copyright notice and this permission notice shall be included in | ||
116 | + * all copies or substantial portions of the Software. | ||
117 | + * | ||
118 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
119 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
120 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
121 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
122 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
123 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
124 | + * THE SOFTWARE. | ||
125 | + */ | ||
126 | + | ||
127 | +#include "qemu/osdep.h" | ||
128 | +#include "qemu/log.h" | ||
129 | +#include "trace.h" | ||
130 | +#include "hw/irq.h" | ||
131 | +#include "migration/vmstate.h" | ||
132 | +#include "hw/misc/stm32f4xx_exti.h" | ||
133 | + | ||
134 | +static void stm32f4xx_exti_reset(DeviceState *dev) | ||
135 | +{ | 29 | +{ |
136 | + STM32F4xxExtiState *s = STM32F4XX_EXTI(dev); | 30 | + return offsetof(CPUARMState, vfp.zregs[reg >> 1].d[reg & 1]); |
137 | + | ||
138 | + s->exti_imr = 0x00000000; | ||
139 | + s->exti_emr = 0x00000000; | ||
140 | + s->exti_rtsr = 0x00000000; | ||
141 | + s->exti_ftsr = 0x00000000; | ||
142 | + s->exti_swier = 0x00000000; | ||
143 | + s->exti_pr = 0x00000000; | ||
144 | +} | 31 | +} |
145 | + | 32 | + |
146 | +static void stm32f4xx_exti_set_irq(void *opaque, int irq, int level) | 33 | static inline long vfp_reg_offset(bool dp, unsigned reg) |
147 | +{ | 34 | { |
148 | + STM32F4xxExtiState *s = opaque; | 35 | if (dp) { |
149 | + | 36 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc |
150 | + trace_stm32f4xx_exti_set_irq(irq, level); | ||
151 | + | ||
152 | + if (((1 << irq) & s->exti_rtsr) && level) { | ||
153 | + /* Rising Edge */ | ||
154 | + s->exti_pr |= 1 << irq; | ||
155 | + } | ||
156 | + | ||
157 | + if (((1 << irq) & s->exti_ftsr) && !level) { | ||
158 | + /* Falling Edge */ | ||
159 | + s->exti_pr |= 1 << irq; | ||
160 | + } | ||
161 | + | ||
162 | + if (!((1 << irq) & s->exti_imr)) { | ||
163 | + /* Interrupt is masked */ | ||
164 | + return; | ||
165 | + } | ||
166 | + qemu_irq_pulse(s->irq[irq]); | ||
167 | +} | ||
168 | + | ||
169 | +static uint64_t stm32f4xx_exti_read(void *opaque, hwaddr addr, | ||
170 | + unsigned int size) | ||
171 | +{ | ||
172 | + STM32F4xxExtiState *s = opaque; | ||
173 | + | ||
174 | + trace_stm32f4xx_exti_read(addr); | ||
175 | + | ||
176 | + switch (addr) { | ||
177 | + case EXTI_IMR: | ||
178 | + return s->exti_imr; | ||
179 | + case EXTI_EMR: | ||
180 | + return s->exti_emr; | ||
181 | + case EXTI_RTSR: | ||
182 | + return s->exti_rtsr; | ||
183 | + case EXTI_FTSR: | ||
184 | + return s->exti_ftsr; | ||
185 | + case EXTI_SWIER: | ||
186 | + return s->exti_swier; | ||
187 | + case EXTI_PR: | ||
188 | + return s->exti_pr; | ||
189 | + default: | ||
190 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
191 | + "STM32F4XX_exti_read: Bad offset %x\n", (int)addr); | ||
192 | + return 0; | ||
193 | + } | ||
194 | + return 0; | ||
195 | +} | ||
196 | + | ||
197 | +static void stm32f4xx_exti_write(void *opaque, hwaddr addr, | ||
198 | + uint64_t val64, unsigned int size) | ||
199 | +{ | ||
200 | + STM32F4xxExtiState *s = opaque; | ||
201 | + uint32_t value = (uint32_t) val64; | ||
202 | + | ||
203 | + trace_stm32f4xx_exti_write(addr, value); | ||
204 | + | ||
205 | + switch (addr) { | ||
206 | + case EXTI_IMR: | ||
207 | + s->exti_imr = value; | ||
208 | + return; | ||
209 | + case EXTI_EMR: | ||
210 | + s->exti_emr = value; | ||
211 | + return; | ||
212 | + case EXTI_RTSR: | ||
213 | + s->exti_rtsr = value; | ||
214 | + return; | ||
215 | + case EXTI_FTSR: | ||
216 | + s->exti_ftsr = value; | ||
217 | + return; | ||
218 | + case EXTI_SWIER: | ||
219 | + s->exti_swier = value; | ||
220 | + return; | ||
221 | + case EXTI_PR: | ||
222 | + /* This bit is cleared by writing a 1 to it */ | ||
223 | + s->exti_pr &= ~value; | ||
224 | + return; | ||
225 | + default: | ||
226 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
227 | + "STM32F4XX_exti_write: Bad offset %x\n", (int)addr); | ||
228 | + } | ||
229 | +} | ||
230 | + | ||
231 | +static const MemoryRegionOps stm32f4xx_exti_ops = { | ||
232 | + .read = stm32f4xx_exti_read, | ||
233 | + .write = stm32f4xx_exti_write, | ||
234 | + .endianness = DEVICE_NATIVE_ENDIAN, | ||
235 | +}; | ||
236 | + | ||
237 | +static void stm32f4xx_exti_init(Object *obj) | ||
238 | +{ | ||
239 | + STM32F4xxExtiState *s = STM32F4XX_EXTI(obj); | ||
240 | + int i; | ||
241 | + | ||
242 | + for (i = 0; i < NUM_INTERRUPT_OUT_LINES; i++) { | ||
243 | + sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq[i]); | ||
244 | + } | ||
245 | + | ||
246 | + memory_region_init_io(&s->mmio, obj, &stm32f4xx_exti_ops, s, | ||
247 | + TYPE_STM32F4XX_EXTI, 0x400); | ||
248 | + sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); | ||
249 | + | ||
250 | + qdev_init_gpio_in(DEVICE(obj), stm32f4xx_exti_set_irq, | ||
251 | + NUM_GPIO_EVENT_IN_LINES); | ||
252 | +} | ||
253 | + | ||
254 | +static const VMStateDescription vmstate_stm32f4xx_exti = { | ||
255 | + .name = TYPE_STM32F4XX_EXTI, | ||
256 | + .version_id = 1, | ||
257 | + .minimum_version_id = 1, | ||
258 | + .fields = (VMStateField[]) { | ||
259 | + VMSTATE_UINT32(exti_imr, STM32F4xxExtiState), | ||
260 | + VMSTATE_UINT32(exti_emr, STM32F4xxExtiState), | ||
261 | + VMSTATE_UINT32(exti_rtsr, STM32F4xxExtiState), | ||
262 | + VMSTATE_UINT32(exti_ftsr, STM32F4xxExtiState), | ||
263 | + VMSTATE_UINT32(exti_swier, STM32F4xxExtiState), | ||
264 | + VMSTATE_UINT32(exti_pr, STM32F4xxExtiState), | ||
265 | + VMSTATE_END_OF_LIST() | ||
266 | + } | ||
267 | +}; | ||
268 | + | ||
269 | +static void stm32f4xx_exti_class_init(ObjectClass *klass, void *data) | ||
270 | +{ | ||
271 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
272 | + | ||
273 | + dc->reset = stm32f4xx_exti_reset; | ||
274 | + dc->vmsd = &vmstate_stm32f4xx_exti; | ||
275 | +} | ||
276 | + | ||
277 | +static const TypeInfo stm32f4xx_exti_info = { | ||
278 | + .name = TYPE_STM32F4XX_EXTI, | ||
279 | + .parent = TYPE_SYS_BUS_DEVICE, | ||
280 | + .instance_size = sizeof(STM32F4xxExtiState), | ||
281 | + .instance_init = stm32f4xx_exti_init, | ||
282 | + .class_init = stm32f4xx_exti_class_init, | ||
283 | +}; | ||
284 | + | ||
285 | +static void stm32f4xx_exti_register_types(void) | ||
286 | +{ | ||
287 | + type_register_static(&stm32f4xx_exti_info); | ||
288 | +} | ||
289 | + | ||
290 | +type_init(stm32f4xx_exti_register_types) | ||
291 | diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig | ||
292 | index XXXXXXX..XXXXXXX 100644 | 37 | index XXXXXXX..XXXXXXX 100644 |
293 | --- a/hw/arm/Kconfig | 38 | --- a/target/arm/translate-neon.c.inc |
294 | +++ b/hw/arm/Kconfig | 39 | +++ b/target/arm/translate-neon.c.inc |
295 | @@ -XXX,XX +XXX,XX @@ config STM32F405_SOC | 40 | @@ -XXX,XX +XXX,XX @@ neon_element_offset(int reg, int element, MemOp size) |
296 | bool | 41 | ofs ^= 8 - element_size; |
297 | select ARM_V7M | 42 | } |
298 | select STM32F4XX_SYSCFG | 43 | #endif |
299 | + select STM32F4XX_EXTI | 44 | - return neon_reg_offset(reg, 0) + ofs; |
300 | 45 | + return neon_full_reg_offset(reg) + ofs; | |
301 | config XLNX_ZYNQMP_ARM | 46 | } |
302 | bool | 47 | |
303 | diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig | 48 | static void neon_load_element(TCGv_i32 var, int reg, int ele, MemOp mop) |
49 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLD_all_lanes(DisasContext *s, arg_VLD_all_lanes *a) | ||
50 | * We cannot write 16 bytes at once because the | ||
51 | * destination is unaligned. | ||
52 | */ | ||
53 | - tcg_gen_gvec_dup_i32(size, neon_reg_offset(vd, 0), | ||
54 | + tcg_gen_gvec_dup_i32(size, neon_full_reg_offset(vd), | ||
55 | 8, 8, tmp); | ||
56 | - tcg_gen_gvec_mov(0, neon_reg_offset(vd + 1, 0), | ||
57 | - neon_reg_offset(vd, 0), 8, 8); | ||
58 | + tcg_gen_gvec_mov(0, neon_full_reg_offset(vd + 1), | ||
59 | + neon_full_reg_offset(vd), 8, 8); | ||
60 | } else { | ||
61 | - tcg_gen_gvec_dup_i32(size, neon_reg_offset(vd, 0), | ||
62 | + tcg_gen_gvec_dup_i32(size, neon_full_reg_offset(vd), | ||
63 | vec_size, vec_size, tmp); | ||
64 | } | ||
65 | tcg_gen_addi_i32(addr, addr, 1 << size); | ||
66 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDST_single(DisasContext *s, arg_VLDST_single *a) | ||
67 | static bool do_3same(DisasContext *s, arg_3same *a, GVecGen3Fn fn) | ||
68 | { | ||
69 | int vec_size = a->q ? 16 : 8; | ||
70 | - int rd_ofs = neon_reg_offset(a->vd, 0); | ||
71 | - int rn_ofs = neon_reg_offset(a->vn, 0); | ||
72 | - int rm_ofs = neon_reg_offset(a->vm, 0); | ||
73 | + int rd_ofs = neon_full_reg_offset(a->vd); | ||
74 | + int rn_ofs = neon_full_reg_offset(a->vn); | ||
75 | + int rm_ofs = neon_full_reg_offset(a->vm); | ||
76 | |||
77 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
78 | return false; | ||
79 | @@ -XXX,XX +XXX,XX @@ static bool do_vector_2sh(DisasContext *s, arg_2reg_shift *a, GVecGen2iFn *fn) | ||
80 | { | ||
81 | /* Handle a 2-reg-shift insn which can be vectorized. */ | ||
82 | int vec_size = a->q ? 16 : 8; | ||
83 | - int rd_ofs = neon_reg_offset(a->vd, 0); | ||
84 | - int rm_ofs = neon_reg_offset(a->vm, 0); | ||
85 | + int rd_ofs = neon_full_reg_offset(a->vd); | ||
86 | + int rm_ofs = neon_full_reg_offset(a->vm); | ||
87 | |||
88 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
89 | return false; | ||
90 | @@ -XXX,XX +XXX,XX @@ static bool do_fp_2sh(DisasContext *s, arg_2reg_shift *a, | ||
91 | { | ||
92 | /* FP operations in 2-reg-and-shift group */ | ||
93 | int vec_size = a->q ? 16 : 8; | ||
94 | - int rd_ofs = neon_reg_offset(a->vd, 0); | ||
95 | - int rm_ofs = neon_reg_offset(a->vm, 0); | ||
96 | + int rd_ofs = neon_full_reg_offset(a->vd); | ||
97 | + int rm_ofs = neon_full_reg_offset(a->vm); | ||
98 | TCGv_ptr fpst; | ||
99 | |||
100 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
101 | @@ -XXX,XX +XXX,XX @@ static bool do_1reg_imm(DisasContext *s, arg_1reg_imm *a, | ||
102 | return true; | ||
103 | } | ||
104 | |||
105 | - reg_ofs = neon_reg_offset(a->vd, 0); | ||
106 | + reg_ofs = neon_full_reg_offset(a->vd); | ||
107 | vec_size = a->q ? 16 : 8; | ||
108 | imm = asimd_imm_const(a->imm, a->cmode, a->op); | ||
109 | |||
110 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMULL_P_3d(DisasContext *s, arg_3diff *a) | ||
111 | return true; | ||
112 | } | ||
113 | |||
114 | - tcg_gen_gvec_3_ool(neon_reg_offset(a->vd, 0), | ||
115 | - neon_reg_offset(a->vn, 0), | ||
116 | - neon_reg_offset(a->vm, 0), | ||
117 | + tcg_gen_gvec_3_ool(neon_full_reg_offset(a->vd), | ||
118 | + neon_full_reg_offset(a->vn), | ||
119 | + neon_full_reg_offset(a->vm), | ||
120 | 16, 16, 0, fn_gvec); | ||
121 | return true; | ||
122 | } | ||
123 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar_fp_vec(DisasContext *s, arg_2scalar *a, | ||
124 | { | ||
125 | /* Two registers and a scalar, using gvec */ | ||
126 | int vec_size = a->q ? 16 : 8; | ||
127 | - int rd_ofs = neon_reg_offset(a->vd, 0); | ||
128 | - int rn_ofs = neon_reg_offset(a->vn, 0); | ||
129 | + int rd_ofs = neon_full_reg_offset(a->vd); | ||
130 | + int rn_ofs = neon_full_reg_offset(a->vn); | ||
131 | int rm_ofs; | ||
132 | int idx; | ||
133 | TCGv_ptr fpstatus; | ||
134 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar_fp_vec(DisasContext *s, arg_2scalar *a, | ||
135 | /* a->vm is M:Vm, which encodes both register and index */ | ||
136 | idx = extract32(a->vm, a->size + 2, 2); | ||
137 | a->vm = extract32(a->vm, 0, a->size + 2); | ||
138 | - rm_ofs = neon_reg_offset(a->vm, 0); | ||
139 | + rm_ofs = neon_full_reg_offset(a->vm); | ||
140 | |||
141 | fpstatus = fpstatus_ptr(a->size == 1 ? FPST_STD_F16 : FPST_STD); | ||
142 | tcg_gen_gvec_3_ptr(rd_ofs, rn_ofs, rm_ofs, fpstatus, | ||
143 | @@ -XXX,XX +XXX,XX @@ static bool trans_VDUP_scalar(DisasContext *s, arg_VDUP_scalar *a) | ||
144 | return true; | ||
145 | } | ||
146 | |||
147 | - tcg_gen_gvec_dup_mem(a->size, neon_reg_offset(a->vd, 0), | ||
148 | + tcg_gen_gvec_dup_mem(a->size, neon_full_reg_offset(a->vd), | ||
149 | neon_element_offset(a->vm, a->index, a->size), | ||
150 | a->q ? 16 : 8, a->q ? 16 : 8); | ||
151 | return true; | ||
152 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_F32_F16(DisasContext *s, arg_2misc *a) | ||
153 | static bool do_2misc_vec(DisasContext *s, arg_2misc *a, GVecGen2Fn *fn) | ||
154 | { | ||
155 | int vec_size = a->q ? 16 : 8; | ||
156 | - int rd_ofs = neon_reg_offset(a->vd, 0); | ||
157 | - int rm_ofs = neon_reg_offset(a->vm, 0); | ||
158 | + int rd_ofs = neon_full_reg_offset(a->vd); | ||
159 | + int rm_ofs = neon_full_reg_offset(a->vm); | ||
160 | |||
161 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
162 | return false; | ||
163 | diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc | ||
304 | index XXXXXXX..XXXXXXX 100644 | 164 | index XXXXXXX..XXXXXXX 100644 |
305 | --- a/hw/misc/Kconfig | 165 | --- a/target/arm/translate-vfp.c.inc |
306 | +++ b/hw/misc/Kconfig | 166 | +++ b/target/arm/translate-vfp.c.inc |
307 | @@ -XXX,XX +XXX,XX @@ config STM32F2XX_SYSCFG | 167 | @@ -XXX,XX +XXX,XX @@ static bool trans_VDUP(DisasContext *s, arg_VDUP *a) |
308 | config STM32F4XX_SYSCFG | 168 | } |
309 | bool | 169 | |
310 | 170 | tmp = load_reg(s, a->rt); | |
311 | +config STM32F4XX_EXTI | 171 | - tcg_gen_gvec_dup_i32(size, neon_reg_offset(a->vn, 0), |
312 | + bool | 172 | + tcg_gen_gvec_dup_i32(size, neon_full_reg_offset(a->vn), |
313 | + | 173 | vec_size, vec_size, tmp); |
314 | config MIPS_ITU | 174 | tcg_temp_free_i32(tmp); |
315 | bool | 175 | |
316 | |||
317 | diff --git a/hw/misc/trace-events b/hw/misc/trace-events | ||
318 | index XXXXXXX..XXXXXXX 100644 | ||
319 | --- a/hw/misc/trace-events | ||
320 | +++ b/hw/misc/trace-events | ||
321 | @@ -XXX,XX +XXX,XX @@ stm32f4xx_pulse_exti(int irq) "Pulse EXTI: %d" | ||
322 | stm32f4xx_syscfg_read(uint64_t addr) "reg read: addr: 0x%" PRIx64 " " | ||
323 | stm32f4xx_syscfg_write(uint64_t addr, uint64_t data) "reg write: addr: 0x%" PRIx64 " val: 0x%" PRIx64 "" | ||
324 | |||
325 | +# stm32f4xx_exti | ||
326 | +stm32f4xx_exti_set_irq(int irq, int leve) "Set EXTI: %d to %d" | ||
327 | +stm32f4xx_exti_read(uint64_t addr) "reg read: addr: 0x%" PRIx64 " " | ||
328 | +stm32f4xx_exti_write(uint64_t addr, uint64_t data) "reg write: addr: 0x%" PRIx64 " val: 0x%" PRIx64 "" | ||
329 | + | ||
330 | # tz-mpc.c | ||
331 | tz_mpc_reg_read(uint32_t offset, uint64_t data, unsigned size) "TZ MPC regs read: offset 0x%x data 0x%" PRIx64 " size %u" | ||
332 | tz_mpc_reg_write(uint32_t offset, uint64_t data, unsigned size) "TZ MPC regs write: offset 0x%x data 0x%" PRIx64 " size %u" | ||
333 | -- | 176 | -- |
334 | 2.20.1 | 177 | 2.20.1 |
335 | 178 | ||
336 | 179 | diff view generated by jsdifflib |
1 | From: Alistair Francis <alistair@alistair23.me> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Alistair Francis <alistair@alistair23.me> | 3 | This will shortly have users outside of translate-neon.c.inc. |
4 | |||
5 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
6 | Message-id: 20201030022618.785675-3-richard.henderson@linaro.org | ||
4 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Message-id: dad8d8d47f7625913e35e27a1c00f603a6b08f9a.1576658572.git.alistair@alistair23.me | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | --- | 9 | --- |
8 | hw/arm/Makefile.objs | 1 + | 10 | target/arm/translate.c | 20 ++++++++++++++++++++ |
9 | hw/arm/netduinoplus2.c | 52 ++++++++++++++++++++++++++++++++++++++++++ | 11 | target/arm/translate-neon.c.inc | 19 ------------------- |
10 | MAINTAINERS | 6 +++++ | 12 | 2 files changed, 20 insertions(+), 19 deletions(-) |
11 | 3 files changed, 59 insertions(+) | ||
12 | create mode 100644 hw/arm/netduinoplus2.c | ||
13 | 13 | ||
14 | diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs | 14 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
15 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/hw/arm/Makefile.objs | 16 | --- a/target/arm/translate.c |
17 | +++ b/hw/arm/Makefile.objs | 17 | +++ b/target/arm/translate.c |
18 | @@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_MAINSTONE) += mainstone.o | 18 | @@ -XXX,XX +XXX,XX @@ static long neon_full_reg_offset(unsigned reg) |
19 | obj-$(CONFIG_MICROBIT) += microbit.o | 19 | return offsetof(CPUARMState, vfp.zregs[reg >> 1].d[reg & 1]); |
20 | obj-$(CONFIG_MUSICPAL) += musicpal.o | 20 | } |
21 | obj-$(CONFIG_NETDUINO2) += netduino2.o | 21 | |
22 | +obj-$(CONFIG_NETDUINOPLUS2) += netduinoplus2.o | ||
23 | obj-$(CONFIG_NSERIES) += nseries.o | ||
24 | obj-$(CONFIG_SX1) += omap_sx1.o | ||
25 | obj-$(CONFIG_CHEETAH) += palm.o | ||
26 | diff --git a/hw/arm/netduinoplus2.c b/hw/arm/netduinoplus2.c | ||
27 | new file mode 100644 | ||
28 | index XXXXXXX..XXXXXXX | ||
29 | --- /dev/null | ||
30 | +++ b/hw/arm/netduinoplus2.c | ||
31 | @@ -XXX,XX +XXX,XX @@ | ||
32 | +/* | 22 | +/* |
33 | + * Netduino Plus 2 Machine Model | 23 | + * Return the offset of a 2**SIZE piece of a NEON register, at index ELE, |
34 | + * | 24 | + * where 0 is the least significant end of the register. |
35 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
36 | + * | ||
37 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
38 | + * of this software and associated documentation files (the "Software"), to deal | ||
39 | + * in the Software without restriction, including without limitation the rights | ||
40 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
41 | + * copies of the Software, and to permit persons to whom the Software is | ||
42 | + * furnished to do so, subject to the following conditions: | ||
43 | + * | ||
44 | + * The above copyright notice and this permission notice shall be included in | ||
45 | + * all copies or substantial portions of the Software. | ||
46 | + * | ||
47 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
48 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
49 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
50 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
51 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
52 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
53 | + * THE SOFTWARE. | ||
54 | + */ | 25 | + */ |
55 | + | 26 | +static long neon_element_offset(int reg, int element, MemOp size) |
56 | +#include "qemu/osdep.h" | ||
57 | +#include "qapi/error.h" | ||
58 | +#include "hw/boards.h" | ||
59 | +#include "hw/qdev-properties.h" | ||
60 | +#include "qemu/error-report.h" | ||
61 | +#include "hw/arm/stm32f405_soc.h" | ||
62 | +#include "hw/arm/boot.h" | ||
63 | + | ||
64 | +static void netduinoplus2_init(MachineState *machine) | ||
65 | +{ | 27 | +{ |
66 | + DeviceState *dev; | 28 | + int element_size = 1 << size; |
67 | + | 29 | + int ofs = element * element_size; |
68 | + dev = qdev_create(NULL, TYPE_STM32F405_SOC); | 30 | +#ifdef HOST_WORDS_BIGENDIAN |
69 | + qdev_prop_set_string(dev, "cpu-type", ARM_CPU_TYPE_NAME("cortex-m4")); | 31 | + /* |
70 | + object_property_set_bool(OBJECT(dev), true, "realized", &error_fatal); | 32 | + * Calculate the offset assuming fully little-endian, |
71 | + | 33 | + * then XOR to account for the order of the 8-byte units. |
72 | + armv7m_load_kernel(ARM_CPU(first_cpu), | 34 | + */ |
73 | + machine->kernel_filename, | 35 | + if (element_size < 8) { |
74 | + FLASH_SIZE); | 36 | + ofs ^= 8 - element_size; |
37 | + } | ||
38 | +#endif | ||
39 | + return neon_full_reg_offset(reg) + ofs; | ||
75 | +} | 40 | +} |
76 | + | 41 | + |
77 | +static void netduinoplus2_machine_init(MachineClass *mc) | 42 | static inline long vfp_reg_offset(bool dp, unsigned reg) |
78 | +{ | 43 | { |
79 | + mc->desc = "Netduino Plus 2 Machine"; | 44 | if (dp) { |
80 | + mc->init = netduinoplus2_init; | 45 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc |
81 | +} | ||
82 | + | ||
83 | +DEFINE_MACHINE("netduinoplus2", netduinoplus2_machine_init) | ||
84 | diff --git a/MAINTAINERS b/MAINTAINERS | ||
85 | index XXXXXXX..XXXXXXX 100644 | 46 | index XXXXXXX..XXXXXXX 100644 |
86 | --- a/MAINTAINERS | 47 | --- a/target/arm/translate-neon.c.inc |
87 | +++ b/MAINTAINERS | 48 | +++ b/target/arm/translate-neon.c.inc |
88 | @@ -XXX,XX +XXX,XX @@ M: Peter Maydell <peter.maydell@linaro.org> | 49 | @@ -XXX,XX +XXX,XX @@ static inline int neon_3same_fp_size(DisasContext *s, int x) |
89 | S: Maintained | 50 | #include "decode-neon-ls.c.inc" |
90 | F: hw/arm/netduino2.c | 51 | #include "decode-neon-shared.c.inc" |
91 | 52 | ||
92 | +Netduino Plus 2 | 53 | -/* Return the offset of a 2**SIZE piece of a NEON register, at index ELE, |
93 | +M: Alistair Francis <alistair@alistair23.me> | 54 | - * where 0 is the least significant end of the register. |
94 | +M: Peter Maydell <peter.maydell@linaro.org> | 55 | - */ |
95 | +S: Maintained | 56 | -static inline long |
96 | +F: hw/arm/netduinoplus2.c | 57 | -neon_element_offset(int reg, int element, MemOp size) |
97 | + | 58 | -{ |
98 | SmartFusion2 | 59 | - int element_size = 1 << size; |
99 | M: Subbaraya Sundeep <sundeep.lkml@gmail.com> | 60 | - int ofs = element * element_size; |
100 | M: Peter Maydell <peter.maydell@linaro.org> | 61 | -#ifdef HOST_WORDS_BIGENDIAN |
62 | - /* Calculate the offset assuming fully little-endian, | ||
63 | - * then XOR to account for the order of the 8-byte units. | ||
64 | - */ | ||
65 | - if (element_size < 8) { | ||
66 | - ofs ^= 8 - element_size; | ||
67 | - } | ||
68 | -#endif | ||
69 | - return neon_full_reg_offset(reg) + ofs; | ||
70 | -} | ||
71 | - | ||
72 | static void neon_load_element(TCGv_i32 var, int reg, int ele, MemOp mop) | ||
73 | { | ||
74 | long offset = neon_element_offset(reg, ele, mop & MO_SIZE); | ||
101 | -- | 75 | -- |
102 | 2.20.1 | 76 | 2.20.1 |
103 | 77 | ||
104 | 78 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | These are the only users of neon_reg_offset, so remove that. | ||
4 | |||
5 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
6 | Message-id: 20201030022618.785675-4-richard.henderson@linaro.org | ||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | --- | ||
10 | target/arm/translate.c | 14 ++------------ | ||
11 | 1 file changed, 2 insertions(+), 12 deletions(-) | ||
12 | |||
13 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
14 | index XXXXXXX..XXXXXXX 100644 | ||
15 | --- a/target/arm/translate.c | ||
16 | +++ b/target/arm/translate.c | ||
17 | @@ -XXX,XX +XXX,XX @@ static inline long vfp_reg_offset(bool dp, unsigned reg) | ||
18 | } | ||
19 | } | ||
20 | |||
21 | -/* Return the offset of a 32-bit piece of a NEON register. | ||
22 | - zero is the least significant end of the register. */ | ||
23 | -static inline long | ||
24 | -neon_reg_offset (int reg, int n) | ||
25 | -{ | ||
26 | - int sreg; | ||
27 | - sreg = reg * 2 + n; | ||
28 | - return vfp_reg_offset(0, sreg); | ||
29 | -} | ||
30 | - | ||
31 | static TCGv_i32 neon_load_reg(int reg, int pass) | ||
32 | { | ||
33 | TCGv_i32 tmp = tcg_temp_new_i32(); | ||
34 | - tcg_gen_ld_i32(tmp, cpu_env, neon_reg_offset(reg, pass)); | ||
35 | + tcg_gen_ld_i32(tmp, cpu_env, neon_element_offset(reg, pass, MO_32)); | ||
36 | return tmp; | ||
37 | } | ||
38 | |||
39 | static void neon_store_reg(int reg, int pass, TCGv_i32 var) | ||
40 | { | ||
41 | - tcg_gen_st_i32(var, cpu_env, neon_reg_offset(reg, pass)); | ||
42 | + tcg_gen_st_i32(var, cpu_env, neon_element_offset(reg, pass, MO_32)); | ||
43 | tcg_temp_free_i32(var); | ||
44 | } | ||
45 | |||
46 | -- | ||
47 | 2.20.1 | ||
48 | |||
49 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | By calling qdev_pass_gpios() we don't need to hold a copy of the | 3 | This seems a bit more readable than using offsetof CPU_DoubleU. |
4 | IRQs from the INTC into the SoC state. | ||
5 | Instead of filling an array of qemu_irq and passing it around, we | ||
6 | can now directly call qdev_get_gpio_in() on the SoC. | ||
7 | 4 | ||
8 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 5 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
9 | Message-id: 20191230110953.25496-5-f4bug@amsat.org | 6 | Message-id: 20201030022618.785675-5-richard.henderson@linaro.org |
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | --- | 9 | --- |
13 | include/hw/arm/allwinner-a10.h | 1 - | 10 | target/arm/translate.c | 13 ++++--------- |
14 | hw/arm/allwinner-a10.c | 24 +++++++++++------------- | 11 | 1 file changed, 4 insertions(+), 9 deletions(-) |
15 | 2 files changed, 11 insertions(+), 14 deletions(-) | ||
16 | 12 | ||
17 | diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h | 13 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
18 | index XXXXXXX..XXXXXXX 100644 | 14 | index XXXXXXX..XXXXXXX 100644 |
19 | --- a/include/hw/arm/allwinner-a10.h | 15 | --- a/target/arm/translate.c |
20 | +++ b/include/hw/arm/allwinner-a10.h | 16 | +++ b/target/arm/translate.c |
21 | @@ -XXX,XX +XXX,XX @@ typedef struct AwA10State { | 17 | @@ -XXX,XX +XXX,XX @@ static long neon_element_offset(int reg, int element, MemOp size) |
22 | /*< public >*/ | 18 | return neon_full_reg_offset(reg) + ofs; |
23 | 19 | } | |
24 | ARMCPU cpu; | 20 | |
25 | - qemu_irq irq[AW_A10_PIC_INT_NR]; | 21 | -static inline long vfp_reg_offset(bool dp, unsigned reg) |
26 | AwA10PITState timer; | 22 | +/* Return the offset of a VFP Dreg (dp = true) or VFP Sreg (dp = false). */ |
27 | AwA10PICState intc; | 23 | +static long vfp_reg_offset(bool dp, unsigned reg) |
28 | AwEmacState emac; | ||
29 | diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c | ||
30 | index XXXXXXX..XXXXXXX 100644 | ||
31 | --- a/hw/arm/allwinner-a10.c | ||
32 | +++ b/hw/arm/allwinner-a10.c | ||
33 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | ||
34 | { | 24 | { |
35 | AwA10State *s = AW_A10(dev); | 25 | if (dp) { |
36 | SysBusDevice *sysbusdev; | 26 | - return offsetof(CPUARMState, vfp.zregs[reg >> 1].d[reg & 1]); |
37 | - uint8_t i; | 27 | + return neon_element_offset(reg, 0, MO_64); |
38 | qemu_irq fiq, irq; | 28 | } else { |
39 | Error *err = NULL; | 29 | - long ofs = offsetof(CPUARMState, vfp.zregs[reg >> 2].d[(reg >> 1) & 1]); |
40 | 30 | - if (reg & 1) { | |
41 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | 31 | - ofs += offsetof(CPU_DoubleU, l.upper); |
42 | sysbus_mmio_map(sysbusdev, 0, AW_A10_PIC_REG_BASE); | 32 | - } else { |
43 | sysbus_connect_irq(sysbusdev, 0, irq); | 33 | - ofs += offsetof(CPU_DoubleU, l.lower); |
44 | sysbus_connect_irq(sysbusdev, 1, fiq); | 34 | - } |
45 | - for (i = 0; i < AW_A10_PIC_INT_NR; i++) { | 35 | - return ofs; |
46 | - s->irq[i] = qdev_get_gpio_in(DEVICE(&s->intc), i); | 36 | + return neon_element_offset(reg >> 1, reg & 1, MO_32); |
47 | - } | ||
48 | + qdev_pass_gpios(DEVICE(&s->intc), dev, NULL); | ||
49 | |||
50 | object_property_set_bool(OBJECT(&s->timer), true, "realized", &err); | ||
51 | if (err != NULL) { | ||
52 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | ||
53 | } | 37 | } |
54 | sysbusdev = SYS_BUS_DEVICE(&s->timer); | ||
55 | sysbus_mmio_map(sysbusdev, 0, AW_A10_PIT_REG_BASE); | ||
56 | - sysbus_connect_irq(sysbusdev, 0, s->irq[22]); | ||
57 | - sysbus_connect_irq(sysbusdev, 1, s->irq[23]); | ||
58 | - sysbus_connect_irq(sysbusdev, 2, s->irq[24]); | ||
59 | - sysbus_connect_irq(sysbusdev, 3, s->irq[25]); | ||
60 | - sysbus_connect_irq(sysbusdev, 4, s->irq[67]); | ||
61 | - sysbus_connect_irq(sysbusdev, 5, s->irq[68]); | ||
62 | + sysbus_connect_irq(sysbusdev, 0, qdev_get_gpio_in(dev, 22)); | ||
63 | + sysbus_connect_irq(sysbusdev, 1, qdev_get_gpio_in(dev, 23)); | ||
64 | + sysbus_connect_irq(sysbusdev, 2, qdev_get_gpio_in(dev, 24)); | ||
65 | + sysbus_connect_irq(sysbusdev, 3, qdev_get_gpio_in(dev, 25)); | ||
66 | + sysbus_connect_irq(sysbusdev, 4, qdev_get_gpio_in(dev, 67)); | ||
67 | + sysbus_connect_irq(sysbusdev, 5, qdev_get_gpio_in(dev, 68)); | ||
68 | |||
69 | memory_region_init_ram(&s->sram_a, OBJECT(dev), "sram A", 48 * KiB, | ||
70 | &error_fatal); | ||
71 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | ||
72 | } | ||
73 | sysbusdev = SYS_BUS_DEVICE(&s->emac); | ||
74 | sysbus_mmio_map(sysbusdev, 0, AW_A10_EMAC_BASE); | ||
75 | - sysbus_connect_irq(sysbusdev, 0, s->irq[55]); | ||
76 | + sysbus_connect_irq(sysbusdev, 0, qdev_get_gpio_in(dev, 55)); | ||
77 | |||
78 | object_property_set_bool(OBJECT(&s->sata), true, "realized", &err); | ||
79 | if (err) { | ||
80 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | ||
81 | return; | ||
82 | } | ||
83 | sysbus_mmio_map(SYS_BUS_DEVICE(&s->sata), 0, AW_A10_SATA_BASE); | ||
84 | - sysbus_connect_irq(SYS_BUS_DEVICE(&s->sata), 0, s->irq[56]); | ||
85 | + sysbus_connect_irq(SYS_BUS_DEVICE(&s->sata), 0, qdev_get_gpio_in(dev, 56)); | ||
86 | |||
87 | /* FIXME use a qdev chardev prop instead of serial_hd() */ | ||
88 | - serial_mm_init(get_system_memory(), AW_A10_UART0_REG_BASE, 2, s->irq[1], | ||
89 | + serial_mm_init(get_system_memory(), AW_A10_UART0_REG_BASE, 2, | ||
90 | + qdev_get_gpio_in(dev, 1), | ||
91 | 115200, serial_hd(0), DEVICE_NATIVE_ENDIAN); | ||
92 | } | 38 | } |
93 | 39 | ||
94 | -- | 40 | -- |
95 | 2.20.1 | 41 | 2.20.1 |
96 | 42 | ||
97 | 43 | diff view generated by jsdifflib |
1 | From: Martin Kaiser <martin@kaiser.cx> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Add an emulation for the RNGC random number generator and the compatible | 3 | Model these off the aa64 read/write_vec_element functions. |
4 | RNGB variant. These peripherals are included (at least) in imx25 and | 4 | Use it within translate-neon.c.inc. The new functions do |
5 | imx35 chipsets. | 5 | not allocate or free temps, so this rearranges the calling |
6 | code a bit. | ||
6 | 7 | ||
7 | The emulation supports the initial self test, reseeding the prng and | 8 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
8 | reading random numbers. | 9 | Message-id: 20201030022618.785675-6-richard.henderson@linaro.org |
9 | |||
10 | Signed-off-by: Martin Kaiser <martin@kaiser.cx> | ||
11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
13 | --- | 12 | --- |
14 | hw/misc/Makefile.objs | 1 + | 13 | target/arm/translate.c | 26 ++++ |
15 | include/hw/arm/fsl-imx25.h | 5 + | 14 | target/arm/translate-neon.c.inc | 256 ++++++++++++++++++++------------ |
16 | include/hw/misc/imx_rngc.h | 35 +++++ | 15 | 2 files changed, 183 insertions(+), 99 deletions(-) |
17 | hw/arm/fsl-imx25.c | 11 ++ | ||
18 | hw/misc/imx_rngc.c | 278 +++++++++++++++++++++++++++++++++++++ | ||
19 | 5 files changed, 330 insertions(+) | ||
20 | create mode 100644 include/hw/misc/imx_rngc.h | ||
21 | create mode 100644 hw/misc/imx_rngc.c | ||
22 | 16 | ||
23 | diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs | 17 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
24 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
25 | --- a/hw/misc/Makefile.objs | 19 | --- a/target/arm/translate.c |
26 | +++ b/hw/misc/Makefile.objs | 20 | +++ b/target/arm/translate.c |
27 | @@ -XXX,XX +XXX,XX @@ common-obj-$(CONFIG_IMX) += imx7_ccm.o | 21 | @@ -XXX,XX +XXX,XX @@ static inline void neon_store_reg32(TCGv_i32 var, int reg) |
28 | common-obj-$(CONFIG_IMX) += imx2_wdt.o | 22 | tcg_gen_st_i32(var, cpu_env, vfp_reg_offset(false, reg)); |
29 | common-obj-$(CONFIG_IMX) += imx7_snvs.o | 23 | } |
30 | common-obj-$(CONFIG_IMX) += imx7_gpr.o | 24 | |
31 | +common-obj-$(CONFIG_IMX) += imx_rngc.o | 25 | +static void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp size) |
32 | common-obj-$(CONFIG_MILKYMIST) += milkymist-hpdmc.o | ||
33 | common-obj-$(CONFIG_MILKYMIST) += milkymist-pfpu.o | ||
34 | common-obj-$(CONFIG_MAINSTONE) += mst_fpga.o | ||
35 | diff --git a/include/hw/arm/fsl-imx25.h b/include/hw/arm/fsl-imx25.h | ||
36 | index XXXXXXX..XXXXXXX 100644 | ||
37 | --- a/include/hw/arm/fsl-imx25.h | ||
38 | +++ b/include/hw/arm/fsl-imx25.h | ||
39 | @@ -XXX,XX +XXX,XX @@ | ||
40 | #include "hw/timer/imx_gpt.h" | ||
41 | #include "hw/timer/imx_epit.h" | ||
42 | #include "hw/net/imx_fec.h" | ||
43 | +#include "hw/misc/imx_rngc.h" | ||
44 | #include "hw/i2c/imx_i2c.h" | ||
45 | #include "hw/gpio/imx_gpio.h" | ||
46 | #include "exec/memory.h" | ||
47 | @@ -XXX,XX +XXX,XX @@ typedef struct FslIMX25State { | ||
48 | IMXGPTState gpt[FSL_IMX25_NUM_GPTS]; | ||
49 | IMXEPITState epit[FSL_IMX25_NUM_EPITS]; | ||
50 | IMXFECState fec; | ||
51 | + IMXRNGCState rngc; | ||
52 | IMXI2CState i2c[FSL_IMX25_NUM_I2CS]; | ||
53 | IMXGPIOState gpio[FSL_IMX25_NUM_GPIOS]; | ||
54 | MemoryRegion rom[2]; | ||
55 | @@ -XXX,XX +XXX,XX @@ typedef struct FslIMX25State { | ||
56 | #define FSL_IMX25_GPIO4_SIZE 0x4000 | ||
57 | #define FSL_IMX25_GPIO3_ADDR 0x53FA4000 | ||
58 | #define FSL_IMX25_GPIO3_SIZE 0x4000 | ||
59 | +#define FSL_IMX25_RNGC_ADDR 0x53FB0000 | ||
60 | +#define FSL_IMX25_RNGC_SIZE 0x4000 | ||
61 | #define FSL_IMX25_GPIO1_ADDR 0x53FCC000 | ||
62 | #define FSL_IMX25_GPIO1_SIZE 0x4000 | ||
63 | #define FSL_IMX25_GPIO2_ADDR 0x53FD0000 | ||
64 | @@ -XXX,XX +XXX,XX @@ typedef struct FslIMX25State { | ||
65 | #define FSL_IMX25_EPIT1_IRQ 28 | ||
66 | #define FSL_IMX25_EPIT2_IRQ 27 | ||
67 | #define FSL_IMX25_FEC_IRQ 57 | ||
68 | +#define FSL_IMX25_RNGC_IRQ 22 | ||
69 | #define FSL_IMX25_I2C1_IRQ 3 | ||
70 | #define FSL_IMX25_I2C2_IRQ 4 | ||
71 | #define FSL_IMX25_I2C3_IRQ 10 | ||
72 | diff --git a/include/hw/misc/imx_rngc.h b/include/hw/misc/imx_rngc.h | ||
73 | new file mode 100644 | ||
74 | index XXXXXXX..XXXXXXX | ||
75 | --- /dev/null | ||
76 | +++ b/include/hw/misc/imx_rngc.h | ||
77 | @@ -XXX,XX +XXX,XX @@ | ||
78 | +/* | ||
79 | + * Freescale i.MX RNGC emulation | ||
80 | + * | ||
81 | + * Copyright (C) 2020 Martin Kaiser <martin@kaiser.cx> | ||
82 | + * | ||
83 | + * This work is licensed under the terms of the GNU GPL, version 2 or later. | ||
84 | + * See the COPYING file in the top-level directory. | ||
85 | + */ | ||
86 | + | ||
87 | +#ifndef IMX_RNGC_H | ||
88 | +#define IMX_RNGC_H | ||
89 | + | ||
90 | +#include "hw/sysbus.h" | ||
91 | + | ||
92 | +#define TYPE_IMX_RNGC "imx.rngc" | ||
93 | +#define IMX_RNGC(obj) OBJECT_CHECK(IMXRNGCState, (obj), TYPE_IMX_RNGC) | ||
94 | + | ||
95 | +typedef struct IMXRNGCState { | ||
96 | + /*< private >*/ | ||
97 | + SysBusDevice parent_obj; | ||
98 | + | ||
99 | + /*< public >*/ | ||
100 | + MemoryRegion iomem; | ||
101 | + | ||
102 | + uint8_t op_self_test; | ||
103 | + uint8_t op_seed; | ||
104 | + uint8_t mask; | ||
105 | + bool auto_seed; | ||
106 | + | ||
107 | + QEMUBH *self_test_bh; | ||
108 | + QEMUBH *seed_bh; | ||
109 | + qemu_irq irq; | ||
110 | +} IMXRNGCState; | ||
111 | + | ||
112 | +#endif /* IMX_RNGC_H */ | ||
113 | diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c | ||
114 | index XXXXXXX..XXXXXXX 100644 | ||
115 | --- a/hw/arm/fsl-imx25.c | ||
116 | +++ b/hw/arm/fsl-imx25.c | ||
117 | @@ -XXX,XX +XXX,XX @@ static void fsl_imx25_init(Object *obj) | ||
118 | |||
119 | sysbus_init_child_obj(obj, "fec", &s->fec, sizeof(s->fec), TYPE_IMX_FEC); | ||
120 | |||
121 | + sysbus_init_child_obj(obj, "rngc", &s->rngc, sizeof(s->rngc), | ||
122 | + TYPE_IMX_RNGC); | ||
123 | + | ||
124 | for (i = 0; i < FSL_IMX25_NUM_I2CS; i++) { | ||
125 | sysbus_init_child_obj(obj, "i2c[*]", &s->i2c[i], sizeof(s->i2c[i]), | ||
126 | TYPE_IMX_I2C); | ||
127 | @@ -XXX,XX +XXX,XX @@ static void fsl_imx25_realize(DeviceState *dev, Error **errp) | ||
128 | sysbus_connect_irq(SYS_BUS_DEVICE(&s->fec), 0, | ||
129 | qdev_get_gpio_in(DEVICE(&s->avic), FSL_IMX25_FEC_IRQ)); | ||
130 | |||
131 | + object_property_set_bool(OBJECT(&s->rngc), true, "realized", &err); | ||
132 | + if (err) { | ||
133 | + error_propagate(errp, err); | ||
134 | + return; | ||
135 | + } | ||
136 | + sysbus_mmio_map(SYS_BUS_DEVICE(&s->rngc), 0, FSL_IMX25_RNGC_ADDR); | ||
137 | + sysbus_connect_irq(SYS_BUS_DEVICE(&s->rngc), 0, | ||
138 | + qdev_get_gpio_in(DEVICE(&s->avic), FSL_IMX25_RNGC_IRQ)); | ||
139 | |||
140 | /* Initialize all I2C */ | ||
141 | for (i = 0; i < FSL_IMX25_NUM_I2CS; i++) { | ||
142 | diff --git a/hw/misc/imx_rngc.c b/hw/misc/imx_rngc.c | ||
143 | new file mode 100644 | ||
144 | index XXXXXXX..XXXXXXX | ||
145 | --- /dev/null | ||
146 | +++ b/hw/misc/imx_rngc.c | ||
147 | @@ -XXX,XX +XXX,XX @@ | ||
148 | +/* | ||
149 | + * Freescale i.MX RNGC emulation | ||
150 | + * | ||
151 | + * Copyright (C) 2020 Martin Kaiser <martin@kaiser.cx> | ||
152 | + * | ||
153 | + * This work is licensed under the terms of the GNU GPL, version 2 or later. | ||
154 | + * See the COPYING file in the top-level directory. | ||
155 | + * | ||
156 | + * This driver provides the minimum functionality to initialize and seed | ||
157 | + * an rngc and to read random numbers. The rngb that is found in imx25 | ||
158 | + * chipsets is also supported. | ||
159 | + */ | ||
160 | + | ||
161 | +#include "qemu/osdep.h" | ||
162 | +#include "qemu/main-loop.h" | ||
163 | +#include "qemu/module.h" | ||
164 | +#include "qemu/log.h" | ||
165 | +#include "qemu/guest-random.h" | ||
166 | +#include "hw/irq.h" | ||
167 | +#include "hw/misc/imx_rngc.h" | ||
168 | +#include "migration/vmstate.h" | ||
169 | + | ||
170 | +#define RNGC_NAME "i.MX RNGC" | ||
171 | + | ||
172 | +#define RNGC_VER_ID 0x00 | ||
173 | +#define RNGC_COMMAND 0x04 | ||
174 | +#define RNGC_CONTROL 0x08 | ||
175 | +#define RNGC_STATUS 0x0C | ||
176 | +#define RNGC_FIFO 0x14 | ||
177 | + | ||
178 | +/* These version info are reported by the rngb in an imx258 chip. */ | ||
179 | +#define RNG_TYPE_RNGB 0x1 | ||
180 | +#define V_MAJ 0x2 | ||
181 | +#define V_MIN 0x40 | ||
182 | + | ||
183 | +#define RNGC_CMD_BIT_SW_RST 0x40 | ||
184 | +#define RNGC_CMD_BIT_CLR_ERR 0x20 | ||
185 | +#define RNGC_CMD_BIT_CLR_INT 0x10 | ||
186 | +#define RNGC_CMD_BIT_SEED 0x02 | ||
187 | +#define RNGC_CMD_BIT_SELF_TEST 0x01 | ||
188 | + | ||
189 | +#define RNGC_CTRL_BIT_MASK_ERR 0x40 | ||
190 | +#define RNGC_CTRL_BIT_MASK_DONE 0x20 | ||
191 | +#define RNGC_CTRL_BIT_AUTO_SEED 0x10 | ||
192 | + | ||
193 | +/* the current status for self-test and seed operations */ | ||
194 | +#define OP_IDLE 0 | ||
195 | +#define OP_RUN 1 | ||
196 | +#define OP_DONE 2 | ||
197 | + | ||
198 | +static uint64_t imx_rngc_read(void *opaque, hwaddr offset, unsigned size) | ||
199 | +{ | 26 | +{ |
200 | + IMXRNGCState *s = IMX_RNGC(opaque); | 27 | + long off = neon_element_offset(reg, ele, size); |
201 | + uint64_t val = 0; | 28 | + |
202 | + | 29 | + switch (size) { |
203 | + switch (offset) { | 30 | + case MO_32: |
204 | + case RNGC_VER_ID: | 31 | + tcg_gen_ld_i32(dest, cpu_env, off); |
205 | + val |= RNG_TYPE_RNGB << 28 | V_MAJ << 8 | V_MIN; | ||
206 | + break; | 32 | + break; |
207 | + | 33 | + default: |
208 | + case RNGC_COMMAND: | 34 | + g_assert_not_reached(); |
209 | + if (s->op_seed == OP_RUN) { | ||
210 | + val |= RNGC_CMD_BIT_SEED; | ||
211 | + } | ||
212 | + if (s->op_self_test == OP_RUN) { | ||
213 | + val |= RNGC_CMD_BIT_SELF_TEST; | ||
214 | + } | ||
215 | + break; | ||
216 | + | ||
217 | + case RNGC_CONTROL: | ||
218 | + /* | ||
219 | + * The CTL_ACC and VERIF_MODE bits are not supported yet. | ||
220 | + * They read as 0. | ||
221 | + */ | ||
222 | + val |= s->mask; | ||
223 | + if (s->auto_seed) { | ||
224 | + val |= RNGC_CTRL_BIT_AUTO_SEED; | ||
225 | + } | ||
226 | + /* | ||
227 | + * We don't have an internal fifo like the real hardware. | ||
228 | + * There's no need for strategy to handle fifo underflows. | ||
229 | + * We return the FIFO_UFLOW_RESPONSE bits as 0. | ||
230 | + */ | ||
231 | + break; | ||
232 | + | ||
233 | + case RNGC_STATUS: | ||
234 | + /* | ||
235 | + * We never report any statistics test or self-test errors or any | ||
236 | + * other errors. STAT_TEST_PF, ST_PF and ERROR are always 0. | ||
237 | + */ | ||
238 | + | ||
239 | + /* | ||
240 | + * We don't have an internal fifo, see above. Therefore, we | ||
241 | + * report back the default fifo size (5 32-bit words) and | ||
242 | + * indicate that our fifo is always full. | ||
243 | + */ | ||
244 | + val |= 5 << 12 | 5 << 8; | ||
245 | + | ||
246 | + /* We always have a new seed available. */ | ||
247 | + val |= 1 << 6; | ||
248 | + | ||
249 | + if (s->op_seed == OP_DONE) { | ||
250 | + val |= 1 << 5; | ||
251 | + } | ||
252 | + if (s->op_self_test == OP_DONE) { | ||
253 | + val |= 1 << 4; | ||
254 | + } | ||
255 | + if (s->op_seed == OP_RUN || s->op_self_test == OP_RUN) { | ||
256 | + /* | ||
257 | + * We're busy if self-test is running or if we're | ||
258 | + * seeding the prng. | ||
259 | + */ | ||
260 | + val |= 1 << 1; | ||
261 | + } else { | ||
262 | + /* | ||
263 | + * We're ready to provide secure random numbers whenever | ||
264 | + * we're not busy. | ||
265 | + */ | ||
266 | + val |= 1; | ||
267 | + } | ||
268 | + break; | ||
269 | + | ||
270 | + case RNGC_FIFO: | ||
271 | + qemu_guest_getrandom_nofail(&val, sizeof(val)); | ||
272 | + break; | ||
273 | + } | ||
274 | + | ||
275 | + return val; | ||
276 | +} | ||
277 | + | ||
278 | +static void imx_rngc_do_reset(IMXRNGCState *s) | ||
279 | +{ | ||
280 | + s->op_self_test = OP_IDLE; | ||
281 | + s->op_seed = OP_IDLE; | ||
282 | + s->mask = 0; | ||
283 | + s->auto_seed = false; | ||
284 | +} | ||
285 | + | ||
286 | +static void imx_rngc_write(void *opaque, hwaddr offset, uint64_t value, | ||
287 | + unsigned size) | ||
288 | +{ | ||
289 | + IMXRNGCState *s = IMX_RNGC(opaque); | ||
290 | + | ||
291 | + switch (offset) { | ||
292 | + case RNGC_COMMAND: | ||
293 | + if (value & RNGC_CMD_BIT_SW_RST) { | ||
294 | + imx_rngc_do_reset(s); | ||
295 | + } | ||
296 | + | ||
297 | + /* | ||
298 | + * For now, both CLR_ERR and CLR_INT clear the interrupt. We | ||
299 | + * don't report any errors yet. | ||
300 | + */ | ||
301 | + if (value & (RNGC_CMD_BIT_CLR_ERR | RNGC_CMD_BIT_CLR_INT)) { | ||
302 | + qemu_irq_lower(s->irq); | ||
303 | + } | ||
304 | + | ||
305 | + if (value & RNGC_CMD_BIT_SEED) { | ||
306 | + s->op_seed = OP_RUN; | ||
307 | + qemu_bh_schedule(s->seed_bh); | ||
308 | + } | ||
309 | + | ||
310 | + if (value & RNGC_CMD_BIT_SELF_TEST) { | ||
311 | + s->op_self_test = OP_RUN; | ||
312 | + qemu_bh_schedule(s->self_test_bh); | ||
313 | + } | ||
314 | + break; | ||
315 | + | ||
316 | + case RNGC_CONTROL: | ||
317 | + /* | ||
318 | + * The CTL_ACC and VERIF_MODE bits are not supported yet. | ||
319 | + * We ignore them if they're set by the caller. | ||
320 | + */ | ||
321 | + | ||
322 | + if (value & RNGC_CTRL_BIT_MASK_ERR) { | ||
323 | + s->mask |= RNGC_CTRL_BIT_MASK_ERR; | ||
324 | + } else { | ||
325 | + s->mask &= ~RNGC_CTRL_BIT_MASK_ERR; | ||
326 | + } | ||
327 | + | ||
328 | + if (value & RNGC_CTRL_BIT_MASK_DONE) { | ||
329 | + s->mask |= RNGC_CTRL_BIT_MASK_DONE; | ||
330 | + } else { | ||
331 | + s->mask &= ~RNGC_CTRL_BIT_MASK_DONE; | ||
332 | + } | ||
333 | + | ||
334 | + if (value & RNGC_CTRL_BIT_AUTO_SEED) { | ||
335 | + s->auto_seed = true; | ||
336 | + } else { | ||
337 | + s->auto_seed = false; | ||
338 | + } | ||
339 | + break; | ||
340 | + } | 35 | + } |
341 | +} | 36 | +} |
342 | + | 37 | + |
343 | +static const MemoryRegionOps imx_rngc_ops = { | 38 | +static void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp size) |
344 | + .read = imx_rngc_read, | ||
345 | + .write = imx_rngc_write, | ||
346 | + .endianness = DEVICE_NATIVE_ENDIAN, | ||
347 | +}; | ||
348 | + | ||
349 | +static void imx_rngc_self_test(void *opaque) | ||
350 | +{ | 39 | +{ |
351 | + IMXRNGCState *s = IMX_RNGC(opaque); | 40 | + long off = neon_element_offset(reg, ele, size); |
352 | + | 41 | + |
353 | + s->op_self_test = OP_DONE; | 42 | + switch (size) { |
354 | + if (!(s->mask & RNGC_CTRL_BIT_MASK_DONE)) { | 43 | + case MO_32: |
355 | + qemu_irq_raise(s->irq); | 44 | + tcg_gen_st_i32(src, cpu_env, off); |
45 | + break; | ||
46 | + default: | ||
47 | + g_assert_not_reached(); | ||
356 | + } | 48 | + } |
357 | +} | 49 | +} |
358 | + | 50 | + |
359 | +static void imx_rngc_seed(void *opaque) | 51 | static TCGv_ptr vfp_reg_ptr(bool dp, int reg) |
360 | +{ | 52 | { |
361 | + IMXRNGCState *s = IMX_RNGC(opaque); | 53 | TCGv_ptr ret = tcg_temp_new_ptr(); |
362 | + | 54 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc |
363 | + s->op_seed = OP_DONE; | 55 | index XXXXXXX..XXXXXXX 100644 |
364 | + if (!(s->mask & RNGC_CTRL_BIT_MASK_DONE)) { | 56 | --- a/target/arm/translate-neon.c.inc |
365 | + qemu_irq_raise(s->irq); | 57 | +++ b/target/arm/translate-neon.c.inc |
366 | + } | 58 | @@ -XXX,XX +XXX,XX @@ static bool do_3same_pair(DisasContext *s, arg_3same *a, NeonGenTwoOpFn *fn) |
367 | +} | 59 | * early. Since Q is 0 there are always just two passes, so instead |
368 | + | 60 | * of a complicated loop over each pass we just unroll. |
369 | +static void imx_rngc_realize(DeviceState *dev, Error **errp) | 61 | */ |
370 | +{ | 62 | - tmp = neon_load_reg(a->vn, 0); |
371 | + IMXRNGCState *s = IMX_RNGC(dev); | 63 | - tmp2 = neon_load_reg(a->vn, 1); |
372 | + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); | 64 | + tmp = tcg_temp_new_i32(); |
373 | + | 65 | + tmp2 = tcg_temp_new_i32(); |
374 | + memory_region_init_io(&s->iomem, OBJECT(s), &imx_rngc_ops, s, | 66 | + tmp3 = tcg_temp_new_i32(); |
375 | + TYPE_IMX_RNGC, 0x1000); | 67 | + |
376 | + sysbus_init_mmio(sbd, &s->iomem); | 68 | + read_neon_element32(tmp, a->vn, 0, MO_32); |
377 | + | 69 | + read_neon_element32(tmp2, a->vn, 1, MO_32); |
378 | + sysbus_init_irq(sbd, &s->irq); | 70 | fn(tmp, tmp, tmp2); |
379 | + s->self_test_bh = qemu_bh_new(imx_rngc_self_test, s); | 71 | - tcg_temp_free_i32(tmp2); |
380 | + s->seed_bh = qemu_bh_new(imx_rngc_seed, s); | 72 | |
381 | +} | 73 | - tmp3 = neon_load_reg(a->vm, 0); |
382 | + | 74 | - tmp2 = neon_load_reg(a->vm, 1); |
383 | +static void imx_rngc_reset(DeviceState *dev) | 75 | + read_neon_element32(tmp3, a->vm, 0, MO_32); |
384 | +{ | 76 | + read_neon_element32(tmp2, a->vm, 1, MO_32); |
385 | + IMXRNGCState *s = IMX_RNGC(dev); | 77 | fn(tmp3, tmp3, tmp2); |
386 | + | 78 | - tcg_temp_free_i32(tmp2); |
387 | + imx_rngc_do_reset(s); | 79 | |
388 | +} | 80 | - neon_store_reg(a->vd, 0, tmp); |
389 | + | 81 | - neon_store_reg(a->vd, 1, tmp3); |
390 | +static const VMStateDescription vmstate_imx_rngc = { | 82 | + write_neon_element32(tmp, a->vd, 0, MO_32); |
391 | + .name = RNGC_NAME, | 83 | + write_neon_element32(tmp3, a->vd, 1, MO_32); |
392 | + .version_id = 1, | 84 | + |
393 | + .minimum_version_id = 1, | 85 | + tcg_temp_free_i32(tmp); |
394 | + .fields = (VMStateField[]) { | 86 | + tcg_temp_free_i32(tmp2); |
395 | + VMSTATE_UINT8(op_self_test, IMXRNGCState), | 87 | + tcg_temp_free_i32(tmp3); |
396 | + VMSTATE_UINT8(op_seed, IMXRNGCState), | 88 | return true; |
397 | + VMSTATE_UINT8(mask, IMXRNGCState), | 89 | } |
398 | + VMSTATE_BOOL(auto_seed, IMXRNGCState), | 90 | |
399 | + VMSTATE_END_OF_LIST() | 91 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_env_32(DisasContext *s, arg_2reg_shift *a, |
400 | + } | 92 | * 2-reg-and-shift operations, size < 3 case, where the |
401 | +}; | 93 | * helper needs to be passed cpu_env. |
402 | + | 94 | */ |
403 | +static void imx_rngc_class_init(ObjectClass *klass, void *data) | 95 | - TCGv_i32 constimm; |
404 | +{ | 96 | + TCGv_i32 constimm, tmp; |
405 | + DeviceClass *dc = DEVICE_CLASS(klass); | 97 | int pass; |
406 | + | 98 | |
407 | + dc->realize = imx_rngc_realize; | 99 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { |
408 | + dc->reset = imx_rngc_reset; | 100 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_env_32(DisasContext *s, arg_2reg_shift *a, |
409 | + dc->desc = RNGC_NAME, | 101 | * by immediate using the variable shift operations. |
410 | + dc->vmsd = &vmstate_imx_rngc; | 102 | */ |
411 | +} | 103 | constimm = tcg_const_i32(dup_const(a->size, a->shift)); |
412 | + | 104 | + tmp = tcg_temp_new_i32(); |
413 | +static const TypeInfo imx_rngc_info = { | 105 | |
414 | + .name = TYPE_IMX_RNGC, | 106 | for (pass = 0; pass < (a->q ? 4 : 2); pass++) { |
415 | + .parent = TYPE_SYS_BUS_DEVICE, | 107 | - TCGv_i32 tmp = neon_load_reg(a->vm, pass); |
416 | + .instance_size = sizeof(IMXRNGCState), | 108 | + read_neon_element32(tmp, a->vm, pass, MO_32); |
417 | + .class_init = imx_rngc_class_init, | 109 | fn(tmp, cpu_env, tmp, constimm); |
418 | +}; | 110 | - neon_store_reg(a->vd, pass, tmp); |
419 | + | 111 | + write_neon_element32(tmp, a->vd, pass, MO_32); |
420 | +static void imx_rngc_register_types(void) | 112 | } |
421 | +{ | 113 | + tcg_temp_free_i32(tmp); |
422 | + type_register_static(&imx_rngc_info); | 114 | tcg_temp_free_i32(constimm); |
423 | +} | 115 | return true; |
424 | + | 116 | } |
425 | +type_init(imx_rngc_register_types) | 117 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_narrow_64(DisasContext *s, arg_2reg_shift *a, |
118 | constimm = tcg_const_i64(-a->shift); | ||
119 | rm1 = tcg_temp_new_i64(); | ||
120 | rm2 = tcg_temp_new_i64(); | ||
121 | + rd = tcg_temp_new_i32(); | ||
122 | |||
123 | /* Load both inputs first to avoid potential overwrite if rm == rd */ | ||
124 | neon_load_reg64(rm1, a->vm); | ||
125 | neon_load_reg64(rm2, a->vm + 1); | ||
126 | |||
127 | shiftfn(rm1, rm1, constimm); | ||
128 | - rd = tcg_temp_new_i32(); | ||
129 | narrowfn(rd, cpu_env, rm1); | ||
130 | - neon_store_reg(a->vd, 0, rd); | ||
131 | + write_neon_element32(rd, a->vd, 0, MO_32); | ||
132 | |||
133 | shiftfn(rm2, rm2, constimm); | ||
134 | - rd = tcg_temp_new_i32(); | ||
135 | narrowfn(rd, cpu_env, rm2); | ||
136 | - neon_store_reg(a->vd, 1, rd); | ||
137 | + write_neon_element32(rd, a->vd, 1, MO_32); | ||
138 | |||
139 | + tcg_temp_free_i32(rd); | ||
140 | tcg_temp_free_i64(rm1); | ||
141 | tcg_temp_free_i64(rm2); | ||
142 | tcg_temp_free_i64(constimm); | ||
143 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_narrow_32(DisasContext *s, arg_2reg_shift *a, | ||
144 | constimm = tcg_const_i32(imm); | ||
145 | |||
146 | /* Load all inputs first to avoid potential overwrite */ | ||
147 | - rm1 = neon_load_reg(a->vm, 0); | ||
148 | - rm2 = neon_load_reg(a->vm, 1); | ||
149 | - rm3 = neon_load_reg(a->vm + 1, 0); | ||
150 | - rm4 = neon_load_reg(a->vm + 1, 1); | ||
151 | + rm1 = tcg_temp_new_i32(); | ||
152 | + rm2 = tcg_temp_new_i32(); | ||
153 | + rm3 = tcg_temp_new_i32(); | ||
154 | + rm4 = tcg_temp_new_i32(); | ||
155 | + read_neon_element32(rm1, a->vm, 0, MO_32); | ||
156 | + read_neon_element32(rm2, a->vm, 1, MO_32); | ||
157 | + read_neon_element32(rm3, a->vm, 2, MO_32); | ||
158 | + read_neon_element32(rm4, a->vm, 3, MO_32); | ||
159 | rtmp = tcg_temp_new_i64(); | ||
160 | |||
161 | shiftfn(rm1, rm1, constimm); | ||
162 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_narrow_32(DisasContext *s, arg_2reg_shift *a, | ||
163 | tcg_temp_free_i32(rm2); | ||
164 | |||
165 | narrowfn(rm1, cpu_env, rtmp); | ||
166 | - neon_store_reg(a->vd, 0, rm1); | ||
167 | + write_neon_element32(rm1, a->vd, 0, MO_32); | ||
168 | + tcg_temp_free_i32(rm1); | ||
169 | |||
170 | shiftfn(rm3, rm3, constimm); | ||
171 | shiftfn(rm4, rm4, constimm); | ||
172 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_narrow_32(DisasContext *s, arg_2reg_shift *a, | ||
173 | |||
174 | narrowfn(rm3, cpu_env, rtmp); | ||
175 | tcg_temp_free_i64(rtmp); | ||
176 | - neon_store_reg(a->vd, 1, rm3); | ||
177 | + write_neon_element32(rm3, a->vd, 1, MO_32); | ||
178 | + tcg_temp_free_i32(rm3); | ||
179 | return true; | ||
180 | } | ||
181 | |||
182 | @@ -XXX,XX +XXX,XX @@ static bool do_vshll_2sh(DisasContext *s, arg_2reg_shift *a, | ||
183 | widen_mask = dup_const(a->size + 1, widen_mask); | ||
184 | } | ||
185 | |||
186 | - rm0 = neon_load_reg(a->vm, 0); | ||
187 | - rm1 = neon_load_reg(a->vm, 1); | ||
188 | + rm0 = tcg_temp_new_i32(); | ||
189 | + rm1 = tcg_temp_new_i32(); | ||
190 | + read_neon_element32(rm0, a->vm, 0, MO_32); | ||
191 | + read_neon_element32(rm1, a->vm, 1, MO_32); | ||
192 | tmp = tcg_temp_new_i64(); | ||
193 | |||
194 | widenfn(tmp, rm0); | ||
195 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
196 | if (src1_wide) { | ||
197 | neon_load_reg64(rn0_64, a->vn); | ||
198 | } else { | ||
199 | - TCGv_i32 tmp = neon_load_reg(a->vn, 0); | ||
200 | + TCGv_i32 tmp = tcg_temp_new_i32(); | ||
201 | + read_neon_element32(tmp, a->vn, 0, MO_32); | ||
202 | widenfn(rn0_64, tmp); | ||
203 | tcg_temp_free_i32(tmp); | ||
204 | } | ||
205 | - rm = neon_load_reg(a->vm, 0); | ||
206 | + rm = tcg_temp_new_i32(); | ||
207 | + read_neon_element32(rm, a->vm, 0, MO_32); | ||
208 | |||
209 | widenfn(rm_64, rm); | ||
210 | tcg_temp_free_i32(rm); | ||
211 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
212 | if (src1_wide) { | ||
213 | neon_load_reg64(rn1_64, a->vn + 1); | ||
214 | } else { | ||
215 | - TCGv_i32 tmp = neon_load_reg(a->vn, 1); | ||
216 | + TCGv_i32 tmp = tcg_temp_new_i32(); | ||
217 | + read_neon_element32(tmp, a->vn, 1, MO_32); | ||
218 | widenfn(rn1_64, tmp); | ||
219 | tcg_temp_free_i32(tmp); | ||
220 | } | ||
221 | - rm = neon_load_reg(a->vm, 1); | ||
222 | + rm = tcg_temp_new_i32(); | ||
223 | + read_neon_element32(rm, a->vm, 1, MO_32); | ||
224 | |||
225 | neon_store_reg64(rn0_64, a->vd); | ||
226 | |||
227 | @@ -XXX,XX +XXX,XX @@ static bool do_narrow_3d(DisasContext *s, arg_3diff *a, | ||
228 | |||
229 | narrowfn(rd1, rn_64); | ||
230 | |||
231 | - neon_store_reg(a->vd, 0, rd0); | ||
232 | - neon_store_reg(a->vd, 1, rd1); | ||
233 | + write_neon_element32(rd0, a->vd, 0, MO_32); | ||
234 | + write_neon_element32(rd1, a->vd, 1, MO_32); | ||
235 | |||
236 | + tcg_temp_free_i32(rd0); | ||
237 | + tcg_temp_free_i32(rd1); | ||
238 | tcg_temp_free_i64(rn_64); | ||
239 | tcg_temp_free_i64(rm_64); | ||
240 | |||
241 | @@ -XXX,XX +XXX,XX @@ static bool do_long_3d(DisasContext *s, arg_3diff *a, | ||
242 | rd0 = tcg_temp_new_i64(); | ||
243 | rd1 = tcg_temp_new_i64(); | ||
244 | |||
245 | - rn = neon_load_reg(a->vn, 0); | ||
246 | - rm = neon_load_reg(a->vm, 0); | ||
247 | + rn = tcg_temp_new_i32(); | ||
248 | + rm = tcg_temp_new_i32(); | ||
249 | + read_neon_element32(rn, a->vn, 0, MO_32); | ||
250 | + read_neon_element32(rm, a->vm, 0, MO_32); | ||
251 | opfn(rd0, rn, rm); | ||
252 | - tcg_temp_free_i32(rn); | ||
253 | - tcg_temp_free_i32(rm); | ||
254 | |||
255 | - rn = neon_load_reg(a->vn, 1); | ||
256 | - rm = neon_load_reg(a->vm, 1); | ||
257 | + read_neon_element32(rn, a->vn, 1, MO_32); | ||
258 | + read_neon_element32(rm, a->vm, 1, MO_32); | ||
259 | opfn(rd1, rn, rm); | ||
260 | tcg_temp_free_i32(rn); | ||
261 | tcg_temp_free_i32(rm); | ||
262 | @@ -XXX,XX +XXX,XX @@ static void gen_neon_dup_high16(TCGv_i32 var) | ||
263 | |||
264 | static inline TCGv_i32 neon_get_scalar(int size, int reg) | ||
265 | { | ||
266 | - TCGv_i32 tmp; | ||
267 | - if (size == 1) { | ||
268 | - tmp = neon_load_reg(reg & 7, reg >> 4); | ||
269 | + TCGv_i32 tmp = tcg_temp_new_i32(); | ||
270 | + if (size == MO_16) { | ||
271 | + read_neon_element32(tmp, reg & 7, reg >> 4, MO_32); | ||
272 | if (reg & 8) { | ||
273 | gen_neon_dup_high16(tmp); | ||
274 | } else { | ||
275 | gen_neon_dup_low16(tmp); | ||
276 | } | ||
277 | } else { | ||
278 | - tmp = neon_load_reg(reg & 15, reg >> 4); | ||
279 | + read_neon_element32(tmp, reg & 15, reg >> 4, MO_32); | ||
280 | } | ||
281 | return tmp; | ||
282 | } | ||
283 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar(DisasContext *s, arg_2scalar *a, | ||
284 | * perform an accumulation operation of that result into the | ||
285 | * destination. | ||
286 | */ | ||
287 | - TCGv_i32 scalar; | ||
288 | + TCGv_i32 scalar, tmp; | ||
289 | int pass; | ||
290 | |||
291 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
292 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar(DisasContext *s, arg_2scalar *a, | ||
293 | } | ||
294 | |||
295 | scalar = neon_get_scalar(a->size, a->vm); | ||
296 | + tmp = tcg_temp_new_i32(); | ||
297 | |||
298 | for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
299 | - TCGv_i32 tmp = neon_load_reg(a->vn, pass); | ||
300 | + read_neon_element32(tmp, a->vn, pass, MO_32); | ||
301 | opfn(tmp, tmp, scalar); | ||
302 | if (accfn) { | ||
303 | - TCGv_i32 rd = neon_load_reg(a->vd, pass); | ||
304 | + TCGv_i32 rd = tcg_temp_new_i32(); | ||
305 | + read_neon_element32(rd, a->vd, pass, MO_32); | ||
306 | accfn(tmp, rd, tmp); | ||
307 | tcg_temp_free_i32(rd); | ||
308 | } | ||
309 | - neon_store_reg(a->vd, pass, tmp); | ||
310 | + write_neon_element32(tmp, a->vd, pass, MO_32); | ||
311 | } | ||
312 | + tcg_temp_free_i32(tmp); | ||
313 | tcg_temp_free_i32(scalar); | ||
314 | return true; | ||
315 | } | ||
316 | @@ -XXX,XX +XXX,XX @@ static bool do_vqrdmlah_2sc(DisasContext *s, arg_2scalar *a, | ||
317 | * performs a kind of fused op-then-accumulate using a helper | ||
318 | * function that takes all of rd, rn and the scalar at once. | ||
319 | */ | ||
320 | - TCGv_i32 scalar; | ||
321 | + TCGv_i32 scalar, rn, rd; | ||
322 | int pass; | ||
323 | |||
324 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
325 | @@ -XXX,XX +XXX,XX @@ static bool do_vqrdmlah_2sc(DisasContext *s, arg_2scalar *a, | ||
326 | } | ||
327 | |||
328 | scalar = neon_get_scalar(a->size, a->vm); | ||
329 | + rn = tcg_temp_new_i32(); | ||
330 | + rd = tcg_temp_new_i32(); | ||
331 | |||
332 | for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
333 | - TCGv_i32 rn = neon_load_reg(a->vn, pass); | ||
334 | - TCGv_i32 rd = neon_load_reg(a->vd, pass); | ||
335 | + read_neon_element32(rn, a->vn, pass, MO_32); | ||
336 | + read_neon_element32(rd, a->vd, pass, MO_32); | ||
337 | opfn(rd, cpu_env, rn, scalar, rd); | ||
338 | - tcg_temp_free_i32(rn); | ||
339 | - neon_store_reg(a->vd, pass, rd); | ||
340 | + write_neon_element32(rd, a->vd, pass, MO_32); | ||
341 | } | ||
342 | + tcg_temp_free_i32(rn); | ||
343 | + tcg_temp_free_i32(rd); | ||
344 | tcg_temp_free_i32(scalar); | ||
345 | |||
346 | return true; | ||
347 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar_long(DisasContext *s, arg_2scalar *a, | ||
348 | scalar = neon_get_scalar(a->size, a->vm); | ||
349 | |||
350 | /* Load all inputs before writing any outputs, in case of overlap */ | ||
351 | - rn = neon_load_reg(a->vn, 0); | ||
352 | + rn = tcg_temp_new_i32(); | ||
353 | + read_neon_element32(rn, a->vn, 0, MO_32); | ||
354 | rn0_64 = tcg_temp_new_i64(); | ||
355 | opfn(rn0_64, rn, scalar); | ||
356 | - tcg_temp_free_i32(rn); | ||
357 | |||
358 | - rn = neon_load_reg(a->vn, 1); | ||
359 | + read_neon_element32(rn, a->vn, 1, MO_32); | ||
360 | rn1_64 = tcg_temp_new_i64(); | ||
361 | opfn(rn1_64, rn, scalar); | ||
362 | tcg_temp_free_i32(rn); | ||
363 | @@ -XXX,XX +XXX,XX @@ static bool trans_VTBL(DisasContext *s, arg_VTBL *a) | ||
364 | return false; | ||
365 | } | ||
366 | n <<= 3; | ||
367 | + tmp = tcg_temp_new_i32(); | ||
368 | if (a->op) { | ||
369 | - tmp = neon_load_reg(a->vd, 0); | ||
370 | + read_neon_element32(tmp, a->vd, 0, MO_32); | ||
371 | } else { | ||
372 | - tmp = tcg_temp_new_i32(); | ||
373 | tcg_gen_movi_i32(tmp, 0); | ||
374 | } | ||
375 | - tmp2 = neon_load_reg(a->vm, 0); | ||
376 | + tmp2 = tcg_temp_new_i32(); | ||
377 | + read_neon_element32(tmp2, a->vm, 0, MO_32); | ||
378 | ptr1 = vfp_reg_ptr(true, a->vn); | ||
379 | tmp4 = tcg_const_i32(n); | ||
380 | gen_helper_neon_tbl(tmp2, tmp2, tmp, ptr1, tmp4); | ||
381 | - tcg_temp_free_i32(tmp); | ||
382 | + | ||
383 | if (a->op) { | ||
384 | - tmp = neon_load_reg(a->vd, 1); | ||
385 | + read_neon_element32(tmp, a->vd, 1, MO_32); | ||
386 | } else { | ||
387 | - tmp = tcg_temp_new_i32(); | ||
388 | tcg_gen_movi_i32(tmp, 0); | ||
389 | } | ||
390 | - tmp3 = neon_load_reg(a->vm, 1); | ||
391 | + tmp3 = tcg_temp_new_i32(); | ||
392 | + read_neon_element32(tmp3, a->vm, 1, MO_32); | ||
393 | gen_helper_neon_tbl(tmp3, tmp3, tmp, ptr1, tmp4); | ||
394 | + tcg_temp_free_i32(tmp); | ||
395 | tcg_temp_free_i32(tmp4); | ||
396 | tcg_temp_free_ptr(ptr1); | ||
397 | - neon_store_reg(a->vd, 0, tmp2); | ||
398 | - neon_store_reg(a->vd, 1, tmp3); | ||
399 | - tcg_temp_free_i32(tmp); | ||
400 | + | ||
401 | + write_neon_element32(tmp2, a->vd, 0, MO_32); | ||
402 | + write_neon_element32(tmp3, a->vd, 1, MO_32); | ||
403 | + tcg_temp_free_i32(tmp2); | ||
404 | + tcg_temp_free_i32(tmp3); | ||
405 | return true; | ||
406 | } | ||
407 | |||
408 | @@ -XXX,XX +XXX,XX @@ static bool trans_VDUP_scalar(DisasContext *s, arg_VDUP_scalar *a) | ||
409 | static bool trans_VREV64(DisasContext *s, arg_VREV64 *a) | ||
410 | { | ||
411 | int pass, half; | ||
412 | + TCGv_i32 tmp[2]; | ||
413 | |||
414 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
415 | return false; | ||
416 | @@ -XXX,XX +XXX,XX @@ static bool trans_VREV64(DisasContext *s, arg_VREV64 *a) | ||
417 | return true; | ||
418 | } | ||
419 | |||
420 | - for (pass = 0; pass < (a->q ? 2 : 1); pass++) { | ||
421 | - TCGv_i32 tmp[2]; | ||
422 | + tmp[0] = tcg_temp_new_i32(); | ||
423 | + tmp[1] = tcg_temp_new_i32(); | ||
424 | |||
425 | + for (pass = 0; pass < (a->q ? 2 : 1); pass++) { | ||
426 | for (half = 0; half < 2; half++) { | ||
427 | - tmp[half] = neon_load_reg(a->vm, pass * 2 + half); | ||
428 | + read_neon_element32(tmp[half], a->vm, pass * 2 + half, MO_32); | ||
429 | switch (a->size) { | ||
430 | case 0: | ||
431 | tcg_gen_bswap32_i32(tmp[half], tmp[half]); | ||
432 | @@ -XXX,XX +XXX,XX @@ static bool trans_VREV64(DisasContext *s, arg_VREV64 *a) | ||
433 | g_assert_not_reached(); | ||
434 | } | ||
435 | } | ||
436 | - neon_store_reg(a->vd, pass * 2, tmp[1]); | ||
437 | - neon_store_reg(a->vd, pass * 2 + 1, tmp[0]); | ||
438 | + write_neon_element32(tmp[1], a->vd, pass * 2, MO_32); | ||
439 | + write_neon_element32(tmp[0], a->vd, pass * 2 + 1, MO_32); | ||
440 | } | ||
441 | + | ||
442 | + tcg_temp_free_i32(tmp[0]); | ||
443 | + tcg_temp_free_i32(tmp[1]); | ||
444 | return true; | ||
445 | } | ||
446 | |||
447 | @@ -XXX,XX +XXX,XX @@ static bool do_2misc_pairwise(DisasContext *s, arg_2misc *a, | ||
448 | rm0_64 = tcg_temp_new_i64(); | ||
449 | rm1_64 = tcg_temp_new_i64(); | ||
450 | rd_64 = tcg_temp_new_i64(); | ||
451 | - tmp = neon_load_reg(a->vm, pass * 2); | ||
452 | + | ||
453 | + tmp = tcg_temp_new_i32(); | ||
454 | + read_neon_element32(tmp, a->vm, pass * 2, MO_32); | ||
455 | widenfn(rm0_64, tmp); | ||
456 | - tcg_temp_free_i32(tmp); | ||
457 | - tmp = neon_load_reg(a->vm, pass * 2 + 1); | ||
458 | + read_neon_element32(tmp, a->vm, pass * 2 + 1, MO_32); | ||
459 | widenfn(rm1_64, tmp); | ||
460 | tcg_temp_free_i32(tmp); | ||
461 | + | ||
462 | opfn(rd_64, rm0_64, rm1_64); | ||
463 | tcg_temp_free_i64(rm0_64); | ||
464 | tcg_temp_free_i64(rm1_64); | ||
465 | @@ -XXX,XX +XXX,XX @@ static bool do_vmovn(DisasContext *s, arg_2misc *a, | ||
466 | narrowfn(rd0, cpu_env, rm); | ||
467 | neon_load_reg64(rm, a->vm + 1); | ||
468 | narrowfn(rd1, cpu_env, rm); | ||
469 | - neon_store_reg(a->vd, 0, rd0); | ||
470 | - neon_store_reg(a->vd, 1, rd1); | ||
471 | + write_neon_element32(rd0, a->vd, 0, MO_32); | ||
472 | + write_neon_element32(rd1, a->vd, 1, MO_32); | ||
473 | + tcg_temp_free_i32(rd0); | ||
474 | + tcg_temp_free_i32(rd1); | ||
475 | tcg_temp_free_i64(rm); | ||
476 | return true; | ||
477 | } | ||
478 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSHLL(DisasContext *s, arg_2misc *a) | ||
479 | } | ||
480 | |||
481 | rd = tcg_temp_new_i64(); | ||
482 | + rm0 = tcg_temp_new_i32(); | ||
483 | + rm1 = tcg_temp_new_i32(); | ||
484 | |||
485 | - rm0 = neon_load_reg(a->vm, 0); | ||
486 | - rm1 = neon_load_reg(a->vm, 1); | ||
487 | + read_neon_element32(rm0, a->vm, 0, MO_32); | ||
488 | + read_neon_element32(rm1, a->vm, 1, MO_32); | ||
489 | |||
490 | widenfn(rd, rm0); | ||
491 | tcg_gen_shli_i64(rd, rd, 8 << a->size); | ||
492 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_F16_F32(DisasContext *s, arg_2misc *a) | ||
493 | |||
494 | fpst = fpstatus_ptr(FPST_STD); | ||
495 | ahp = get_ahp_flag(); | ||
496 | - tmp = neon_load_reg(a->vm, 0); | ||
497 | + tmp = tcg_temp_new_i32(); | ||
498 | + read_neon_element32(tmp, a->vm, 0, MO_32); | ||
499 | gen_helper_vfp_fcvt_f32_to_f16(tmp, tmp, fpst, ahp); | ||
500 | - tmp2 = neon_load_reg(a->vm, 1); | ||
501 | + tmp2 = tcg_temp_new_i32(); | ||
502 | + read_neon_element32(tmp2, a->vm, 1, MO_32); | ||
503 | gen_helper_vfp_fcvt_f32_to_f16(tmp2, tmp2, fpst, ahp); | ||
504 | tcg_gen_shli_i32(tmp2, tmp2, 16); | ||
505 | tcg_gen_or_i32(tmp2, tmp2, tmp); | ||
506 | - tcg_temp_free_i32(tmp); | ||
507 | - tmp = neon_load_reg(a->vm, 2); | ||
508 | + read_neon_element32(tmp, a->vm, 2, MO_32); | ||
509 | gen_helper_vfp_fcvt_f32_to_f16(tmp, tmp, fpst, ahp); | ||
510 | - tmp3 = neon_load_reg(a->vm, 3); | ||
511 | - neon_store_reg(a->vd, 0, tmp2); | ||
512 | + tmp3 = tcg_temp_new_i32(); | ||
513 | + read_neon_element32(tmp3, a->vm, 3, MO_32); | ||
514 | + write_neon_element32(tmp2, a->vd, 0, MO_32); | ||
515 | + tcg_temp_free_i32(tmp2); | ||
516 | gen_helper_vfp_fcvt_f32_to_f16(tmp3, tmp3, fpst, ahp); | ||
517 | tcg_gen_shli_i32(tmp3, tmp3, 16); | ||
518 | tcg_gen_or_i32(tmp3, tmp3, tmp); | ||
519 | - neon_store_reg(a->vd, 1, tmp3); | ||
520 | + write_neon_element32(tmp3, a->vd, 1, MO_32); | ||
521 | + tcg_temp_free_i32(tmp3); | ||
522 | tcg_temp_free_i32(tmp); | ||
523 | tcg_temp_free_i32(ahp); | ||
524 | tcg_temp_free_ptr(fpst); | ||
525 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_F32_F16(DisasContext *s, arg_2misc *a) | ||
526 | fpst = fpstatus_ptr(FPST_STD); | ||
527 | ahp = get_ahp_flag(); | ||
528 | tmp3 = tcg_temp_new_i32(); | ||
529 | - tmp = neon_load_reg(a->vm, 0); | ||
530 | - tmp2 = neon_load_reg(a->vm, 1); | ||
531 | + tmp2 = tcg_temp_new_i32(); | ||
532 | + tmp = tcg_temp_new_i32(); | ||
533 | + read_neon_element32(tmp, a->vm, 0, MO_32); | ||
534 | + read_neon_element32(tmp2, a->vm, 1, MO_32); | ||
535 | tcg_gen_ext16u_i32(tmp3, tmp); | ||
536 | gen_helper_vfp_fcvt_f16_to_f32(tmp3, tmp3, fpst, ahp); | ||
537 | - neon_store_reg(a->vd, 0, tmp3); | ||
538 | + write_neon_element32(tmp3, a->vd, 0, MO_32); | ||
539 | tcg_gen_shri_i32(tmp, tmp, 16); | ||
540 | gen_helper_vfp_fcvt_f16_to_f32(tmp, tmp, fpst, ahp); | ||
541 | - neon_store_reg(a->vd, 1, tmp); | ||
542 | - tmp3 = tcg_temp_new_i32(); | ||
543 | + write_neon_element32(tmp, a->vd, 1, MO_32); | ||
544 | + tcg_temp_free_i32(tmp); | ||
545 | tcg_gen_ext16u_i32(tmp3, tmp2); | ||
546 | gen_helper_vfp_fcvt_f16_to_f32(tmp3, tmp3, fpst, ahp); | ||
547 | - neon_store_reg(a->vd, 2, tmp3); | ||
548 | + write_neon_element32(tmp3, a->vd, 2, MO_32); | ||
549 | + tcg_temp_free_i32(tmp3); | ||
550 | tcg_gen_shri_i32(tmp2, tmp2, 16); | ||
551 | gen_helper_vfp_fcvt_f16_to_f32(tmp2, tmp2, fpst, ahp); | ||
552 | - neon_store_reg(a->vd, 3, tmp2); | ||
553 | + write_neon_element32(tmp2, a->vd, 3, MO_32); | ||
554 | + tcg_temp_free_i32(tmp2); | ||
555 | tcg_temp_free_i32(ahp); | ||
556 | tcg_temp_free_ptr(fpst); | ||
557 | |||
558 | @@ -XXX,XX +XXX,XX @@ DO_2M_CRYPTO(SHA256SU0, aa32_sha2, 2) | ||
559 | |||
560 | static bool do_2misc(DisasContext *s, arg_2misc *a, NeonGenOneOpFn *fn) | ||
561 | { | ||
562 | + TCGv_i32 tmp; | ||
563 | int pass; | ||
564 | |||
565 | /* Handle a 2-reg-misc operation by iterating 32 bits at a time */ | ||
566 | @@ -XXX,XX +XXX,XX @@ static bool do_2misc(DisasContext *s, arg_2misc *a, NeonGenOneOpFn *fn) | ||
567 | return true; | ||
568 | } | ||
569 | |||
570 | + tmp = tcg_temp_new_i32(); | ||
571 | for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
572 | - TCGv_i32 tmp = neon_load_reg(a->vm, pass); | ||
573 | + read_neon_element32(tmp, a->vm, pass, MO_32); | ||
574 | fn(tmp, tmp); | ||
575 | - neon_store_reg(a->vd, pass, tmp); | ||
576 | + write_neon_element32(tmp, a->vd, pass, MO_32); | ||
577 | } | ||
578 | + tcg_temp_free_i32(tmp); | ||
579 | |||
580 | return true; | ||
581 | } | ||
582 | @@ -XXX,XX +XXX,XX @@ static bool trans_VTRN(DisasContext *s, arg_2misc *a) | ||
583 | return true; | ||
584 | } | ||
585 | |||
586 | - if (a->size == 2) { | ||
587 | + tmp = tcg_temp_new_i32(); | ||
588 | + tmp2 = tcg_temp_new_i32(); | ||
589 | + if (a->size == MO_32) { | ||
590 | for (pass = 0; pass < (a->q ? 4 : 2); pass += 2) { | ||
591 | - tmp = neon_load_reg(a->vm, pass); | ||
592 | - tmp2 = neon_load_reg(a->vd, pass + 1); | ||
593 | - neon_store_reg(a->vm, pass, tmp2); | ||
594 | - neon_store_reg(a->vd, pass + 1, tmp); | ||
595 | + read_neon_element32(tmp, a->vm, pass, MO_32); | ||
596 | + read_neon_element32(tmp2, a->vd, pass + 1, MO_32); | ||
597 | + write_neon_element32(tmp2, a->vm, pass, MO_32); | ||
598 | + write_neon_element32(tmp, a->vd, pass + 1, MO_32); | ||
599 | } | ||
600 | } else { | ||
601 | for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
602 | - tmp = neon_load_reg(a->vm, pass); | ||
603 | - tmp2 = neon_load_reg(a->vd, pass); | ||
604 | - if (a->size == 0) { | ||
605 | + read_neon_element32(tmp, a->vm, pass, MO_32); | ||
606 | + read_neon_element32(tmp2, a->vd, pass, MO_32); | ||
607 | + if (a->size == MO_8) { | ||
608 | gen_neon_trn_u8(tmp, tmp2); | ||
609 | } else { | ||
610 | gen_neon_trn_u16(tmp, tmp2); | ||
611 | } | ||
612 | - neon_store_reg(a->vm, pass, tmp2); | ||
613 | - neon_store_reg(a->vd, pass, tmp); | ||
614 | + write_neon_element32(tmp2, a->vm, pass, MO_32); | ||
615 | + write_neon_element32(tmp, a->vd, pass, MO_32); | ||
616 | } | ||
617 | } | ||
618 | + tcg_temp_free_i32(tmp); | ||
619 | + tcg_temp_free_i32(tmp2); | ||
620 | return true; | ||
621 | } | ||
426 | -- | 622 | -- |
427 | 2.20.1 | 623 | 2.20.1 |
428 | 624 | ||
429 | 625 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Richard Henderson <richard.henderson@linaro.org> | |
2 | |||
3 | We can then use this to improve VMOV (scalar to gp) and | ||
4 | VMOV (gp to scalar) so that we simply perform the memory | ||
5 | operation that we wanted, rather than inserting or | ||
6 | extracting from a 32-bit quantity. | ||
7 | |||
8 | These were the last uses of neon_load/store_reg, so remove them. | ||
9 | |||
10 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
11 | Message-id: 20201030022618.785675-7-richard.henderson@linaro.org | ||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | --- | ||
15 | target/arm/translate.c | 50 +++++++++++++----------- | ||
16 | target/arm/translate-vfp.c.inc | 71 +++++----------------------------- | ||
17 | 2 files changed, 37 insertions(+), 84 deletions(-) | ||
18 | |||
19 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
20 | index XXXXXXX..XXXXXXX 100644 | ||
21 | --- a/target/arm/translate.c | ||
22 | +++ b/target/arm/translate.c | ||
23 | @@ -XXX,XX +XXX,XX @@ static long neon_full_reg_offset(unsigned reg) | ||
24 | * Return the offset of a 2**SIZE piece of a NEON register, at index ELE, | ||
25 | * where 0 is the least significant end of the register. | ||
26 | */ | ||
27 | -static long neon_element_offset(int reg, int element, MemOp size) | ||
28 | +static long neon_element_offset(int reg, int element, MemOp memop) | ||
29 | { | ||
30 | - int element_size = 1 << size; | ||
31 | + int element_size = 1 << (memop & MO_SIZE); | ||
32 | int ofs = element * element_size; | ||
33 | #ifdef HOST_WORDS_BIGENDIAN | ||
34 | /* | ||
35 | @@ -XXX,XX +XXX,XX @@ static long vfp_reg_offset(bool dp, unsigned reg) | ||
36 | } | ||
37 | } | ||
38 | |||
39 | -static TCGv_i32 neon_load_reg(int reg, int pass) | ||
40 | -{ | ||
41 | - TCGv_i32 tmp = tcg_temp_new_i32(); | ||
42 | - tcg_gen_ld_i32(tmp, cpu_env, neon_element_offset(reg, pass, MO_32)); | ||
43 | - return tmp; | ||
44 | -} | ||
45 | - | ||
46 | -static void neon_store_reg(int reg, int pass, TCGv_i32 var) | ||
47 | -{ | ||
48 | - tcg_gen_st_i32(var, cpu_env, neon_element_offset(reg, pass, MO_32)); | ||
49 | - tcg_temp_free_i32(var); | ||
50 | -} | ||
51 | - | ||
52 | static inline void neon_load_reg64(TCGv_i64 var, int reg) | ||
53 | { | ||
54 | tcg_gen_ld_i64(var, cpu_env, vfp_reg_offset(1, reg)); | ||
55 | @@ -XXX,XX +XXX,XX @@ static inline void neon_store_reg32(TCGv_i32 var, int reg) | ||
56 | tcg_gen_st_i32(var, cpu_env, vfp_reg_offset(false, reg)); | ||
57 | } | ||
58 | |||
59 | -static void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp size) | ||
60 | +static void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp memop) | ||
61 | { | ||
62 | - long off = neon_element_offset(reg, ele, size); | ||
63 | + long off = neon_element_offset(reg, ele, memop); | ||
64 | |||
65 | - switch (size) { | ||
66 | - case MO_32: | ||
67 | + switch (memop) { | ||
68 | + case MO_SB: | ||
69 | + tcg_gen_ld8s_i32(dest, cpu_env, off); | ||
70 | + break; | ||
71 | + case MO_UB: | ||
72 | + tcg_gen_ld8u_i32(dest, cpu_env, off); | ||
73 | + break; | ||
74 | + case MO_SW: | ||
75 | + tcg_gen_ld16s_i32(dest, cpu_env, off); | ||
76 | + break; | ||
77 | + case MO_UW: | ||
78 | + tcg_gen_ld16u_i32(dest, cpu_env, off); | ||
79 | + break; | ||
80 | + case MO_UL: | ||
81 | + case MO_SL: | ||
82 | tcg_gen_ld_i32(dest, cpu_env, off); | ||
83 | break; | ||
84 | default: | ||
85 | @@ -XXX,XX +XXX,XX @@ static void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp size) | ||
86 | } | ||
87 | } | ||
88 | |||
89 | -static void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp size) | ||
90 | +static void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp memop) | ||
91 | { | ||
92 | - long off = neon_element_offset(reg, ele, size); | ||
93 | + long off = neon_element_offset(reg, ele, memop); | ||
94 | |||
95 | - switch (size) { | ||
96 | + switch (memop) { | ||
97 | + case MO_8: | ||
98 | + tcg_gen_st8_i32(src, cpu_env, off); | ||
99 | + break; | ||
100 | + case MO_16: | ||
101 | + tcg_gen_st16_i32(src, cpu_env, off); | ||
102 | + break; | ||
103 | case MO_32: | ||
104 | tcg_gen_st_i32(src, cpu_env, off); | ||
105 | break; | ||
106 | diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc | ||
107 | index XXXXXXX..XXXXXXX 100644 | ||
108 | --- a/target/arm/translate-vfp.c.inc | ||
109 | +++ b/target/arm/translate-vfp.c.inc | ||
110 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_to_gp(DisasContext *s, arg_VMOV_to_gp *a) | ||
111 | { | ||
112 | /* VMOV scalar to general purpose register */ | ||
113 | TCGv_i32 tmp; | ||
114 | - int pass; | ||
115 | - uint32_t offset; | ||
116 | |||
117 | - /* SIZE == 2 is a VFP instruction; otherwise NEON. */ | ||
118 | - if (a->size == 2 | ||
119 | + /* SIZE == MO_32 is a VFP instruction; otherwise NEON. */ | ||
120 | + if (a->size == MO_32 | ||
121 | ? !dc_isar_feature(aa32_fpsp_v2, s) | ||
122 | : !arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
123 | return false; | ||
124 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_to_gp(DisasContext *s, arg_VMOV_to_gp *a) | ||
125 | return false; | ||
126 | } | ||
127 | |||
128 | - offset = a->index << a->size; | ||
129 | - pass = extract32(offset, 2, 1); | ||
130 | - offset = extract32(offset, 0, 2) * 8; | ||
131 | - | ||
132 | if (!vfp_access_check(s)) { | ||
133 | return true; | ||
134 | } | ||
135 | |||
136 | - tmp = neon_load_reg(a->vn, pass); | ||
137 | - switch (a->size) { | ||
138 | - case 0: | ||
139 | - if (offset) { | ||
140 | - tcg_gen_shri_i32(tmp, tmp, offset); | ||
141 | - } | ||
142 | - if (a->u) { | ||
143 | - gen_uxtb(tmp); | ||
144 | - } else { | ||
145 | - gen_sxtb(tmp); | ||
146 | - } | ||
147 | - break; | ||
148 | - case 1: | ||
149 | - if (a->u) { | ||
150 | - if (offset) { | ||
151 | - tcg_gen_shri_i32(tmp, tmp, 16); | ||
152 | - } else { | ||
153 | - gen_uxth(tmp); | ||
154 | - } | ||
155 | - } else { | ||
156 | - if (offset) { | ||
157 | - tcg_gen_sari_i32(tmp, tmp, 16); | ||
158 | - } else { | ||
159 | - gen_sxth(tmp); | ||
160 | - } | ||
161 | - } | ||
162 | - break; | ||
163 | - case 2: | ||
164 | - break; | ||
165 | - } | ||
166 | + tmp = tcg_temp_new_i32(); | ||
167 | + read_neon_element32(tmp, a->vn, a->index, a->size | (a->u ? 0 : MO_SIGN)); | ||
168 | store_reg(s, a->rt, tmp); | ||
169 | |||
170 | return true; | ||
171 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_to_gp(DisasContext *s, arg_VMOV_to_gp *a) | ||
172 | static bool trans_VMOV_from_gp(DisasContext *s, arg_VMOV_from_gp *a) | ||
173 | { | ||
174 | /* VMOV general purpose register to scalar */ | ||
175 | - TCGv_i32 tmp, tmp2; | ||
176 | - int pass; | ||
177 | - uint32_t offset; | ||
178 | + TCGv_i32 tmp; | ||
179 | |||
180 | - /* SIZE == 2 is a VFP instruction; otherwise NEON. */ | ||
181 | - if (a->size == 2 | ||
182 | + /* SIZE == MO_32 is a VFP instruction; otherwise NEON. */ | ||
183 | + if (a->size == MO_32 | ||
184 | ? !dc_isar_feature(aa32_fpsp_v2, s) | ||
185 | : !arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
186 | return false; | ||
187 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_from_gp(DisasContext *s, arg_VMOV_from_gp *a) | ||
188 | return false; | ||
189 | } | ||
190 | |||
191 | - offset = a->index << a->size; | ||
192 | - pass = extract32(offset, 2, 1); | ||
193 | - offset = extract32(offset, 0, 2) * 8; | ||
194 | - | ||
195 | if (!vfp_access_check(s)) { | ||
196 | return true; | ||
197 | } | ||
198 | |||
199 | tmp = load_reg(s, a->rt); | ||
200 | - switch (a->size) { | ||
201 | - case 0: | ||
202 | - tmp2 = neon_load_reg(a->vn, pass); | ||
203 | - tcg_gen_deposit_i32(tmp, tmp2, tmp, offset, 8); | ||
204 | - tcg_temp_free_i32(tmp2); | ||
205 | - break; | ||
206 | - case 1: | ||
207 | - tmp2 = neon_load_reg(a->vn, pass); | ||
208 | - tcg_gen_deposit_i32(tmp, tmp2, tmp, offset, 16); | ||
209 | - tcg_temp_free_i32(tmp2); | ||
210 | - break; | ||
211 | - case 2: | ||
212 | - break; | ||
213 | - } | ||
214 | - neon_store_reg(a->vn, pass, tmp); | ||
215 | + write_neon_element32(tmp, a->vn, a->index, a->size); | ||
216 | + tcg_temp_free_i32(tmp); | ||
217 | |||
218 | return true; | ||
219 | } | ||
220 | -- | ||
221 | 2.20.1 | ||
222 | |||
223 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | The only uses of this function are for loading VFP | ||
4 | single-precision values, and nothing to do with NEON. | ||
5 | |||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Message-id: 20201030022618.785675-8-richard.henderson@linaro.org | ||
8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/translate.c | 4 +- | ||
12 | target/arm/translate-vfp.c.inc | 184 ++++++++++++++++----------------- | ||
13 | 2 files changed, 94 insertions(+), 94 deletions(-) | ||
14 | |||
15 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/target/arm/translate.c | ||
18 | +++ b/target/arm/translate.c | ||
19 | @@ -XXX,XX +XXX,XX @@ static inline void neon_store_reg64(TCGv_i64 var, int reg) | ||
20 | tcg_gen_st_i64(var, cpu_env, vfp_reg_offset(1, reg)); | ||
21 | } | ||
22 | |||
23 | -static inline void neon_load_reg32(TCGv_i32 var, int reg) | ||
24 | +static inline void vfp_load_reg32(TCGv_i32 var, int reg) | ||
25 | { | ||
26 | tcg_gen_ld_i32(var, cpu_env, vfp_reg_offset(false, reg)); | ||
27 | } | ||
28 | |||
29 | -static inline void neon_store_reg32(TCGv_i32 var, int reg) | ||
30 | +static inline void vfp_store_reg32(TCGv_i32 var, int reg) | ||
31 | { | ||
32 | tcg_gen_st_i32(var, cpu_env, vfp_reg_offset(false, reg)); | ||
33 | } | ||
34 | diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc | ||
35 | index XXXXXXX..XXXXXXX 100644 | ||
36 | --- a/target/arm/translate-vfp.c.inc | ||
37 | +++ b/target/arm/translate-vfp.c.inc | ||
38 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSEL(DisasContext *s, arg_VSEL *a) | ||
39 | frn = tcg_temp_new_i32(); | ||
40 | frm = tcg_temp_new_i32(); | ||
41 | dest = tcg_temp_new_i32(); | ||
42 | - neon_load_reg32(frn, rn); | ||
43 | - neon_load_reg32(frm, rm); | ||
44 | + vfp_load_reg32(frn, rn); | ||
45 | + vfp_load_reg32(frm, rm); | ||
46 | switch (a->cc) { | ||
47 | case 0: /* eq: Z */ | ||
48 | tcg_gen_movcond_i32(TCG_COND_EQ, dest, cpu_ZF, zero, | ||
49 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSEL(DisasContext *s, arg_VSEL *a) | ||
50 | if (sz == 1) { | ||
51 | tcg_gen_andi_i32(dest, dest, 0xffff); | ||
52 | } | ||
53 | - neon_store_reg32(dest, rd); | ||
54 | + vfp_store_reg32(dest, rd); | ||
55 | tcg_temp_free_i32(frn); | ||
56 | tcg_temp_free_i32(frm); | ||
57 | tcg_temp_free_i32(dest); | ||
58 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINT(DisasContext *s, arg_VRINT *a) | ||
59 | TCGv_i32 tcg_res; | ||
60 | tcg_op = tcg_temp_new_i32(); | ||
61 | tcg_res = tcg_temp_new_i32(); | ||
62 | - neon_load_reg32(tcg_op, rm); | ||
63 | + vfp_load_reg32(tcg_op, rm); | ||
64 | if (sz == 1) { | ||
65 | gen_helper_rinth(tcg_res, tcg_op, fpst); | ||
66 | } else { | ||
67 | gen_helper_rints(tcg_res, tcg_op, fpst); | ||
68 | } | ||
69 | - neon_store_reg32(tcg_res, rd); | ||
70 | + vfp_store_reg32(tcg_res, rd); | ||
71 | tcg_temp_free_i32(tcg_op); | ||
72 | tcg_temp_free_i32(tcg_res); | ||
73 | } | ||
74 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT(DisasContext *s, arg_VCVT *a) | ||
75 | gen_helper_vfp_tould(tcg_res, tcg_double, tcg_shift, fpst); | ||
76 | } | ||
77 | tcg_gen_extrl_i64_i32(tcg_tmp, tcg_res); | ||
78 | - neon_store_reg32(tcg_tmp, rd); | ||
79 | + vfp_store_reg32(tcg_tmp, rd); | ||
80 | tcg_temp_free_i32(tcg_tmp); | ||
81 | tcg_temp_free_i64(tcg_res); | ||
82 | tcg_temp_free_i64(tcg_double); | ||
83 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT(DisasContext *s, arg_VCVT *a) | ||
84 | TCGv_i32 tcg_single, tcg_res; | ||
85 | tcg_single = tcg_temp_new_i32(); | ||
86 | tcg_res = tcg_temp_new_i32(); | ||
87 | - neon_load_reg32(tcg_single, rm); | ||
88 | + vfp_load_reg32(tcg_single, rm); | ||
89 | if (sz == 1) { | ||
90 | if (is_signed) { | ||
91 | gen_helper_vfp_toslh(tcg_res, tcg_single, tcg_shift, fpst); | ||
92 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT(DisasContext *s, arg_VCVT *a) | ||
93 | gen_helper_vfp_touls(tcg_res, tcg_single, tcg_shift, fpst); | ||
94 | } | ||
95 | } | ||
96 | - neon_store_reg32(tcg_res, rd); | ||
97 | + vfp_store_reg32(tcg_res, rd); | ||
98 | tcg_temp_free_i32(tcg_res); | ||
99 | tcg_temp_free_i32(tcg_single); | ||
100 | } | ||
101 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_half(DisasContext *s, arg_VMOV_single *a) | ||
102 | if (a->l) { | ||
103 | /* VFP to general purpose register */ | ||
104 | tmp = tcg_temp_new_i32(); | ||
105 | - neon_load_reg32(tmp, a->vn); | ||
106 | + vfp_load_reg32(tmp, a->vn); | ||
107 | tcg_gen_andi_i32(tmp, tmp, 0xffff); | ||
108 | store_reg(s, a->rt, tmp); | ||
109 | } else { | ||
110 | /* general purpose register to VFP */ | ||
111 | tmp = load_reg(s, a->rt); | ||
112 | tcg_gen_andi_i32(tmp, tmp, 0xffff); | ||
113 | - neon_store_reg32(tmp, a->vn); | ||
114 | + vfp_store_reg32(tmp, a->vn); | ||
115 | tcg_temp_free_i32(tmp); | ||
116 | } | ||
117 | |||
118 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_single(DisasContext *s, arg_VMOV_single *a) | ||
119 | if (a->l) { | ||
120 | /* VFP to general purpose register */ | ||
121 | tmp = tcg_temp_new_i32(); | ||
122 | - neon_load_reg32(tmp, a->vn); | ||
123 | + vfp_load_reg32(tmp, a->vn); | ||
124 | if (a->rt == 15) { | ||
125 | /* Set the 4 flag bits in the CPSR. */ | ||
126 | gen_set_nzcv(tmp); | ||
127 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_single(DisasContext *s, arg_VMOV_single *a) | ||
128 | } else { | ||
129 | /* general purpose register to VFP */ | ||
130 | tmp = load_reg(s, a->rt); | ||
131 | - neon_store_reg32(tmp, a->vn); | ||
132 | + vfp_store_reg32(tmp, a->vn); | ||
133 | tcg_temp_free_i32(tmp); | ||
134 | } | ||
135 | |||
136 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_64_sp(DisasContext *s, arg_VMOV_64_sp *a) | ||
137 | if (a->op) { | ||
138 | /* fpreg to gpreg */ | ||
139 | tmp = tcg_temp_new_i32(); | ||
140 | - neon_load_reg32(tmp, a->vm); | ||
141 | + vfp_load_reg32(tmp, a->vm); | ||
142 | store_reg(s, a->rt, tmp); | ||
143 | tmp = tcg_temp_new_i32(); | ||
144 | - neon_load_reg32(tmp, a->vm + 1); | ||
145 | + vfp_load_reg32(tmp, a->vm + 1); | ||
146 | store_reg(s, a->rt2, tmp); | ||
147 | } else { | ||
148 | /* gpreg to fpreg */ | ||
149 | tmp = load_reg(s, a->rt); | ||
150 | - neon_store_reg32(tmp, a->vm); | ||
151 | + vfp_store_reg32(tmp, a->vm); | ||
152 | tcg_temp_free_i32(tmp); | ||
153 | tmp = load_reg(s, a->rt2); | ||
154 | - neon_store_reg32(tmp, a->vm + 1); | ||
155 | + vfp_store_reg32(tmp, a->vm + 1); | ||
156 | tcg_temp_free_i32(tmp); | ||
157 | } | ||
158 | |||
159 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_64_dp(DisasContext *s, arg_VMOV_64_dp *a) | ||
160 | if (a->op) { | ||
161 | /* fpreg to gpreg */ | ||
162 | tmp = tcg_temp_new_i32(); | ||
163 | - neon_load_reg32(tmp, a->vm * 2); | ||
164 | + vfp_load_reg32(tmp, a->vm * 2); | ||
165 | store_reg(s, a->rt, tmp); | ||
166 | tmp = tcg_temp_new_i32(); | ||
167 | - neon_load_reg32(tmp, a->vm * 2 + 1); | ||
168 | + vfp_load_reg32(tmp, a->vm * 2 + 1); | ||
169 | store_reg(s, a->rt2, tmp); | ||
170 | } else { | ||
171 | /* gpreg to fpreg */ | ||
172 | tmp = load_reg(s, a->rt); | ||
173 | - neon_store_reg32(tmp, a->vm * 2); | ||
174 | + vfp_store_reg32(tmp, a->vm * 2); | ||
175 | tcg_temp_free_i32(tmp); | ||
176 | tmp = load_reg(s, a->rt2); | ||
177 | - neon_store_reg32(tmp, a->vm * 2 + 1); | ||
178 | + vfp_store_reg32(tmp, a->vm * 2 + 1); | ||
179 | tcg_temp_free_i32(tmp); | ||
180 | } | ||
181 | |||
182 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDR_VSTR_hp(DisasContext *s, arg_VLDR_VSTR_sp *a) | ||
183 | tmp = tcg_temp_new_i32(); | ||
184 | if (a->l) { | ||
185 | gen_aa32_ld16u(s, tmp, addr, get_mem_index(s)); | ||
186 | - neon_store_reg32(tmp, a->vd); | ||
187 | + vfp_store_reg32(tmp, a->vd); | ||
188 | } else { | ||
189 | - neon_load_reg32(tmp, a->vd); | ||
190 | + vfp_load_reg32(tmp, a->vd); | ||
191 | gen_aa32_st16(s, tmp, addr, get_mem_index(s)); | ||
192 | } | ||
193 | tcg_temp_free_i32(tmp); | ||
194 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDR_VSTR_sp(DisasContext *s, arg_VLDR_VSTR_sp *a) | ||
195 | tmp = tcg_temp_new_i32(); | ||
196 | if (a->l) { | ||
197 | gen_aa32_ld32u(s, tmp, addr, get_mem_index(s)); | ||
198 | - neon_store_reg32(tmp, a->vd); | ||
199 | + vfp_store_reg32(tmp, a->vd); | ||
200 | } else { | ||
201 | - neon_load_reg32(tmp, a->vd); | ||
202 | + vfp_load_reg32(tmp, a->vd); | ||
203 | gen_aa32_st32(s, tmp, addr, get_mem_index(s)); | ||
204 | } | ||
205 | tcg_temp_free_i32(tmp); | ||
206 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDM_VSTM_sp(DisasContext *s, arg_VLDM_VSTM_sp *a) | ||
207 | if (a->l) { | ||
208 | /* load */ | ||
209 | gen_aa32_ld32u(s, tmp, addr, get_mem_index(s)); | ||
210 | - neon_store_reg32(tmp, a->vd + i); | ||
211 | + vfp_store_reg32(tmp, a->vd + i); | ||
212 | } else { | ||
213 | /* store */ | ||
214 | - neon_load_reg32(tmp, a->vd + i); | ||
215 | + vfp_load_reg32(tmp, a->vd + i); | ||
216 | gen_aa32_st32(s, tmp, addr, get_mem_index(s)); | ||
217 | } | ||
218 | tcg_gen_addi_i32(addr, addr, offset); | ||
219 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_3op_sp(DisasContext *s, VFPGen3OpSPFn *fn, | ||
220 | fd = tcg_temp_new_i32(); | ||
221 | fpst = fpstatus_ptr(FPST_FPCR); | ||
222 | |||
223 | - neon_load_reg32(f0, vn); | ||
224 | - neon_load_reg32(f1, vm); | ||
225 | + vfp_load_reg32(f0, vn); | ||
226 | + vfp_load_reg32(f1, vm); | ||
227 | |||
228 | for (;;) { | ||
229 | if (reads_vd) { | ||
230 | - neon_load_reg32(fd, vd); | ||
231 | + vfp_load_reg32(fd, vd); | ||
232 | } | ||
233 | fn(fd, f0, f1, fpst); | ||
234 | - neon_store_reg32(fd, vd); | ||
235 | + vfp_store_reg32(fd, vd); | ||
236 | |||
237 | if (veclen == 0) { | ||
238 | break; | ||
239 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_3op_sp(DisasContext *s, VFPGen3OpSPFn *fn, | ||
240 | veclen--; | ||
241 | vd = vfp_advance_sreg(vd, delta_d); | ||
242 | vn = vfp_advance_sreg(vn, delta_d); | ||
243 | - neon_load_reg32(f0, vn); | ||
244 | + vfp_load_reg32(f0, vn); | ||
245 | if (delta_m) { | ||
246 | vm = vfp_advance_sreg(vm, delta_m); | ||
247 | - neon_load_reg32(f1, vm); | ||
248 | + vfp_load_reg32(f1, vm); | ||
249 | } | ||
250 | } | ||
251 | |||
252 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_3op_hp(DisasContext *s, VFPGen3OpSPFn *fn, | ||
253 | fd = tcg_temp_new_i32(); | ||
254 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
255 | |||
256 | - neon_load_reg32(f0, vn); | ||
257 | - neon_load_reg32(f1, vm); | ||
258 | + vfp_load_reg32(f0, vn); | ||
259 | + vfp_load_reg32(f1, vm); | ||
260 | |||
261 | if (reads_vd) { | ||
262 | - neon_load_reg32(fd, vd); | ||
263 | + vfp_load_reg32(fd, vd); | ||
264 | } | ||
265 | fn(fd, f0, f1, fpst); | ||
266 | - neon_store_reg32(fd, vd); | ||
267 | + vfp_store_reg32(fd, vd); | ||
268 | |||
269 | tcg_temp_free_i32(f0); | ||
270 | tcg_temp_free_i32(f1); | ||
271 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_sp(DisasContext *s, VFPGen2OpSPFn *fn, int vd, int vm) | ||
272 | f0 = tcg_temp_new_i32(); | ||
273 | fd = tcg_temp_new_i32(); | ||
274 | |||
275 | - neon_load_reg32(f0, vm); | ||
276 | + vfp_load_reg32(f0, vm); | ||
277 | |||
278 | for (;;) { | ||
279 | fn(fd, f0); | ||
280 | - neon_store_reg32(fd, vd); | ||
281 | + vfp_store_reg32(fd, vd); | ||
282 | |||
283 | if (veclen == 0) { | ||
284 | break; | ||
285 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_sp(DisasContext *s, VFPGen2OpSPFn *fn, int vd, int vm) | ||
286 | /* single source one-many */ | ||
287 | while (veclen--) { | ||
288 | vd = vfp_advance_sreg(vd, delta_d); | ||
289 | - neon_store_reg32(fd, vd); | ||
290 | + vfp_store_reg32(fd, vd); | ||
291 | } | ||
292 | break; | ||
293 | } | ||
294 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_sp(DisasContext *s, VFPGen2OpSPFn *fn, int vd, int vm) | ||
295 | veclen--; | ||
296 | vd = vfp_advance_sreg(vd, delta_d); | ||
297 | vm = vfp_advance_sreg(vm, delta_m); | ||
298 | - neon_load_reg32(f0, vm); | ||
299 | + vfp_load_reg32(f0, vm); | ||
300 | } | ||
301 | |||
302 | tcg_temp_free_i32(f0); | ||
303 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_hp(DisasContext *s, VFPGen2OpSPFn *fn, int vd, int vm) | ||
304 | } | ||
305 | |||
306 | f0 = tcg_temp_new_i32(); | ||
307 | - neon_load_reg32(f0, vm); | ||
308 | + vfp_load_reg32(f0, vm); | ||
309 | fn(f0, f0); | ||
310 | - neon_store_reg32(f0, vd); | ||
311 | + vfp_store_reg32(f0, vd); | ||
312 | tcg_temp_free_i32(f0); | ||
313 | |||
314 | return true; | ||
315 | @@ -XXX,XX +XXX,XX @@ static bool do_vfm_hp(DisasContext *s, arg_VFMA_sp *a, bool neg_n, bool neg_d) | ||
316 | vm = tcg_temp_new_i32(); | ||
317 | vd = tcg_temp_new_i32(); | ||
318 | |||
319 | - neon_load_reg32(vn, a->vn); | ||
320 | - neon_load_reg32(vm, a->vm); | ||
321 | + vfp_load_reg32(vn, a->vn); | ||
322 | + vfp_load_reg32(vm, a->vm); | ||
323 | if (neg_n) { | ||
324 | /* VFNMS, VFMS */ | ||
325 | gen_helper_vfp_negh(vn, vn); | ||
326 | } | ||
327 | - neon_load_reg32(vd, a->vd); | ||
328 | + vfp_load_reg32(vd, a->vd); | ||
329 | if (neg_d) { | ||
330 | /* VFNMA, VFNMS */ | ||
331 | gen_helper_vfp_negh(vd, vd); | ||
332 | } | ||
333 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
334 | gen_helper_vfp_muladdh(vd, vn, vm, vd, fpst); | ||
335 | - neon_store_reg32(vd, a->vd); | ||
336 | + vfp_store_reg32(vd, a->vd); | ||
337 | |||
338 | tcg_temp_free_ptr(fpst); | ||
339 | tcg_temp_free_i32(vn); | ||
340 | @@ -XXX,XX +XXX,XX @@ static bool do_vfm_sp(DisasContext *s, arg_VFMA_sp *a, bool neg_n, bool neg_d) | ||
341 | vm = tcg_temp_new_i32(); | ||
342 | vd = tcg_temp_new_i32(); | ||
343 | |||
344 | - neon_load_reg32(vn, a->vn); | ||
345 | - neon_load_reg32(vm, a->vm); | ||
346 | + vfp_load_reg32(vn, a->vn); | ||
347 | + vfp_load_reg32(vm, a->vm); | ||
348 | if (neg_n) { | ||
349 | /* VFNMS, VFMS */ | ||
350 | gen_helper_vfp_negs(vn, vn); | ||
351 | } | ||
352 | - neon_load_reg32(vd, a->vd); | ||
353 | + vfp_load_reg32(vd, a->vd); | ||
354 | if (neg_d) { | ||
355 | /* VFNMA, VFNMS */ | ||
356 | gen_helper_vfp_negs(vd, vd); | ||
357 | } | ||
358 | fpst = fpstatus_ptr(FPST_FPCR); | ||
359 | gen_helper_vfp_muladds(vd, vn, vm, vd, fpst); | ||
360 | - neon_store_reg32(vd, a->vd); | ||
361 | + vfp_store_reg32(vd, a->vd); | ||
362 | |||
363 | tcg_temp_free_ptr(fpst); | ||
364 | tcg_temp_free_i32(vn); | ||
365 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_imm_hp(DisasContext *s, arg_VMOV_imm_sp *a) | ||
366 | } | ||
367 | |||
368 | fd = tcg_const_i32(vfp_expand_imm(MO_16, a->imm)); | ||
369 | - neon_store_reg32(fd, a->vd); | ||
370 | + vfp_store_reg32(fd, a->vd); | ||
371 | tcg_temp_free_i32(fd); | ||
372 | return true; | ||
373 | } | ||
374 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_imm_sp(DisasContext *s, arg_VMOV_imm_sp *a) | ||
375 | fd = tcg_const_i32(vfp_expand_imm(MO_32, a->imm)); | ||
376 | |||
377 | for (;;) { | ||
378 | - neon_store_reg32(fd, vd); | ||
379 | + vfp_store_reg32(fd, vd); | ||
380 | |||
381 | if (veclen == 0) { | ||
382 | break; | ||
383 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCMP_hp(DisasContext *s, arg_VCMP_sp *a) | ||
384 | vd = tcg_temp_new_i32(); | ||
385 | vm = tcg_temp_new_i32(); | ||
386 | |||
387 | - neon_load_reg32(vd, a->vd); | ||
388 | + vfp_load_reg32(vd, a->vd); | ||
389 | if (a->z) { | ||
390 | tcg_gen_movi_i32(vm, 0); | ||
391 | } else { | ||
392 | - neon_load_reg32(vm, a->vm); | ||
393 | + vfp_load_reg32(vm, a->vm); | ||
394 | } | ||
395 | |||
396 | if (a->e) { | ||
397 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCMP_sp(DisasContext *s, arg_VCMP_sp *a) | ||
398 | vd = tcg_temp_new_i32(); | ||
399 | vm = tcg_temp_new_i32(); | ||
400 | |||
401 | - neon_load_reg32(vd, a->vd); | ||
402 | + vfp_load_reg32(vd, a->vd); | ||
403 | if (a->z) { | ||
404 | tcg_gen_movi_i32(vm, 0); | ||
405 | } else { | ||
406 | - neon_load_reg32(vm, a->vm); | ||
407 | + vfp_load_reg32(vm, a->vm); | ||
408 | } | ||
409 | |||
410 | if (a->e) { | ||
411 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_f32_f16(DisasContext *s, arg_VCVT_f32_f16 *a) | ||
412 | /* The T bit tells us if we want the low or high 16 bits of Vm */ | ||
413 | tcg_gen_ld16u_i32(tmp, cpu_env, vfp_f16_offset(a->vm, a->t)); | ||
414 | gen_helper_vfp_fcvt_f16_to_f32(tmp, tmp, fpst, ahp_mode); | ||
415 | - neon_store_reg32(tmp, a->vd); | ||
416 | + vfp_store_reg32(tmp, a->vd); | ||
417 | tcg_temp_free_i32(ahp_mode); | ||
418 | tcg_temp_free_ptr(fpst); | ||
419 | tcg_temp_free_i32(tmp); | ||
420 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_f16_f32(DisasContext *s, arg_VCVT_f16_f32 *a) | ||
421 | ahp_mode = get_ahp_flag(); | ||
422 | tmp = tcg_temp_new_i32(); | ||
423 | |||
424 | - neon_load_reg32(tmp, a->vm); | ||
425 | + vfp_load_reg32(tmp, a->vm); | ||
426 | gen_helper_vfp_fcvt_f32_to_f16(tmp, tmp, fpst, ahp_mode); | ||
427 | tcg_gen_st16_i32(tmp, cpu_env, vfp_f16_offset(a->vd, a->t)); | ||
428 | tcg_temp_free_i32(ahp_mode); | ||
429 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTR_hp(DisasContext *s, arg_VRINTR_sp *a) | ||
430 | } | ||
431 | |||
432 | tmp = tcg_temp_new_i32(); | ||
433 | - neon_load_reg32(tmp, a->vm); | ||
434 | + vfp_load_reg32(tmp, a->vm); | ||
435 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
436 | gen_helper_rinth(tmp, tmp, fpst); | ||
437 | - neon_store_reg32(tmp, a->vd); | ||
438 | + vfp_store_reg32(tmp, a->vd); | ||
439 | tcg_temp_free_ptr(fpst); | ||
440 | tcg_temp_free_i32(tmp); | ||
441 | return true; | ||
442 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTR_sp(DisasContext *s, arg_VRINTR_sp *a) | ||
443 | } | ||
444 | |||
445 | tmp = tcg_temp_new_i32(); | ||
446 | - neon_load_reg32(tmp, a->vm); | ||
447 | + vfp_load_reg32(tmp, a->vm); | ||
448 | fpst = fpstatus_ptr(FPST_FPCR); | ||
449 | gen_helper_rints(tmp, tmp, fpst); | ||
450 | - neon_store_reg32(tmp, a->vd); | ||
451 | + vfp_store_reg32(tmp, a->vd); | ||
452 | tcg_temp_free_ptr(fpst); | ||
453 | tcg_temp_free_i32(tmp); | ||
454 | return true; | ||
455 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTZ_hp(DisasContext *s, arg_VRINTZ_sp *a) | ||
456 | } | ||
457 | |||
458 | tmp = tcg_temp_new_i32(); | ||
459 | - neon_load_reg32(tmp, a->vm); | ||
460 | + vfp_load_reg32(tmp, a->vm); | ||
461 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
462 | tcg_rmode = tcg_const_i32(float_round_to_zero); | ||
463 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
464 | gen_helper_rinth(tmp, tmp, fpst); | ||
465 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
466 | - neon_store_reg32(tmp, a->vd); | ||
467 | + vfp_store_reg32(tmp, a->vd); | ||
468 | tcg_temp_free_ptr(fpst); | ||
469 | tcg_temp_free_i32(tcg_rmode); | ||
470 | tcg_temp_free_i32(tmp); | ||
471 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTZ_sp(DisasContext *s, arg_VRINTZ_sp *a) | ||
472 | } | ||
473 | |||
474 | tmp = tcg_temp_new_i32(); | ||
475 | - neon_load_reg32(tmp, a->vm); | ||
476 | + vfp_load_reg32(tmp, a->vm); | ||
477 | fpst = fpstatus_ptr(FPST_FPCR); | ||
478 | tcg_rmode = tcg_const_i32(float_round_to_zero); | ||
479 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
480 | gen_helper_rints(tmp, tmp, fpst); | ||
481 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
482 | - neon_store_reg32(tmp, a->vd); | ||
483 | + vfp_store_reg32(tmp, a->vd); | ||
484 | tcg_temp_free_ptr(fpst); | ||
485 | tcg_temp_free_i32(tcg_rmode); | ||
486 | tcg_temp_free_i32(tmp); | ||
487 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTX_hp(DisasContext *s, arg_VRINTX_sp *a) | ||
488 | } | ||
489 | |||
490 | tmp = tcg_temp_new_i32(); | ||
491 | - neon_load_reg32(tmp, a->vm); | ||
492 | + vfp_load_reg32(tmp, a->vm); | ||
493 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
494 | gen_helper_rinth_exact(tmp, tmp, fpst); | ||
495 | - neon_store_reg32(tmp, a->vd); | ||
496 | + vfp_store_reg32(tmp, a->vd); | ||
497 | tcg_temp_free_ptr(fpst); | ||
498 | tcg_temp_free_i32(tmp); | ||
499 | return true; | ||
500 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTX_sp(DisasContext *s, arg_VRINTX_sp *a) | ||
501 | } | ||
502 | |||
503 | tmp = tcg_temp_new_i32(); | ||
504 | - neon_load_reg32(tmp, a->vm); | ||
505 | + vfp_load_reg32(tmp, a->vm); | ||
506 | fpst = fpstatus_ptr(FPST_FPCR); | ||
507 | gen_helper_rints_exact(tmp, tmp, fpst); | ||
508 | - neon_store_reg32(tmp, a->vd); | ||
509 | + vfp_store_reg32(tmp, a->vd); | ||
510 | tcg_temp_free_ptr(fpst); | ||
511 | tcg_temp_free_i32(tmp); | ||
512 | return true; | ||
513 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_sp(DisasContext *s, arg_VCVT_sp *a) | ||
514 | |||
515 | vm = tcg_temp_new_i32(); | ||
516 | vd = tcg_temp_new_i64(); | ||
517 | - neon_load_reg32(vm, a->vm); | ||
518 | + vfp_load_reg32(vm, a->vm); | ||
519 | gen_helper_vfp_fcvtds(vd, vm, cpu_env); | ||
520 | neon_store_reg64(vd, a->vd); | ||
521 | tcg_temp_free_i32(vm); | ||
522 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_dp(DisasContext *s, arg_VCVT_dp *a) | ||
523 | vm = tcg_temp_new_i64(); | ||
524 | neon_load_reg64(vm, a->vm); | ||
525 | gen_helper_vfp_fcvtsd(vd, vm, cpu_env); | ||
526 | - neon_store_reg32(vd, a->vd); | ||
527 | + vfp_store_reg32(vd, a->vd); | ||
528 | tcg_temp_free_i32(vd); | ||
529 | tcg_temp_free_i64(vm); | ||
530 | return true; | ||
531 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_hp(DisasContext *s, arg_VCVT_int_sp *a) | ||
532 | } | ||
533 | |||
534 | vm = tcg_temp_new_i32(); | ||
535 | - neon_load_reg32(vm, a->vm); | ||
536 | + vfp_load_reg32(vm, a->vm); | ||
537 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
538 | if (a->s) { | ||
539 | /* i32 -> f16 */ | ||
540 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_hp(DisasContext *s, arg_VCVT_int_sp *a) | ||
541 | /* u32 -> f16 */ | ||
542 | gen_helper_vfp_uitoh(vm, vm, fpst); | ||
543 | } | ||
544 | - neon_store_reg32(vm, a->vd); | ||
545 | + vfp_store_reg32(vm, a->vd); | ||
546 | tcg_temp_free_i32(vm); | ||
547 | tcg_temp_free_ptr(fpst); | ||
548 | return true; | ||
549 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_sp(DisasContext *s, arg_VCVT_int_sp *a) | ||
550 | } | ||
551 | |||
552 | vm = tcg_temp_new_i32(); | ||
553 | - neon_load_reg32(vm, a->vm); | ||
554 | + vfp_load_reg32(vm, a->vm); | ||
555 | fpst = fpstatus_ptr(FPST_FPCR); | ||
556 | if (a->s) { | ||
557 | /* i32 -> f32 */ | ||
558 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_sp(DisasContext *s, arg_VCVT_int_sp *a) | ||
559 | /* u32 -> f32 */ | ||
560 | gen_helper_vfp_uitos(vm, vm, fpst); | ||
561 | } | ||
562 | - neon_store_reg32(vm, a->vd); | ||
563 | + vfp_store_reg32(vm, a->vd); | ||
564 | tcg_temp_free_i32(vm); | ||
565 | tcg_temp_free_ptr(fpst); | ||
566 | return true; | ||
567 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_dp(DisasContext *s, arg_VCVT_int_dp *a) | ||
568 | |||
569 | vm = tcg_temp_new_i32(); | ||
570 | vd = tcg_temp_new_i64(); | ||
571 | - neon_load_reg32(vm, a->vm); | ||
572 | + vfp_load_reg32(vm, a->vm); | ||
573 | fpst = fpstatus_ptr(FPST_FPCR); | ||
574 | if (a->s) { | ||
575 | /* i32 -> f64 */ | ||
576 | @@ -XXX,XX +XXX,XX @@ static bool trans_VJCVT(DisasContext *s, arg_VJCVT *a) | ||
577 | vd = tcg_temp_new_i32(); | ||
578 | neon_load_reg64(vm, a->vm); | ||
579 | gen_helper_vjcvt(vd, vm, cpu_env); | ||
580 | - neon_store_reg32(vd, a->vd); | ||
581 | + vfp_store_reg32(vd, a->vd); | ||
582 | tcg_temp_free_i64(vm); | ||
583 | tcg_temp_free_i32(vd); | ||
584 | return true; | ||
585 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_hp(DisasContext *s, arg_VCVT_fix_sp *a) | ||
586 | frac_bits = (a->opc & 1) ? (32 - a->imm) : (16 - a->imm); | ||
587 | |||
588 | vd = tcg_temp_new_i32(); | ||
589 | - neon_load_reg32(vd, a->vd); | ||
590 | + vfp_load_reg32(vd, a->vd); | ||
591 | |||
592 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
593 | shift = tcg_const_i32(frac_bits); | ||
594 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_hp(DisasContext *s, arg_VCVT_fix_sp *a) | ||
595 | g_assert_not_reached(); | ||
596 | } | ||
597 | |||
598 | - neon_store_reg32(vd, a->vd); | ||
599 | + vfp_store_reg32(vd, a->vd); | ||
600 | tcg_temp_free_i32(vd); | ||
601 | tcg_temp_free_i32(shift); | ||
602 | tcg_temp_free_ptr(fpst); | ||
603 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_sp(DisasContext *s, arg_VCVT_fix_sp *a) | ||
604 | frac_bits = (a->opc & 1) ? (32 - a->imm) : (16 - a->imm); | ||
605 | |||
606 | vd = tcg_temp_new_i32(); | ||
607 | - neon_load_reg32(vd, a->vd); | ||
608 | + vfp_load_reg32(vd, a->vd); | ||
609 | |||
610 | fpst = fpstatus_ptr(FPST_FPCR); | ||
611 | shift = tcg_const_i32(frac_bits); | ||
612 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_sp(DisasContext *s, arg_VCVT_fix_sp *a) | ||
613 | g_assert_not_reached(); | ||
614 | } | ||
615 | |||
616 | - neon_store_reg32(vd, a->vd); | ||
617 | + vfp_store_reg32(vd, a->vd); | ||
618 | tcg_temp_free_i32(vd); | ||
619 | tcg_temp_free_i32(shift); | ||
620 | tcg_temp_free_ptr(fpst); | ||
621 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_hp_int(DisasContext *s, arg_VCVT_sp_int *a) | ||
622 | |||
623 | fpst = fpstatus_ptr(FPST_FPCR_F16); | ||
624 | vm = tcg_temp_new_i32(); | ||
625 | - neon_load_reg32(vm, a->vm); | ||
626 | + vfp_load_reg32(vm, a->vm); | ||
627 | |||
628 | if (a->s) { | ||
629 | if (a->rz) { | ||
630 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_hp_int(DisasContext *s, arg_VCVT_sp_int *a) | ||
631 | gen_helper_vfp_touih(vm, vm, fpst); | ||
632 | } | ||
633 | } | ||
634 | - neon_store_reg32(vm, a->vd); | ||
635 | + vfp_store_reg32(vm, a->vd); | ||
636 | tcg_temp_free_i32(vm); | ||
637 | tcg_temp_free_ptr(fpst); | ||
638 | return true; | ||
639 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_sp_int(DisasContext *s, arg_VCVT_sp_int *a) | ||
640 | |||
641 | fpst = fpstatus_ptr(FPST_FPCR); | ||
642 | vm = tcg_temp_new_i32(); | ||
643 | - neon_load_reg32(vm, a->vm); | ||
644 | + vfp_load_reg32(vm, a->vm); | ||
645 | |||
646 | if (a->s) { | ||
647 | if (a->rz) { | ||
648 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_sp_int(DisasContext *s, arg_VCVT_sp_int *a) | ||
649 | gen_helper_vfp_touis(vm, vm, fpst); | ||
650 | } | ||
651 | } | ||
652 | - neon_store_reg32(vm, a->vd); | ||
653 | + vfp_store_reg32(vm, a->vd); | ||
654 | tcg_temp_free_i32(vm); | ||
655 | tcg_temp_free_ptr(fpst); | ||
656 | return true; | ||
657 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_dp_int(DisasContext *s, arg_VCVT_dp_int *a) | ||
658 | gen_helper_vfp_touid(vd, vm, fpst); | ||
659 | } | ||
660 | } | ||
661 | - neon_store_reg32(vd, a->vd); | ||
662 | + vfp_store_reg32(vd, a->vd); | ||
663 | tcg_temp_free_i32(vd); | ||
664 | tcg_temp_free_i64(vm); | ||
665 | tcg_temp_free_ptr(fpst); | ||
666 | @@ -XXX,XX +XXX,XX @@ static bool trans_VINS(DisasContext *s, arg_VINS *a) | ||
667 | /* Insert low half of Vm into high half of Vd */ | ||
668 | rm = tcg_temp_new_i32(); | ||
669 | rd = tcg_temp_new_i32(); | ||
670 | - neon_load_reg32(rm, a->vm); | ||
671 | - neon_load_reg32(rd, a->vd); | ||
672 | + vfp_load_reg32(rm, a->vm); | ||
673 | + vfp_load_reg32(rd, a->vd); | ||
674 | tcg_gen_deposit_i32(rd, rd, rm, 16, 16); | ||
675 | - neon_store_reg32(rd, a->vd); | ||
676 | + vfp_store_reg32(rd, a->vd); | ||
677 | tcg_temp_free_i32(rm); | ||
678 | tcg_temp_free_i32(rd); | ||
679 | return true; | ||
680 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOVX(DisasContext *s, arg_VINS *a) | ||
681 | |||
682 | /* Set Vd to high half of Vm */ | ||
683 | rm = tcg_temp_new_i32(); | ||
684 | - neon_load_reg32(rm, a->vm); | ||
685 | + vfp_load_reg32(rm, a->vm); | ||
686 | tcg_gen_shri_i32(rm, rm, 16); | ||
687 | - neon_store_reg32(rm, a->vd); | ||
688 | + vfp_store_reg32(rm, a->vd); | ||
689 | tcg_temp_free_i32(rm); | ||
690 | return true; | ||
691 | } | ||
692 | -- | ||
693 | 2.20.1 | ||
694 | |||
695 | diff view generated by jsdifflib |
1 | From: Alistair Francis <alistair@alistair23.me> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Alistair Francis <alistair@alistair23.me> | 3 | Replace all uses of neon_load/store_reg64 within translate-neon.c.inc. |
4 | |||
5 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
6 | Message-id: 20201030022618.785675-9-richard.henderson@linaro.org | ||
4 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Message-id: 49b01423a09cef2ca832ff73a84a996568f1a8fc.1576658572.git.alistair@alistair23.me | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | --- | 9 | --- |
8 | hw/misc/Makefile.objs | 1 + | 10 | target/arm/translate.c | 26 +++++++++ |
9 | include/hw/misc/stm32f4xx_syscfg.h | 61 ++++++++++ | 11 | target/arm/translate-neon.c.inc | 94 ++++++++++++++++----------------- |
10 | hw/misc/stm32f4xx_syscfg.c | 171 +++++++++++++++++++++++++++++ | 12 | 2 files changed, 73 insertions(+), 47 deletions(-) |
11 | default-configs/arm-softmmu.mak | 1 + | 13 | |
12 | hw/arm/Kconfig | 9 ++ | 14 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
13 | hw/misc/Kconfig | 3 + | ||
14 | hw/misc/trace-events | 6 + | ||
15 | 7 files changed, 252 insertions(+) | ||
16 | create mode 100644 include/hw/misc/stm32f4xx_syscfg.h | ||
17 | create mode 100644 hw/misc/stm32f4xx_syscfg.c | ||
18 | |||
19 | diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs | ||
20 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
21 | --- a/hw/misc/Makefile.objs | 16 | --- a/target/arm/translate.c |
22 | +++ b/hw/misc/Makefile.objs | 17 | +++ b/target/arm/translate.c |
23 | @@ -XXX,XX +XXX,XX @@ common-obj-$(CONFIG_SLAVIO) += slavio_misc.o | 18 | @@ -XXX,XX +XXX,XX @@ static void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp memop) |
24 | common-obj-$(CONFIG_ZYNQ) += zynq_slcr.o | 19 | } |
25 | common-obj-$(CONFIG_ZYNQ) += zynq-xadc.o | 20 | } |
26 | common-obj-$(CONFIG_STM32F2XX_SYSCFG) += stm32f2xx_syscfg.o | 21 | |
27 | +common-obj-$(CONFIG_STM32F4XX_SYSCFG) += stm32f4xx_syscfg.o | 22 | +static void read_neon_element64(TCGv_i64 dest, int reg, int ele, MemOp memop) |
28 | obj-$(CONFIG_MIPS_CPS) += mips_cmgcr.o | 23 | +{ |
29 | obj-$(CONFIG_MIPS_CPS) += mips_cpc.o | 24 | + long off = neon_element_offset(reg, ele, memop); |
30 | obj-$(CONFIG_MIPS_ITU) += mips_itu.o | ||
31 | diff --git a/include/hw/misc/stm32f4xx_syscfg.h b/include/hw/misc/stm32f4xx_syscfg.h | ||
32 | new file mode 100644 | ||
33 | index XXXXXXX..XXXXXXX | ||
34 | --- /dev/null | ||
35 | +++ b/include/hw/misc/stm32f4xx_syscfg.h | ||
36 | @@ -XXX,XX +XXX,XX @@ | ||
37 | +/* | ||
38 | + * STM32F4xx SYSCFG | ||
39 | + * | ||
40 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
41 | + * | ||
42 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
43 | + * of this software and associated documentation files (the "Software"), to deal | ||
44 | + * in the Software without restriction, including without limitation the rights | ||
45 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
46 | + * copies of the Software, and to permit persons to whom the Software is | ||
47 | + * furnished to do so, subject to the following conditions: | ||
48 | + * | ||
49 | + * The above copyright notice and this permission notice shall be included in | ||
50 | + * all copies or substantial portions of the Software. | ||
51 | + * | ||
52 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
53 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
54 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
55 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
56 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
57 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
58 | + * THE SOFTWARE. | ||
59 | + */ | ||
60 | + | 25 | + |
61 | +#ifndef HW_STM_SYSCFG_H | 26 | + switch (memop) { |
62 | +#define HW_STM_SYSCFG_H | 27 | + case MO_Q: |
63 | + | 28 | + tcg_gen_ld_i64(dest, cpu_env, off); |
64 | +#include "hw/sysbus.h" | 29 | + break; |
65 | +#include "hw/hw.h" | ||
66 | + | ||
67 | +#define SYSCFG_MEMRMP 0x00 | ||
68 | +#define SYSCFG_PMC 0x04 | ||
69 | +#define SYSCFG_EXTICR1 0x08 | ||
70 | +#define SYSCFG_EXTICR2 0x0C | ||
71 | +#define SYSCFG_EXTICR3 0x10 | ||
72 | +#define SYSCFG_EXTICR4 0x14 | ||
73 | +#define SYSCFG_CMPCR 0x20 | ||
74 | + | ||
75 | +#define TYPE_STM32F4XX_SYSCFG "stm32f4xx-syscfg" | ||
76 | +#define STM32F4XX_SYSCFG(obj) \ | ||
77 | + OBJECT_CHECK(STM32F4xxSyscfgState, (obj), TYPE_STM32F4XX_SYSCFG) | ||
78 | + | ||
79 | +#define SYSCFG_NUM_EXTICR 4 | ||
80 | + | ||
81 | +typedef struct { | ||
82 | + /* <private> */ | ||
83 | + SysBusDevice parent_obj; | ||
84 | + | ||
85 | + /* <public> */ | ||
86 | + MemoryRegion mmio; | ||
87 | + | ||
88 | + uint32_t syscfg_memrmp; | ||
89 | + uint32_t syscfg_pmc; | ||
90 | + uint32_t syscfg_exticr[SYSCFG_NUM_EXTICR]; | ||
91 | + uint32_t syscfg_cmpcr; | ||
92 | + | ||
93 | + qemu_irq irq; | ||
94 | + qemu_irq gpio_out[16]; | ||
95 | +} STM32F4xxSyscfgState; | ||
96 | + | ||
97 | +#endif | ||
98 | diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c | ||
99 | new file mode 100644 | ||
100 | index XXXXXXX..XXXXXXX | ||
101 | --- /dev/null | ||
102 | +++ b/hw/misc/stm32f4xx_syscfg.c | ||
103 | @@ -XXX,XX +XXX,XX @@ | ||
104 | +/* | ||
105 | + * STM32F4xx SYSCFG | ||
106 | + * | ||
107 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
108 | + * | ||
109 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
110 | + * of this software and associated documentation files (the "Software"), to deal | ||
111 | + * in the Software without restriction, including without limitation the rights | ||
112 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
113 | + * copies of the Software, and to permit persons to whom the Software is | ||
114 | + * furnished to do so, subject to the following conditions: | ||
115 | + * | ||
116 | + * The above copyright notice and this permission notice shall be included in | ||
117 | + * all copies or substantial portions of the Software. | ||
118 | + * | ||
119 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
120 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
121 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
122 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
123 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
124 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
125 | + * THE SOFTWARE. | ||
126 | + */ | ||
127 | + | ||
128 | +#include "qemu/osdep.h" | ||
129 | +#include "qemu/log.h" | ||
130 | +#include "trace.h" | ||
131 | +#include "hw/irq.h" | ||
132 | +#include "migration/vmstate.h" | ||
133 | +#include "hw/misc/stm32f4xx_syscfg.h" | ||
134 | + | ||
135 | +static void stm32f4xx_syscfg_reset(DeviceState *dev) | ||
136 | +{ | ||
137 | + STM32F4xxSyscfgState *s = STM32F4XX_SYSCFG(dev); | ||
138 | + | ||
139 | + s->syscfg_memrmp = 0x00000000; | ||
140 | + s->syscfg_pmc = 0x00000000; | ||
141 | + s->syscfg_exticr[0] = 0x00000000; | ||
142 | + s->syscfg_exticr[1] = 0x00000000; | ||
143 | + s->syscfg_exticr[2] = 0x00000000; | ||
144 | + s->syscfg_exticr[3] = 0x00000000; | ||
145 | + s->syscfg_cmpcr = 0x00000000; | ||
146 | +} | ||
147 | + | ||
148 | +static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level) | ||
149 | +{ | ||
150 | + STM32F4xxSyscfgState *s = opaque; | ||
151 | + int icrreg = irq / 4; | ||
152 | + int startbit = (irq & 3) * 4; | ||
153 | + uint8_t config = config = irq / 16; | ||
154 | + | ||
155 | + trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level); | ||
156 | + | ||
157 | + g_assert(icrreg < SYSCFG_NUM_EXTICR); | ||
158 | + | ||
159 | + if (extract32(s->syscfg_exticr[icrreg], startbit, 4) == config) { | ||
160 | + qemu_set_irq(s->gpio_out[irq], level); | ||
161 | + trace_stm32f4xx_pulse_exti(irq); | ||
162 | + } | ||
163 | +} | ||
164 | + | ||
165 | +static uint64_t stm32f4xx_syscfg_read(void *opaque, hwaddr addr, | ||
166 | + unsigned int size) | ||
167 | +{ | ||
168 | + STM32F4xxSyscfgState *s = opaque; | ||
169 | + | ||
170 | + trace_stm32f4xx_syscfg_read(addr); | ||
171 | + | ||
172 | + switch (addr) { | ||
173 | + case SYSCFG_MEMRMP: | ||
174 | + return s->syscfg_memrmp; | ||
175 | + case SYSCFG_PMC: | ||
176 | + return s->syscfg_pmc; | ||
177 | + case SYSCFG_EXTICR1...SYSCFG_EXTICR4: | ||
178 | + return s->syscfg_exticr[addr / 4 - SYSCFG_EXTICR1 / 4]; | ||
179 | + case SYSCFG_CMPCR: | ||
180 | + return s->syscfg_cmpcr; | ||
181 | + default: | 30 | + default: |
182 | + qemu_log_mask(LOG_GUEST_ERROR, | 31 | + g_assert_not_reached(); |
183 | + "%s: Bad offset 0x%"HWADDR_PRIx"\n", __func__, addr); | ||
184 | + return 0; | ||
185 | + } | 32 | + } |
186 | +} | 33 | +} |
187 | + | 34 | + |
188 | +static void stm32f4xx_syscfg_write(void *opaque, hwaddr addr, | 35 | static void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp memop) |
189 | + uint64_t val64, unsigned int size) | 36 | { |
37 | long off = neon_element_offset(reg, ele, memop); | ||
38 | @@ -XXX,XX +XXX,XX @@ static void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp memop) | ||
39 | } | ||
40 | } | ||
41 | |||
42 | +static void write_neon_element64(TCGv_i64 src, int reg, int ele, MemOp memop) | ||
190 | +{ | 43 | +{ |
191 | + STM32F4xxSyscfgState *s = opaque; | 44 | + long off = neon_element_offset(reg, ele, memop); |
192 | + uint32_t value = val64; | ||
193 | + | 45 | + |
194 | + trace_stm32f4xx_syscfg_write(value, addr); | 46 | + switch (memop) { |
195 | + | 47 | + case MO_64: |
196 | + switch (addr) { | 48 | + tcg_gen_st_i64(src, cpu_env, off); |
197 | + case SYSCFG_MEMRMP: | 49 | + break; |
198 | + qemu_log_mask(LOG_UNIMP, | ||
199 | + "%s: Changing the memory mapping isn't supported " \ | ||
200 | + "in QEMU\n", __func__); | ||
201 | + return; | ||
202 | + case SYSCFG_PMC: | ||
203 | + qemu_log_mask(LOG_UNIMP, | ||
204 | + "%s: Changing the memory mapping isn't supported " \ | ||
205 | + "in QEMU\n", __func__); | ||
206 | + return; | ||
207 | + case SYSCFG_EXTICR1...SYSCFG_EXTICR4: | ||
208 | + s->syscfg_exticr[addr / 4 - SYSCFG_EXTICR1 / 4] = (value & 0xFFFF); | ||
209 | + return; | ||
210 | + case SYSCFG_CMPCR: | ||
211 | + s->syscfg_cmpcr = value; | ||
212 | + return; | ||
213 | + default: | 50 | + default: |
214 | + qemu_log_mask(LOG_GUEST_ERROR, | 51 | + g_assert_not_reached(); |
215 | + "%s: Bad offset 0x%"HWADDR_PRIx"\n", __func__, addr); | ||
216 | + } | 52 | + } |
217 | +} | 53 | +} |
218 | + | 54 | + |
219 | +static const MemoryRegionOps stm32f4xx_syscfg_ops = { | 55 | static TCGv_ptr vfp_reg_ptr(bool dp, int reg) |
220 | + .read = stm32f4xx_syscfg_read, | 56 | { |
221 | + .write = stm32f4xx_syscfg_write, | 57 | TCGv_ptr ret = tcg_temp_new_ptr(); |
222 | + .endianness = DEVICE_NATIVE_ENDIAN, | 58 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc |
223 | +}; | ||
224 | + | ||
225 | +static void stm32f4xx_syscfg_init(Object *obj) | ||
226 | +{ | ||
227 | + STM32F4xxSyscfgState *s = STM32F4XX_SYSCFG(obj); | ||
228 | + | ||
229 | + sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); | ||
230 | + | ||
231 | + memory_region_init_io(&s->mmio, obj, &stm32f4xx_syscfg_ops, s, | ||
232 | + TYPE_STM32F4XX_SYSCFG, 0x400); | ||
233 | + sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); | ||
234 | + | ||
235 | + qdev_init_gpio_in(DEVICE(obj), stm32f4xx_syscfg_set_irq, 16 * 9); | ||
236 | + qdev_init_gpio_out(DEVICE(obj), s->gpio_out, 16); | ||
237 | +} | ||
238 | + | ||
239 | +static const VMStateDescription vmstate_stm32f4xx_syscfg = { | ||
240 | + .name = TYPE_STM32F4XX_SYSCFG, | ||
241 | + .version_id = 1, | ||
242 | + .minimum_version_id = 1, | ||
243 | + .fields = (VMStateField[]) { | ||
244 | + VMSTATE_UINT32(syscfg_memrmp, STM32F4xxSyscfgState), | ||
245 | + VMSTATE_UINT32(syscfg_pmc, STM32F4xxSyscfgState), | ||
246 | + VMSTATE_UINT32_ARRAY(syscfg_exticr, STM32F4xxSyscfgState, | ||
247 | + SYSCFG_NUM_EXTICR), | ||
248 | + VMSTATE_UINT32(syscfg_cmpcr, STM32F4xxSyscfgState), | ||
249 | + VMSTATE_END_OF_LIST() | ||
250 | + } | ||
251 | +}; | ||
252 | + | ||
253 | +static void stm32f4xx_syscfg_class_init(ObjectClass *klass, void *data) | ||
254 | +{ | ||
255 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
256 | + | ||
257 | + dc->reset = stm32f4xx_syscfg_reset; | ||
258 | + dc->vmsd = &vmstate_stm32f4xx_syscfg; | ||
259 | +} | ||
260 | + | ||
261 | +static const TypeInfo stm32f4xx_syscfg_info = { | ||
262 | + .name = TYPE_STM32F4XX_SYSCFG, | ||
263 | + .parent = TYPE_SYS_BUS_DEVICE, | ||
264 | + .instance_size = sizeof(STM32F4xxSyscfgState), | ||
265 | + .instance_init = stm32f4xx_syscfg_init, | ||
266 | + .class_init = stm32f4xx_syscfg_class_init, | ||
267 | +}; | ||
268 | + | ||
269 | +static void stm32f4xx_syscfg_register_types(void) | ||
270 | +{ | ||
271 | + type_register_static(&stm32f4xx_syscfg_info); | ||
272 | +} | ||
273 | + | ||
274 | +type_init(stm32f4xx_syscfg_register_types) | ||
275 | diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak | ||
276 | index XXXXXXX..XXXXXXX 100644 | 59 | index XXXXXXX..XXXXXXX 100644 |
277 | --- a/default-configs/arm-softmmu.mak | 60 | --- a/target/arm/translate-neon.c.inc |
278 | +++ b/default-configs/arm-softmmu.mak | 61 | +++ b/target/arm/translate-neon.c.inc |
279 | @@ -XXX,XX +XXX,XX @@ CONFIG_Z2=y | 62 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_env_64(DisasContext *s, arg_2reg_shift *a, |
280 | CONFIG_COLLIE=y | 63 | for (pass = 0; pass < a->q + 1; pass++) { |
281 | CONFIG_ASPEED_SOC=y | 64 | TCGv_i64 tmp = tcg_temp_new_i64(); |
282 | CONFIG_NETDUINO2=y | 65 | |
283 | +CONFIG_NETDUINOPLUS2=y | 66 | - neon_load_reg64(tmp, a->vm + pass); |
284 | CONFIG_MPS2=y | 67 | + read_neon_element64(tmp, a->vm, pass, MO_64); |
285 | CONFIG_RASPI=y | 68 | fn(tmp, cpu_env, tmp, constimm); |
286 | CONFIG_DIGIC=y | 69 | - neon_store_reg64(tmp, a->vd + pass); |
287 | diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig | 70 | + write_neon_element64(tmp, a->vd, pass, MO_64); |
288 | index XXXXXXX..XXXXXXX 100644 | 71 | tcg_temp_free_i64(tmp); |
289 | --- a/hw/arm/Kconfig | 72 | } |
290 | +++ b/hw/arm/Kconfig | 73 | tcg_temp_free_i64(constimm); |
291 | @@ -XXX,XX +XXX,XX @@ config NETDUINO2 | 74 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_narrow_64(DisasContext *s, arg_2reg_shift *a, |
292 | bool | 75 | rd = tcg_temp_new_i32(); |
293 | select STM32F205_SOC | 76 | |
294 | 77 | /* Load both inputs first to avoid potential overwrite if rm == rd */ | |
295 | +config NETDUINOPLUS2 | 78 | - neon_load_reg64(rm1, a->vm); |
296 | + bool | 79 | - neon_load_reg64(rm2, a->vm + 1); |
297 | + select STM32F405_SOC | 80 | + read_neon_element64(rm1, a->vm, 0, MO_64); |
298 | + | 81 | + read_neon_element64(rm2, a->vm, 1, MO_64); |
299 | config NSERIES | 82 | |
300 | bool | 83 | shiftfn(rm1, rm1, constimm); |
301 | select OMAP | 84 | narrowfn(rd, cpu_env, rm1); |
302 | @@ -XXX,XX +XXX,XX @@ config STM32F205_SOC | 85 | @@ -XXX,XX +XXX,XX @@ static bool do_vshll_2sh(DisasContext *s, arg_2reg_shift *a, |
303 | select STM32F2XX_ADC | 86 | tcg_gen_shli_i64(tmp, tmp, a->shift); |
304 | select STM32F2XX_SPI | 87 | tcg_gen_andi_i64(tmp, tmp, ~widen_mask); |
305 | 88 | } | |
306 | +config STM32F405_SOC | 89 | - neon_store_reg64(tmp, a->vd); |
307 | + bool | 90 | + write_neon_element64(tmp, a->vd, 0, MO_64); |
308 | + select ARM_V7M | 91 | |
309 | + select STM32F4XX_SYSCFG | 92 | widenfn(tmp, rm1); |
310 | + | 93 | tcg_temp_free_i32(rm1); |
311 | config XLNX_ZYNQMP_ARM | 94 | @@ -XXX,XX +XXX,XX @@ static bool do_vshll_2sh(DisasContext *s, arg_2reg_shift *a, |
312 | bool | 95 | tcg_gen_shli_i64(tmp, tmp, a->shift); |
313 | select AHCI | 96 | tcg_gen_andi_i64(tmp, tmp, ~widen_mask); |
314 | diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig | 97 | } |
315 | index XXXXXXX..XXXXXXX 100644 | 98 | - neon_store_reg64(tmp, a->vd + 1); |
316 | --- a/hw/misc/Kconfig | 99 | + write_neon_element64(tmp, a->vd, 1, MO_64); |
317 | +++ b/hw/misc/Kconfig | 100 | tcg_temp_free_i64(tmp); |
318 | @@ -XXX,XX +XXX,XX @@ config IMX | 101 | return true; |
319 | config STM32F2XX_SYSCFG | 102 | } |
320 | bool | 103 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, |
321 | 104 | rm_64 = tcg_temp_new_i64(); | |
322 | +config STM32F4XX_SYSCFG | 105 | |
323 | + bool | 106 | if (src1_wide) { |
324 | + | 107 | - neon_load_reg64(rn0_64, a->vn); |
325 | config MIPS_ITU | 108 | + read_neon_element64(rn0_64, a->vn, 0, MO_64); |
326 | bool | 109 | } else { |
327 | 110 | TCGv_i32 tmp = tcg_temp_new_i32(); | |
328 | diff --git a/hw/misc/trace-events b/hw/misc/trace-events | 111 | read_neon_element32(tmp, a->vn, 0, MO_32); |
329 | index XXXXXXX..XXXXXXX 100644 | 112 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, |
330 | --- a/hw/misc/trace-events | 113 | * avoid incorrect results if a narrow input overlaps with the result. |
331 | +++ b/hw/misc/trace-events | 114 | */ |
332 | @@ -XXX,XX +XXX,XX @@ mos6522_set_sr_int(void) "set sr_int" | 115 | if (src1_wide) { |
333 | mos6522_write(uint64_t addr, uint64_t val) "reg=0x%"PRIx64 " val=0x%"PRIx64 | 116 | - neon_load_reg64(rn1_64, a->vn + 1); |
334 | mos6522_read(uint64_t addr, unsigned val) "reg=0x%"PRIx64 " val=0x%x" | 117 | + read_neon_element64(rn1_64, a->vn, 1, MO_64); |
335 | 118 | } else { | |
336 | +# stm32f4xx_syscfg | 119 | TCGv_i32 tmp = tcg_temp_new_i32(); |
337 | +stm32f4xx_syscfg_set_irq(int gpio, int line, int level) "Interupt: GPIO: %d, Line: %d; Level: %d" | 120 | read_neon_element32(tmp, a->vn, 1, MO_32); |
338 | +stm32f4xx_pulse_exti(int irq) "Pulse EXTI: %d" | 121 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, |
339 | +stm32f4xx_syscfg_read(uint64_t addr) "reg read: addr: 0x%" PRIx64 " " | 122 | rm = tcg_temp_new_i32(); |
340 | +stm32f4xx_syscfg_write(uint64_t addr, uint64_t data) "reg write: addr: 0x%" PRIx64 " val: 0x%" PRIx64 "" | 123 | read_neon_element32(rm, a->vm, 1, MO_32); |
341 | + | 124 | |
342 | # tz-mpc.c | 125 | - neon_store_reg64(rn0_64, a->vd); |
343 | tz_mpc_reg_read(uint32_t offset, uint64_t data, unsigned size) "TZ MPC regs read: offset 0x%x data 0x%" PRIx64 " size %u" | 126 | + write_neon_element64(rn0_64, a->vd, 0, MO_64); |
344 | tz_mpc_reg_write(uint32_t offset, uint64_t data, unsigned size) "TZ MPC regs write: offset 0x%x data 0x%" PRIx64 " size %u" | 127 | |
128 | widenfn(rm_64, rm); | ||
129 | tcg_temp_free_i32(rm); | ||
130 | opfn(rn1_64, rn1_64, rm_64); | ||
131 | - neon_store_reg64(rn1_64, a->vd + 1); | ||
132 | + write_neon_element64(rn1_64, a->vd, 1, MO_64); | ||
133 | |||
134 | tcg_temp_free_i64(rn0_64); | ||
135 | tcg_temp_free_i64(rn1_64); | ||
136 | @@ -XXX,XX +XXX,XX @@ static bool do_narrow_3d(DisasContext *s, arg_3diff *a, | ||
137 | rd0 = tcg_temp_new_i32(); | ||
138 | rd1 = tcg_temp_new_i32(); | ||
139 | |||
140 | - neon_load_reg64(rn_64, a->vn); | ||
141 | - neon_load_reg64(rm_64, a->vm); | ||
142 | + read_neon_element64(rn_64, a->vn, 0, MO_64); | ||
143 | + read_neon_element64(rm_64, a->vm, 0, MO_64); | ||
144 | |||
145 | opfn(rn_64, rn_64, rm_64); | ||
146 | |||
147 | narrowfn(rd0, rn_64); | ||
148 | |||
149 | - neon_load_reg64(rn_64, a->vn + 1); | ||
150 | - neon_load_reg64(rm_64, a->vm + 1); | ||
151 | + read_neon_element64(rn_64, a->vn, 1, MO_64); | ||
152 | + read_neon_element64(rm_64, a->vm, 1, MO_64); | ||
153 | |||
154 | opfn(rn_64, rn_64, rm_64); | ||
155 | |||
156 | @@ -XXX,XX +XXX,XX @@ static bool do_long_3d(DisasContext *s, arg_3diff *a, | ||
157 | /* Don't store results until after all loads: they might overlap */ | ||
158 | if (accfn) { | ||
159 | tmp = tcg_temp_new_i64(); | ||
160 | - neon_load_reg64(tmp, a->vd); | ||
161 | + read_neon_element64(tmp, a->vd, 0, MO_64); | ||
162 | accfn(tmp, tmp, rd0); | ||
163 | - neon_store_reg64(tmp, a->vd); | ||
164 | - neon_load_reg64(tmp, a->vd + 1); | ||
165 | + write_neon_element64(tmp, a->vd, 0, MO_64); | ||
166 | + read_neon_element64(tmp, a->vd, 1, MO_64); | ||
167 | accfn(tmp, tmp, rd1); | ||
168 | - neon_store_reg64(tmp, a->vd + 1); | ||
169 | + write_neon_element64(tmp, a->vd, 1, MO_64); | ||
170 | tcg_temp_free_i64(tmp); | ||
171 | } else { | ||
172 | - neon_store_reg64(rd0, a->vd); | ||
173 | - neon_store_reg64(rd1, a->vd + 1); | ||
174 | + write_neon_element64(rd0, a->vd, 0, MO_64); | ||
175 | + write_neon_element64(rd1, a->vd, 1, MO_64); | ||
176 | } | ||
177 | |||
178 | tcg_temp_free_i64(rd0); | ||
179 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar_long(DisasContext *s, arg_2scalar *a, | ||
180 | |||
181 | if (accfn) { | ||
182 | TCGv_i64 t64 = tcg_temp_new_i64(); | ||
183 | - neon_load_reg64(t64, a->vd); | ||
184 | + read_neon_element64(t64, a->vd, 0, MO_64); | ||
185 | accfn(t64, t64, rn0_64); | ||
186 | - neon_store_reg64(t64, a->vd); | ||
187 | - neon_load_reg64(t64, a->vd + 1); | ||
188 | + write_neon_element64(t64, a->vd, 0, MO_64); | ||
189 | + read_neon_element64(t64, a->vd, 1, MO_64); | ||
190 | accfn(t64, t64, rn1_64); | ||
191 | - neon_store_reg64(t64, a->vd + 1); | ||
192 | + write_neon_element64(t64, a->vd, 1, MO_64); | ||
193 | tcg_temp_free_i64(t64); | ||
194 | } else { | ||
195 | - neon_store_reg64(rn0_64, a->vd); | ||
196 | - neon_store_reg64(rn1_64, a->vd + 1); | ||
197 | + write_neon_element64(rn0_64, a->vd, 0, MO_64); | ||
198 | + write_neon_element64(rn1_64, a->vd, 1, MO_64); | ||
199 | } | ||
200 | tcg_temp_free_i64(rn0_64); | ||
201 | tcg_temp_free_i64(rn1_64); | ||
202 | @@ -XXX,XX +XXX,XX @@ static bool trans_VEXT(DisasContext *s, arg_VEXT *a) | ||
203 | right = tcg_temp_new_i64(); | ||
204 | dest = tcg_temp_new_i64(); | ||
205 | |||
206 | - neon_load_reg64(right, a->vn); | ||
207 | - neon_load_reg64(left, a->vm); | ||
208 | + read_neon_element64(right, a->vn, 0, MO_64); | ||
209 | + read_neon_element64(left, a->vm, 0, MO_64); | ||
210 | tcg_gen_extract2_i64(dest, right, left, a->imm * 8); | ||
211 | - neon_store_reg64(dest, a->vd); | ||
212 | + write_neon_element64(dest, a->vd, 0, MO_64); | ||
213 | |||
214 | tcg_temp_free_i64(left); | ||
215 | tcg_temp_free_i64(right); | ||
216 | @@ -XXX,XX +XXX,XX @@ static bool trans_VEXT(DisasContext *s, arg_VEXT *a) | ||
217 | destright = tcg_temp_new_i64(); | ||
218 | |||
219 | if (a->imm < 8) { | ||
220 | - neon_load_reg64(right, a->vn); | ||
221 | - neon_load_reg64(middle, a->vn + 1); | ||
222 | + read_neon_element64(right, a->vn, 0, MO_64); | ||
223 | + read_neon_element64(middle, a->vn, 1, MO_64); | ||
224 | tcg_gen_extract2_i64(destright, right, middle, a->imm * 8); | ||
225 | - neon_load_reg64(left, a->vm); | ||
226 | + read_neon_element64(left, a->vm, 0, MO_64); | ||
227 | tcg_gen_extract2_i64(destleft, middle, left, a->imm * 8); | ||
228 | } else { | ||
229 | - neon_load_reg64(right, a->vn + 1); | ||
230 | - neon_load_reg64(middle, a->vm); | ||
231 | + read_neon_element64(right, a->vn, 1, MO_64); | ||
232 | + read_neon_element64(middle, a->vm, 0, MO_64); | ||
233 | tcg_gen_extract2_i64(destright, right, middle, (a->imm - 8) * 8); | ||
234 | - neon_load_reg64(left, a->vm + 1); | ||
235 | + read_neon_element64(left, a->vm, 1, MO_64); | ||
236 | tcg_gen_extract2_i64(destleft, middle, left, (a->imm - 8) * 8); | ||
237 | } | ||
238 | |||
239 | - neon_store_reg64(destright, a->vd); | ||
240 | - neon_store_reg64(destleft, a->vd + 1); | ||
241 | + write_neon_element64(destright, a->vd, 0, MO_64); | ||
242 | + write_neon_element64(destleft, a->vd, 1, MO_64); | ||
243 | |||
244 | tcg_temp_free_i64(destright); | ||
245 | tcg_temp_free_i64(destleft); | ||
246 | @@ -XXX,XX +XXX,XX @@ static bool do_2misc_pairwise(DisasContext *s, arg_2misc *a, | ||
247 | |||
248 | if (accfn) { | ||
249 | TCGv_i64 tmp64 = tcg_temp_new_i64(); | ||
250 | - neon_load_reg64(tmp64, a->vd + pass); | ||
251 | + read_neon_element64(tmp64, a->vd, pass, MO_64); | ||
252 | accfn(rd_64, tmp64, rd_64); | ||
253 | tcg_temp_free_i64(tmp64); | ||
254 | } | ||
255 | - neon_store_reg64(rd_64, a->vd + pass); | ||
256 | + write_neon_element64(rd_64, a->vd, pass, MO_64); | ||
257 | tcg_temp_free_i64(rd_64); | ||
258 | } | ||
259 | return true; | ||
260 | @@ -XXX,XX +XXX,XX @@ static bool do_vmovn(DisasContext *s, arg_2misc *a, | ||
261 | rd0 = tcg_temp_new_i32(); | ||
262 | rd1 = tcg_temp_new_i32(); | ||
263 | |||
264 | - neon_load_reg64(rm, a->vm); | ||
265 | + read_neon_element64(rm, a->vm, 0, MO_64); | ||
266 | narrowfn(rd0, cpu_env, rm); | ||
267 | - neon_load_reg64(rm, a->vm + 1); | ||
268 | + read_neon_element64(rm, a->vm, 1, MO_64); | ||
269 | narrowfn(rd1, cpu_env, rm); | ||
270 | write_neon_element32(rd0, a->vd, 0, MO_32); | ||
271 | write_neon_element32(rd1, a->vd, 1, MO_32); | ||
272 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSHLL(DisasContext *s, arg_2misc *a) | ||
273 | |||
274 | widenfn(rd, rm0); | ||
275 | tcg_gen_shli_i64(rd, rd, 8 << a->size); | ||
276 | - neon_store_reg64(rd, a->vd); | ||
277 | + write_neon_element64(rd, a->vd, 0, MO_64); | ||
278 | widenfn(rd, rm1); | ||
279 | tcg_gen_shli_i64(rd, rd, 8 << a->size); | ||
280 | - neon_store_reg64(rd, a->vd + 1); | ||
281 | + write_neon_element64(rd, a->vd, 1, MO_64); | ||
282 | |||
283 | tcg_temp_free_i64(rd); | ||
284 | tcg_temp_free_i32(rm0); | ||
285 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSWP(DisasContext *s, arg_2misc *a) | ||
286 | rm = tcg_temp_new_i64(); | ||
287 | rd = tcg_temp_new_i64(); | ||
288 | for (pass = 0; pass < (a->q ? 2 : 1); pass++) { | ||
289 | - neon_load_reg64(rm, a->vm + pass); | ||
290 | - neon_load_reg64(rd, a->vd + pass); | ||
291 | - neon_store_reg64(rm, a->vd + pass); | ||
292 | - neon_store_reg64(rd, a->vm + pass); | ||
293 | + read_neon_element64(rm, a->vm, pass, MO_64); | ||
294 | + read_neon_element64(rd, a->vd, pass, MO_64); | ||
295 | + write_neon_element64(rm, a->vd, pass, MO_64); | ||
296 | + write_neon_element64(rd, a->vm, pass, MO_64); | ||
297 | } | ||
298 | tcg_temp_free_i64(rm); | ||
299 | tcg_temp_free_i64(rd); | ||
345 | -- | 300 | -- |
346 | 2.20.1 | 301 | 2.20.1 |
347 | 302 | ||
348 | 303 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | During the conversion to decodetree, the setting of | 3 | The only uses of this function are for loading VFP |
4 | ISSIs16Bit got lost. This causes the guest os to | 4 | double-precision values, and nothing to do with NEON. |
5 | incorrectly adjust trapping memory operations. | 5 | |
6 | |||
7 | Cc: qemu-stable@nongnu.org | ||
8 | Fixes: 46beb58efbb8a2a32 ("target/arm: Convert T16, load (literal)") | ||
9 | Reported-by: Jeff Kubascik <jeff.kubascik@dornerworks.com> | ||
10 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
11 | Message-id: 20200117004618.2742-3-richard.henderson@linaro.org | 7 | Message-id: 20201030022618.785675-10-richard.henderson@linaro.org |
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
14 | --- | 10 | --- |
15 | target/arm/translate.c | 3 +++ | 11 | target/arm/translate.c | 8 ++-- |
16 | 1 file changed, 3 insertions(+) | 12 | target/arm/translate-vfp.c.inc | 84 +++++++++++++++++----------------- |
13 | 2 files changed, 46 insertions(+), 46 deletions(-) | ||
17 | 14 | ||
18 | diff --git a/target/arm/translate.c b/target/arm/translate.c | 15 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
19 | index XXXXXXX..XXXXXXX 100644 | 16 | index XXXXXXX..XXXXXXX 100644 |
20 | --- a/target/arm/translate.c | 17 | --- a/target/arm/translate.c |
21 | +++ b/target/arm/translate.c | 18 | +++ b/target/arm/translate.c |
22 | @@ -XXX,XX +XXX,XX @@ static ISSInfo make_issinfo(DisasContext *s, int rd, bool p, bool w) | 19 | @@ -XXX,XX +XXX,XX @@ static long vfp_reg_offset(bool dp, unsigned reg) |
23 | /* ISS not valid if writeback */ | 20 | } |
24 | if (p && !w) { | 21 | } |
25 | ret = rd; | 22 | |
26 | + if (s->base.pc_next - s->pc_curr == 2) { | 23 | -static inline void neon_load_reg64(TCGv_i64 var, int reg) |
27 | + ret |= ISSIs16Bit; | 24 | +static inline void vfp_load_reg64(TCGv_i64 var, int reg) |
28 | + } | 25 | { |
26 | - tcg_gen_ld_i64(var, cpu_env, vfp_reg_offset(1, reg)); | ||
27 | + tcg_gen_ld_i64(var, cpu_env, vfp_reg_offset(true, reg)); | ||
28 | } | ||
29 | |||
30 | -static inline void neon_store_reg64(TCGv_i64 var, int reg) | ||
31 | +static inline void vfp_store_reg64(TCGv_i64 var, int reg) | ||
32 | { | ||
33 | - tcg_gen_st_i64(var, cpu_env, vfp_reg_offset(1, reg)); | ||
34 | + tcg_gen_st_i64(var, cpu_env, vfp_reg_offset(true, reg)); | ||
35 | } | ||
36 | |||
37 | static inline void vfp_load_reg32(TCGv_i32 var, int reg) | ||
38 | diff --git a/target/arm/translate-vfp.c.inc b/target/arm/translate-vfp.c.inc | ||
39 | index XXXXXXX..XXXXXXX 100644 | ||
40 | --- a/target/arm/translate-vfp.c.inc | ||
41 | +++ b/target/arm/translate-vfp.c.inc | ||
42 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSEL(DisasContext *s, arg_VSEL *a) | ||
43 | tcg_gen_ext_i32_i64(nf, cpu_NF); | ||
44 | tcg_gen_ext_i32_i64(vf, cpu_VF); | ||
45 | |||
46 | - neon_load_reg64(frn, rn); | ||
47 | - neon_load_reg64(frm, rm); | ||
48 | + vfp_load_reg64(frn, rn); | ||
49 | + vfp_load_reg64(frm, rm); | ||
50 | switch (a->cc) { | ||
51 | case 0: /* eq: Z */ | ||
52 | tcg_gen_movcond_i64(TCG_COND_EQ, dest, zf, zero, | ||
53 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSEL(DisasContext *s, arg_VSEL *a) | ||
54 | tcg_temp_free_i64(tmp); | ||
55 | break; | ||
56 | } | ||
57 | - neon_store_reg64(dest, rd); | ||
58 | + vfp_store_reg64(dest, rd); | ||
59 | tcg_temp_free_i64(frn); | ||
60 | tcg_temp_free_i64(frm); | ||
61 | tcg_temp_free_i64(dest); | ||
62 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINT(DisasContext *s, arg_VRINT *a) | ||
63 | TCGv_i64 tcg_res; | ||
64 | tcg_op = tcg_temp_new_i64(); | ||
65 | tcg_res = tcg_temp_new_i64(); | ||
66 | - neon_load_reg64(tcg_op, rm); | ||
67 | + vfp_load_reg64(tcg_op, rm); | ||
68 | gen_helper_rintd(tcg_res, tcg_op, fpst); | ||
69 | - neon_store_reg64(tcg_res, rd); | ||
70 | + vfp_store_reg64(tcg_res, rd); | ||
71 | tcg_temp_free_i64(tcg_op); | ||
72 | tcg_temp_free_i64(tcg_res); | ||
29 | } else { | 73 | } else { |
30 | ret = ISSInvalid; | 74 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT(DisasContext *s, arg_VCVT *a) |
31 | } | 75 | tcg_double = tcg_temp_new_i64(); |
76 | tcg_res = tcg_temp_new_i64(); | ||
77 | tcg_tmp = tcg_temp_new_i32(); | ||
78 | - neon_load_reg64(tcg_double, rm); | ||
79 | + vfp_load_reg64(tcg_double, rm); | ||
80 | if (is_signed) { | ||
81 | gen_helper_vfp_tosld(tcg_res, tcg_double, tcg_shift, fpst); | ||
82 | } else { | ||
83 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDR_VSTR_dp(DisasContext *s, arg_VLDR_VSTR_dp *a) | ||
84 | tmp = tcg_temp_new_i64(); | ||
85 | if (a->l) { | ||
86 | gen_aa32_ld64(s, tmp, addr, get_mem_index(s)); | ||
87 | - neon_store_reg64(tmp, a->vd); | ||
88 | + vfp_store_reg64(tmp, a->vd); | ||
89 | } else { | ||
90 | - neon_load_reg64(tmp, a->vd); | ||
91 | + vfp_load_reg64(tmp, a->vd); | ||
92 | gen_aa32_st64(s, tmp, addr, get_mem_index(s)); | ||
93 | } | ||
94 | tcg_temp_free_i64(tmp); | ||
95 | @@ -XXX,XX +XXX,XX @@ static bool trans_VLDM_VSTM_dp(DisasContext *s, arg_VLDM_VSTM_dp *a) | ||
96 | if (a->l) { | ||
97 | /* load */ | ||
98 | gen_aa32_ld64(s, tmp, addr, get_mem_index(s)); | ||
99 | - neon_store_reg64(tmp, a->vd + i); | ||
100 | + vfp_store_reg64(tmp, a->vd + i); | ||
101 | } else { | ||
102 | /* store */ | ||
103 | - neon_load_reg64(tmp, a->vd + i); | ||
104 | + vfp_load_reg64(tmp, a->vd + i); | ||
105 | gen_aa32_st64(s, tmp, addr, get_mem_index(s)); | ||
106 | } | ||
107 | tcg_gen_addi_i32(addr, addr, offset); | ||
108 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_3op_dp(DisasContext *s, VFPGen3OpDPFn *fn, | ||
109 | fd = tcg_temp_new_i64(); | ||
110 | fpst = fpstatus_ptr(FPST_FPCR); | ||
111 | |||
112 | - neon_load_reg64(f0, vn); | ||
113 | - neon_load_reg64(f1, vm); | ||
114 | + vfp_load_reg64(f0, vn); | ||
115 | + vfp_load_reg64(f1, vm); | ||
116 | |||
117 | for (;;) { | ||
118 | if (reads_vd) { | ||
119 | - neon_load_reg64(fd, vd); | ||
120 | + vfp_load_reg64(fd, vd); | ||
121 | } | ||
122 | fn(fd, f0, f1, fpst); | ||
123 | - neon_store_reg64(fd, vd); | ||
124 | + vfp_store_reg64(fd, vd); | ||
125 | |||
126 | if (veclen == 0) { | ||
127 | break; | ||
128 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_3op_dp(DisasContext *s, VFPGen3OpDPFn *fn, | ||
129 | veclen--; | ||
130 | vd = vfp_advance_dreg(vd, delta_d); | ||
131 | vn = vfp_advance_dreg(vn, delta_d); | ||
132 | - neon_load_reg64(f0, vn); | ||
133 | + vfp_load_reg64(f0, vn); | ||
134 | if (delta_m) { | ||
135 | vm = vfp_advance_dreg(vm, delta_m); | ||
136 | - neon_load_reg64(f1, vm); | ||
137 | + vfp_load_reg64(f1, vm); | ||
138 | } | ||
139 | } | ||
140 | |||
141 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_dp(DisasContext *s, VFPGen2OpDPFn *fn, int vd, int vm) | ||
142 | f0 = tcg_temp_new_i64(); | ||
143 | fd = tcg_temp_new_i64(); | ||
144 | |||
145 | - neon_load_reg64(f0, vm); | ||
146 | + vfp_load_reg64(f0, vm); | ||
147 | |||
148 | for (;;) { | ||
149 | fn(fd, f0); | ||
150 | - neon_store_reg64(fd, vd); | ||
151 | + vfp_store_reg64(fd, vd); | ||
152 | |||
153 | if (veclen == 0) { | ||
154 | break; | ||
155 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_dp(DisasContext *s, VFPGen2OpDPFn *fn, int vd, int vm) | ||
156 | /* single source one-many */ | ||
157 | while (veclen--) { | ||
158 | vd = vfp_advance_dreg(vd, delta_d); | ||
159 | - neon_store_reg64(fd, vd); | ||
160 | + vfp_store_reg64(fd, vd); | ||
161 | } | ||
162 | break; | ||
163 | } | ||
164 | @@ -XXX,XX +XXX,XX @@ static bool do_vfp_2op_dp(DisasContext *s, VFPGen2OpDPFn *fn, int vd, int vm) | ||
165 | veclen--; | ||
166 | vd = vfp_advance_dreg(vd, delta_d); | ||
167 | vd = vfp_advance_dreg(vm, delta_m); | ||
168 | - neon_load_reg64(f0, vm); | ||
169 | + vfp_load_reg64(f0, vm); | ||
170 | } | ||
171 | |||
172 | tcg_temp_free_i64(f0); | ||
173 | @@ -XXX,XX +XXX,XX @@ static bool do_vfm_dp(DisasContext *s, arg_VFMA_dp *a, bool neg_n, bool neg_d) | ||
174 | vm = tcg_temp_new_i64(); | ||
175 | vd = tcg_temp_new_i64(); | ||
176 | |||
177 | - neon_load_reg64(vn, a->vn); | ||
178 | - neon_load_reg64(vm, a->vm); | ||
179 | + vfp_load_reg64(vn, a->vn); | ||
180 | + vfp_load_reg64(vm, a->vm); | ||
181 | if (neg_n) { | ||
182 | /* VFNMS, VFMS */ | ||
183 | gen_helper_vfp_negd(vn, vn); | ||
184 | } | ||
185 | - neon_load_reg64(vd, a->vd); | ||
186 | + vfp_load_reg64(vd, a->vd); | ||
187 | if (neg_d) { | ||
188 | /* VFNMA, VFNMS */ | ||
189 | gen_helper_vfp_negd(vd, vd); | ||
190 | } | ||
191 | fpst = fpstatus_ptr(FPST_FPCR); | ||
192 | gen_helper_vfp_muladdd(vd, vn, vm, vd, fpst); | ||
193 | - neon_store_reg64(vd, a->vd); | ||
194 | + vfp_store_reg64(vd, a->vd); | ||
195 | |||
196 | tcg_temp_free_ptr(fpst); | ||
197 | tcg_temp_free_i64(vn); | ||
198 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMOV_imm_dp(DisasContext *s, arg_VMOV_imm_dp *a) | ||
199 | fd = tcg_const_i64(vfp_expand_imm(MO_64, a->imm)); | ||
200 | |||
201 | for (;;) { | ||
202 | - neon_store_reg64(fd, vd); | ||
203 | + vfp_store_reg64(fd, vd); | ||
204 | |||
205 | if (veclen == 0) { | ||
206 | break; | ||
207 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCMP_dp(DisasContext *s, arg_VCMP_dp *a) | ||
208 | vd = tcg_temp_new_i64(); | ||
209 | vm = tcg_temp_new_i64(); | ||
210 | |||
211 | - neon_load_reg64(vd, a->vd); | ||
212 | + vfp_load_reg64(vd, a->vd); | ||
213 | if (a->z) { | ||
214 | tcg_gen_movi_i64(vm, 0); | ||
215 | } else { | ||
216 | - neon_load_reg64(vm, a->vm); | ||
217 | + vfp_load_reg64(vm, a->vm); | ||
218 | } | ||
219 | |||
220 | if (a->e) { | ||
221 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_f64_f16(DisasContext *s, arg_VCVT_f64_f16 *a) | ||
222 | tcg_gen_ld16u_i32(tmp, cpu_env, vfp_f16_offset(a->vm, a->t)); | ||
223 | vd = tcg_temp_new_i64(); | ||
224 | gen_helper_vfp_fcvt_f16_to_f64(vd, tmp, fpst, ahp_mode); | ||
225 | - neon_store_reg64(vd, a->vd); | ||
226 | + vfp_store_reg64(vd, a->vd); | ||
227 | tcg_temp_free_i32(ahp_mode); | ||
228 | tcg_temp_free_ptr(fpst); | ||
229 | tcg_temp_free_i32(tmp); | ||
230 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_f16_f64(DisasContext *s, arg_VCVT_f16_f64 *a) | ||
231 | tmp = tcg_temp_new_i32(); | ||
232 | vm = tcg_temp_new_i64(); | ||
233 | |||
234 | - neon_load_reg64(vm, a->vm); | ||
235 | + vfp_load_reg64(vm, a->vm); | ||
236 | gen_helper_vfp_fcvt_f64_to_f16(tmp, vm, fpst, ahp_mode); | ||
237 | tcg_temp_free_i64(vm); | ||
238 | tcg_gen_st16_i32(tmp, cpu_env, vfp_f16_offset(a->vd, a->t)); | ||
239 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTR_dp(DisasContext *s, arg_VRINTR_dp *a) | ||
240 | } | ||
241 | |||
242 | tmp = tcg_temp_new_i64(); | ||
243 | - neon_load_reg64(tmp, a->vm); | ||
244 | + vfp_load_reg64(tmp, a->vm); | ||
245 | fpst = fpstatus_ptr(FPST_FPCR); | ||
246 | gen_helper_rintd(tmp, tmp, fpst); | ||
247 | - neon_store_reg64(tmp, a->vd); | ||
248 | + vfp_store_reg64(tmp, a->vd); | ||
249 | tcg_temp_free_ptr(fpst); | ||
250 | tcg_temp_free_i64(tmp); | ||
251 | return true; | ||
252 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTZ_dp(DisasContext *s, arg_VRINTZ_dp *a) | ||
253 | } | ||
254 | |||
255 | tmp = tcg_temp_new_i64(); | ||
256 | - neon_load_reg64(tmp, a->vm); | ||
257 | + vfp_load_reg64(tmp, a->vm); | ||
258 | fpst = fpstatus_ptr(FPST_FPCR); | ||
259 | tcg_rmode = tcg_const_i32(float_round_to_zero); | ||
260 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
261 | gen_helper_rintd(tmp, tmp, fpst); | ||
262 | gen_helper_set_rmode(tcg_rmode, tcg_rmode, fpst); | ||
263 | - neon_store_reg64(tmp, a->vd); | ||
264 | + vfp_store_reg64(tmp, a->vd); | ||
265 | tcg_temp_free_ptr(fpst); | ||
266 | tcg_temp_free_i64(tmp); | ||
267 | tcg_temp_free_i32(tcg_rmode); | ||
268 | @@ -XXX,XX +XXX,XX @@ static bool trans_VRINTX_dp(DisasContext *s, arg_VRINTX_dp *a) | ||
269 | } | ||
270 | |||
271 | tmp = tcg_temp_new_i64(); | ||
272 | - neon_load_reg64(tmp, a->vm); | ||
273 | + vfp_load_reg64(tmp, a->vm); | ||
274 | fpst = fpstatus_ptr(FPST_FPCR); | ||
275 | gen_helper_rintd_exact(tmp, tmp, fpst); | ||
276 | - neon_store_reg64(tmp, a->vd); | ||
277 | + vfp_store_reg64(tmp, a->vd); | ||
278 | tcg_temp_free_ptr(fpst); | ||
279 | tcg_temp_free_i64(tmp); | ||
280 | return true; | ||
281 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_sp(DisasContext *s, arg_VCVT_sp *a) | ||
282 | vd = tcg_temp_new_i64(); | ||
283 | vfp_load_reg32(vm, a->vm); | ||
284 | gen_helper_vfp_fcvtds(vd, vm, cpu_env); | ||
285 | - neon_store_reg64(vd, a->vd); | ||
286 | + vfp_store_reg64(vd, a->vd); | ||
287 | tcg_temp_free_i32(vm); | ||
288 | tcg_temp_free_i64(vd); | ||
289 | return true; | ||
290 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_dp(DisasContext *s, arg_VCVT_dp *a) | ||
291 | |||
292 | vd = tcg_temp_new_i32(); | ||
293 | vm = tcg_temp_new_i64(); | ||
294 | - neon_load_reg64(vm, a->vm); | ||
295 | + vfp_load_reg64(vm, a->vm); | ||
296 | gen_helper_vfp_fcvtsd(vd, vm, cpu_env); | ||
297 | vfp_store_reg32(vd, a->vd); | ||
298 | tcg_temp_free_i32(vd); | ||
299 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_int_dp(DisasContext *s, arg_VCVT_int_dp *a) | ||
300 | /* u32 -> f64 */ | ||
301 | gen_helper_vfp_uitod(vd, vm, fpst); | ||
302 | } | ||
303 | - neon_store_reg64(vd, a->vd); | ||
304 | + vfp_store_reg64(vd, a->vd); | ||
305 | tcg_temp_free_i32(vm); | ||
306 | tcg_temp_free_i64(vd); | ||
307 | tcg_temp_free_ptr(fpst); | ||
308 | @@ -XXX,XX +XXX,XX @@ static bool trans_VJCVT(DisasContext *s, arg_VJCVT *a) | ||
309 | |||
310 | vm = tcg_temp_new_i64(); | ||
311 | vd = tcg_temp_new_i32(); | ||
312 | - neon_load_reg64(vm, a->vm); | ||
313 | + vfp_load_reg64(vm, a->vm); | ||
314 | gen_helper_vjcvt(vd, vm, cpu_env); | ||
315 | vfp_store_reg32(vd, a->vd); | ||
316 | tcg_temp_free_i64(vm); | ||
317 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_dp(DisasContext *s, arg_VCVT_fix_dp *a) | ||
318 | frac_bits = (a->opc & 1) ? (32 - a->imm) : (16 - a->imm); | ||
319 | |||
320 | vd = tcg_temp_new_i64(); | ||
321 | - neon_load_reg64(vd, a->vd); | ||
322 | + vfp_load_reg64(vd, a->vd); | ||
323 | |||
324 | fpst = fpstatus_ptr(FPST_FPCR); | ||
325 | shift = tcg_const_i32(frac_bits); | ||
326 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_fix_dp(DisasContext *s, arg_VCVT_fix_dp *a) | ||
327 | g_assert_not_reached(); | ||
328 | } | ||
329 | |||
330 | - neon_store_reg64(vd, a->vd); | ||
331 | + vfp_store_reg64(vd, a->vd); | ||
332 | tcg_temp_free_i64(vd); | ||
333 | tcg_temp_free_i32(shift); | ||
334 | tcg_temp_free_ptr(fpst); | ||
335 | @@ -XXX,XX +XXX,XX @@ static bool trans_VCVT_dp_int(DisasContext *s, arg_VCVT_dp_int *a) | ||
336 | fpst = fpstatus_ptr(FPST_FPCR); | ||
337 | vm = tcg_temp_new_i64(); | ||
338 | vd = tcg_temp_new_i32(); | ||
339 | - neon_load_reg64(vm, a->vm); | ||
340 | + vfp_load_reg64(vm, a->vm); | ||
341 | |||
342 | if (a->s) { | ||
343 | if (a->rz) { | ||
32 | -- | 344 | -- |
33 | 2.20.1 | 345 | 2.20.1 |
34 | 346 | ||
35 | 347 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
1 | 2 | ||
3 | In both cases, we can sink the write-back and perform | ||
4 | the accumulate into the normal destination temps. | ||
5 | |||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Message-id: 20201030022618.785675-11-richard.henderson@linaro.org | ||
8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/translate-neon.c.inc | 23 +++++++++-------------- | ||
12 | 1 file changed, 9 insertions(+), 14 deletions(-) | ||
13 | |||
14 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/translate-neon.c.inc | ||
17 | +++ b/target/arm/translate-neon.c.inc | ||
18 | @@ -XXX,XX +XXX,XX @@ static bool do_long_3d(DisasContext *s, arg_3diff *a, | ||
19 | if (accfn) { | ||
20 | tmp = tcg_temp_new_i64(); | ||
21 | read_neon_element64(tmp, a->vd, 0, MO_64); | ||
22 | - accfn(tmp, tmp, rd0); | ||
23 | - write_neon_element64(tmp, a->vd, 0, MO_64); | ||
24 | + accfn(rd0, tmp, rd0); | ||
25 | read_neon_element64(tmp, a->vd, 1, MO_64); | ||
26 | - accfn(tmp, tmp, rd1); | ||
27 | - write_neon_element64(tmp, a->vd, 1, MO_64); | ||
28 | + accfn(rd1, tmp, rd1); | ||
29 | tcg_temp_free_i64(tmp); | ||
30 | - } else { | ||
31 | - write_neon_element64(rd0, a->vd, 0, MO_64); | ||
32 | - write_neon_element64(rd1, a->vd, 1, MO_64); | ||
33 | } | ||
34 | |||
35 | + write_neon_element64(rd0, a->vd, 0, MO_64); | ||
36 | + write_neon_element64(rd1, a->vd, 1, MO_64); | ||
37 | tcg_temp_free_i64(rd0); | ||
38 | tcg_temp_free_i64(rd1); | ||
39 | |||
40 | @@ -XXX,XX +XXX,XX @@ static bool do_2scalar_long(DisasContext *s, arg_2scalar *a, | ||
41 | if (accfn) { | ||
42 | TCGv_i64 t64 = tcg_temp_new_i64(); | ||
43 | read_neon_element64(t64, a->vd, 0, MO_64); | ||
44 | - accfn(t64, t64, rn0_64); | ||
45 | - write_neon_element64(t64, a->vd, 0, MO_64); | ||
46 | + accfn(rn0_64, t64, rn0_64); | ||
47 | read_neon_element64(t64, a->vd, 1, MO_64); | ||
48 | - accfn(t64, t64, rn1_64); | ||
49 | - write_neon_element64(t64, a->vd, 1, MO_64); | ||
50 | + accfn(rn1_64, t64, rn1_64); | ||
51 | tcg_temp_free_i64(t64); | ||
52 | - } else { | ||
53 | - write_neon_element64(rn0_64, a->vd, 0, MO_64); | ||
54 | - write_neon_element64(rn1_64, a->vd, 1, MO_64); | ||
55 | } | ||
56 | + | ||
57 | + write_neon_element64(rn0_64, a->vd, 0, MO_64); | ||
58 | + write_neon_element64(rn1_64, a->vd, 1, MO_64); | ||
59 | tcg_temp_free_i64(rn0_64); | ||
60 | tcg_temp_free_i64(rn1_64); | ||
61 | return true; | ||
62 | -- | ||
63 | 2.20.1 | ||
64 | |||
65 | diff view generated by jsdifflib |
1 | From: Masahiro Yamada <masahiroy@kernel.org> | 1 | From: Richard Henderson <richard.henderson@linaro.org> |
---|---|---|---|
2 | 2 | ||
3 | According to the specification "Semihosting for AArch32 and Aarch64", | 3 | We can use proper widening loads to extend 32-bit inputs, |
4 | the SYS_OPEN operation should return: | 4 | and skip the "widenfn" step. |
5 | 5 | ||
6 | - A nonzero handle if the call is successful | 6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> |
7 | - -1 if the call is not successful | 7 | Message-id: 20201030022618.785675-12-richard.henderson@linaro.org |
8 | 8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | |
9 | So, it should never return 0. | ||
10 | |||
11 | Prior to commit 35e9a0a8ce4b ("target/arm/arm-semi: Make semihosting | ||
12 | code hand out its own file descriptors"), the guest fd matched to the | ||
13 | host fd. It returned a nonzero handle on success since the fd 0 is | ||
14 | already used for stdin. | ||
15 | |||
16 | Now that the guest fd is the index of guestfd_array, it starts from 0. | ||
17 | |||
18 | I noticed this issue particularly because Trusted Firmware-A built with | ||
19 | PLAT=qemu is no longer working. Its io_semihosting driver only handles | ||
20 | a positive return value as a valid filehandle. | ||
21 | |||
22 | Basically, there are two ways to fix this: | ||
23 | |||
24 | - Use (guestfd - 1) as the index of guestfs_arrary. We need to insert | ||
25 | increment/decrement to convert the guestfd and the array index back | ||
26 | and forth. | ||
27 | |||
28 | - Keep using guestfd as the index of guestfs_array. The first entry | ||
29 | of guestfs_array is left unused. | ||
30 | |||
31 | I thought the latter is simpler. We end up with wasting a small piece | ||
32 | of memory for the unused first entry of guestfd_array, but this is | ||
33 | probably not a big deal. | ||
34 | |||
35 | Fixes: 35e9a0a8ce4b ("target/arm/arm-semi: Make semihosting code hand out its own file descriptors") | ||
36 | Cc: qemu-stable@nongnu.org | ||
37 | Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> | ||
38 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
39 | Message-id: 20200109041228.10131-1-masahiroy@kernel.org | ||
40 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
41 | --- | 10 | --- |
42 | target/arm/arm-semi.c | 5 +++-- | 11 | target/arm/translate.c | 6 +++ |
43 | 1 file changed, 3 insertions(+), 2 deletions(-) | 12 | target/arm/translate-neon.c.inc | 66 ++++++++++++++++++--------------- |
13 | 2 files changed, 43 insertions(+), 29 deletions(-) | ||
44 | 14 | ||
45 | diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c | 15 | diff --git a/target/arm/translate.c b/target/arm/translate.c |
46 | index XXXXXXX..XXXXXXX 100644 | 16 | index XXXXXXX..XXXXXXX 100644 |
47 | --- a/target/arm/arm-semi.c | 17 | --- a/target/arm/translate.c |
48 | +++ b/target/arm/arm-semi.c | 18 | +++ b/target/arm/translate.c |
49 | @@ -XXX,XX +XXX,XX @@ static int alloc_guestfd(void) | 19 | @@ -XXX,XX +XXX,XX @@ static void read_neon_element64(TCGv_i64 dest, int reg, int ele, MemOp memop) |
50 | guestfd_array = g_array_new(FALSE, TRUE, sizeof(GuestFD)); | 20 | long off = neon_element_offset(reg, ele, memop); |
21 | |||
22 | switch (memop) { | ||
23 | + case MO_SL: | ||
24 | + tcg_gen_ld32s_i64(dest, cpu_env, off); | ||
25 | + break; | ||
26 | + case MO_UL: | ||
27 | + tcg_gen_ld32u_i64(dest, cpu_env, off); | ||
28 | + break; | ||
29 | case MO_Q: | ||
30 | tcg_gen_ld_i64(dest, cpu_env, off); | ||
31 | break; | ||
32 | diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc | ||
33 | index XXXXXXX..XXXXXXX 100644 | ||
34 | --- a/target/arm/translate-neon.c.inc | ||
35 | +++ b/target/arm/translate-neon.c.inc | ||
36 | @@ -XXX,XX +XXX,XX @@ static bool trans_Vimm_1r(DisasContext *s, arg_1reg_imm *a) | ||
37 | static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
38 | NeonGenWidenFn *widenfn, | ||
39 | NeonGenTwo64OpFn *opfn, | ||
40 | - bool src1_wide) | ||
41 | + int src1_mop, int src2_mop) | ||
42 | { | ||
43 | /* 3-regs different lengths, prewidening case (VADDL/VSUBL/VAADW/VSUBW) */ | ||
44 | TCGv_i64 rn0_64, rn1_64, rm_64; | ||
45 | - TCGv_i32 rm; | ||
46 | |||
47 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
48 | return false; | ||
49 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
50 | return false; | ||
51 | } | 51 | } |
52 | 52 | ||
53 | - for (i = 0; i < guestfd_array->len; i++) { | 53 | - if (!widenfn || !opfn) { |
54 | + /* SYS_OPEN should return nonzero handle on success. Start guestfd from 1 */ | 54 | + if (!opfn) { |
55 | + for (i = 1; i < guestfd_array->len; i++) { | 55 | /* size == 3 case, which is an entirely different insn group */ |
56 | GuestFD *gf = &g_array_index(guestfd_array, GuestFD, i); | 56 | return false; |
57 | |||
58 | if (gf->type == GuestFDUnused) { | ||
59 | @@ -XXX,XX +XXX,XX @@ static GuestFD *do_get_guestfd(int guestfd) | ||
60 | return NULL; | ||
61 | } | 57 | } |
62 | 58 | ||
63 | - if (guestfd < 0 || guestfd >= guestfd_array->len) { | 59 | - if ((a->vd & 1) || (src1_wide && (a->vn & 1))) { |
64 | + if (guestfd <= 0 || guestfd >= guestfd_array->len) { | 60 | + if ((a->vd & 1) || (src1_mop == MO_Q && (a->vn & 1))) { |
65 | return NULL; | 61 | return false; |
66 | } | 62 | } |
67 | 63 | ||
64 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
65 | rn1_64 = tcg_temp_new_i64(); | ||
66 | rm_64 = tcg_temp_new_i64(); | ||
67 | |||
68 | - if (src1_wide) { | ||
69 | - read_neon_element64(rn0_64, a->vn, 0, MO_64); | ||
70 | + if (src1_mop >= 0) { | ||
71 | + read_neon_element64(rn0_64, a->vn, 0, src1_mop); | ||
72 | } else { | ||
73 | TCGv_i32 tmp = tcg_temp_new_i32(); | ||
74 | read_neon_element32(tmp, a->vn, 0, MO_32); | ||
75 | widenfn(rn0_64, tmp); | ||
76 | tcg_temp_free_i32(tmp); | ||
77 | } | ||
78 | - rm = tcg_temp_new_i32(); | ||
79 | - read_neon_element32(rm, a->vm, 0, MO_32); | ||
80 | + if (src2_mop >= 0) { | ||
81 | + read_neon_element64(rm_64, a->vm, 0, src2_mop); | ||
82 | + } else { | ||
83 | + TCGv_i32 tmp = tcg_temp_new_i32(); | ||
84 | + read_neon_element32(tmp, a->vm, 0, MO_32); | ||
85 | + widenfn(rm_64, tmp); | ||
86 | + tcg_temp_free_i32(tmp); | ||
87 | + } | ||
88 | |||
89 | - widenfn(rm_64, rm); | ||
90 | - tcg_temp_free_i32(rm); | ||
91 | opfn(rn0_64, rn0_64, rm_64); | ||
92 | |||
93 | /* | ||
94 | * Load second pass inputs before storing the first pass result, to | ||
95 | * avoid incorrect results if a narrow input overlaps with the result. | ||
96 | */ | ||
97 | - if (src1_wide) { | ||
98 | - read_neon_element64(rn1_64, a->vn, 1, MO_64); | ||
99 | + if (src1_mop >= 0) { | ||
100 | + read_neon_element64(rn1_64, a->vn, 1, src1_mop); | ||
101 | } else { | ||
102 | TCGv_i32 tmp = tcg_temp_new_i32(); | ||
103 | read_neon_element32(tmp, a->vn, 1, MO_32); | ||
104 | widenfn(rn1_64, tmp); | ||
105 | tcg_temp_free_i32(tmp); | ||
106 | } | ||
107 | - rm = tcg_temp_new_i32(); | ||
108 | - read_neon_element32(rm, a->vm, 1, MO_32); | ||
109 | + if (src2_mop >= 0) { | ||
110 | + read_neon_element64(rm_64, a->vm, 1, src2_mop); | ||
111 | + } else { | ||
112 | + TCGv_i32 tmp = tcg_temp_new_i32(); | ||
113 | + read_neon_element32(tmp, a->vm, 1, MO_32); | ||
114 | + widenfn(rm_64, tmp); | ||
115 | + tcg_temp_free_i32(tmp); | ||
116 | + } | ||
117 | |||
118 | write_neon_element64(rn0_64, a->vd, 0, MO_64); | ||
119 | |||
120 | - widenfn(rm_64, rm); | ||
121 | - tcg_temp_free_i32(rm); | ||
122 | opfn(rn1_64, rn1_64, rm_64); | ||
123 | write_neon_element64(rn1_64, a->vd, 1, MO_64); | ||
124 | |||
125 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
126 | return true; | ||
127 | } | ||
128 | |||
129 | -#define DO_PREWIDEN(INSN, S, EXT, OP, SRC1WIDE) \ | ||
130 | +#define DO_PREWIDEN(INSN, S, OP, SRC1WIDE, SIGN) \ | ||
131 | static bool trans_##INSN##_3d(DisasContext *s, arg_3diff *a) \ | ||
132 | { \ | ||
133 | static NeonGenWidenFn * const widenfn[] = { \ | ||
134 | gen_helper_neon_widen_##S##8, \ | ||
135 | gen_helper_neon_widen_##S##16, \ | ||
136 | - tcg_gen_##EXT##_i32_i64, \ | ||
137 | - NULL, \ | ||
138 | + NULL, NULL, \ | ||
139 | }; \ | ||
140 | static NeonGenTwo64OpFn * const addfn[] = { \ | ||
141 | gen_helper_neon_##OP##l_u16, \ | ||
142 | @@ -XXX,XX +XXX,XX @@ static bool do_prewiden_3d(DisasContext *s, arg_3diff *a, | ||
143 | tcg_gen_##OP##_i64, \ | ||
144 | NULL, \ | ||
145 | }; \ | ||
146 | - return do_prewiden_3d(s, a, widenfn[a->size], \ | ||
147 | - addfn[a->size], SRC1WIDE); \ | ||
148 | + int narrow_mop = a->size == MO_32 ? MO_32 | SIGN : -1; \ | ||
149 | + return do_prewiden_3d(s, a, widenfn[a->size], addfn[a->size], \ | ||
150 | + SRC1WIDE ? MO_Q : narrow_mop, \ | ||
151 | + narrow_mop); \ | ||
152 | } | ||
153 | |||
154 | -DO_PREWIDEN(VADDL_S, s, ext, add, false) | ||
155 | -DO_PREWIDEN(VADDL_U, u, extu, add, false) | ||
156 | -DO_PREWIDEN(VSUBL_S, s, ext, sub, false) | ||
157 | -DO_PREWIDEN(VSUBL_U, u, extu, sub, false) | ||
158 | -DO_PREWIDEN(VADDW_S, s, ext, add, true) | ||
159 | -DO_PREWIDEN(VADDW_U, u, extu, add, true) | ||
160 | -DO_PREWIDEN(VSUBW_S, s, ext, sub, true) | ||
161 | -DO_PREWIDEN(VSUBW_U, u, extu, sub, true) | ||
162 | +DO_PREWIDEN(VADDL_S, s, add, false, MO_SIGN) | ||
163 | +DO_PREWIDEN(VADDL_U, u, add, false, 0) | ||
164 | +DO_PREWIDEN(VSUBL_S, s, sub, false, MO_SIGN) | ||
165 | +DO_PREWIDEN(VSUBL_U, u, sub, false, 0) | ||
166 | +DO_PREWIDEN(VADDW_S, s, add, true, MO_SIGN) | ||
167 | +DO_PREWIDEN(VADDW_U, u, add, true, 0) | ||
168 | +DO_PREWIDEN(VSUBW_S, s, sub, true, MO_SIGN) | ||
169 | +DO_PREWIDEN(VSUBW_U, u, sub, true, 0) | ||
170 | |||
171 | static bool do_narrow_3d(DisasContext *s, arg_3diff *a, | ||
172 | NeonGenTwo64OpFn *opfn, NeonGenNarrowFn *narrowfn) | ||
68 | -- | 173 | -- |
69 | 2.20.1 | 174 | 2.20.1 |
70 | 175 | ||
71 | 176 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error | ||
2 | meant we were using the H4() address swizzler macro rather than the | ||
3 | H2() which is required for 2-byte data. This had no effect on | ||
4 | little-endian hosts but meant we put the result data into the | ||
5 | destination Dreg in the wrong order on big-endian hosts. | ||
1 | 6 | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
9 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
10 | Message-id: 20201028191712.4910-2-peter.maydell@linaro.org | ||
11 | --- | ||
12 | target/arm/vec_helper.c | 8 ++++---- | ||
13 | 1 file changed, 4 insertions(+), 4 deletions(-) | ||
14 | |||
15 | diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/target/arm/vec_helper.c | ||
18 | +++ b/target/arm/vec_helper.c | ||
19 | @@ -XXX,XX +XXX,XX @@ DO_ABA(gvec_uaba_d, uint64_t) | ||
20 | r2 = float16_##OP(m[H2(0)], m[H2(1)], fpst); \ | ||
21 | r3 = float16_##OP(m[H2(2)], m[H2(3)], fpst); \ | ||
22 | \ | ||
23 | - d[H4(0)] = r0; \ | ||
24 | - d[H4(1)] = r1; \ | ||
25 | - d[H4(2)] = r2; \ | ||
26 | - d[H4(3)] = r3; \ | ||
27 | + d[H2(0)] = r0; \ | ||
28 | + d[H2(1)] = r1; \ | ||
29 | + d[H2(2)] = r2; \ | ||
30 | + d[H2(3)] = r3; \ | ||
31 | } | ||
32 | |||
33 | DO_NEON_PAIRWISE(neon_padd, add) | ||
34 | -- | ||
35 | 2.20.1 | ||
36 | |||
37 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | The helper functions for performing the udot/sdot operations against | ||
2 | a scalar were not using an address-swizzling macro when converting | ||
3 | the index of the scalar element into a pointer into the vm array. | ||
4 | This had no effect on little-endian hosts but meant we generated | ||
5 | incorrect results on big-endian hosts. | ||
1 | 6 | ||
7 | For these insns, the index is indexing over group of 4 8-bit values, | ||
8 | so 32 bits per indexed entity, and H4() is therefore what we want. | ||
9 | (For Neon the only possible input indexes are 0 and 1.) | ||
10 | |||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
12 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
13 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
14 | Message-id: 20201028191712.4910-3-peter.maydell@linaro.org | ||
15 | --- | ||
16 | target/arm/vec_helper.c | 4 ++-- | ||
17 | 1 file changed, 2 insertions(+), 2 deletions(-) | ||
18 | |||
19 | diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c | ||
20 | index XXXXXXX..XXXXXXX 100644 | ||
21 | --- a/target/arm/vec_helper.c | ||
22 | +++ b/target/arm/vec_helper.c | ||
23 | @@ -XXX,XX +XXX,XX @@ void HELPER(gvec_sdot_idx_b)(void *vd, void *vn, void *vm, uint32_t desc) | ||
24 | intptr_t index = simd_data(desc); | ||
25 | uint32_t *d = vd; | ||
26 | int8_t *n = vn; | ||
27 | - int8_t *m_indexed = (int8_t *)vm + index * 4; | ||
28 | + int8_t *m_indexed = (int8_t *)vm + H4(index) * 4; | ||
29 | |||
30 | /* Notice the special case of opr_sz == 8, from aa64/aa32 advsimd. | ||
31 | * Otherwise opr_sz is a multiple of 16. | ||
32 | @@ -XXX,XX +XXX,XX @@ void HELPER(gvec_udot_idx_b)(void *vd, void *vn, void *vm, uint32_t desc) | ||
33 | intptr_t index = simd_data(desc); | ||
34 | uint32_t *d = vd; | ||
35 | uint8_t *n = vn; | ||
36 | - uint8_t *m_indexed = (uint8_t *)vm + index * 4; | ||
37 | + uint8_t *m_indexed = (uint8_t *)vm + H4(index) * 4; | ||
38 | |||
39 | /* Notice the special case of opr_sz == 8, from aa64/aa32 advsimd. | ||
40 | * Otherwise opr_sz is a multiple of 16. | ||
41 | -- | ||
42 | 2.20.1 | ||
43 | |||
44 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> | ||
1 | 2 | ||
3 | HCR should be applied when NS is set, not when it is cleared. | ||
4 | |||
5 | Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> | ||
6 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | --- | ||
9 | target/arm/helper.c | 5 ++--- | ||
10 | 1 file changed, 2 insertions(+), 3 deletions(-) | ||
11 | |||
12 | diff --git a/target/arm/helper.c b/target/arm/helper.c | ||
13 | index XXXXXXX..XXXXXXX 100644 | ||
14 | --- a/target/arm/helper.c | ||
15 | +++ b/target/arm/helper.c | ||
16 | @@ -XXX,XX +XXX,XX @@ static void tlbimvaa_is_write(CPUARMState *env, const ARMCPRegInfo *ri, | ||
17 | |||
18 | /* | ||
19 | * Non-IS variants of TLB operations are upgraded to | ||
20 | - * IS versions if we are at NS EL1 and HCR_EL2.FB is set to | ||
21 | + * IS versions if we are at EL1 and HCR_EL2.FB is effectively set to | ||
22 | * force broadcast of these operations. | ||
23 | */ | ||
24 | static bool tlb_force_broadcast(CPUARMState *env) | ||
25 | { | ||
26 | - return (env->cp15.hcr_el2 & HCR_FB) && | ||
27 | - arm_current_el(env) == 1 && arm_is_secure_below_el3(env); | ||
28 | + return arm_current_el(env) == 1 && (arm_hcr_el2_eff(env) & HCR_FB); | ||
29 | } | ||
30 | |||
31 | static void tlbiall_write(CPUARMState *env, const ARMCPRegInfo *ri, | ||
32 | -- | ||
33 | 2.20.1 | ||
34 | |||
35 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> |
---|---|---|---|
2 | 2 | ||
3 | The kernel image and DeviceTree blob are built by the Armbian | 3 | Secure mode is not exempted from checking SCR_EL3.TLOR, and in the |
4 | project (based on Debian): | 4 | future HCR_EL2.TLOR when S-EL2 is enabled. |
5 | https://docs.armbian.com/Developer-Guide_Build-Preparation/ | ||
6 | 5 | ||
7 | The cpio image used comes from the linux-build-test project: | 6 | Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> |
8 | https://github.com/groeck/linux-build-test | 7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
9 | |||
10 | If ARM is a target being built, "make check-acceptance" will | ||
11 | automatically include this test by the use of the "arch:arm" tags. | ||
12 | |||
13 | Alternatively, this test can be run using: | ||
14 | |||
15 | $ avocado --show=console run -t machine:cubieboard tests/acceptance/boot_linux_console.py | ||
16 | console: Uncompressing Linux... done, booting the kernel. | ||
17 | console: Booting Linux on physical CPU 0x0 | ||
18 | console: Linux version 4.20.7-sunxi (root@armbian.com) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #5.75 SMP Fri Feb 8 09:02:10 CET 2019 | ||
19 | [...] | ||
20 | console: ahci-sunxi 1c18000.sata: Linked as a consumer to regulator.4 | ||
21 | console: ahci-sunxi 1c18000.sata: controller can't do 64bit DMA, forcing 32bit | ||
22 | console: ahci-sunxi 1c18000.sata: AHCI 0001.0000 32 slots 1 ports 1.5 Gbps 0x1 impl platform mode | ||
23 | console: ahci-sunxi 1c18000.sata: flags: ncq only | ||
24 | console: scsi host0: ahci-sunxi | ||
25 | console: ata1: SATA max UDMA/133 mmio [mem 0x01c18000-0x01c18fff] port 0x100 irq 27 | ||
26 | console: of_cfs_init | ||
27 | console: of_cfs_init: OK | ||
28 | console: vcc3v0: disabling | ||
29 | console: vcc5v0: disabling | ||
30 | console: usb1-vbus: disabling | ||
31 | console: usb2-vbus: disabling | ||
32 | console: ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) | ||
33 | console: ata1.00: ATA-7: QEMU HARDDISK, 2.5+, max UDMA/100 | ||
34 | console: ata1.00: 40960 sectors, multi 16: LBA48 NCQ (depth 32) | ||
35 | console: ata1.00: applying bridge limits | ||
36 | console: ata1.00: configured for UDMA/100 | ||
37 | console: scsi 0:0:0:0: Direct-Access ATA QEMU HARDDISK 2.5+ PQ: 0 ANSI: 5 | ||
38 | console: sd 0:0:0:0: Attached scsi generic sg0 type 0 | ||
39 | console: sd 0:0:0:0: [sda] 40960 512-byte logical blocks: (21.0 MB/20.0 MiB) | ||
40 | console: sd 0:0:0:0: [sda] Write Protect is off | ||
41 | console: sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA | ||
42 | console: sd 0:0:0:0: [sda] Attached SCSI disk | ||
43 | console: EXT4-fs (sda): mounting ext2 file system using the ext4 subsystem | ||
44 | console: EXT4-fs (sda): mounted filesystem without journal. Opts: (null) | ||
45 | console: VFS: Mounted root (ext2 filesystem) readonly on device 8:0. | ||
46 | [...] | ||
47 | console: cat /proc/partitions | ||
48 | console: / # cat /proc/partitions | ||
49 | console: major minor #blocks name | ||
50 | console: 1 0 4096 ram0 | ||
51 | console: 1 1 4096 ram1 | ||
52 | console: 1 2 4096 ram2 | ||
53 | console: 1 3 4096 ram3 | ||
54 | console: 8 0 20480 sda | ||
55 | console: reboot | ||
56 | console: / # reboot | ||
57 | [...] | ||
58 | console: sd 0:0:0:0: [sda] Synchronizing SCSI cache | ||
59 | console: reboot: Restarting system | ||
60 | PASS (48.39 s) | ||
61 | |||
62 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
63 | Message-id: 20191230110953.25496-3-f4bug@amsat.org | ||
64 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
65 | --- | 9 | --- |
66 | tests/acceptance/boot_linux_console.py | 44 ++++++++++++++++++++++++++ | 10 | target/arm/helper.c | 19 +++++-------------- |
67 | 1 file changed, 44 insertions(+) | 11 | 1 file changed, 5 insertions(+), 14 deletions(-) |
68 | 12 | ||
69 | diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py | 13 | diff --git a/target/arm/helper.c b/target/arm/helper.c |
70 | index XXXXXXX..XXXXXXX 100644 | 14 | index XXXXXXX..XXXXXXX 100644 |
71 | --- a/tests/acceptance/boot_linux_console.py | 15 | --- a/target/arm/helper.c |
72 | +++ b/tests/acceptance/boot_linux_console.py | 16 | +++ b/target/arm/helper.c |
73 | @@ -XXX,XX +XXX,XX @@ class BootLinuxConsole(Test): | 17 | @@ -XXX,XX +XXX,XX @@ static uint64_t id_aa64pfr0_read(CPUARMState *env, const ARMCPRegInfo *ri) |
74 | exec_command_and_wait_for_pattern(self, 'reboot', | 18 | #endif |
75 | 'reboot: Restarting system') | 19 | |
76 | 20 | /* Shared logic between LORID and the rest of the LOR* registers. | |
77 | + def test_arm_cubieboard_sata(self): | 21 | - * Secure state has already been delt with. |
78 | + """ | 22 | + * Secure state exclusion has already been dealt with. |
79 | + :avocado: tags=arch:arm | 23 | */ |
80 | + :avocado: tags=machine:cubieboard | 24 | -static CPAccessResult access_lor_ns(CPUARMState *env) |
81 | + """ | 25 | +static CPAccessResult access_lor_ns(CPUARMState *env, |
82 | + deb_url = ('https://apt.armbian.com/pool/main/l/' | 26 | + const ARMCPRegInfo *ri, bool isread) |
83 | + 'linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb') | 27 | { |
84 | + deb_hash = '1334c29c44d984ffa05ed10de8c3361f33d78315' | 28 | int el = arm_current_el(env); |
85 | + deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash) | 29 | |
86 | + kernel_path = self.extract_from_deb(deb_path, | 30 | @@ -XXX,XX +XXX,XX @@ static CPAccessResult access_lor_ns(CPUARMState *env) |
87 | + '/boot/vmlinuz-4.20.7-sunxi') | 31 | return CP_ACCESS_OK; |
88 | + dtb_path = '/usr/lib/linux-image-dev-sunxi/sun4i-a10-cubieboard.dtb' | 32 | } |
89 | + dtb_path = self.extract_from_deb(deb_path, dtb_path) | 33 | |
90 | + rootfs_url = ('https://github.com/groeck/linux-build-test/raw/' | 34 | -static CPAccessResult access_lorid(CPUARMState *env, const ARMCPRegInfo *ri, |
91 | + '2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/' | 35 | - bool isread) |
92 | + 'arm/rootfs-armv5.ext2.gz') | 36 | -{ |
93 | + rootfs_hash = '093e89d2b4d982234bf528bc9fb2f2f17a9d1f93' | 37 | - if (arm_is_secure_below_el3(env)) { |
94 | + rootfs_path_gz = self.fetch_asset(rootfs_url, asset_hash=rootfs_hash) | 38 | - /* Access ok in secure mode. */ |
95 | + rootfs_path = os.path.join(self.workdir, 'rootfs.cpio') | 39 | - return CP_ACCESS_OK; |
96 | + archive.gzip_uncompress(rootfs_path_gz, rootfs_path) | 40 | - } |
97 | + | 41 | - return access_lor_ns(env); |
98 | + self.vm.set_console() | 42 | -} |
99 | + kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + | 43 | - |
100 | + 'console=ttyS0,115200 ' | 44 | static CPAccessResult access_lor_other(CPUARMState *env, |
101 | + 'usbcore.nousb ' | 45 | const ARMCPRegInfo *ri, bool isread) |
102 | + 'root=/dev/sda ro ' | 46 | { |
103 | + 'panic=-1 noreboot') | 47 | @@ -XXX,XX +XXX,XX @@ static CPAccessResult access_lor_other(CPUARMState *env, |
104 | + self.vm.add_args('-kernel', kernel_path, | 48 | /* Access denied in secure mode. */ |
105 | + '-dtb', dtb_path, | 49 | return CP_ACCESS_TRAP; |
106 | + '-drive', 'if=none,format=raw,id=disk0,file=' | 50 | } |
107 | + + rootfs_path, | 51 | - return access_lor_ns(env); |
108 | + '-device', 'ide-hd,bus=ide.0,drive=disk0', | 52 | + return access_lor_ns(env, ri, isread); |
109 | + '-append', kernel_command_line, | 53 | } |
110 | + '-no-reboot') | 54 | |
111 | + self.vm.launch() | 55 | /* |
112 | + self.wait_for_console_pattern('Boot successful.') | 56 | @@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo lor_reginfo[] = { |
113 | + | 57 | .type = ARM_CP_CONST, .resetvalue = 0 }, |
114 | + exec_command_and_wait_for_pattern(self, 'cat /proc/cpuinfo', | 58 | { .name = "LORID_EL1", .state = ARM_CP_STATE_AA64, |
115 | + 'Allwinner sun4i/sun5i') | 59 | .opc0 = 3, .opc1 = 0, .crn = 10, .crm = 4, .opc2 = 7, |
116 | + exec_command_and_wait_for_pattern(self, 'cat /proc/partitions', | 60 | - .access = PL1_R, .accessfn = access_lorid, |
117 | + 'sda') | 61 | + .access = PL1_R, .accessfn = access_lor_ns, |
118 | + exec_command_and_wait_for_pattern(self, 'reboot', | 62 | .type = ARM_CP_CONST, .resetvalue = 0 }, |
119 | + 'reboot: Restarting system') | 63 | REGINFO_SENTINEL |
120 | + | 64 | }; |
121 | def test_s390x_s390_ccw_virtio(self): | ||
122 | """ | ||
123 | :avocado: tags=arch:s390x | ||
124 | -- | 65 | -- |
125 | 2.20.1 | 66 | 2.20.1 |
126 | 67 | ||
127 | 68 | diff view generated by jsdifflib |
1 | From: Jeff Kubascik <jeff.kubascik@dornerworks.com> | 1 | If we're using the capstone disassembler, disassembly of a run of |
---|---|---|---|
2 | instructions more than 32 bytes long disassembles the wrong data for | ||
3 | instructions beyond the 32 byte mark: | ||
2 | 4 | ||
3 | The IL bit is set for 32-bit instructions, thus passing false | 5 | (qemu) xp /16x 0x100 |
4 | with the is_16bit parameter to syn_data_abort_with_iss() makes | 6 | 0000000000000100: 0x00000005 0x54410001 0x00000001 0x00001000 |
5 | a syn mask that always has the IL bit set. | 7 | 0000000000000110: 0x00000000 0x00000004 0x54410002 0x3c000000 |
8 | 0000000000000120: 0x00000000 0x00000004 0x54410009 0x74736574 | ||
9 | 0000000000000130: 0x00000000 0x00000000 0x00000000 0x00000000 | ||
10 | (qemu) xp /16i 0x100 | ||
11 | 0x00000100: 00000005 andeq r0, r0, r5 | ||
12 | 0x00000104: 54410001 strbpl r0, [r1], #-1 | ||
13 | 0x00000108: 00000001 andeq r0, r0, r1 | ||
14 | 0x0000010c: 00001000 andeq r1, r0, r0 | ||
15 | 0x00000110: 00000000 andeq r0, r0, r0 | ||
16 | 0x00000114: 00000004 andeq r0, r0, r4 | ||
17 | 0x00000118: 54410002 strbpl r0, [r1], #-2 | ||
18 | 0x0000011c: 3c000000 .byte 0x00, 0x00, 0x00, 0x3c | ||
19 | 0x00000120: 54410001 strbpl r0, [r1], #-1 | ||
20 | 0x00000124: 00000001 andeq r0, r0, r1 | ||
21 | 0x00000128: 00001000 andeq r1, r0, r0 | ||
22 | 0x0000012c: 00000000 andeq r0, r0, r0 | ||
23 | 0x00000130: 00000004 andeq r0, r0, r4 | ||
24 | 0x00000134: 54410002 strbpl r0, [r1], #-2 | ||
25 | 0x00000138: 3c000000 .byte 0x00, 0x00, 0x00, 0x3c | ||
26 | 0x0000013c: 00000000 andeq r0, r0, r0 | ||
6 | 27 | ||
7 | Pass is_16bit as true to make the initial syn mask have IL=0, | 28 | Here the disassembly of 0x120..0x13f is using the data that is in |
8 | so that the final IL value comes from or'ing template_syn. | 29 | 0x104..0x123. |
30 | |||
31 | This is caused by passing the wrong value to the read_memory_func(). | ||
32 | The intention is that at this point in the loop the 'cap_buf' buffer | ||
33 | already contains 'csize' bytes of data for the instruction at guest | ||
34 | addr 'pc', and we want to read in an extra 'tsize' bytes. Those | ||
35 | extra bytes are therefore at 'pc + csize', not 'pc'. On the first | ||
36 | time through the loop 'csize' happens to be zero, so the initial read | ||
37 | of 32 bytes into cap_buf is correct and as long as the disassembly | ||
38 | never needs to read more data we return the correct information. | ||
39 | |||
40 | Use the correct guest address in the call to read_memory_func(). | ||
9 | 41 | ||
10 | Cc: qemu-stable@nongnu.org | 42 | Cc: qemu-stable@nongnu.org |
11 | Fixes: aaa1f954d4ca ("target-arm: A64: Create Instruction Syndromes for Data Aborts") | 43 | Fixes: https://bugs.launchpad.net/qemu/+bug/1900779 |
12 | Signed-off-by: Jeff Kubascik <jeff.kubascik@dornerworks.com> | ||
13 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
14 | Message-id: 20200117004618.2742-2-richard.henderson@linaro.org | ||
15 | [rth: Extracted this as a self-contained bug fix from a larger patch] | ||
16 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
17 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
18 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 44 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
45 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
46 | Message-id: 20201022132445.25039-1-peter.maydell@linaro.org | ||
19 | --- | 47 | --- |
20 | target/arm/tlb_helper.c | 2 +- | 48 | disas/capstone.c | 2 +- |
21 | 1 file changed, 1 insertion(+), 1 deletion(-) | 49 | 1 file changed, 1 insertion(+), 1 deletion(-) |
22 | 50 | ||
23 | diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c | 51 | diff --git a/disas/capstone.c b/disas/capstone.c |
24 | index XXXXXXX..XXXXXXX 100644 | 52 | index XXXXXXX..XXXXXXX 100644 |
25 | --- a/target/arm/tlb_helper.c | 53 | --- a/disas/capstone.c |
26 | +++ b/target/arm/tlb_helper.c | 54 | +++ b/disas/capstone.c |
27 | @@ -XXX,XX +XXX,XX @@ static inline uint32_t merge_syn_data_abort(uint32_t template_syn, | 55 | @@ -XXX,XX +XXX,XX @@ bool cap_disas_monitor(disassemble_info *info, uint64_t pc, int count) |
28 | syn = syn_data_abort_with_iss(same_el, | 56 | |
29 | 0, 0, 0, 0, 0, | 57 | /* Make certain that we can make progress. */ |
30 | ea, 0, s1ptw, is_write, fsc, | 58 | assert(tsize != 0); |
31 | - false); | 59 | - info->read_memory_func(pc, cap_buf + csize, tsize, info); |
32 | + true); | 60 | + info->read_memory_func(pc + csize, cap_buf + csize, tsize, info); |
33 | /* Merge the runtime syndrome with the template syndrome. */ | 61 | csize += tsize; |
34 | syn |= template_syn; | 62 | |
35 | } | 63 | if (cs_disasm_iter(handle, &cbuf, &csize, &pc, insn)) { |
36 | -- | 64 | -- |
37 | 2.20.1 | 65 | 2.20.1 |
38 | 66 | ||
39 | 67 | diff view generated by jsdifflib |
1 | From: Jeff Kubascik <jeff.kubascik@dornerworks.com> | 1 | From: Philippe Mathieu-Daudé <philmd@redhat.com> |
---|---|---|---|
2 | 2 | ||
3 | The wfi instruction can be configured to be trapped by a higher exception | 3 | Use the BIT_ULL() macro to ensure we use 64-bit arithmetic. |
4 | level, such as the EL2 hypervisor. When the instruction is trapped, the | 4 | This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN): |
5 | program counter should contain the address of the wfi instruction that | ||
6 | caused the exception. The program counter is adjusted for this in the wfi op | ||
7 | helper function. | ||
8 | 5 | ||
9 | However, this correction is done to env->pc, which only applies to AArch64 | 6 | CID 1432363 (#1 of 1): Unintentional integer overflow: |
10 | mode. For AArch32, the program counter is stored in env->regs[15]. This | ||
11 | adds an if-else statement to modify the correct program counter location | ||
12 | based on the the current CPU mode. | ||
13 | 7 | ||
14 | Signed-off-by: Jeff Kubascik <jeff.kubascik@dornerworks.com> | 8 | overflow_before_widen: |
15 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 9 | Potentially overflowing expression 1 << scale with type int |
10 | (32 bits, signed) is evaluated using 32-bit arithmetic, and | ||
11 | then used in a context that expects an expression of type | ||
12 | hwaddr (64 bits, unsigned). | ||
13 | |||
14 | Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
15 | Acked-by: Eric Auger <eric.auger@redhat.com> | ||
16 | Message-id: 20201030144617.1535064-1-philmd@redhat.com | ||
17 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
16 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 18 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
17 | --- | 19 | --- |
18 | target/arm/op_helper.c | 7 ++++++- | 20 | hw/arm/smmuv3.c | 3 ++- |
19 | 1 file changed, 6 insertions(+), 1 deletion(-) | 21 | 1 file changed, 2 insertions(+), 1 deletion(-) |
20 | 22 | ||
21 | diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c | 23 | diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c |
22 | index XXXXXXX..XXXXXXX 100644 | 24 | index XXXXXXX..XXXXXXX 100644 |
23 | --- a/target/arm/op_helper.c | 25 | --- a/hw/arm/smmuv3.c |
24 | +++ b/target/arm/op_helper.c | 26 | +++ b/hw/arm/smmuv3.c |
25 | @@ -XXX,XX +XXX,XX @@ void HELPER(wfi)(CPUARMState *env, uint32_t insn_len) | 27 | @@ -XXX,XX +XXX,XX @@ |
28 | */ | ||
29 | |||
30 | #include "qemu/osdep.h" | ||
31 | +#include "qemu/bitops.h" | ||
32 | #include "hw/irq.h" | ||
33 | #include "hw/sysbus.h" | ||
34 | #include "migration/vmstate.h" | ||
35 | @@ -XXX,XX +XXX,XX @@ static void smmuv3_s1_range_inval(SMMUState *s, Cmd *cmd) | ||
36 | scale = CMD_SCALE(cmd); | ||
37 | num = CMD_NUM(cmd); | ||
38 | ttl = CMD_TTL(cmd); | ||
39 | - num_pages = (num + 1) * (1 << (scale)); | ||
40 | + num_pages = (num + 1) * BIT_ULL(scale); | ||
26 | } | 41 | } |
27 | 42 | ||
28 | if (target_el) { | 43 | if (type == SMMU_CMD_TLBI_NH_VA) { |
29 | - env->pc -= insn_len; | ||
30 | + if (env->aarch64) { | ||
31 | + env->pc -= insn_len; | ||
32 | + } else { | ||
33 | + env->regs[15] -= insn_len; | ||
34 | + } | ||
35 | + | ||
36 | raise_exception(env, EXCP_UDEF, syn_wfx(1, 0xe, 0, insn_len == 2), | ||
37 | target_el); | ||
38 | } | ||
39 | -- | 44 | -- |
40 | 2.20.1 | 45 | 2.20.1 |
41 | 46 | ||
42 | 47 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> |
---|---|---|---|
2 | 2 | ||
3 | This test boots a Linux kernel on a CubieBoard and verify | 3 | When booting a CPU with EL3 using the -kernel flag, set up CPTR_EL3 so |
4 | the serial output is working. | 4 | that SVE will not trap to EL3. |
5 | 5 | ||
6 | The kernel image and DeviceTree blob are built by the Armbian | 6 | Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com> |
7 | project (based on Debian): | 7 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
8 | https://docs.armbian.com/Developer-Guide_Build-Preparation/ | 8 | Message-id: 20201030151541.11976-1-remi@remlab.net |
9 | |||
10 | The cpio image used comes from the linux-build-test project: | ||
11 | https://github.com/groeck/linux-build-test | ||
12 | |||
13 | If ARM is a target being built, "make check-acceptance" will | ||
14 | automatically include this test by the use of the "arch:arm" tags. | ||
15 | |||
16 | Alternatively, this test can be run using: | ||
17 | |||
18 | $ avocado --show=console run -t machine:cubieboard tests/acceptance/boot_linux_console.py | ||
19 | console: Uncompressing Linux... done, booting the kernel. | ||
20 | console: Booting Linux on physical CPU 0x0 | ||
21 | console: Linux version 4.20.7-sunxi (root@armbian.com) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #5.75 SMP Fri Feb 8 09:02:10 CET 2019 | ||
22 | console: CPU: ARMv7 Processor [410fc080] revision 0 (ARMv7), cr=50c5387d | ||
23 | console: CPU: PIPT / VIPT nonaliasing data cache, VIPT nonaliasing instruction cache | ||
24 | console: OF: fdt: Machine model: Cubietech Cubieboard | ||
25 | [...] | ||
26 | console: Boot successful. | ||
27 | console: cat /proc/cpuinfo | ||
28 | console: / # cat /proc/cpuinfo | ||
29 | console: processor : 0 | ||
30 | console: model name : ARMv7 Processor rev 0 (v7l) | ||
31 | console: BogoMIPS : 832.51 | ||
32 | [...] | ||
33 | console: Hardware : Allwinner sun4i/sun5i Families | ||
34 | console: Revision : 0000 | ||
35 | console: Serial : 0000000000000000 | ||
36 | console: cat /proc/iomem | ||
37 | console: / # cat /proc/iomem | ||
38 | console: 01c00000-01c0002f : system-control@1c00000 | ||
39 | console: 01c02000-01c02fff : dma-controller@1c02000 | ||
40 | console: 01c05000-01c05fff : spi@1c05000 | ||
41 | console: 01c0b080-01c0b093 : mdio@1c0b080 | ||
42 | console: 01c0c000-01c0cfff : lcd-controller@1c0c000 | ||
43 | console: 01c0d000-01c0dfff : lcd-controller@1c0d000 | ||
44 | console: 01c0f000-01c0ffff : mmc@1c0f000 | ||
45 | [...] | ||
46 | PASS (54.35 s) | ||
47 | |||
48 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
49 | Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> | ||
50 | Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com> | ||
51 | Message-id: 20191230110953.25496-2-f4bug@amsat.org | ||
52 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
53 | --- | 10 | --- |
54 | tests/acceptance/boot_linux_console.py | 41 ++++++++++++++++++++++++++ | 11 | hw/arm/boot.c | 3 +++ |
55 | 1 file changed, 41 insertions(+) | 12 | 1 file changed, 3 insertions(+) |
56 | 13 | ||
57 | diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py | 14 | diff --git a/hw/arm/boot.c b/hw/arm/boot.c |
58 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
59 | --- a/tests/acceptance/boot_linux_console.py | 16 | --- a/hw/arm/boot.c |
60 | +++ b/tests/acceptance/boot_linux_console.py | 17 | +++ b/hw/arm/boot.c |
61 | @@ -XXX,XX +XXX,XX @@ class BootLinuxConsole(Test): | 18 | @@ -XXX,XX +XXX,XX @@ static void do_cpu_reset(void *opaque) |
62 | self.wait_for_console_pattern('Boot successful.') | 19 | if (cpu_isar_feature(aa64_mte, cpu)) { |
63 | # TODO user command, for now the uart is stuck | 20 | env->cp15.scr_el3 |= SCR_ATA; |
64 | 21 | } | |
65 | + def test_arm_cubieboard_initrd(self): | 22 | + if (cpu_isar_feature(aa64_sve, cpu)) { |
66 | + """ | 23 | + env->cp15.cptr_el[3] |= CPTR_EZ; |
67 | + :avocado: tags=arch:arm | 24 | + } |
68 | + :avocado: tags=machine:cubieboard | 25 | /* AArch64 kernels never boot in secure mode */ |
69 | + """ | 26 | assert(!info->secure_boot); |
70 | + deb_url = ('https://apt.armbian.com/pool/main/l/' | 27 | /* This hook is only supported for AArch32 currently: |
71 | + 'linux-4.20.7-sunxi/linux-image-dev-sunxi_5.75_armhf.deb') | ||
72 | + deb_hash = '1334c29c44d984ffa05ed10de8c3361f33d78315' | ||
73 | + deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash) | ||
74 | + kernel_path = self.extract_from_deb(deb_path, | ||
75 | + '/boot/vmlinuz-4.20.7-sunxi') | ||
76 | + dtb_path = '/usr/lib/linux-image-dev-sunxi/sun4i-a10-cubieboard.dtb' | ||
77 | + dtb_path = self.extract_from_deb(deb_path, dtb_path) | ||
78 | + initrd_url = ('https://github.com/groeck/linux-build-test/raw/' | ||
79 | + '2eb0a73b5d5a28df3170c546ddaaa9757e1e0848/rootfs/' | ||
80 | + 'arm/rootfs-armv5.cpio.gz') | ||
81 | + initrd_hash = '2b50f1873e113523967806f4da2afe385462ff9b' | ||
82 | + initrd_path_gz = self.fetch_asset(initrd_url, asset_hash=initrd_hash) | ||
83 | + initrd_path = os.path.join(self.workdir, 'rootfs.cpio') | ||
84 | + archive.gzip_uncompress(initrd_path_gz, initrd_path) | ||
85 | + | ||
86 | + self.vm.set_console() | ||
87 | + kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + | ||
88 | + 'console=ttyS0,115200 ' | ||
89 | + 'usbcore.nousb ' | ||
90 | + 'panic=-1 noreboot') | ||
91 | + self.vm.add_args('-kernel', kernel_path, | ||
92 | + '-dtb', dtb_path, | ||
93 | + '-initrd', initrd_path, | ||
94 | + '-append', kernel_command_line, | ||
95 | + '-no-reboot') | ||
96 | + self.vm.launch() | ||
97 | + self.wait_for_console_pattern('Boot successful.') | ||
98 | + | ||
99 | + exec_command_and_wait_for_pattern(self, 'cat /proc/cpuinfo', | ||
100 | + 'Allwinner sun4i/sun5i') | ||
101 | + exec_command_and_wait_for_pattern(self, 'cat /proc/iomem', | ||
102 | + 'system-control@1c00000') | ||
103 | + exec_command_and_wait_for_pattern(self, 'reboot', | ||
104 | + 'reboot: Restarting system') | ||
105 | + | ||
106 | def test_s390x_s390_ccw_virtio(self): | ||
107 | """ | ||
108 | :avocado: tags=arch:s390x | ||
109 | -- | 28 | -- |
110 | 2.20.1 | 29 | 2.20.1 |
111 | 30 | ||
112 | 31 | diff view generated by jsdifflib |
1 | From: Alistair Francis <alistair@alistair23.me> | 1 | From: AlexChen <alex.chen@huawei.com> |
---|---|---|---|
2 | 2 | ||
3 | Signed-off-by: Alistair Francis <alistair@alistair23.me> | 3 | In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before |
4 | being check if it is valid, which may lead to NULL pointer dereference. | ||
5 | So move the assignment to surface after checking that the omap_lcd is valid | ||
6 | and move surface_bits_per_pixel(surface) to after the surface assignment. | ||
7 | |||
8 | Reported-by: Euler Robot <euler.robot@huawei.com> | ||
9 | Signed-off-by: AlexChen <alex.chen@huawei.com> | ||
10 | Message-id: 5F9CDB8A.9000001@huawei.com | ||
4 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Message-id: 1d145c4c13e5fa140caf131232a6f524c88fcd72.1576658572.git.alistair@alistair23.me | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | --- | 13 | --- |
8 | hw/arm/Makefile.objs | 1 + | 14 | hw/display/omap_lcdc.c | 10 +++++++--- |
9 | include/hw/arm/stm32f405_soc.h | 73 ++++++++ | 15 | 1 file changed, 7 insertions(+), 3 deletions(-) |
10 | hw/arm/stm32f405_soc.c | 302 +++++++++++++++++++++++++++++++++ | ||
11 | MAINTAINERS | 8 + | ||
12 | 4 files changed, 384 insertions(+) | ||
13 | create mode 100644 include/hw/arm/stm32f405_soc.h | ||
14 | create mode 100644 hw/arm/stm32f405_soc.c | ||
15 | 16 | ||
16 | diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs | 17 | diff --git a/hw/display/omap_lcdc.c b/hw/display/omap_lcdc.c |
17 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/hw/arm/Makefile.objs | 19 | --- a/hw/display/omap_lcdc.c |
19 | +++ b/hw/arm/Makefile.objs | 20 | +++ b/hw/display/omap_lcdc.c |
20 | @@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_STRONGARM) += strongarm.o | 21 | @@ -XXX,XX +XXX,XX @@ static void omap_lcd_interrupts(struct omap_lcd_panel_s *s) |
21 | obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o | 22 | static void omap_update_display(void *opaque) |
22 | obj-$(CONFIG_RASPI) += bcm2835_peripherals.o bcm2836.o raspi.o | 23 | { |
23 | obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o | 24 | struct omap_lcd_panel_s *omap_lcd = (struct omap_lcd_panel_s *) opaque; |
24 | +obj-$(CONFIG_STM32F405_SOC) += stm32f405_soc.o | 25 | - DisplaySurface *surface = qemu_console_surface(omap_lcd->con); |
25 | obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o | 26 | + DisplaySurface *surface; |
26 | obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o xlnx-versal-virt.o | 27 | draw_line_func draw_line; |
27 | obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o | 28 | int size, height, first, last; |
28 | diff --git a/include/hw/arm/stm32f405_soc.h b/include/hw/arm/stm32f405_soc.h | 29 | int width, linesize, step, bpp, frame_offset; |
29 | new file mode 100644 | 30 | hwaddr frame_base; |
30 | index XXXXXXX..XXXXXXX | 31 | |
31 | --- /dev/null | 32 | - if (!omap_lcd || omap_lcd->plm == 1 || !omap_lcd->enable || |
32 | +++ b/include/hw/arm/stm32f405_soc.h | 33 | - !surface_bits_per_pixel(surface)) { |
33 | @@ -XXX,XX +XXX,XX @@ | 34 | + if (!omap_lcd || omap_lcd->plm == 1 || !omap_lcd->enable) { |
34 | +/* | ||
35 | + * STM32F405 SoC | ||
36 | + * | ||
37 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
38 | + * | ||
39 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
40 | + * of this software and associated documentation files (the "Software"), to deal | ||
41 | + * in the Software without restriction, including without limitation the rights | ||
42 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
43 | + * copies of the Software, and to permit persons to whom the Software is | ||
44 | + * furnished to do so, subject to the following conditions: | ||
45 | + * | ||
46 | + * The above copyright notice and this permission notice shall be included in | ||
47 | + * all copies or substantial portions of the Software. | ||
48 | + * | ||
49 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
50 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
51 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
52 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
53 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
54 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
55 | + * THE SOFTWARE. | ||
56 | + */ | ||
57 | + | ||
58 | +#ifndef HW_ARM_STM32F405_SOC_H | ||
59 | +#define HW_ARM_STM32F405_SOC_H | ||
60 | + | ||
61 | +#include "hw/misc/stm32f4xx_syscfg.h" | ||
62 | +#include "hw/timer/stm32f2xx_timer.h" | ||
63 | +#include "hw/char/stm32f2xx_usart.h" | ||
64 | +#include "hw/adc/stm32f2xx_adc.h" | ||
65 | +#include "hw/misc/stm32f4xx_exti.h" | ||
66 | +#include "hw/or-irq.h" | ||
67 | +#include "hw/ssi/stm32f2xx_spi.h" | ||
68 | +#include "hw/arm/armv7m.h" | ||
69 | + | ||
70 | +#define TYPE_STM32F405_SOC "stm32f405-soc" | ||
71 | +#define STM32F405_SOC(obj) \ | ||
72 | + OBJECT_CHECK(STM32F405State, (obj), TYPE_STM32F405_SOC) | ||
73 | + | ||
74 | +#define STM_NUM_USARTS 7 | ||
75 | +#define STM_NUM_TIMERS 4 | ||
76 | +#define STM_NUM_ADCS 6 | ||
77 | +#define STM_NUM_SPIS 6 | ||
78 | + | ||
79 | +#define FLASH_BASE_ADDRESS 0x08000000 | ||
80 | +#define FLASH_SIZE (1024 * 1024) | ||
81 | +#define SRAM_BASE_ADDRESS 0x20000000 | ||
82 | +#define SRAM_SIZE (192 * 1024) | ||
83 | + | ||
84 | +typedef struct STM32F405State { | ||
85 | + /*< private >*/ | ||
86 | + SysBusDevice parent_obj; | ||
87 | + /*< public >*/ | ||
88 | + | ||
89 | + char *cpu_type; | ||
90 | + | ||
91 | + ARMv7MState armv7m; | ||
92 | + | ||
93 | + STM32F4xxSyscfgState syscfg; | ||
94 | + STM32F4xxExtiState exti; | ||
95 | + STM32F2XXUsartState usart[STM_NUM_USARTS]; | ||
96 | + STM32F2XXTimerState timer[STM_NUM_TIMERS]; | ||
97 | + qemu_or_irq adc_irqs; | ||
98 | + STM32F2XXADCState adc[STM_NUM_ADCS]; | ||
99 | + STM32F2XXSPIState spi[STM_NUM_SPIS]; | ||
100 | + | ||
101 | + MemoryRegion sram; | ||
102 | + MemoryRegion flash; | ||
103 | + MemoryRegion flash_alias; | ||
104 | +} STM32F405State; | ||
105 | + | ||
106 | +#endif | ||
107 | diff --git a/hw/arm/stm32f405_soc.c b/hw/arm/stm32f405_soc.c | ||
108 | new file mode 100644 | ||
109 | index XXXXXXX..XXXXXXX | ||
110 | --- /dev/null | ||
111 | +++ b/hw/arm/stm32f405_soc.c | ||
112 | @@ -XXX,XX +XXX,XX @@ | ||
113 | +/* | ||
114 | + * STM32F405 SoC | ||
115 | + * | ||
116 | + * Copyright (c) 2014 Alistair Francis <alistair@alistair23.me> | ||
117 | + * | ||
118 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
119 | + * of this software and associated documentation files (the "Software"), to deal | ||
120 | + * in the Software without restriction, including without limitation the rights | ||
121 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
122 | + * copies of the Software, and to permit persons to whom the Software is | ||
123 | + * furnished to do so, subject to the following conditions: | ||
124 | + * | ||
125 | + * The above copyright notice and this permission notice shall be included in | ||
126 | + * all copies or substantial portions of the Software. | ||
127 | + * | ||
128 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
129 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
130 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
131 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
132 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
133 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
134 | + * THE SOFTWARE. | ||
135 | + */ | ||
136 | + | ||
137 | +#include "qemu/osdep.h" | ||
138 | +#include "qapi/error.h" | ||
139 | +#include "qemu-common.h" | ||
140 | +#include "exec/address-spaces.h" | ||
141 | +#include "sysemu/sysemu.h" | ||
142 | +#include "hw/arm/stm32f405_soc.h" | ||
143 | +#include "hw/misc/unimp.h" | ||
144 | + | ||
145 | +#define SYSCFG_ADD 0x40013800 | ||
146 | +static const uint32_t usart_addr[] = { 0x40011000, 0x40004400, 0x40004800, | ||
147 | + 0x40004C00, 0x40005000, 0x40011400, | ||
148 | + 0x40007800, 0x40007C00 }; | ||
149 | +/* At the moment only Timer 2 to 5 are modelled */ | ||
150 | +static const uint32_t timer_addr[] = { 0x40000000, 0x40000400, | ||
151 | + 0x40000800, 0x40000C00 }; | ||
152 | +#define ADC_ADDR 0x40012000 | ||
153 | +static const uint32_t spi_addr[] = { 0x40013000, 0x40003800, 0x40003C00, | ||
154 | + 0x40013400, 0x40015000, 0x40015400 }; | ||
155 | +#define EXTI_ADDR 0x40013C00 | ||
156 | + | ||
157 | +#define SYSCFG_IRQ 71 | ||
158 | +static const int usart_irq[] = { 37, 38, 39, 52, 53, 71, 82, 83 }; | ||
159 | +static const int timer_irq[] = { 28, 29, 30, 50 }; | ||
160 | +#define ADC_IRQ 18 | ||
161 | +static const int spi_irq[] = { 35, 36, 51, 0, 0, 0 }; | ||
162 | +static const int exti_irq[] = { 6, 7, 8, 9, 10, 23, 23, 23, 23, 23, 40, | ||
163 | + 40, 40, 40, 40, 40} ; | ||
164 | + | ||
165 | + | ||
166 | +static void stm32f405_soc_initfn(Object *obj) | ||
167 | +{ | ||
168 | + STM32F405State *s = STM32F405_SOC(obj); | ||
169 | + int i; | ||
170 | + | ||
171 | + sysbus_init_child_obj(obj, "armv7m", &s->armv7m, sizeof(s->armv7m), | ||
172 | + TYPE_ARMV7M); | ||
173 | + | ||
174 | + sysbus_init_child_obj(obj, "syscfg", &s->syscfg, sizeof(s->syscfg), | ||
175 | + TYPE_STM32F4XX_SYSCFG); | ||
176 | + | ||
177 | + for (i = 0; i < STM_NUM_USARTS; i++) { | ||
178 | + sysbus_init_child_obj(obj, "usart[*]", &s->usart[i], | ||
179 | + sizeof(s->usart[i]), TYPE_STM32F2XX_USART); | ||
180 | + } | ||
181 | + | ||
182 | + for (i = 0; i < STM_NUM_TIMERS; i++) { | ||
183 | + sysbus_init_child_obj(obj, "timer[*]", &s->timer[i], | ||
184 | + sizeof(s->timer[i]), TYPE_STM32F2XX_TIMER); | ||
185 | + } | ||
186 | + | ||
187 | + for (i = 0; i < STM_NUM_ADCS; i++) { | ||
188 | + sysbus_init_child_obj(obj, "adc[*]", &s->adc[i], sizeof(s->adc[i]), | ||
189 | + TYPE_STM32F2XX_ADC); | ||
190 | + } | ||
191 | + | ||
192 | + for (i = 0; i < STM_NUM_SPIS; i++) { | ||
193 | + sysbus_init_child_obj(obj, "spi[*]", &s->spi[i], sizeof(s->spi[i]), | ||
194 | + TYPE_STM32F2XX_SPI); | ||
195 | + } | ||
196 | + | ||
197 | + sysbus_init_child_obj(obj, "exti", &s->exti, sizeof(s->exti), | ||
198 | + TYPE_STM32F4XX_EXTI); | ||
199 | +} | ||
200 | + | ||
201 | +static void stm32f405_soc_realize(DeviceState *dev_soc, Error **errp) | ||
202 | +{ | ||
203 | + STM32F405State *s = STM32F405_SOC(dev_soc); | ||
204 | + MemoryRegion *system_memory = get_system_memory(); | ||
205 | + DeviceState *dev, *armv7m; | ||
206 | + SysBusDevice *busdev; | ||
207 | + Error *err = NULL; | ||
208 | + int i; | ||
209 | + | ||
210 | + memory_region_init_ram(&s->flash, NULL, "STM32F405.flash", FLASH_SIZE, | ||
211 | + &err); | ||
212 | + if (err != NULL) { | ||
213 | + error_propagate(errp, err); | ||
214 | + return; | ||
215 | + } | ||
216 | + memory_region_init_alias(&s->flash_alias, NULL, "STM32F405.flash.alias", | ||
217 | + &s->flash, 0, FLASH_SIZE); | ||
218 | + | ||
219 | + memory_region_set_readonly(&s->flash, true); | ||
220 | + memory_region_set_readonly(&s->flash_alias, true); | ||
221 | + | ||
222 | + memory_region_add_subregion(system_memory, FLASH_BASE_ADDRESS, &s->flash); | ||
223 | + memory_region_add_subregion(system_memory, 0, &s->flash_alias); | ||
224 | + | ||
225 | + memory_region_init_ram(&s->sram, NULL, "STM32F405.sram", SRAM_SIZE, | ||
226 | + &err); | ||
227 | + if (err != NULL) { | ||
228 | + error_propagate(errp, err); | ||
229 | + return; | ||
230 | + } | ||
231 | + memory_region_add_subregion(system_memory, SRAM_BASE_ADDRESS, &s->sram); | ||
232 | + | ||
233 | + armv7m = DEVICE(&s->armv7m); | ||
234 | + qdev_prop_set_uint32(armv7m, "num-irq", 96); | ||
235 | + qdev_prop_set_string(armv7m, "cpu-type", s->cpu_type); | ||
236 | + qdev_prop_set_bit(armv7m, "enable-bitband", true); | ||
237 | + object_property_set_link(OBJECT(&s->armv7m), OBJECT(system_memory), | ||
238 | + "memory", &error_abort); | ||
239 | + object_property_set_bool(OBJECT(&s->armv7m), true, "realized", &err); | ||
240 | + if (err != NULL) { | ||
241 | + error_propagate(errp, err); | ||
242 | + return; | 35 | + return; |
243 | + } | 36 | + } |
244 | + | 37 | + |
245 | + /* System configuration controller */ | 38 | + surface = qemu_console_surface(omap_lcd->con); |
246 | + dev = DEVICE(&s->syscfg); | 39 | + if (!surface_bits_per_pixel(surface)) { |
247 | + object_property_set_bool(OBJECT(&s->syscfg), true, "realized", &err); | 40 | return; |
248 | + if (err != NULL) { | 41 | } |
249 | + error_propagate(errp, err); | 42 | |
250 | + return; | ||
251 | + } | ||
252 | + busdev = SYS_BUS_DEVICE(dev); | ||
253 | + sysbus_mmio_map(busdev, 0, SYSCFG_ADD); | ||
254 | + sysbus_connect_irq(busdev, 0, qdev_get_gpio_in(armv7m, SYSCFG_IRQ)); | ||
255 | + | ||
256 | + /* Attach UART (uses USART registers) and USART controllers */ | ||
257 | + for (i = 0; i < STM_NUM_USARTS; i++) { | ||
258 | + dev = DEVICE(&(s->usart[i])); | ||
259 | + qdev_prop_set_chr(dev, "chardev", serial_hd(i)); | ||
260 | + object_property_set_bool(OBJECT(&s->usart[i]), true, "realized", &err); | ||
261 | + if (err != NULL) { | ||
262 | + error_propagate(errp, err); | ||
263 | + return; | ||
264 | + } | ||
265 | + busdev = SYS_BUS_DEVICE(dev); | ||
266 | + sysbus_mmio_map(busdev, 0, usart_addr[i]); | ||
267 | + sysbus_connect_irq(busdev, 0, qdev_get_gpio_in(armv7m, usart_irq[i])); | ||
268 | + } | ||
269 | + | ||
270 | + /* Timer 2 to 5 */ | ||
271 | + for (i = 0; i < STM_NUM_TIMERS; i++) { | ||
272 | + dev = DEVICE(&(s->timer[i])); | ||
273 | + qdev_prop_set_uint64(dev, "clock-frequency", 1000000000); | ||
274 | + object_property_set_bool(OBJECT(&s->timer[i]), true, "realized", &err); | ||
275 | + if (err != NULL) { | ||
276 | + error_propagate(errp, err); | ||
277 | + return; | ||
278 | + } | ||
279 | + busdev = SYS_BUS_DEVICE(dev); | ||
280 | + sysbus_mmio_map(busdev, 0, timer_addr[i]); | ||
281 | + sysbus_connect_irq(busdev, 0, qdev_get_gpio_in(armv7m, timer_irq[i])); | ||
282 | + } | ||
283 | + | ||
284 | + /* ADC device, the IRQs are ORed together */ | ||
285 | + object_initialize_child(OBJECT(s), "adc-orirq", &s->adc_irqs, | ||
286 | + sizeof(s->adc_irqs), TYPE_OR_IRQ, | ||
287 | + &err, NULL); | ||
288 | + if (err != NULL) { | ||
289 | + error_propagate(errp, err); | ||
290 | + return; | ||
291 | + } | ||
292 | + object_property_set_int(OBJECT(&s->adc_irqs), STM_NUM_ADCS, | ||
293 | + "num-lines", &err); | ||
294 | + object_property_set_bool(OBJECT(&s->adc_irqs), true, "realized", &err); | ||
295 | + if (err != NULL) { | ||
296 | + error_propagate(errp, err); | ||
297 | + return; | ||
298 | + } | ||
299 | + qdev_connect_gpio_out(DEVICE(&s->adc_irqs), 0, | ||
300 | + qdev_get_gpio_in(armv7m, ADC_IRQ)); | ||
301 | + | ||
302 | + dev = DEVICE(&(s->adc[i])); | ||
303 | + object_property_set_bool(OBJECT(&s->adc[i]), true, "realized", &err); | ||
304 | + if (err != NULL) { | ||
305 | + error_propagate(errp, err); | ||
306 | + return; | ||
307 | + } | ||
308 | + busdev = SYS_BUS_DEVICE(dev); | ||
309 | + sysbus_mmio_map(busdev, 0, ADC_ADDR); | ||
310 | + sysbus_connect_irq(busdev, 0, | ||
311 | + qdev_get_gpio_in(DEVICE(&s->adc_irqs), i)); | ||
312 | + | ||
313 | + /* SPI devices */ | ||
314 | + for (i = 0; i < STM_NUM_SPIS; i++) { | ||
315 | + dev = DEVICE(&(s->spi[i])); | ||
316 | + object_property_set_bool(OBJECT(&s->spi[i]), true, "realized", &err); | ||
317 | + if (err != NULL) { | ||
318 | + error_propagate(errp, err); | ||
319 | + return; | ||
320 | + } | ||
321 | + busdev = SYS_BUS_DEVICE(dev); | ||
322 | + sysbus_mmio_map(busdev, 0, spi_addr[i]); | ||
323 | + sysbus_connect_irq(busdev, 0, qdev_get_gpio_in(armv7m, spi_irq[i])); | ||
324 | + } | ||
325 | + | ||
326 | + /* EXTI device */ | ||
327 | + dev = DEVICE(&s->exti); | ||
328 | + object_property_set_bool(OBJECT(&s->exti), true, "realized", &err); | ||
329 | + if (err != NULL) { | ||
330 | + error_propagate(errp, err); | ||
331 | + return; | ||
332 | + } | ||
333 | + busdev = SYS_BUS_DEVICE(dev); | ||
334 | + sysbus_mmio_map(busdev, 0, EXTI_ADDR); | ||
335 | + for (i = 0; i < 16; i++) { | ||
336 | + sysbus_connect_irq(busdev, i, qdev_get_gpio_in(armv7m, exti_irq[i])); | ||
337 | + } | ||
338 | + for (i = 0; i < 16; i++) { | ||
339 | + qdev_connect_gpio_out(DEVICE(&s->syscfg), i, qdev_get_gpio_in(dev, i)); | ||
340 | + } | ||
341 | + | ||
342 | + create_unimplemented_device("timer[7]", 0x40001400, 0x400); | ||
343 | + create_unimplemented_device("timer[12]", 0x40001800, 0x400); | ||
344 | + create_unimplemented_device("timer[6]", 0x40001000, 0x400); | ||
345 | + create_unimplemented_device("timer[13]", 0x40001C00, 0x400); | ||
346 | + create_unimplemented_device("timer[14]", 0x40002000, 0x400); | ||
347 | + create_unimplemented_device("RTC and BKP", 0x40002800, 0x400); | ||
348 | + create_unimplemented_device("WWDG", 0x40002C00, 0x400); | ||
349 | + create_unimplemented_device("IWDG", 0x40003000, 0x400); | ||
350 | + create_unimplemented_device("I2S2ext", 0x40003000, 0x400); | ||
351 | + create_unimplemented_device("I2S3ext", 0x40004000, 0x400); | ||
352 | + create_unimplemented_device("I2C1", 0x40005400, 0x400); | ||
353 | + create_unimplemented_device("I2C2", 0x40005800, 0x400); | ||
354 | + create_unimplemented_device("I2C3", 0x40005C00, 0x400); | ||
355 | + create_unimplemented_device("CAN1", 0x40006400, 0x400); | ||
356 | + create_unimplemented_device("CAN2", 0x40006800, 0x400); | ||
357 | + create_unimplemented_device("PWR", 0x40007000, 0x400); | ||
358 | + create_unimplemented_device("DAC", 0x40007400, 0x400); | ||
359 | + create_unimplemented_device("timer[1]", 0x40010000, 0x400); | ||
360 | + create_unimplemented_device("timer[8]", 0x40010400, 0x400); | ||
361 | + create_unimplemented_device("SDIO", 0x40012C00, 0x400); | ||
362 | + create_unimplemented_device("timer[9]", 0x40014000, 0x400); | ||
363 | + create_unimplemented_device("timer[10]", 0x40014400, 0x400); | ||
364 | + create_unimplemented_device("timer[11]", 0x40014800, 0x400); | ||
365 | + create_unimplemented_device("GPIOA", 0x40020000, 0x400); | ||
366 | + create_unimplemented_device("GPIOB", 0x40020400, 0x400); | ||
367 | + create_unimplemented_device("GPIOC", 0x40020800, 0x400); | ||
368 | + create_unimplemented_device("GPIOD", 0x40020C00, 0x400); | ||
369 | + create_unimplemented_device("GPIOE", 0x40021000, 0x400); | ||
370 | + create_unimplemented_device("GPIOF", 0x40021400, 0x400); | ||
371 | + create_unimplemented_device("GPIOG", 0x40021800, 0x400); | ||
372 | + create_unimplemented_device("GPIOH", 0x40021C00, 0x400); | ||
373 | + create_unimplemented_device("GPIOI", 0x40022000, 0x400); | ||
374 | + create_unimplemented_device("CRC", 0x40023000, 0x400); | ||
375 | + create_unimplemented_device("RCC", 0x40023800, 0x400); | ||
376 | + create_unimplemented_device("Flash Int", 0x40023C00, 0x400); | ||
377 | + create_unimplemented_device("BKPSRAM", 0x40024000, 0x400); | ||
378 | + create_unimplemented_device("DMA1", 0x40026000, 0x400); | ||
379 | + create_unimplemented_device("DMA2", 0x40026400, 0x400); | ||
380 | + create_unimplemented_device("Ethernet", 0x40028000, 0x1400); | ||
381 | + create_unimplemented_device("USB OTG HS", 0x40040000, 0x30000); | ||
382 | + create_unimplemented_device("USB OTG FS", 0x50000000, 0x31000); | ||
383 | + create_unimplemented_device("DCMI", 0x50050000, 0x400); | ||
384 | + create_unimplemented_device("RNG", 0x50060800, 0x400); | ||
385 | +} | ||
386 | + | ||
387 | +static Property stm32f405_soc_properties[] = { | ||
388 | + DEFINE_PROP_STRING("cpu-type", STM32F405State, cpu_type), | ||
389 | + DEFINE_PROP_END_OF_LIST(), | ||
390 | +}; | ||
391 | + | ||
392 | +static void stm32f405_soc_class_init(ObjectClass *klass, void *data) | ||
393 | +{ | ||
394 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
395 | + | ||
396 | + dc->realize = stm32f405_soc_realize; | ||
397 | + dc->props = stm32f405_soc_properties; | ||
398 | + /* No vmstate or reset required: device has no internal state */ | ||
399 | +} | ||
400 | + | ||
401 | +static const TypeInfo stm32f405_soc_info = { | ||
402 | + .name = TYPE_STM32F405_SOC, | ||
403 | + .parent = TYPE_SYS_BUS_DEVICE, | ||
404 | + .instance_size = sizeof(STM32F405State), | ||
405 | + .instance_init = stm32f405_soc_initfn, | ||
406 | + .class_init = stm32f405_soc_class_init, | ||
407 | +}; | ||
408 | + | ||
409 | +static void stm32f405_soc_types(void) | ||
410 | +{ | ||
411 | + type_register_static(&stm32f405_soc_info); | ||
412 | +} | ||
413 | + | ||
414 | +type_init(stm32f405_soc_types) | ||
415 | diff --git a/MAINTAINERS b/MAINTAINERS | ||
416 | index XXXXXXX..XXXXXXX 100644 | ||
417 | --- a/MAINTAINERS | ||
418 | +++ b/MAINTAINERS | ||
419 | @@ -XXX,XX +XXX,XX @@ F: hw/adc/* | ||
420 | F: hw/ssi/stm32f2xx_spi.c | ||
421 | F: include/hw/*/stm32*.h | ||
422 | |||
423 | +STM32F405 | ||
424 | +M: Alistair Francis <alistair@alistair23.me> | ||
425 | +M: Peter Maydell <peter.maydell@linaro.org> | ||
426 | +S: Maintained | ||
427 | +F: hw/arm/stm32f405_soc.c | ||
428 | +F: hw/misc/stm32f4xx_syscfg.c | ||
429 | +F: hw/misc/stm32f4xx_exti.c | ||
430 | + | ||
431 | Netduino 2 | ||
432 | M: Alistair Francis <alistair@alistair23.me> | ||
433 | M: Peter Maydell <peter.maydell@linaro.org> | ||
434 | -- | 43 | -- |
435 | 2.20.1 | 44 | 2.20.1 |
436 | 45 | ||
437 | 46 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | From: AlexChen <alex.chen@huawei.com> |
---|---|---|---|
2 | 2 | ||
3 | We won't reuse the CPU IRQ/FIQ variables. Simplify by calling | 3 | In exynos4210_fimd_update(), the pointer s is dereferinced before |
4 | qdev_get_gpio_in() in place. | 4 | being check if it is valid, which may lead to NULL pointer dereference. |
5 | So move the assignment to global_width after checking that the s is valid. | ||
5 | 6 | ||
6 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 7 | Reported-by: Euler Robot <euler.robot@huawei.com> |
7 | Message-id: 20191230110953.25496-6-f4bug@amsat.org | 8 | Signed-off-by: Alex Chen <alex.chen@huawei.com> |
9 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
10 | Message-id: 5F9F8D88.9030102@huawei.com | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | 12 | --- |
11 | hw/arm/allwinner-a10.c | 9 ++++----- | 13 | hw/display/exynos4210_fimd.c | 4 +++- |
12 | 1 file changed, 4 insertions(+), 5 deletions(-) | 14 | 1 file changed, 3 insertions(+), 1 deletion(-) |
13 | 15 | ||
14 | diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c | 16 | diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c |
15 | index XXXXXXX..XXXXXXX 100644 | 17 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/hw/arm/allwinner-a10.c | 18 | --- a/hw/display/exynos4210_fimd.c |
17 | +++ b/hw/arm/allwinner-a10.c | 19 | +++ b/hw/display/exynos4210_fimd.c |
18 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | 20 | @@ -XXX,XX +XXX,XX @@ static void exynos4210_fimd_update(void *opaque) |
19 | { | 21 | bool blend = false; |
20 | AwA10State *s = AW_A10(dev); | 22 | uint8_t *host_fb_addr; |
21 | SysBusDevice *sysbusdev; | 23 | bool is_dirty = false; |
22 | - qemu_irq fiq, irq; | 24 | - const int global_width = (s->vidtcon[2] & FIMD_VIDTCON2_SIZE_MASK) + 1; |
23 | Error *err = NULL; | 25 | + int global_width; |
24 | 26 | ||
25 | object_property_set_bool(OBJECT(&s->cpu), true, "realized", &err); | 27 | if (!s || !s->console || !s->enabled || |
26 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | 28 | surface_bits_per_pixel(qemu_console_surface(s->console)) == 0) { |
27 | error_propagate(errp, err); | ||
28 | return; | 29 | return; |
29 | } | 30 | } |
30 | - irq = qdev_get_gpio_in(DEVICE(&s->cpu), ARM_CPU_IRQ); | 31 | + |
31 | - fiq = qdev_get_gpio_in(DEVICE(&s->cpu), ARM_CPU_FIQ); | 32 | + global_width = (s->vidtcon[2] & FIMD_VIDTCON2_SIZE_MASK) + 1; |
32 | 33 | exynos4210_update_resolution(s); | |
33 | object_property_set_bool(OBJECT(&s->intc), true, "realized", &err); | 34 | surface = qemu_console_surface(s->console); |
34 | if (err != NULL) { | 35 | |
35 | @@ -XXX,XX +XXX,XX @@ static void aw_a10_realize(DeviceState *dev, Error **errp) | ||
36 | } | ||
37 | sysbusdev = SYS_BUS_DEVICE(&s->intc); | ||
38 | sysbus_mmio_map(sysbusdev, 0, AW_A10_PIC_REG_BASE); | ||
39 | - sysbus_connect_irq(sysbusdev, 0, irq); | ||
40 | - sysbus_connect_irq(sysbusdev, 1, fiq); | ||
41 | + sysbus_connect_irq(sysbusdev, 0, | ||
42 | + qdev_get_gpio_in(DEVICE(&s->cpu), ARM_CPU_IRQ)); | ||
43 | + sysbus_connect_irq(sysbusdev, 1, | ||
44 | + qdev_get_gpio_in(DEVICE(&s->cpu), ARM_CPU_FIQ)); | ||
45 | qdev_pass_gpios(DEVICE(&s->intc), dev, NULL); | ||
46 | |||
47 | object_property_set_bool(OBJECT(&s->timer), true, "realized", &err); | ||
48 | -- | 36 | -- |
49 | 2.20.1 | 37 | 2.20.1 |
50 | 38 | ||
51 | 39 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | In arm_v7m_mmu_idx_for_secstate() we get the 'priv' level to pass to | ||
2 | armv7m_mmu_idx_for_secstate_and_priv() by calling arm_current_el(). | ||
3 | This is incorrect when the security state being queried is not the | ||
4 | current one, because arm_current_el() uses the current security state | ||
5 | to determine which of the banked CONTROL.nPRIV bits to look at. | ||
6 | The effect was that if (for instance) Secure state was in privileged | ||
7 | mode but Non-Secure was not then we would return the wrong MMU index. | ||
1 | 8 | ||
9 | The only places where we are using this function in a way that could | ||
10 | trigger this bug are for the stack loads during a v8M function-return | ||
11 | and for the instruction fetch of a v8M SG insn. | ||
12 | |||
13 | Fix the bug by expanding out the M-profile version of the | ||
14 | arm_current_el() logic inline so it can use the passed in secstate | ||
15 | rather than env->v7m.secure. | ||
16 | |||
17 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
18 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | ||
19 | Message-id: 20201022164408.13214-1-peter.maydell@linaro.org | ||
20 | --- | ||
21 | target/arm/m_helper.c | 3 ++- | ||
22 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
23 | |||
24 | diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/target/arm/m_helper.c | ||
27 | +++ b/target/arm/m_helper.c | ||
28 | @@ -XXX,XX +XXX,XX @@ ARMMMUIdx arm_v7m_mmu_idx_for_secstate_and_priv(CPUARMState *env, | ||
29 | /* Return the MMU index for a v7M CPU in the specified security state */ | ||
30 | ARMMMUIdx arm_v7m_mmu_idx_for_secstate(CPUARMState *env, bool secstate) | ||
31 | { | ||
32 | - bool priv = arm_current_el(env) != 0; | ||
33 | + bool priv = arm_v7m_is_handler_mode(env) || | ||
34 | + !(env->v7m.control[secstate] & 1); | ||
35 | |||
36 | return arm_v7m_mmu_idx_for_secstate_and_priv(env, secstate, priv); | ||
37 | } | ||
38 | -- | ||
39 | 2.20.1 | ||
40 | |||
41 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | On some hosts (eg Ubuntu Bionic) pkg-config returns a set of | ||
2 | libraries for gio-2.0 which don't actually work when compiling | ||
3 | statically. (Specifically, the returned library string includes | ||
4 | -lmount, but not -lblkid which -lmount depends upon, so linking | ||
5 | fails due to missing symbols.) | ||
1 | 6 | ||
7 | Check that the libraries work, and don't enable gio if they don't, | ||
8 | in the same way we do for gnutls. | ||
9 | |||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> | ||
12 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
13 | Message-id: 20200928160402.7961-1-peter.maydell@linaro.org | ||
14 | --- | ||
15 | configure | 10 +++++++++- | ||
16 | 1 file changed, 9 insertions(+), 1 deletion(-) | ||
17 | |||
18 | diff --git a/configure b/configure | ||
19 | index XXXXXXX..XXXXXXX 100755 | ||
20 | --- a/configure | ||
21 | +++ b/configure | ||
22 | @@ -XXX,XX +XXX,XX @@ if test "$static" = yes && test "$mingw32" = yes; then | ||
23 | fi | ||
24 | |||
25 | if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then | ||
26 | - gio=yes | ||
27 | gio_cflags=$($pkg_config --cflags gio-2.0) | ||
28 | gio_libs=$($pkg_config --libs gio-2.0) | ||
29 | gdbus_codegen=$($pkg_config --variable=gdbus_codegen gio-2.0) | ||
30 | if [ ! -x "$gdbus_codegen" ]; then | ||
31 | gdbus_codegen= | ||
32 | fi | ||
33 | + # Check that the libraries actually work -- Ubuntu 18.04 ships | ||
34 | + # with pkg-config --static --libs data for gio-2.0 that is missing | ||
35 | + # -lblkid and will give a link error. | ||
36 | + write_c_skeleton | ||
37 | + if compile_prog "" "gio_libs" ; then | ||
38 | + gio=yes | ||
39 | + else | ||
40 | + gio=no | ||
41 | + fi | ||
42 | else | ||
43 | gio=no | ||
44 | fi | ||
45 | -- | ||
46 | 2.20.1 | ||
47 | |||
48 | diff view generated by jsdifflib |
1 | From: Jeff Kubascik <jeff.kubascik@dornerworks.com> | 1 | In gicv3_init_cpuif() we copy the ARMCPU gicv3_maintenance_interrupt |
---|---|---|---|
2 | into the GICv3CPUState struct's maintenance_irq field. This will | ||
3 | only work if the board happens to have already wired up the CPU | ||
4 | maintenance IRQ before the GIC was realized. Unfortunately this is | ||
5 | not the case for the 'virt' board, and so the value that gets copied | ||
6 | is NULL (since a qemu_irq is really a pointer to an IRQState struct | ||
7 | under the hood). The effect is that the CPU interface code never | ||
8 | actually raises the maintenance interrupt line. | ||
2 | 9 | ||
3 | The IAR0/IAR1 register is used to acknowledge an interrupt - a read of the | 10 | Instead, since the GICv3CPUState has a pointer to the CPUState, make |
4 | register activates the highest priority pending interrupt and provides its | 11 | the dereference at the point where we want to raise the interrupt, to |
5 | interrupt ID. Activating an interrupt can change the CPU's virtual interrupt | 12 | avoid an implicit requirement on board code to wire things up in a |
6 | state - this change makes sure the virtual irq state is updated. | 13 | particular order. |
7 | 14 | ||
8 | Signed-off-by: Jeff Kubascik <jeff.kubascik@dornerworks.com> | 15 | Reported-by: Jose Martins <josemartins90@gmail.com> |
9 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
10 | Message-id: 20200113154607.97032-1-jeff.kubascik@dornerworks.com | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 16 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
17 | Message-id: 20201009153904.28529-1-peter.maydell@linaro.org | ||
18 | Reviewed-by: Luc Michel <luc@lmichel.fr> | ||
12 | --- | 19 | --- |
13 | hw/intc/arm_gicv3_cpuif.c | 3 +++ | 20 | include/hw/intc/arm_gicv3_common.h | 1 - |
14 | 1 file changed, 3 insertions(+) | 21 | hw/intc/arm_gicv3_cpuif.c | 5 ++--- |
22 | 2 files changed, 2 insertions(+), 4 deletions(-) | ||
15 | 23 | ||
24 | diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/include/hw/intc/arm_gicv3_common.h | ||
27 | +++ b/include/hw/intc/arm_gicv3_common.h | ||
28 | @@ -XXX,XX +XXX,XX @@ struct GICv3CPUState { | ||
29 | qemu_irq parent_fiq; | ||
30 | qemu_irq parent_virq; | ||
31 | qemu_irq parent_vfiq; | ||
32 | - qemu_irq maintenance_irq; | ||
33 | |||
34 | /* Redistributor */ | ||
35 | uint32_t level; /* Current IRQ level */ | ||
16 | diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c | 36 | diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c |
17 | index XXXXXXX..XXXXXXX 100644 | 37 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/hw/intc/arm_gicv3_cpuif.c | 38 | --- a/hw/intc/arm_gicv3_cpuif.c |
19 | +++ b/hw/intc/arm_gicv3_cpuif.c | 39 | +++ b/hw/intc/arm_gicv3_cpuif.c |
20 | @@ -XXX,XX +XXX,XX @@ static uint64_t icv_iar_read(CPUARMState *env, const ARMCPRegInfo *ri) | 40 | @@ -XXX,XX +XXX,XX @@ static void gicv3_cpuif_virt_update(GICv3CPUState *cs) |
21 | 41 | int irqlevel = 0; | |
22 | trace_gicv3_icv_iar_read(ri->crm == 8 ? 0 : 1, | 42 | int fiqlevel = 0; |
23 | gicv3_redist_affid(cs), intid); | 43 | int maintlevel = 0; |
24 | + | 44 | + ARMCPU *cpu = ARM_CPU(cs->cpu); |
25 | + gicv3_cpuif_virt_update(cs); | 45 | |
26 | + | 46 | idx = hppvi_index(cs); |
27 | return intid; | 47 | trace_gicv3_cpuif_virt_update(gicv3_redist_affid(cs), idx); |
48 | @@ -XXX,XX +XXX,XX @@ static void gicv3_cpuif_virt_update(GICv3CPUState *cs) | ||
49 | |||
50 | qemu_set_irq(cs->parent_vfiq, fiqlevel); | ||
51 | qemu_set_irq(cs->parent_virq, irqlevel); | ||
52 | - qemu_set_irq(cs->maintenance_irq, maintlevel); | ||
53 | + qemu_set_irq(cpu->gicv3_maintenance_interrupt, maintlevel); | ||
28 | } | 54 | } |
29 | 55 | ||
56 | static uint64_t icv_ap_read(CPUARMState *env, const ARMCPRegInfo *ri) | ||
57 | @@ -XXX,XX +XXX,XX @@ void gicv3_init_cpuif(GICv3State *s) | ||
58 | && cpu->gic_num_lrs) { | ||
59 | int j; | ||
60 | |||
61 | - cs->maintenance_irq = cpu->gicv3_maintenance_interrupt; | ||
62 | - | ||
63 | cs->num_list_regs = cpu->gic_num_lrs; | ||
64 | cs->vpribits = cpu->gic_vpribits; | ||
65 | cs->vprebits = cpu->gic_vprebits; | ||
30 | -- | 66 | -- |
31 | 2.20.1 | 67 | 2.20.1 |
32 | 68 | ||
33 | 69 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | The kerneldoc script currently emits Sphinx markup for a macro with | ||
2 | arguments that uses the c:function directive. This is correct for | ||
3 | Sphinx versions earlier than Sphinx 3, where c:macro doesn't allow | ||
4 | documentation of macros with arguments and c:function is not picky | ||
5 | about the syntax of what it is passed. However, in Sphinx 3 the | ||
6 | c:macro directive was enhanced to support macros with arguments, | ||
7 | and c:function was made more picky about what syntax it accepted. | ||
1 | 8 | ||
9 | When kerneldoc is told that it needs to produce output for Sphinx | ||
10 | 3 or later, make it emit c:function only for functions and c:macro | ||
11 | for macros with arguments. We assume that anything with a return | ||
12 | type is a function and anything without is a macro. | ||
13 | |||
14 | This fixes the Sphinx error: | ||
15 | |||
16 | /home/petmay01/linaro/qemu-from-laptop/qemu/docs/../include/qom/object.h:155:Error in declarator | ||
17 | If declarator-id with parameters (e.g., 'void f(int arg)'): | ||
18 | Invalid C declaration: Expected identifier in nested name. [error at 25] | ||
19 | DECLARE_INSTANCE_CHECKER ( InstanceType, OBJ_NAME, TYPENAME) | ||
20 | -------------------------^ | ||
21 | If parenthesis in noptr-declarator (e.g., 'void (*f(int arg))(double)'): | ||
22 | Error in declarator or parameters | ||
23 | Invalid C declaration: Expecting "(" in parameters. [error at 39] | ||
24 | DECLARE_INSTANCE_CHECKER ( InstanceType, OBJ_NAME, TYPENAME) | ||
25 | ---------------------------------------^ | ||
26 | |||
27 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
28 | Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> | ||
29 | Tested-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
30 | Message-id: 20201030174700.7204-2-peter.maydell@linaro.org | ||
31 | --- | ||
32 | scripts/kernel-doc | 18 +++++++++++++++++- | ||
33 | 1 file changed, 17 insertions(+), 1 deletion(-) | ||
34 | |||
35 | diff --git a/scripts/kernel-doc b/scripts/kernel-doc | ||
36 | index XXXXXXX..XXXXXXX 100755 | ||
37 | --- a/scripts/kernel-doc | ||
38 | +++ b/scripts/kernel-doc | ||
39 | @@ -XXX,XX +XXX,XX @@ sub output_function_rst(%) { | ||
40 | output_highlight_rst($args{'purpose'}); | ||
41 | $start = "\n\n**Syntax**\n\n ``"; | ||
42 | } else { | ||
43 | - print ".. c:function:: "; | ||
44 | + if ((split(/\./, $sphinx_version))[0] >= 3) { | ||
45 | + # Sphinx 3 and later distinguish macros and functions and | ||
46 | + # complain if you use c:function with something that's not | ||
47 | + # syntactically valid as a function declaration. | ||
48 | + # We assume that anything with a return type is a function | ||
49 | + # and anything without is a macro. | ||
50 | + if ($args{'functiontype'} ne "") { | ||
51 | + print ".. c:function:: "; | ||
52 | + } else { | ||
53 | + print ".. c:macro:: "; | ||
54 | + } | ||
55 | + } else { | ||
56 | + # Older Sphinx don't support documenting macros that take | ||
57 | + # arguments with c:macro, and don't complain about the use | ||
58 | + # of c:function for this. | ||
59 | + print ".. c:function:: "; | ||
60 | + } | ||
61 | } | ||
62 | if ($args{'functiontype'} ne "") { | ||
63 | $start .= $args{'functiontype'} . " " . $args{'function'} . " ("; | ||
64 | -- | ||
65 | 2.20.1 | ||
66 | |||
67 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | Sphinx 3.2 is pickier than earlier versions about the option:: markup, | ||
2 | and complains about our usage in qemu-option-trace.rst: | ||
1 | 3 | ||
4 | ../../docs/qemu-option-trace.rst.inc:4:Malformed option description | ||
5 | '[enable=]PATTERN', should look like "opt", "-opt args", "--opt args", | ||
6 | "/opt args" or "+opt args" | ||
7 | |||
8 | In this file, we're really trying to document the different parts of | ||
9 | the top-level --trace option, which qemu-nbd.rst and qemu-img.rst | ||
10 | have already introduced with an option:: markup. So it's not right | ||
11 | to use option:: here anyway. Switch to a different markup | ||
12 | (definition lists) which gives about the same formatted output. | ||
13 | |||
14 | (Unlike option::, this markup doesn't produce index entries; but | ||
15 | at the moment we don't do anything much with indexes anyway, and | ||
16 | in any case I think it doesn't make much sense to have individual | ||
17 | index entries for the sub-parts of the --trace option.) | ||
18 | |||
19 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
20 | Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> | ||
21 | Tested-by: Stefan Hajnoczi <stefanha@redhat.com> | ||
22 | Message-id: 20201030174700.7204-3-peter.maydell@linaro.org | ||
23 | --- | ||
24 | docs/qemu-option-trace.rst.inc | 6 +++--- | ||
25 | 1 file changed, 3 insertions(+), 3 deletions(-) | ||
26 | |||
27 | diff --git a/docs/qemu-option-trace.rst.inc b/docs/qemu-option-trace.rst.inc | ||
28 | index XXXXXXX..XXXXXXX 100644 | ||
29 | --- a/docs/qemu-option-trace.rst.inc | ||
30 | +++ b/docs/qemu-option-trace.rst.inc | ||
31 | @@ -XXX,XX +XXX,XX @@ | ||
32 | |||
33 | Specify tracing options. | ||
34 | |||
35 | -.. option:: [enable=]PATTERN | ||
36 | +``[enable=]PATTERN`` | ||
37 | |||
38 | Immediately enable events matching *PATTERN* | ||
39 | (either event name or a globbing pattern). This option is only | ||
40 | @@ -XXX,XX +XXX,XX @@ Specify tracing options. | ||
41 | |||
42 | Use :option:`-trace help` to print a list of names of trace points. | ||
43 | |||
44 | -.. option:: events=FILE | ||
45 | +``events=FILE`` | ||
46 | |||
47 | Immediately enable events listed in *FILE*. | ||
48 | The file must contain one event name (as listed in the ``trace-events-all`` | ||
49 | @@ -XXX,XX +XXX,XX @@ Specify tracing options. | ||
50 | available if QEMU has been compiled with the ``simple``, ``log`` or | ||
51 | ``ftrace`` tracing backend. | ||
52 | |||
53 | -.. option:: file=FILE | ||
54 | +``file=FILE`` | ||
55 | |||
56 | Log output traces to *FILE*. | ||
57 | This option is only available if QEMU has been compiled with | ||
58 | -- | ||
59 | 2.20.1 | ||
60 | |||
61 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | The randomness tests in the NPCM7xx RNG test fail intermittently |
---|---|---|---|
2 | but fairly frequently. On my machine running the test in a loop: | ||
3 | while QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/npcm7xx_rng-test; do true; done | ||
2 | 4 | ||
3 | These definitions are specific to the A10 SoC and don't need | 5 | will fail in less than a minute with an error like: |
4 | to be exported to the different Allwinner peripherals. | 6 | ERROR:../../tests/qtest/npcm7xx_rng-test.c:256:test_first_byte_runs: |
7 | assertion failed (calc_runs_p(buf.l, sizeof(buf) * BITS_PER_BYTE) > 0.01): (0.00286205989 > 0.01) | ||
5 | 8 | ||
6 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 9 | (Failures have been observed on all 4 of the randomness tests, |
7 | Message-id: 20191230110953.25496-4-f4bug@amsat.org | 10 | not just first_byte_runs.) |
11 | |||
12 | It's not clear why these tests are failing like this, but intermittent | ||
13 | failures make CI and merge testing awkward, so disable running them | ||
14 | unless a developer specifically sets QEMU_TEST_FLAKY_RNG_TESTS when | ||
15 | running the test suite, until we work out the cause. | ||
16 | |||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 17 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 18 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> |
19 | Message-id: 20201102152454.8287-1-peter.maydell@linaro.org | ||
20 | Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com> | ||
10 | --- | 21 | --- |
11 | include/hw/arm/allwinner-a10.h | 6 ------ | 22 | tests/qtest/npcm7xx_rng-test.c | 14 ++++++++++---- |
12 | hw/arm/allwinner-a10.c | 6 ++++++ | 23 | 1 file changed, 10 insertions(+), 4 deletions(-) |
13 | 2 files changed, 6 insertions(+), 6 deletions(-) | ||
14 | 24 | ||
15 | diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h | 25 | diff --git a/tests/qtest/npcm7xx_rng-test.c b/tests/qtest/npcm7xx_rng-test.c |
16 | index XXXXXXX..XXXXXXX 100644 | 26 | index XXXXXXX..XXXXXXX 100644 |
17 | --- a/include/hw/arm/allwinner-a10.h | 27 | --- a/tests/qtest/npcm7xx_rng-test.c |
18 | +++ b/include/hw/arm/allwinner-a10.h | 28 | +++ b/tests/qtest/npcm7xx_rng-test.c |
19 | @@ -XXX,XX +XXX,XX @@ | 29 | @@ -XXX,XX +XXX,XX @@ int main(int argc, char **argv) |
20 | #include "target/arm/cpu.h" | 30 | |
21 | 31 | qtest_add_func("npcm7xx_rng/enable_disable", test_enable_disable); | |
22 | 32 | qtest_add_func("npcm7xx_rng/rosel", test_rosel); | |
23 | -#define AW_A10_PIC_REG_BASE 0x01c20400 | 33 | - qtest_add_func("npcm7xx_rng/continuous/monobit", test_continuous_monobit); |
24 | -#define AW_A10_PIT_REG_BASE 0x01c20c00 | 34 | - qtest_add_func("npcm7xx_rng/continuous/runs", test_continuous_runs); |
25 | -#define AW_A10_UART0_REG_BASE 0x01c28000 | 35 | - qtest_add_func("npcm7xx_rng/first_byte/monobit", test_first_byte_monobit); |
26 | -#define AW_A10_EMAC_BASE 0x01c0b000 | 36 | - qtest_add_func("npcm7xx_rng/first_byte/runs", test_first_byte_runs); |
27 | -#define AW_A10_SATA_BASE 0x01c18000 | 37 | + /* |
28 | - | 38 | + * These tests fail intermittently; only run them on explicit |
29 | #define AW_A10_SDRAM_BASE 0x40000000 | 39 | + * request until we figure out why. |
30 | 40 | + */ | |
31 | #define TYPE_AW_A10 "allwinner-a10" | 41 | + if (getenv("QEMU_TEST_FLAKY_RNG_TESTS")) { |
32 | diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c | 42 | + qtest_add_func("npcm7xx_rng/continuous/monobit", test_continuous_monobit); |
33 | index XXXXXXX..XXXXXXX 100644 | 43 | + qtest_add_func("npcm7xx_rng/continuous/runs", test_continuous_runs); |
34 | --- a/hw/arm/allwinner-a10.c | 44 | + qtest_add_func("npcm7xx_rng/first_byte/monobit", test_first_byte_monobit); |
35 | +++ b/hw/arm/allwinner-a10.c | 45 | + qtest_add_func("npcm7xx_rng/first_byte/runs", test_first_byte_runs); |
36 | @@ -XXX,XX +XXX,XX @@ | 46 | + } |
37 | #include "hw/misc/unimp.h" | 47 | |
38 | #include "sysemu/sysemu.h" | 48 | qtest_start("-machine npcm750-evb"); |
39 | 49 | ret = g_test_run(); | |
40 | +#define AW_A10_PIC_REG_BASE 0x01c20400 | ||
41 | +#define AW_A10_PIT_REG_BASE 0x01c20c00 | ||
42 | +#define AW_A10_UART0_REG_BASE 0x01c28000 | ||
43 | +#define AW_A10_EMAC_BASE 0x01c0b000 | ||
44 | +#define AW_A10_SATA_BASE 0x01c18000 | ||
45 | + | ||
46 | static void aw_a10_init(Object *obj) | ||
47 | { | ||
48 | AwA10State *s = AW_A10(obj); | ||
49 | -- | 50 | -- |
50 | 2.20.1 | 51 | 2.20.1 |
51 | 52 | ||
52 | 53 | diff view generated by jsdifflib |