configure: check for gdbus-codegen presence

[PATCH] configure: check for gdbus-codegen presence

Marc-André Lureau posted 1 patch 4 years, 3 months ago

Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200110112725.689401-1-marcandre.lureau@redhat.com

configure | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[PATCH] configure: check for gdbus-codegen presence

Posted by Marc-André Lureau 4 years, 3 months ago

Some distros ship gdbus-codegen separately for gio headers/pc...

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 0ce2c0354a..28ee2a254f 100755
--- a/configure
+++ b/configure
@@ -3702,6 +3702,9 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
     gio_cflags=$($pkg_config --cflags gio-2.0)
     gio_libs=$($pkg_config --libs gio-2.0)
     gdbus_codegen=$($pkg_config --variable=gdbus_codegen gio-2.0)
+    if [ ! -x "$gdbus_codegen" ]; then
+        gdbus_codegen=
+    fi
 else
     gio=no
 fi
-- 
2.25.0.rc1.20.g2443f3f80d.dirty

Re: [PATCH] configure: check for gdbus-codegen presence

Posted by Peter Maydell 4 years, 3 months ago

On Fri, 10 Jan 2020 at 11:27, Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
>
> Some distros ship gdbus-codegen separately for gio headers/pc...
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 0ce2c0354a..28ee2a254f 100755
> --- a/configure
> +++ b/configure
> @@ -3702,6 +3702,9 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
>      gio_cflags=$($pkg_config --cflags gio-2.0)
>      gio_libs=$($pkg_config --libs gio-2.0)
>      gdbus_codegen=$($pkg_config --variable=gdbus_codegen gio-2.0)
> +    if [ ! -x "$gdbus_codegen" ]; then
> +        gdbus_codegen=
> +    fi
>  else
>      gio=no
>  fi
> --
> 2.25.0.rc1.20.g2443f3f80d.dirty

Thanks; applied to master as a buildfix.

-- PMM