hw/smbios/smbios: Remove unused include

[PATCH] hw/smbios/smbios: Remove unused include

Philippe Mathieu-Daudé posted 1 patch 4 years, 3 months ago

Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200109112504.32622-1-philmd@redhat.com

Maintainers: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

hw/smbios/smbios.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] hw/smbios/smbios: Remove unused include

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/smbios/smbios.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index ded5f1f4e2..1a0f461541 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -24,7 +24,6 @@
 #include "qemu/option.h"
 #include "sysemu/sysemu.h"
 #include "qemu/uuid.h"
-#include "sysemu/cpus.h"
 #include "hw/firmware/smbios.h"
 #include "hw/loader.h"
 #include "hw/boards.h"
-- 
2.21.1

Re: [PATCH] hw/smbios/smbios: Remove unused include

Posted by Michael S. Tsirkin 4 years, 3 months ago

On Thu, Jan 09, 2020 at 12:25:04PM +0100, Philippe Mathieu-Daudé wrote:
> Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>



> ---
>  hw/smbios/smbios.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index ded5f1f4e2..1a0f461541 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -24,7 +24,6 @@
>  #include "qemu/option.h"
>  #include "sysemu/sysemu.h"
>  #include "qemu/uuid.h"
> -#include "sysemu/cpus.h"
>  #include "hw/firmware/smbios.h"
>  #include "hw/loader.h"
>  #include "hw/boards.h"
> -- 
> 2.21.1

Re: [PATCH] hw/smbios/smbios: Remove unused include

Posted by Laurent Vivier 4 years, 2 months ago

Le 09/01/2020 à 12:25, Philippe Mathieu-Daudé a écrit :
> Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/smbios/smbios.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index ded5f1f4e2..1a0f461541 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -24,7 +24,6 @@
>  #include "qemu/option.h"
>  #include "sysemu/sysemu.h"
>  #include "qemu/uuid.h"
> -#include "sysemu/cpus.h"
>  #include "hw/firmware/smbios.h"
>  #include "hw/loader.h"
>  #include "hw/boards.h"
> 

Applied to my trivial-patches branch.

Thanks,
Laurent