hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

[PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

Philippe Mathieu-Daudé posted 1 patch 4 years, 3 months ago

Download mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200106171912.16523-1-philmd@redhat.com

hw/timer/Kconfig | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h"
we can not select it when ISA_BUS is disabled. Add a 'depends on'
clause.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/timer/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
index a990f9fe35..59b3f44d69 100644
--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -15,6 +15,7 @@ config HPET
 
 config I8254
     bool
+    depends on ISA_BUS
 
 config ALTERA_TIMER
     bool
-- 
2.21.1

Re: [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

Posted by Paolo Bonzini 4 years, 3 months ago

On 06/01/20 18:19, Philippe Mathieu-Daudé wrote:
> Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h"
> we can not select it when ISA_BUS is disabled. Add a 'depends on'
> clause.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/timer/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index a990f9fe35..59b3f44d69 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -15,6 +15,7 @@ config HPET
>  
>  config I8254
>      bool
> +    depends on ISA_BUS
>  
>  config ALTERA_TIMER
>      bool
> 

Queued, thanks.

Paolo