freebsd: use python37

[PATCH] freebsd: use python37

Posted by Gerd Hoffmann 4 years, 3 months ago

FreeBSD seems to use python37 by default now, which breaks the build
script.  Add python to the package list, to explicitly pick the version,
and also adapt the configure command line.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 tests/vm/freebsd | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 1825cc58218b..33a736298a9a 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
         "git",
         "pkgconf",
         "bzip2",
+        "python37",
 
         # gnu tools
         "bash",
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
         mkdir src build; cd src;
         tar -xf /dev/vtbd1;
         cd ../build
-        ../src/configure --python=python3.6 {configure_opts};
+        ../src/configure --python=python3.7 {configure_opts};
         gmake --output-sync -j{jobs} {target} {verbose};
     """
 
-- 
2.18.1

Re: [PATCH] freebsd: use python37

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

On 1/6/20 1:37 PM, Gerd Hoffmann wrote:
> FreeBSD seems to use python37 by default now, which breaks the build
> script.  Add python to the package list, to explicitly pick the version,
> and also adapt the configure command line.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   tests/vm/freebsd | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 1825cc58218b..33a736298a9a 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
>           "git",
>           "pkgconf",
>           "bzip2",
> +        "python37",
>   
>           # gnu tools
>           "bash",
> @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
>           mkdir src build; cd src;
>           tar -xf /dev/vtbd1;
>           cd ../build
> -        ../src/configure --python=python3.6 {configure_opts};
> +        ../src/configure --python=python3.7 {configure_opts};
>           gmake --output-sync -j{jobs} {target} {verbose};
>       """
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] freebsd: use python37

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

On Mon, Jan 6, 2020 at 2:19 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 1/6/20 1:37 PM, Gerd Hoffmann wrote:
> > FreeBSD seems to use python37 by default now, which breaks the build

BTW it looks clearer replacing by 'python3.7' here and in subject.

> > script.  Add python to the package list, to explicitly pick the version,
> > and also adapt the configure command line.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >   tests/vm/freebsd | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> > index 1825cc58218b..33a736298a9a 100755
> > --- a/tests/vm/freebsd
> > +++ b/tests/vm/freebsd
> > @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
> >           "git",
> >           "pkgconf",
> >           "bzip2",
> > +        "python37",
> >
> >           # gnu tools
> >           "bash",
> > @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
> >           mkdir src build; cd src;
> >           tar -xf /dev/vtbd1;
> >           cd ../build
> > -        ../src/configure --python=python3.6 {configure_opts};
> > +        ../src/configure --python=python3.7 {configure_opts};
> >           gmake --output-sync -j{jobs} {target} {verbose};
> >       """
> >
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] freebsd: use python37

Posted by Alex Bennée 4 years, 3 months ago

Gerd Hoffmann <kraxel@redhat.com> writes:

> FreeBSD seems to use python37 by default now, which breaks the build
> script.  Add python to the package list, to explicitly pick the version,
> and also adapt the configure command line.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Queued to testing/next, thanks.

> ---
>  tests/vm/freebsd | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 1825cc58218b..33a736298a9a 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
>          "git",
>          "pkgconf",
>          "bzip2",
> +        "python37",
>  
>          # gnu tools
>          "bash",
> @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
>          mkdir src build; cd src;
>          tar -xf /dev/vtbd1;
>          cd ../build
> -        ../src/configure --python=python3.6 {configure_opts};
> +        ../src/configure --python=python3.7 {configure_opts};
>          gmake --output-sync -j{jobs} {target} {verbose};
>      """


-- 
Alex Bennée