plugins/core: add missing break in cb_to_tcg_flags

[PATCH] plugins/core: add missing break in cb_to_tcg_flags

Emilio G. Cota posted 1 patch 5 years, 10 months ago

Download mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200105072940.32204-1-cota@braap.org

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>

plugins/core.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] plugins/core: add missing break in cb_to_tcg_flags

Posted by Emilio G. Cota 5 years, 10 months ago

Reported-by: Robert Henry <robhenry@microsoft.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 plugins/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/core.c b/plugins/core.c
index 9e1b9e7a91..ed863011ba 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum qemu_plugin_cb_flags flags)
     switch (flags) {
     case QEMU_PLUGIN_CB_RW_REGS:
         ret = 0;
+        break;
     case QEMU_PLUGIN_CB_R_REGS:
         ret = TCG_CALL_NO_WG;
         break;
-- 
2.20.1

Re: [PATCH] plugins/core: add missing break in cb_to_tcg_flags

Posted by Alex Bennée 5 years, 9 months ago

Emilio G. Cota <cota@braap.org> writes:

> Reported-by: Robert Henry <robhenry@microsoft.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>


Queued to plugins/next, thanks.

> ---
>  plugins/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/plugins/core.c b/plugins/core.c
> index 9e1b9e7a91..ed863011ba 100644
> --- a/plugins/core.c
> +++ b/plugins/core.c
> @@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum qemu_plugin_cb_flags flags)
>      switch (flags) {
>      case QEMU_PLUGIN_CB_RW_REGS:
>          ret = 0;
> +        break;
>      case QEMU_PLUGIN_CB_R_REGS:
>          ret = TCG_CALL_NO_WG;
>          break;


-- 
Alex Bennée

Re: [PATCH] plugins/core: add missing break in cb_to_tcg_flags

Posted by Richard Henderson 5 years, 10 months ago

On 1/5/20 5:29 PM, Emilio G. Cota wrote:
> Reported-by: Robert Henry <robhenry@microsoft.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  plugins/core.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~