[PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list

Philippe Mathieu-Daudé posted 4 patches 4 years, 4 months ago
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
Test asan failed
Test checkpatch passed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200101112303.20724-1-philmd@redhat.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Marek Vasut <marex@denx.de>, Palmer Dabbelt <palmer@dabbelt.com>, David Gibson <david@gibson.dropbear.id.au>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Anthony Green <green@moxielogic.com>, Michael Walle <michael@walle.cc>, David Hildenbrand <david@redhat.com>, Chris Wulff <crwulff@gmail.com>, Laurent Vivier <laurent@vivier.eu>, Aleksandar Markovic <amarkovic@wavecomp.com>, Max Filippov <jcmvbkbc@gmail.com>, Alistair Francis <Alistair.Francis@wdc.com>, Richard Henderson <rth@twiddle.net>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Stefan Weil <sw@weilnetz.de>, Andrzej Zaborowski <balrogg@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Peter Maydell <peter.maydell@linaro.org>, Stafford Horne <shorne@gmail.com>, Claudio Fontana <claudio.fontana@huawei.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Riku Voipio <riku.voipio@iki.fi>
configure                            | 1 -
include/exec/cpu_ldst.h              | 2 +-
{tcg => include/tcg}/tcg-gvec-desc.h | 0
{tcg => include/tcg}/tcg-mo.h        | 0
{tcg => include/tcg}/tcg-op-gvec.h   | 0
{tcg => include/tcg}/tcg-op.h        | 2 +-
{tcg => include/tcg}/tcg-opc.h       | 0
{tcg => include/tcg}/tcg.h           | 4 ++--
tcg/i386/tcg-target.h                | 2 +-
accel/tcg/cpu-exec.c                 | 2 +-
accel/tcg/tcg-runtime-gvec.c         | 2 +-
accel/tcg/translate-all.c            | 2 +-
accel/tcg/user-exec.c                | 2 +-
bsd-user/main.c                      | 2 +-
cpus.c                               | 2 +-
exec.c                               | 2 +-
linux-user/main.c                    | 2 +-
target/alpha/translate.c             | 2 +-
target/arm/helper-a64.c              | 2 +-
target/arm/translate-a64.c           | 4 ++--
target/arm/translate-sve.c           | 6 +++---
target/arm/translate.c               | 4 ++--
target/cris/translate.c              | 2 +-
target/hppa/translate.c              | 2 +-
target/i386/mem_helper.c             | 2 +-
target/i386/translate.c              | 2 +-
target/lm32/translate.c              | 2 +-
target/m68k/translate.c              | 2 +-
target/microblaze/translate.c        | 2 +-
target/mips/translate.c              | 2 +-
target/moxie/translate.c             | 2 +-
target/nios2/translate.c             | 2 +-
target/openrisc/translate.c          | 2 +-
target/ppc/mem_helper.c              | 2 +-
target/ppc/translate.c               | 4 ++--
target/riscv/cpu_helper.c            | 2 +-
target/riscv/translate.c             | 2 +-
target/s390x/translate.c             | 4 ++--
target/sh4/translate.c               | 2 +-
target/sparc/ldst_helper.c           | 2 +-
target/sparc/translate.c             | 2 +-
target/tilegx/translate.c            | 2 +-
target/tricore/translate.c           | 2 +-
target/unicore32/translate.c         | 2 +-
target/xtensa/translate.c            | 2 +-
tcg/aarch64/tcg-target.inc.c         | 4 ++--
tcg/arm/tcg-target.inc.c             | 4 ++--
tcg/i386/tcg-target.inc.c            | 4 ++--
tcg/mips/tcg-target.inc.c            | 2 +-
tcg/optimize.c                       | 2 +-
tcg/ppc/tcg-target.inc.c             | 4 ++--
tcg/riscv/tcg-target.inc.c           | 4 ++--
tcg/s390/tcg-target.inc.c            | 4 ++--
tcg/sparc/tcg-target.inc.c           | 2 +-
tcg/tcg-common.c                     | 2 +-
tcg/tcg-op-gvec.c                    | 8 ++++----
tcg/tcg-op-vec.c                     | 6 +++---
tcg/tcg-op.c                         | 6 +++---
tcg/tcg.c                            | 2 +-
tcg/tci.c                            | 2 +-
MAINTAINERS                          | 1 +
61 files changed, 76 insertions(+), 76 deletions(-)
rename {tcg => include/tcg}/tcg-gvec-desc.h (100%)
rename {tcg => include/tcg}/tcg-mo.h (100%)
rename {tcg => include/tcg}/tcg-op-gvec.h (100%)
rename {tcg => include/tcg}/tcg-op.h (99%)
rename {tcg => include/tcg}/tcg-opc.h (100%)
rename {tcg => include/tcg}/tcg.h (99%)
[PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list
Posted by Philippe Mathieu-Daudé 4 years, 4 months ago
Noticed we could clean this while reviewing Richard patch last night:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html

Since v1:
- moved headers to include/tcg/ (Paolo)
- include in .inc.c relative to parent (Stefan)

v1: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05356.html

Philippe Mathieu-Daudé (4):
  tcg: Search includes from the project root source directory
  tcg: Search includes in the parent source directory
  tcg: Move TCG headers to include/tcg/
  configure: Remove tcg/ from the preprocessor include search list

 configure                            | 1 -
 include/exec/cpu_ldst.h              | 2 +-
 {tcg => include/tcg}/tcg-gvec-desc.h | 0
 {tcg => include/tcg}/tcg-mo.h        | 0
 {tcg => include/tcg}/tcg-op-gvec.h   | 0
 {tcg => include/tcg}/tcg-op.h        | 2 +-
 {tcg => include/tcg}/tcg-opc.h       | 0
 {tcg => include/tcg}/tcg.h           | 4 ++--
 tcg/i386/tcg-target.h                | 2 +-
 accel/tcg/cpu-exec.c                 | 2 +-
 accel/tcg/tcg-runtime-gvec.c         | 2 +-
 accel/tcg/translate-all.c            | 2 +-
 accel/tcg/user-exec.c                | 2 +-
 bsd-user/main.c                      | 2 +-
 cpus.c                               | 2 +-
 exec.c                               | 2 +-
 linux-user/main.c                    | 2 +-
 target/alpha/translate.c             | 2 +-
 target/arm/helper-a64.c              | 2 +-
 target/arm/translate-a64.c           | 4 ++--
 target/arm/translate-sve.c           | 6 +++---
 target/arm/translate.c               | 4 ++--
 target/cris/translate.c              | 2 +-
 target/hppa/translate.c              | 2 +-
 target/i386/mem_helper.c             | 2 +-
 target/i386/translate.c              | 2 +-
 target/lm32/translate.c              | 2 +-
 target/m68k/translate.c              | 2 +-
 target/microblaze/translate.c        | 2 +-
 target/mips/translate.c              | 2 +-
 target/moxie/translate.c             | 2 +-
 target/nios2/translate.c             | 2 +-
 target/openrisc/translate.c          | 2 +-
 target/ppc/mem_helper.c              | 2 +-
 target/ppc/translate.c               | 4 ++--
 target/riscv/cpu_helper.c            | 2 +-
 target/riscv/translate.c             | 2 +-
 target/s390x/translate.c             | 4 ++--
 target/sh4/translate.c               | 2 +-
 target/sparc/ldst_helper.c           | 2 +-
 target/sparc/translate.c             | 2 +-
 target/tilegx/translate.c            | 2 +-
 target/tricore/translate.c           | 2 +-
 target/unicore32/translate.c         | 2 +-
 target/xtensa/translate.c            | 2 +-
 tcg/aarch64/tcg-target.inc.c         | 4 ++--
 tcg/arm/tcg-target.inc.c             | 4 ++--
 tcg/i386/tcg-target.inc.c            | 4 ++--
 tcg/mips/tcg-target.inc.c            | 2 +-
 tcg/optimize.c                       | 2 +-
 tcg/ppc/tcg-target.inc.c             | 4 ++--
 tcg/riscv/tcg-target.inc.c           | 4 ++--
 tcg/s390/tcg-target.inc.c            | 4 ++--
 tcg/sparc/tcg-target.inc.c           | 2 +-
 tcg/tcg-common.c                     | 2 +-
 tcg/tcg-op-gvec.c                    | 8 ++++----
 tcg/tcg-op-vec.c                     | 6 +++---
 tcg/tcg-op.c                         | 6 +++---
 tcg/tcg.c                            | 2 +-
 tcg/tci.c                            | 2 +-
 MAINTAINERS                          | 1 +
 61 files changed, 76 insertions(+), 76 deletions(-)
 rename {tcg => include/tcg}/tcg-gvec-desc.h (100%)
 rename {tcg => include/tcg}/tcg-mo.h (100%)
 rename {tcg => include/tcg}/tcg-op-gvec.h (100%)
 rename {tcg => include/tcg}/tcg-op.h (99%)
 rename {tcg => include/tcg}/tcg-opc.h (100%)
 rename {tcg => include/tcg}/tcg.h (99%)

-- 
2.21.0


Re: [PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list
Posted by Paolo Bonzini 4 years, 4 months ago
On 01/01/20 12:22, Philippe Mathieu-Daudé wrote:
> Noticed we could clean this while reviewing Richard patch last night:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html
> 
> Since v1:
> - moved headers to include/tcg/ (Paolo)
> - include in .inc.c relative to parent (Stefan)
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05356.html


Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

but I'll let Richad pick it up.

Paolo


Re: [PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list
Posted by Stefan Weil 4 years, 4 months ago
Am 01.01.20 um 12:22 schrieb Philippe Mathieu-Daudé:

> Noticed we could clean this while reviewing Richard patch last night:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html
>
> Since v1:
> - moved headers to include/tcg/ (Paolo)
> - include in .inc.c relative to parent (Stefan)
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05356.html
>
> Philippe Mathieu-Daudé (4):
>   tcg: Search includes from the project root source directory
>   tcg: Search includes in the parent source directory
>   tcg: Move TCG headers to include/tcg/
>   configure: Remove tcg/ from the preprocessor include search list
>
>  configure                            | 1 -
>  include/exec/cpu_ldst.h              | 2 +-
>  {tcg => include/tcg}/tcg-gvec-desc.h | 0
>  {tcg => include/tcg}/tcg-mo.h        | 0
>  {tcg => include/tcg}/tcg-op-gvec.h   | 0
>  {tcg => include/tcg}/tcg-op.h        | 2 +-
>  {tcg => include/tcg}/tcg-opc.h       | 0
>  {tcg => include/tcg}/tcg.h           | 4 ++--
>  tcg/i386/tcg-target.h                | 2 +-
>  accel/tcg/cpu-exec.c                 | 2 +-
>  accel/tcg/tcg-runtime-gvec.c         | 2 +-
>  accel/tcg/translate-all.c            | 2 +-
>  accel/tcg/user-exec.c                | 2 +-
>  bsd-user/main.c                      | 2 +-
>  cpus.c                               | 2 +-
>  exec.c                               | 2 +-
>  linux-user/main.c                    | 2 +-
>  target/alpha/translate.c             | 2 +-
>  target/arm/helper-a64.c              | 2 +-
>  target/arm/translate-a64.c           | 4 ++--
>  target/arm/translate-sve.c           | 6 +++---
>  target/arm/translate.c               | 4 ++--
>  target/cris/translate.c              | 2 +-
>  target/hppa/translate.c              | 2 +-
>  target/i386/mem_helper.c             | 2 +-
>  target/i386/translate.c              | 2 +-
>  target/lm32/translate.c              | 2 +-
>  target/m68k/translate.c              | 2 +-
>  target/microblaze/translate.c        | 2 +-
>  target/mips/translate.c              | 2 +-
>  target/moxie/translate.c             | 2 +-
>  target/nios2/translate.c             | 2 +-
>  target/openrisc/translate.c          | 2 +-
>  target/ppc/mem_helper.c              | 2 +-
>  target/ppc/translate.c               | 4 ++--
>  target/riscv/cpu_helper.c            | 2 +-
>  target/riscv/translate.c             | 2 +-
>  target/s390x/translate.c             | 4 ++--
>  target/sh4/translate.c               | 2 +-
>  target/sparc/ldst_helper.c           | 2 +-
>  target/sparc/translate.c             | 2 +-
>  target/tilegx/translate.c            | 2 +-
>  target/tricore/translate.c           | 2 +-
>  target/unicore32/translate.c         | 2 +-
>  target/xtensa/translate.c            | 2 +-
>  tcg/aarch64/tcg-target.inc.c         | 4 ++--
>  tcg/arm/tcg-target.inc.c             | 4 ++--
>  tcg/i386/tcg-target.inc.c            | 4 ++--
>  tcg/mips/tcg-target.inc.c            | 2 +-
>  tcg/optimize.c                       | 2 +-
>  tcg/ppc/tcg-target.inc.c             | 4 ++--
>  tcg/riscv/tcg-target.inc.c           | 4 ++--
>  tcg/s390/tcg-target.inc.c            | 4 ++--
>  tcg/sparc/tcg-target.inc.c           | 2 +-
>  tcg/tcg-common.c                     | 2 +-
>  tcg/tcg-op-gvec.c                    | 8 ++++----
>  tcg/tcg-op-vec.c                     | 6 +++---
>  tcg/tcg-op.c                         | 6 +++---
>  tcg/tcg.c                            | 2 +-
>  tcg/tci.c                            | 2 +-
>  MAINTAINERS                          | 1 +
>  61 files changed, 76 insertions(+), 76 deletions(-)
>  rename {tcg => include/tcg}/tcg-gvec-desc.h (100%)
>  rename {tcg => include/tcg}/tcg-mo.h (100%)
>  rename {tcg => include/tcg}/tcg-op-gvec.h (100%)
>  rename {tcg => include/tcg}/tcg-op.h (99%)
>  rename {tcg => include/tcg}/tcg-opc.h (100%)
>  rename {tcg => include/tcg}/tcg.h (99%)


Thank you, Philippe and Paolo.

Reviewed-by: Stefan Weil <sw@weilnetz.de>



Re: [PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list
Posted by Richard Henderson 4 years, 4 months ago
On 1/1/20 10:22 PM, Philippe Mathieu-Daudé wrote:
> Noticed we could clean this while reviewing Richard patch last night:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html
> 
> Since v1:
> - moved headers to include/tcg/ (Paolo)
> - include in .inc.c relative to parent (Stefan)
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05356.html
> 
> Philippe Mathieu-Daudé (4):
>   tcg: Search includes from the project root source directory
>   tcg: Search includes in the parent source directory
>   tcg: Move TCG headers to include/tcg/
>   configure: Remove tcg/ from the preprocessor include search list

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Will queue shortly.


r~