hw: Fix various --without-default-devices issues

[RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC

Posted by Philippe Mathieu-Daudé 6 years, 1 month ago

apic_eoi() calls ioapic_eoi_broadcast(), so APIC has to
select the IOAPIC Kconfig.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: "Michael S. Tsirkin" <mst@redhat.com>

RFC because I'm not sure the design is correct (meanwhile the fix is, however).
---
 hw/intc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig
index a189d6fedd..82748ae13d 100644
--- a/hw/intc/Kconfig
+++ b/hw/intc/Kconfig
@@ -24,6 +24,7 @@ config APIC
     bool
     select MSI_NONBROKEN
     select I8259
+    select IOAPIC
 
 config ARM_GIC_KVM
     bool
-- 
2.21.0

Re: [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC

Posted by Paolo Bonzini 6 years, 1 month ago

On 31/12/19 19:32, Philippe Mathieu-Daudé wrote:
> apic_eoi() calls ioapic_eoi_broadcast(), so APIC has to
> select the IOAPIC Kconfig.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> 
> RFC because I'm not sure the design is correct (meanwhile the fix is, however).

Just add a comment like "# for ioapic_eoi_broadcast()".  If anybody
wants to drop it, they can add a stub.

Paolo

> ---
>  hw/intc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig
> index a189d6fedd..82748ae13d 100644
> --- a/hw/intc/Kconfig
> +++ b/hw/intc/Kconfig
> @@ -24,6 +24,7 @@ config APIC
>      bool
>      select MSI_NONBROKEN
>      select I8259
> +    select IOAPIC
>  
>  config ARM_GIC_KVM
>      bool
>