scripts/git.orderfile: Display decodetree before C source

[PATCH] scripts/git.orderfile: Display decodetree before C source

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

To avoid scrolling each instruction when reviewing tcg
helpers written for the decodetree script, display the
.decode files (similar to header declarations) before
the C source (implementation of previous declarations).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 scripts/git.orderfile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index e89790941c..1f747b583a 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -25,5 +25,8 @@ qga/*.json
 # headers
 *.h
 
+# decoding tree specification
+*.decode
+
 # code
 *.c
-- 
2.21.0

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

Posted by Alex Bennée 4 years, 4 months ago

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> To avoid scrolling each instruction when reviewing tcg
> helpers written for the decodetree script, display the
> .decode files (similar to header declarations) before
> the C source (implementation of previous declarations).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  scripts/git.orderfile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> index e89790941c..1f747b583a 100644
> --- a/scripts/git.orderfile
> +++ b/scripts/git.orderfile
> @@ -25,5 +25,8 @@ qga/*.json
>  # headers
>  *.h
>  
> +# decoding tree specification
> +*.decode
> +
>  # code
>  *.c


-- 
Alex Bennée

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

Cc'ing qemu-trivial@

On 12/30/19 9:28 AM, Philippe Mathieu-Daudé wrote:
> To avoid scrolling each instruction when reviewing tcg
> helpers written for the decodetree script, display the
> .decode files (similar to header declarations) before
> the C source (implementation of previous declarations).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   scripts/git.orderfile | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> index e89790941c..1f747b583a 100644
> --- a/scripts/git.orderfile
> +++ b/scripts/git.orderfile
> @@ -25,5 +25,8 @@ qga/*.json
>   # headers
>   *.h
>   
> +# decoding tree specification
> +*.decode
> +
>   # code
>   *.c
>

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

Posted by Richard Henderson 4 years, 3 months ago

On 1/18/20 12:09 AM, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
> 
> On 12/30/19 9:28 AM, Philippe Mathieu-Daudé wrote:
>> To avoid scrolling each instruction when reviewing tcg
>> helpers written for the decodetree script, display the
>> .decode files (similar to header declarations) before
>> the C source (implementation of previous declarations).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued to tcg-next, since no one else has picked this up.


r~

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

Posted by Stefano Garzarella 4 years, 4 months ago

On Mon, Dec 30, 2019 at 09:28:56AM +0100, Philippe Mathieu-Daudé wrote:
> To avoid scrolling each instruction when reviewing tcg
> helpers written for the decodetree script, display the
> .decode files (similar to header declarations) before
> the C source (implementation of previous declarations).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  scripts/git.orderfile | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

> 
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> index e89790941c..1f747b583a 100644
> --- a/scripts/git.orderfile
> +++ b/scripts/git.orderfile
> @@ -25,5 +25,8 @@ qga/*.json
>  # headers
>  *.h
>  
> +# decoding tree specification
> +*.decode
> +
>  # code
>  *.c
> -- 
> 2.21.0
> 
>