iotests: Add more "_require_drivers" checks to the shell-based tests

[PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

Thomas Huth posted 1 patch 4 years, 4 months ago

Download mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191218161541.30769-1-thuth@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

tests/qemu-iotests/051 | 1 +
tests/qemu-iotests/267 | 1 +
2 files changed, 2 insertions(+)

Expand all Fold all

[PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

Posted by Thomas Huth 4 years, 4 months ago

Test 051 should be skipped if nbd is not available, and 267 should
be skipped if copy-on-read is not enabled.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/051 | 1 +
 tests/qemu-iotests/267 | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 53bcdbc911..a13bce2fd0 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -41,6 +41,7 @@ _supported_proto file
 # A compat=0.10 image is created in this test which does not support anything
 # other than refcount_bits=16
 _unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)'
+_require_drivers nbd
 
 do_run_qemu()
 {
diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267
index 17ac640a83..c1536f45b9 100755
--- a/tests/qemu-iotests/267
+++ b/tests/qemu-iotests/267
@@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fmt qcow2
 _supported_proto file
 _supported_os Linux
+_require_drivers copy-on-read
 
 # Internal snapshots are (currently) impossible with refcount_bits=1
 _unsupported_imgopts 'refcount_bits=1[^0-9]'
-- 
2.18.1

Re: [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

Posted by Kevin Wolf 4 years, 3 months ago

Am 18.12.2019 um 17:15 hat Thomas Huth geschrieben:
> Test 051 should be skipped if nbd is not available, and 267 should
> be skipped if copy-on-read is not enabled.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

Posted by Eric Blake 4 years, 4 months ago

On 12/18/19 10:15 AM, Thomas Huth wrote:
> Test 051 should be skipped if nbd is not available, and 267 should
> be skipped if copy-on-read is not enabled.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qemu-iotests/051 | 1 +
>   tests/qemu-iotests/267 | 1 +
>   2 files changed, 2 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
> index 53bcdbc911..a13bce2fd0 100755
> --- a/tests/qemu-iotests/051
> +++ b/tests/qemu-iotests/051
> @@ -41,6 +41,7 @@ _supported_proto file
>   # A compat=0.10 image is created in this test which does not support anything
>   # other than refcount_bits=16
>   _unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)'
> +_require_drivers nbd
>   
>   do_run_qemu()
>   {
> diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267
> index 17ac640a83..c1536f45b9 100755
> --- a/tests/qemu-iotests/267
> +++ b/tests/qemu-iotests/267
> @@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   _supported_fmt qcow2
>   _supported_proto file
>   _supported_os Linux
> +_require_drivers copy-on-read
>   
>   # Internal snapshots are (currently) impossible with refcount_bits=1
>   _unsupported_imgopts 'refcount_bits=1[^0-9]'
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org