[PATCH 3/7] configure: Do not force pie=no for non-x86

Richard Henderson posted 7 patches 6 years, 1 month ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
There is a newer version of this series
[PATCH 3/7] configure: Do not force pie=no for non-x86
Posted by Richard Henderson 6 years, 1 month ago
PIE is supported on many other hosts besides x86.

The default for non-x86 is now the same as x86: pie is used
if supported, and may be forced via --enable/--disable-pie.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 configure | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/configure b/configure
index 255ac432af..2fb4457d7c 100755
--- a/configure
+++ b/configure
@@ -2012,16 +2012,6 @@ if ! compile_prog "-Werror" "" ; then
 	"Thread-Local Storage (TLS). Please upgrade to a version that does."
 fi
 
-if test "$pie" = ""; then
-  case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
-      ;;
-    *)
-      pie="no"
-      ;;
-  esac
-fi
-
 if test "$pie" != "no" ; then
   cat > $TMPC << EOF
 
-- 
2.20.1


Re: [PATCH 3/7] configure: Do not force pie=no for non-x86
Posted by Thomas Huth 6 years, 1 month ago
On 18/12/2019 04.19, Richard Henderson wrote:
> PIE is supported on many other hosts besides x86.
> 
> The default for non-x86 is now the same as x86: pie is used
> if supported, and may be forced via --enable/--disable-pie.

The original commit that introduce this code (40d6444e91c) said:

 "Non-x86 are not changed, as they require TCG changes"

... are these "TCG changes" in place nowadays? Did you check on non-x86
systems? If so, please mention this in the commit message.

 Thomas


Re: [PATCH 3/7] configure: Do not force pie=no for non-x86
Posted by Richard Henderson 6 years, 1 month ago
On 12/17/19 9:05 PM, Thomas Huth wrote:
> On 18/12/2019 04.19, Richard Henderson wrote:
>> PIE is supported on many other hosts besides x86.
>>
>> The default for non-x86 is now the same as x86: pie is used
>> if supported, and may be forced via --enable/--disable-pie.
> 
> The original commit that introduce this code (40d6444e91c) said:
> 
>  "Non-x86 are not changed, as they require TCG changes"
> 
> ... are these "TCG changes" in place nowadays? Did you check on non-x86
> systems? If so, please mention this in the commit message.

I have no idea what those "tcg changes" would be.  I have checked aarch64
(bionic) and ppc64le (centos 7).  I'll update the commit message.


r~