target/ppc: Remove unused PPC_INPUT_INT defines

[PATCH] target/ppc: Remove unused PPC_INPUT_INT defines

Fabiano Rosas posted 1 patch 4 years, 4 months ago

Download mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191218014616.686124-1-farosas@linux.ibm.com

Maintainers: David Gibson <david@gibson.dropbear.id.au>

target/ppc/kvm.c | 6 ------
1 file changed, 6 deletions(-)

Expand all Fold all

[PATCH] target/ppc: Remove unused PPC_INPUT_INT defines

Posted by Fabiano Rosas 4 years, 4 months ago

They were added in "16415335be Use correct input constant" with a
single use in kvm_arch_pre_run but that function's implementation was
removed by "1e8f51e856 ppc: remove idle_timer logic".

Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
 target/ppc/kvm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 7406d18945..b19555e97e 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1325,12 +1325,6 @@ int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level)
     return 0;
 }
 
-#if defined(TARGET_PPC64)
-#define PPC_INPUT_INT PPC970_INPUT_INT
-#else
-#define PPC_INPUT_INT PPC6xx_INPUT_INT
-#endif
-
 void kvm_arch_pre_run(CPUState *cs, struct kvm_run *run)
 {
     return;
-- 
2.23.0

Re: [PATCH] target/ppc: Remove unused PPC_INPUT_INT defines

Posted by David Gibson 4 years, 4 months ago

On Tue, Dec 17, 2019 at 10:46:16PM -0300, Fabiano Rosas wrote:
> They were added in "16415335be Use correct input constant" with a
> single use in kvm_arch_pre_run but that function's implementation was
> removed by "1e8f51e856 ppc: remove idle_timer logic".
> 
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>

Applied to ppc-for-5.0, thanks.

> ---
>  target/ppc/kvm.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 7406d18945..b19555e97e 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -1325,12 +1325,6 @@ int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level)
>      return 0;
>  }
>  
> -#if defined(TARGET_PPC64)
> -#define PPC_INPUT_INT PPC970_INPUT_INT
> -#else
> -#define PPC_INPUT_INT PPC6xx_INPUT_INT
> -#endif
> -
>  void kvm_arch_pre_run(CPUState *cs, struct kvm_run *run)
>  {
>      return;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson