[v4] virtio: make seg_max virtqueue size dependent

[PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

Denis Plotnikov posted 2 patches 4 years, 4 months ago

Diff against v3 v5 v5
Download series mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191216100451.28060-1-dplotnikov@virtuozzo.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

There is a newer version of this series

hw/block/virtio-blk.c                     |   9 +-
hw/core/machine.c                         |   3 +
hw/scsi/vhost-scsi.c                      |   2 +
hw/scsi/virtio-scsi.c                     |  10 +-
include/hw/virtio/virtio-blk.h            |   1 +
include/hw/virtio/virtio-scsi.h           |   1 +
tests/acceptance/virtio_seg_max_adjust.py | 135 ++++++++++++++++++++++
7 files changed, 159 insertions(+), 2 deletions(-)
create mode 100755 tests/acceptance/virtio_seg_max_adjust.py

Expand all Fold all

[PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

Posted by Denis Plotnikov 4 years, 4 months ago

v4:
  * rebased on 4.2 [MST]

v3:
  * add property to set in machine type [MST]
  * add min queue size check [Stefan]
  * add avocado based test [Max, Stefan, Eduardo, Cleber]

v2:
  * the standalone patch to make seg_max virtqueue size dependent
  * other patches are postponed

v1:
  the initial series

Denis Plotnikov (2):
  virtio: make seg_max virtqueue size dependent
  tests: add virtio-scsi and virtio-blk seg_max_adjust test

 hw/block/virtio-blk.c                     |   9 +-
 hw/core/machine.c                         |   3 +
 hw/scsi/vhost-scsi.c                      |   2 +
 hw/scsi/virtio-scsi.c                     |  10 +-
 include/hw/virtio/virtio-blk.h            |   1 +
 include/hw/virtio/virtio-scsi.h           |   1 +
 tests/acceptance/virtio_seg_max_adjust.py | 135 ++++++++++++++++++++++
 7 files changed, 159 insertions(+), 2 deletions(-)
 create mode 100755 tests/acceptance/virtio_seg_max_adjust.py

-- 
2.17.0

Re: [PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

Posted by Michael S. Tsirkin 4 years, 4 months ago

On Mon, Dec 16, 2019 at 01:04:49PM +0300, Denis Plotnikov wrote:
> v4:
>   * rebased on 4.2 [MST]


Looks good. Can I get some acks from storage guys pls?

> v3:
>   * add property to set in machine type [MST]
>   * add min queue size check [Stefan]
>   * add avocado based test [Max, Stefan, Eduardo, Cleber]
> 
> v2:
>   * the standalone patch to make seg_max virtqueue size dependent
>   * other patches are postponed
> 
> v1:
>   the initial series
> 
> Denis Plotnikov (2):
>   virtio: make seg_max virtqueue size dependent
>   tests: add virtio-scsi and virtio-blk seg_max_adjust test
> 
>  hw/block/virtio-blk.c                     |   9 +-
>  hw/core/machine.c                         |   3 +
>  hw/scsi/vhost-scsi.c                      |   2 +
>  hw/scsi/virtio-scsi.c                     |  10 +-
>  include/hw/virtio/virtio-blk.h            |   1 +
>  include/hw/virtio/virtio-scsi.h           |   1 +
>  tests/acceptance/virtio_seg_max_adjust.py | 135 ++++++++++++++++++++++
>  7 files changed, 159 insertions(+), 2 deletions(-)
>  create mode 100755 tests/acceptance/virtio_seg_max_adjust.py
> 
> -- 
> 2.17.0

Re: [PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

Posted by Stefan Hajnoczi 4 years, 4 months ago

On Mon, Dec 16, 2019 at 06:04:21AM -0500, Michael S. Tsirkin wrote:
> On Mon, Dec 16, 2019 at 01:04:49PM +0300, Denis Plotnikov wrote:
> > v4:
> >   * rebased on 4.2 [MST]
> 
> 
> Looks good. Can I get some acks from storage guys pls?

Looks good to me.

Stefan

Re: [PATCH v4 0/2] virtio: make seg_max virtqueue size dependent

Posted by Stefan Hajnoczi 4 years, 4 months ago

On Mon, Dec 16, 2019 at 01:04:49PM +0300, Denis Plotnikov wrote:
> v4:
>   * rebased on 4.2 [MST]
> 
> v3:
>   * add property to set in machine type [MST]
>   * add min queue size check [Stefan]
>   * add avocado based test [Max, Stefan, Eduardo, Cleber]
> 
> v2:
>   * the standalone patch to make seg_max virtqueue size dependent
>   * other patches are postponed
> 
> v1:
>   the initial series
> 
> Denis Plotnikov (2):
>   virtio: make seg_max virtqueue size dependent
>   tests: add virtio-scsi and virtio-blk seg_max_adjust test
> 
>  hw/block/virtio-blk.c                     |   9 +-
>  hw/core/machine.c                         |   3 +
>  hw/scsi/vhost-scsi.c                      |   2 +
>  hw/scsi/virtio-scsi.c                     |  10 +-
>  include/hw/virtio/virtio-blk.h            |   1 +
>  include/hw/virtio/virtio-scsi.h           |   1 +
>  tests/acceptance/virtio_seg_max_adjust.py | 135 ++++++++++++++++++++++
>  7 files changed, 159 insertions(+), 2 deletions(-)
>  create mode 100755 tests/acceptance/virtio_seg_max_adjust.py

Bellissimo!  Thanks for doing this :)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>