1. Patchew
  2. QEMU
  3. View series

[PATCH] qapi: better document NVMe blockdev @device parameter

Daniel P. Berrangé posted 1 patch 4 years, 4 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191206143811.3777524-1-berrange@redhat.com
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
qapi/block-core.json | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH] qapi: better document NVMe blockdev @device parameter
Posted by Daniel P. Berrangé 4 years, 4 months ago 
Mention that this is a PCI device address & give the format it is
expected it. Also mention that it must be first unbound from any
host kernel driver.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 qapi/block-core.json | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..fcb52ec24f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2963,9 +2963,13 @@
 #
 # Driver specific block device options for the NVMe backend.
 #
-# @device:    controller address of the NVMe device.
+# @device:    PCI controller address of the NVMe device in
+#             format hhhh:bb:ss.f (host:bus:slot.function)
 # @namespace: namespace number of the device, starting from 1.
 #
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
 # Since: 2.12
 ##
 { 'struct': 'BlockdevOptionsNVMe',
-- 
2.23.0
Re: [PATCH] qapi: better document NVMe blockdev @device parameter
Posted by Eric Blake 4 years, 4 months ago 
On 12/6/19 8:38 AM, Daniel P. Berrangé wrote:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any

maybe s/expected it/expecting/

> host kernel driver.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   qapi/block-core.json | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0cf68fea14..fcb52ec24f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2963,9 +2963,13 @@
>   #
>   # Driver specific block device options for the NVMe backend.
>   #
> -# @device:    controller address of the NVMe device.
> +# @device:    PCI controller address of the NVMe device in
> +#             format hhhh:bb:ss.f (host:bus:slot.function)
>   # @namespace: namespace number of the device, starting from 1.
>   #
> +# Note that the PCI @device must have been unbound from any host
> +# kernel driver before instructing QEMU to add the blockdev.
> +#

Reviewed-by: Eric Blake <eblake@redhat.com>

Doesn't affect code, but similarly no reason to hurry this into 4.2. 
5.0 and qemu-stable (cc'd) is good enough.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
Re: [PATCH] qapi: better document NVMe blockdev @device parameter
Posted by Daniel P. Berrangé 4 years, 4 months ago 
On Fri, Dec 06, 2019 at 08:51:15AM -0600, Eric Blake wrote:
> On 12/6/19 8:38 AM, Daniel P. Berrangé wrote:
> > Mention that this is a PCI device address & give the format it is
> > expected it. Also mention that it must be first unbound from any
> 
> maybe s/expected it/expecting/

It was supposed to be "in" rather than "it", but your suggestion
is fine too.

> 
> > host kernel driver.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   qapi/block-core.json | 6 +++++-
> >   1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 0cf68fea14..fcb52ec24f 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2963,9 +2963,13 @@
> >   #
> >   # Driver specific block device options for the NVMe backend.
> >   #
> > -# @device:    controller address of the NVMe device.
> > +# @device:    PCI controller address of the NVMe device in
> > +#             format hhhh:bb:ss.f (host:bus:slot.function)
> >   # @namespace: namespace number of the device, starting from 1.
> >   #
> > +# Note that the PCI @device must have been unbound from any host
> > +# kernel driver before instructing QEMU to add the blockdev.
> > +#
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Doesn't affect code, but similarly no reason to hurry this into 4.2. 5.0 and
> qemu-stable (cc'd) is good enough.
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH] qapi: better document NVMe blockdev @device parameter
Posted by Kevin Wolf 4 years, 4 months ago 
Am 06.12.2019 um 15:38 hat Daniel P. Berrangé geschrieben:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any
> host kernel driver.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks, applied to the block branch.

Kevin
Re: [PATCH] qapi: better document NVMe blockdev @device parameter
Posted by Stefan Hajnoczi 4 years, 4 months ago 
On Fri, Dec 06, 2019 at 02:38:11PM +0000, Daniel P. Berrangé wrote:
> Mention that this is a PCI device address & give the format it is
> expected it. Also mention that it must be first unbound from any
> host kernel driver.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qapi/block-core.json | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.