[v8] error: prepare for auto propagated local_err

[PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp

Vladimir Sementsov-Ogievskiy posted 21 patches 5 years, 11 months ago

Diff against v7
Download mbox

Maintainers: David Gibson <david@gibson.dropbear.id.au>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Stefan Berger <stefanb@linux.ibm.com>, Max Reitz <mreitz@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Richard Henderson <rth@twiddle.net>, Kevin Wolf <kwolf@redhat.com>, Cornelia Huck <cohuck@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Greg Kurz <groug@kaod.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Eric Blake <eblake@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Pierre Morel <pmorel@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, David Hildenbrand <david@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Tony Krowiak <akrowiak@linux.ibm.com>, Markus Armbruster <armbru@redhat.com>, Paul Burton <pburton@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

Expand all Fold all

[PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp

Posted by Vladimir Sementsov-Ogievskiy 5 years, 11 months ago

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 hw/usb/dev-network.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 5de6213cc4..b81a8abe83 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
@@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
     .cleanup = usbnet_cleanup,
 };
 
-static void usb_net_realize(USBDevice *dev, Error **errrp)
+static void usb_net_realize(USBDevice *dev, Error **errp)
 {
     USBNetState *s = USB_NET(dev);
 
-- 
2.21.0

Re: [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp

Posted by Philippe Mathieu-Daudé 5 years, 11 months ago

On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   hw/usb/dev-network.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
> index 5de6213cc4..b81a8abe83 100644
> --- a/hw/usb/dev-network.c
> +++ b/hw/usb/dev-network.c
> @@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
>       .cleanup = usbnet_cleanup,
>   };
>   
> -static void usb_net_realize(USBDevice *dev, Error **errrp)

Funny one.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +static void usb_net_realize(USBDevice *dev, Error **errp)
>   {
>       USBNetState *s = USB_NET(dev);
>   
>

Re: [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp

Posted by Vladimir Sementsov-Ogievskiy 5 years, 11 months ago

06.12.2019 10:38, Philippe Mathieu-Daudé wrote:
> On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   hw/usb/dev-network.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
>> index 5de6213cc4..b81a8abe83 100644
>> --- a/hw/usb/dev-network.c
>> +++ b/hw/usb/dev-network.c
>> @@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
>>       .cleanup = usbnet_cleanup,
>>   };
>> -static void usb_net_realize(USBDevice *dev, Error **errrp)
> 
> Funny one.
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Thanks a lot for reviewing!


-- 
Best regards,
Vladimir