[PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix

Alex Bennée posted 1 patch 4 years, 4 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191127132430.3681-1-alex.bennee@linaro.org
.travis.yml | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
[PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix
Posted by Alex Bennée 4 years, 4 months ago
It's broken so it's no longer helping. The latest Xcode is covered by
Cirrus.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index c09b6a00143..445b0646c18 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -237,13 +237,7 @@ matrix:
         - TEST_CMD=""
 
 
-    # MacOSX builds
-    - env:
-        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}"
-      os: osx
-      osx_image: xcode9.4
-      compiler: clang
-
+    # MacOSX builds - cirrus.yml also tests some MacOS builds including latest Xcode
 
     - env:
         - CONFIG="--target-list=i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu"
-- 
2.20.1


Re: [PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix
Posted by Philippe Mathieu-Daudé 4 years, 4 months ago
Le mer. 27 nov. 2019 14:51, Alex Bennée <alex.bennee@linaro.org> a écrit :

> It's broken so it's no longer helping. The latest Xcode is covered by
> Cirrus.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

---
>  .travis.yml | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index c09b6a00143..445b0646c18 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -237,13 +237,7 @@ matrix:
>          - TEST_CMD=""
>
>
> -    # MacOSX builds
> -    - env:
> -        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}"
> -      os: osx
> -      osx_image: xcode9.4
> -      compiler: clang
> -
> +    # MacOSX builds - cirrus.yml also tests some MacOS builds including
> latest Xcode
>
>      - env:
>          -
> CONFIG="--target-list=i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu"
> --
> 2.20.1
>
>
>
Re: [PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix
Posted by Thomas Huth 4 years, 4 months ago
On 27/11/2019 14.24, Alex Bennée wrote:
> It's broken so it's no longer helping. The latest Xcode is covered by
> Cirrus.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .travis.yml | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index c09b6a00143..445b0646c18 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -237,13 +237,7 @@ matrix:
>          - TEST_CMD=""
>  
>  
> -    # MacOSX builds
> -    - env:
> -        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}"
> -      os: osx
> -      osx_image: xcode9.4
> -      compiler: clang
> -
> +    # MacOSX builds - cirrus.yml also tests some MacOS builds including latest Xcode

Ack for removing xcode9.4, it's also constantly failing for me, which is
quite annoying.

Additionally, the xcode9.4 runs on macOS 10.13, which we do not
officially support anymore in QEMU (we only support the latest two
releases).

But maybe instead of removing the entry completely, you could replace it
with "xcode11.2" instead if that works? See:

 https://docs.travis-ci.com/user/reference/osx

  Thomas


Re: [PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix
Posted by Peter Maydell 4 years, 4 months ago
On Fri, 29 Nov 2019 at 13:52, Thomas Huth <thuth@redhat.com> wrote:
>
> On 27/11/2019 14.24, Alex Bennée wrote:
> > It's broken so it's no longer helping. The latest Xcode is covered by
> > Cirrus.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> >  .travis.yml | 8 +-------
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index c09b6a00143..445b0646c18 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -237,13 +237,7 @@ matrix:
> >          - TEST_CMD=""
> >
> >
> > -    # MacOSX builds
> > -    - env:
> > -        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}"
> > -      os: osx
> > -      osx_image: xcode9.4
> > -      compiler: clang
> > -
> > +    # MacOSX builds - cirrus.yml also tests some MacOS builds including latest Xcode
>
> Ack for removing xcode9.4, it's also constantly failing for me, which is
> quite annoying.
>
> Additionally, the xcode9.4 runs on macOS 10.13, which we do not
> officially support anymore in QEMU (we only support the latest two
> releases).
>
> But maybe instead of removing the entry completely, you could replace it
> with "xcode11.2" instead if that works? See:

For purposes of 4.2 I've applied this patch-as is (since we're
going to get an rc4 anyway, and this is a simple change which
will stop travis complaining about the 4.2 stable branch in
future). We can look at xcode11.2 for 5.0.

thanks
-- PMM