hw/block/pflash_cfi01.c | 8 ++++---- hw/block/pflash_cfi02.c | 8 ++++---- hw/block/trace-events | 8 ++++---- hw/mips/gt64xxx_pci.c | 16 ++++++++-------- hw/mips/trace-events | 4 ++-- 5 files changed, 22 insertions(+), 22 deletions(-)
The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) ---------------------------------------------------------------- Pull request Tracing fixes for MIPS. ---------------------------------------------------------------- Philippe Mathieu-Daudé (2): hw/block/pflash: Remove dynamic field width from trace events hw/mips/gt64xxx: Remove dynamic field width from trace events hw/block/pflash_cfi01.c | 8 ++++---- hw/block/pflash_cfi02.c | 8 ++++---- hw/block/trace-events | 8 ++++---- hw/mips/gt64xxx_pci.c | 16 ++++++++-------- hw/mips/trace-events | 4 ++-- 5 files changed, 22 insertions(+), 22 deletions(-) -- 2.23.0
On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: > > hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) > > ---------------------------------------------------------------- > Pull request > > Tracing fixes for MIPS. > > ---------------------------------------------------------------- > Hello, Stefan, Philippe, Peter. This appears to be a duplicate of the pull request sent today by Philippe (and already applied by Peter just hours ago): https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html The patches from the two pull requests appear to be identical, except some minor details in commit messages: Stefan's versions contain "Message-Id:" identifiers, while Philippe's don't (my suggestion to Philippe is to include "Message-Id:" for all patches that are part of any pull request in future; this can be achieved effortlessly/automatically by applying patches using patchwork). In summary, for this very situation, it looks to me we are all set, no need for Peter to process this pull request. Regards, Aleksandar > Philippe Mathieu-Daudé (2): > hw/block/pflash: Remove dynamic field width from trace events > hw/mips/gt64xxx: Remove dynamic field width from trace events > > hw/block/pflash_cfi01.c | 8 ++++---- > hw/block/pflash_cfi02.c | 8 ++++---- > hw/block/trace-events | 8 ++++---- > hw/mips/gt64xxx_pci.c | 16 ++++++++-------- > hw/mips/trace-events | 4 ++-- > 5 files changed, 22 insertions(+), 22 deletions(-) > > -- > 2.23.0 > >
On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote: > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: > > > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) > > > > are available in the Git repository at: > > > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > > > for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: > > > > hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) > > > > ---------------------------------------------------------------- > > Pull request > > > > Tracing fixes for MIPS. > > > > ---------------------------------------------------------------- > > > > Hello, Stefan, Philippe, Peter. > > This appears to be a duplicate of the pull request sent today by Philippe > (and already applied by Peter just hours ago): > > https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html > > The patches from the two pull requests appear to be identical, except > some minor details in commit messages: Stefan's versions contain > "Message-Id:" identifiers, while Philippe's don't (my suggestion to > Philippe is to include "Message-Id:" for all patches that are part of any > pull request in future; this can be achieved effortlessly/automatically > by applying patches using patchwork). > > In summary, for this very situation, it looks to me we are all set, no need > for Peter to process this pull request. > And just another really friendly advice for Philippe: When you apply some patches or a series to your pull request, just inform others about that by replying to the patches or a series: "I applied XXX to my queue/pull request" - this helps avoiding duplicate efforts like it happened here. This is also reminder to me too, I didn't do it in all cases of my applying to my my pull requests, and I should have, but I will improve too. Thanks for these fixes! Aleksandar > Regards, > Aleksandar > > > Philippe Mathieu-Daudé (2): > > hw/block/pflash: Remove dynamic field width from trace events > > hw/mips/gt64xxx: Remove dynamic field width from trace events > > > > hw/block/pflash_cfi01.c | 8 ++++---- > > hw/block/pflash_cfi02.c | 8 ++++---- > > hw/block/trace-events | 8 ++++---- > > hw/mips/gt64xxx_pci.c | 16 ++++++++-------- > > hw/mips/trace-events | 4 ++-- > > 5 files changed, 22 insertions(+), 22 deletions(-) > > > > -- > > 2.23.0 > > > >
On 11/19/19 10:35 PM, Aleksandar Markovic wrote: > On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic > <aleksandar.m.mail@gmail.com> wrote: >> >> On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: >>> >>> The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: >>> >>> Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) >>> >>> are available in the Git repository at: >>> >>> https://github.com/stefanha/qemu.git tags/tracing-pull-request >>> >>> for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: >>> >>> hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) >>> >>> ---------------------------------------------------------------- >>> Pull request >>> >>> Tracing fixes for MIPS. >>> >>> ---------------------------------------------------------------- >>> >> >> Hello, Stefan, Philippe, Peter. >> >> This appears to be a duplicate of the pull request sent today by Philippe >> (and already applied by Peter just hours ago): >> >> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html >> >> The patches from the two pull requests appear to be identical, except >> some minor details in commit messages: Stefan's versions contain >> "Message-Id:" identifiers, while Philippe's don't (my suggestion to >> Philippe is to include "Message-Id:" for all patches that are part of any >> pull request in future; this can be achieved effortlessly/automatically >> by applying patches using patchwork). >> >> In summary, for this very situation, it looks to me we are all set, no need >> for Peter to process this pull request. >> > > And just another really friendly advice for Philippe: When you apply > some patches or a series to your pull request, just inform others > about that by replying to the patches or a series: "I applied XXX to > my queue/pull request" - this helps avoiding duplicate efforts like > it happened here. This is also reminder to me too, I didn't do it in > all cases of my applying to my my pull requests, and I should have, > but I will improve too. You are totally correct, in a rush to get these patches merged before the release candidate get tagged, I neglected to reply to my series and let Stefan waste his time. Stefan, I sincerely apologize and will make efforts so this won't happen again. > > Thanks for these fixes! > > Aleksandar > >> Regards, >> Aleksandar >> >>> Philippe Mathieu-Daudé (2): >>> hw/block/pflash: Remove dynamic field width from trace events >>> hw/mips/gt64xxx: Remove dynamic field width from trace events >>> >>> hw/block/pflash_cfi01.c | 8 ++++---- >>> hw/block/pflash_cfi02.c | 8 ++++---- >>> hw/block/trace-events | 8 ++++---- >>> hw/mips/gt64xxx_pci.c | 16 ++++++++-------- >>> hw/mips/trace-events | 4 ++-- >>> 5 files changed, 22 insertions(+), 22 deletions(-) >>> >>> -- >>> 2.23.0 >>> >>> >
On Wed, Nov 20, 2019 at 10:33:35AM +0100, Philippe Mathieu-Daudé wrote: > On 11/19/19 10:35 PM, Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic > > <aleksandar.m.mail@gmail.com> wrote: > > > > > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: > > > > > > > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > > > > > > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) > > > > > > > > are available in the Git repository at: > > > > > > > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > > > > > > > for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: > > > > > > > > hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) > > > > > > > > ---------------------------------------------------------------- > > > > Pull request > > > > > > > > Tracing fixes for MIPS. > > > > > > > > ---------------------------------------------------------------- > > > > > > > > > > Hello, Stefan, Philippe, Peter. > > > > > > This appears to be a duplicate of the pull request sent today by Philippe > > > (and already applied by Peter just hours ago): > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html > > > > > > The patches from the two pull requests appear to be identical, except > > > some minor details in commit messages: Stefan's versions contain > > > "Message-Id:" identifiers, while Philippe's don't (my suggestion to > > > Philippe is to include "Message-Id:" for all patches that are part of any > > > pull request in future; this can be achieved effortlessly/automatically > > > by applying patches using patchwork). > > > > > > In summary, for this very situation, it looks to me we are all set, no need > > > for Peter to process this pull request. > > > > > > > And just another really friendly advice for Philippe: When you apply > > some patches or a series to your pull request, just inform others > > about that by replying to the patches or a series: "I applied XXX to > > my queue/pull request" - this helps avoiding duplicate efforts like > > it happened here. This is also reminder to me too, I didn't do it in > > all cases of my applying to my my pull requests, and I should have, > > but I will improve too. > > You are totally correct, in a rush to get these patches merged before the > release candidate get tagged, I neglected to reply to my series and let > Stefan waste his time. > > Stefan, I sincerely apologize and will make efforts so this won't happen > again. No problem, I just wanted to make sure we don't miss these patches. Stefan
On 11/19/19 10:14 PM, Aleksandar Markovic wrote: > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: >> >> The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: >> >> Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' into staging (2019-11-18 21:35:48 +0000) >> >> are available in the Git repository at: >> >> https://github.com/stefanha/qemu.git tags/tracing-pull-request >> >> for you to fetch changes up to 6b904f1a528a6d8c21f7fbdeab13b9603d1b6df7: >> >> hw/mips/gt64xxx: Remove dynamic field width from trace events (2019-11-19 16:17:05 +0000) >> >> ---------------------------------------------------------------- >> Pull request >> >> Tracing fixes for MIPS. >> >> ---------------------------------------------------------------- >> > > Hello, Stefan, Philippe, Peter. > > This appears to be a duplicate of the pull request sent today by Philippe > (and already applied by Peter just hours ago): > > https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html > > The patches from the two pull requests appear to be identical, except > some minor details in commit messages: Stefan's versions contain > "Message-Id:" identifiers, while Philippe's don't (my suggestion to > Philippe is to include "Message-Id:" for all patches that are part of any > pull request in future; this can be achieved effortlessly/automatically > by applying patches using patchwork). Yes you are right. I usually use 'pwclient git-am' to apply patches from the mailing list, which automatically amend the proper Message-Id tag. I totally forgot to use it with here. I'll see how to not miss them in the future. > In summary, for this very situation, it looks to me we are all set, no need > for Peter to process this pull request. > > Regards, > Aleksandar > >> Philippe Mathieu-Daudé (2): >> hw/block/pflash: Remove dynamic field width from trace events >> hw/mips/gt64xxx: Remove dynamic field width from trace events >> >> hw/block/pflash_cfi01.c | 8 ++++---- >> hw/block/pflash_cfi02.c | 8 ++++---- >> hw/block/trace-events | 8 ++++---- >> hw/mips/gt64xxx_pci.c | 16 ++++++++-------- >> hw/mips/trace-events | 4 ++-- >> 5 files changed, 22 insertions(+), 22 deletions(-) >> >> -- >> 2.23.0 >> >> >
Patchew URL: https://patchew.org/QEMU/20191119204551.240792-1-stefanha@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL for-4.2-rc2 0/2] Tracing patches Type: series Message-id: 20191119204551.240792-1-stefanha@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' === OUTPUT BEGIN === checkpatch.pl: no revisions returned for revlist '1' === OUTPUT END === Test command exited with code: 255 The full log is available at http://patchew.org/logs/20191119204551.240792-1-stefanha@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.