travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

[PATCH] travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

Thomas Huth posted 1 patch 4 years, 5 months ago

Download mbox

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Test asan passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191119092147.4260-1-thuth@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Fam Zheng <fam@euphon.net>

.travis.yml | 6 ------
1 file changed, 6 deletions(-)

Expand all Fold all

[PATCH] travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

Posted by Thomas Huth 4 years, 5 months ago

We test clang with the MAIN_SOFTMMU_TARGETS twice, once without
sanitizers and once with sanitizers enabled. That's somewhat redundant
since if compilation and tests succeeded with sanitizers enabled, it
should also work fine without sanitizers. Thus remove the clang entry
without sanitizers to speed up the CI testing a little bit.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index b9a026c8ee..47875bdafe 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -181,12 +181,6 @@ matrix:
       compiler: clang
 
 
-    - env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
-      compiler: clang
-
-
     - env:
         - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
-- 
2.23.0

Re: [PATCH] travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

Posted by Wainer dos Santos Moschetta 4 years, 5 months ago

On 11/19/19 7:21 AM, Thomas Huth wrote:
> We test clang with the MAIN_SOFTMMU_TARGETS twice, once without
> sanitizers and once with sanitizers enabled. That's somewhat redundant
> since if compilation and tests succeeded with sanitizers enabled, it
> should also work fine without sanitizers. Thus remove the clang entry
> without sanitizers to speed up the CI testing a little bit.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   .travis.yml | 6 ------
>   1 file changed, 6 deletions(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/.travis.yml b/.travis.yml
> index b9a026c8ee..47875bdafe 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -181,12 +181,6 @@ matrix:
>         compiler: clang
>   
>   
> -    - env:
> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
> -      compiler: clang
> -
> -
>       - env:
>           - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"

Re: [PATCH] travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

Posted by Alex Bennée 4 years, 4 months ago

Thomas Huth <thuth@redhat.com> writes:

> We test clang with the MAIN_SOFTMMU_TARGETS twice, once without
> sanitizers and once with sanitizers enabled. That's somewhat redundant
> since if compilation and tests succeeded with sanitizers enabled, it
> should also work fine without sanitizers. Thus remove the clang entry
> without sanitizers to speed up the CI testing a little bit.

Queued to pullreq/testing-logging-misc, thanks.

>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index b9a026c8ee..47875bdafe 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -181,12 +181,6 @@ matrix:
>        compiler: clang
>  
>  
> -    - env:
> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
> -      compiler: clang
> -
> -
>      - env:
>          - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"


-- 
Alex Bennée