Monitor patches for 2019-11-19

[PULL 0/1] Monitor patches for 2019-11-19

Markus Armbruster posted 1 patch 4 years, 5 months ago

Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191119090037.21686-1-armbru@redhat.com

Maintainers: Markus Armbruster <armbru@redhat.com>

monitor/qmp.c | 36 +++++++++++++++++++++++++++++++-----
1 file changed, 31 insertions(+), 5 deletions(-)

Expand all Fold all

[PULL 0/1] Monitor patches for 2019-11-19

Posted by Markus Armbruster 4 years, 5 months ago

I'd like to propose this bug fix for -rc2.  Certain usage of QMP can
leave the monitor permanently wedged (depends on event timing).
Libvirt does not use it this way as far as I know.  I understand it
affects other applications.  It's not a a regression in 4.2.

If it's too late for fixing it in 4.2, we'll punt to 5.0 with cc:
qemu-stable.

The following changes since commit a5c2a235103ab366ad5318636ec138e52c6dcfa4:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-11-18 17:06:17 +0000)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2019-11-19

for you to fetch changes up to 2895aaa139b3f916b3650ca516b35dceb9c0d4c4:

  monitor/qmp: resume monitor when clearing its queue (2019-11-19 08:21:47 +0100)

----------------------------------------------------------------
Monitor patches for 2019-11-19

----------------------------------------------------------------
Wolfgang Bumiller (1):
      monitor/qmp: resume monitor when clearing its queue

 monitor/qmp.c | 36 +++++++++++++++++++++++++++++++-----
 1 file changed, 31 insertions(+), 5 deletions(-)

-- 
2.21.0

Re: [PULL 0/1] Monitor patches for 2019-11-19

Posted by Peter Maydell 4 years, 5 months ago

On Tue, 19 Nov 2019 at 09:05, Markus Armbruster <armbru@redhat.com> wrote:
>
> I'd like to propose this bug fix for -rc2.  Certain usage of QMP can
> leave the monitor permanently wedged (depends on event timing).
> Libvirt does not use it this way as far as I know.  I understand it
> affects other applications.  It's not a a regression in 4.2.
>
> If it's too late for fixing it in 4.2, we'll punt to 5.0 with cc:
> qemu-stable.
>
> The following changes since commit a5c2a235103ab366ad5318636ec138e52c6dcfa4:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-11-18 17:06:17 +0000)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2019-11-19
>
> for you to fetch changes up to 2895aaa139b3f916b3650ca516b35dceb9c0d4c4:
>
>   monitor/qmp: resume monitor when clearing its queue (2019-11-19 08:21:47 +0100)
>
> ----------------------------------------------------------------
> Monitor patches for 2019-11-19
>
> ----------------------------------------------------------------
> Wolfgang Bumiller (1):
>       monitor/qmp: resume monitor when clearing its queue


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM