vhost-user-fs: remove "vhostfd" property

[PATCH] vhost-user-fs: remove "vhostfd" property

Marc-André Lureau posted 1 patch 4 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191116112016.14872-1-marcandre.lureau@redhat.com

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>

hw/virtio/vhost-user-fs.c         | 1 -
include/hw/virtio/vhost-user-fs.h | 1 -
2 files changed, 2 deletions(-)

Expand all Fold all

[PATCH] vhost-user-fs: remove "vhostfd" property

Posted by Marc-André Lureau 4 years, 5 months ago

The property doesn't make much sense for a vhost-user device.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/virtio/vhost-user-fs.c         | 1 -
 include/hw/virtio/vhost-user-fs.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
index f0df7f4746..ca0b7fc9de 100644
--- a/hw/virtio/vhost-user-fs.c
+++ b/hw/virtio/vhost-user-fs.c
@@ -263,7 +263,6 @@ static Property vuf_properties[] = {
     DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
                        conf.num_request_queues, 1),
     DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
-    DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
     DEFINE_PROP_END_OF_LIST(),
 };
 
diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
index 539885b458..9ff1bdb7cf 100644
--- a/include/hw/virtio/vhost-user-fs.h
+++ b/include/hw/virtio/vhost-user-fs.h
@@ -28,7 +28,6 @@ typedef struct {
     char *tag;
     uint16_t num_request_queues;
     uint16_t queue_size;
-    char *vhostfd;
 } VHostUserFSConf;
 
 typedef struct {
-- 
2.24.0

Re: [PATCH] vhost-user-fs: remove "vhostfd" property

Posted by Stefan Hajnoczi 4 years, 4 months ago

On Sat, Nov 16, 2019 at 03:20:16PM +0400, Marc-André Lureau wrote:
> The property doesn't make much sense for a vhost-user device.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/virtio/vhost-user-fs.c         | 1 -
>  include/hw/virtio/vhost-user-fs.h | 1 -
>  2 files changed, 2 deletions(-)

It was never implemented either :).

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH] vhost-user-fs: remove "vhostfd" property

Posted by Dr. David Alan Gilbert 4 years, 4 months ago

* Marc-André Lureau (marcandre.lureau@redhat.com) wrote:
> The property doesn't make much sense for a vhost-user device.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Queued for virtiofs

> ---
>  hw/virtio/vhost-user-fs.c         | 1 -
>  include/hw/virtio/vhost-user-fs.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c
> index f0df7f4746..ca0b7fc9de 100644
> --- a/hw/virtio/vhost-user-fs.c
> +++ b/hw/virtio/vhost-user-fs.c
> @@ -263,7 +263,6 @@ static Property vuf_properties[] = {
>      DEFINE_PROP_UINT16("num-request-queues", VHostUserFS,
>                         conf.num_request_queues, 1),
>      DEFINE_PROP_UINT16("queue-size", VHostUserFS, conf.queue_size, 128),
> -    DEFINE_PROP_STRING("vhostfd", VHostUserFS, conf.vhostfd),
>      DEFINE_PROP_END_OF_LIST(),
>  };
>  
> diff --git a/include/hw/virtio/vhost-user-fs.h b/include/hw/virtio/vhost-user-fs.h
> index 539885b458..9ff1bdb7cf 100644
> --- a/include/hw/virtio/vhost-user-fs.h
> +++ b/include/hw/virtio/vhost-user-fs.h
> @@ -28,7 +28,6 @@ typedef struct {
>      char *tag;
>      uint16_t num_request_queues;
>      uint16_t queue_size;
> -    char *vhostfd;
>  } VHostUserFSConf;
>  
>  typedef struct {
> -- 
> 2.24.0
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK