[v1] python/qemu: New accel module and improvements

[PATCH 0/4] python/qemu: New accel module and improvements

Wainer dos Santos Moschetta posted 4 patches 4 years, 5 months ago

Diff against v2 v3 v4
Download series mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191115180829.10275-1-wainersm@redhat.com

Maintainers: Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Cleber Rosa <crosa@redhat.com>

There is a newer version of this series

python/qemu/__init__.py | 20 +----------
python/qemu/accel.py    | 79 +++++++++++++++++++++++++++++++++++++++++
tests/vm/basevm.py      |  2 +-
3 files changed, 81 insertions(+), 20 deletions(-)
create mode 100644 python/qemu/accel.py

Expand all Fold all

[PATCH 0/4] python/qemu: New accel module and improvements

Posted by Wainer dos Santos Moschetta 4 years, 5 months ago

On commit abf0bf998dcb John Snow moved some code out of __init__.py
to machine.py. kvm_available() remained in though. So on patch 01
I continue his work by creating a home for that method (the new
'accel' module). Honestly I was unsure about whether move the code
to any existing module or make a new, but since I am adding more
methods related with accelerators then I thought they would 
deserve a module.

The patches 02-04 introduce new helpers and make improvements. Later
I intend to use those methods on the acceptance tests such as
to automatically set the accelerator in QEMUMachine VM via Avocado
tags, and skip the test if the accelerator is not available.

Git:
 - Tree: https://github.com/wainersm/qemu
 - Branch: python_accel

CI:
 - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/612382935
   Non-related fail due build timeout

Wainer dos Santos Moschetta (4):
  python/qemu: Move kvm_available() to its own module
  python/qemu: accel: Add list_accel() method
  python/qemu: accel: Strengthen kvm_available() checks
  python/qemu: accel: Add tcg_available() method

 python/qemu/__init__.py | 20 +----------
 python/qemu/accel.py    | 79 +++++++++++++++++++++++++++++++++++++++++
 tests/vm/basevm.py      |  2 +-
 3 files changed, 81 insertions(+), 20 deletions(-)
 create mode 100644 python/qemu/accel.py

-- 
2.18.1

Re: [PATCH 0/4] python/qemu: New accel module and improvements

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

On 11/15/19 7:08 PM, Wainer dos Santos Moschetta wrote:
> On commit abf0bf998dcb John Snow moved some code out of __init__.py
> to machine.py. kvm_available() remained in though. So on patch 01
> I continue his work by creating a home for that method (the new
> 'accel' module). Honestly I was unsure about whether move the code
> to any existing module or make a new, but since I am adding more
> methods related with accelerators then I thought they would
> deserve a module.
> 
> The patches 02-04 introduce new helpers and make improvements. Later
> I intend to use those methods on the acceptance tests such as
> to automatically set the accelerator in QEMUMachine VM via Avocado
> tags, and skip the test if the accelerator is not available.
> 
> Git:
>   - Tree: https://github.com/wainersm/qemu
>   - Branch: python_accel
> 
> CI:
>   - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/612382935
>     Non-related fail due build timeout
> 
> Wainer dos Santos Moschetta (4):
>    python/qemu: Move kvm_available() to its own module
>    python/qemu: accel: Add list_accel() method
>    python/qemu: accel: Strengthen kvm_available() checks
>    python/qemu: accel: Add tcg_available() method

No more comment that what Alex said, I'd move the logging import in 
patch #2 where you use LOG.
With Alex comment fixed:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>