iotests: Test failing mirror complete

[PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete

Max Reitz posted 5 patches 4 years, 5 months ago

Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191108123455.39445-1-mreitz@redhat.com

Maintainers: Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block.c                       | 47 ++++++++++--------
block/blkdebug.c              | 93 ++++++++++++++++++++++++++++++++++-
include/block/block.h         |  1 +
qapi/block-core.json          | 14 +++++-
tests/qemu-iotests/041        | 44 +++++++++++++++++
tests/qemu-iotests/041.out    |  4 +-
tests/qemu-iotests/iotests.py | 18 ++++---
7 files changed, 190 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete

Posted by Max Reitz 4 years, 5 months ago

Hi,

v3 of this series was this:

https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00868.html

In the meantime, I’ve merged the first patch, so the subject of the
series has changed.

In v4, I’ve tried to address Vladimir’s concern of how to map QAPI
BlockPermission values to BLK_PERM_* flags with the new patches 1 and 2,
and a minor change to patch 3:
- Patch 1: Added, this new function will translate QAPI BlockPermission
           values to BLK_PERM_* flags
- Patch 2: Added; we can make use of the new function in
           xdbg_graph_add_edge() to save some LoC
- Patch 3:
  - %s/4.2/5.0/
  - Let blkdebug_parse_perm_list() initialize *dest
  - Use bdrv_qapi_perm_to_blk_perm() to translate QAPI BlockPermission
    values instead of blindly assuming an x -> 2^x mapping


git-backport-diff against v3:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/5:[down] 'block: Add bdrv_qapi_perm_to_blk_perm()'
002/5:[down] 'block: Use bdrv_qapi_perm_to_blk_perm()'
003/5:[0008] [FC] 'blkdebug: Allow taking/unsharing permissions'
004/5:[----] [--] 'iotests: Add @error to wait_until_completed'
005/5:[----] [--] 'iotests: Add test for failing mirror complete'


Max Reitz (5):
  block: Add bdrv_qapi_perm_to_blk_perm()
  block: Use bdrv_qapi_perm_to_blk_perm()
  blkdebug: Allow taking/unsharing permissions
  iotests: Add @error to wait_until_completed
  iotests: Add test for failing mirror complete

 block.c                       | 47 ++++++++++--------
 block/blkdebug.c              | 93 ++++++++++++++++++++++++++++++++++-
 include/block/block.h         |  1 +
 qapi/block-core.json          | 14 +++++-
 tests/qemu-iotests/041        | 44 +++++++++++++++++
 tests/qemu-iotests/041.out    |  4 +-
 tests/qemu-iotests/iotests.py | 18 ++++---
 7 files changed, 190 insertions(+), 31 deletions(-)

-- 
2.23.0

Re: [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete

Posted by Max Reitz 4 years, 5 months ago

On 08.11.19 13:34, Max Reitz wrote:
> Hi,
> 
> v3 of this series was this:
> 
> https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00868.html
> 
> In the meantime, I’ve merged the first patch, so the subject of the
> series has changed.
> 
> In v4, I’ve tried to address Vladimir’s concern of how to map QAPI
> BlockPermission values to BLK_PERM_* flags with the new patches 1 and 2,
> and a minor change to patch 3:
> - Patch 1: Added, this new function will translate QAPI BlockPermission
>            values to BLK_PERM_* flags
> - Patch 2: Added; we can make use of the new function in
>            xdbg_graph_add_edge() to save some LoC
> - Patch 3:
>   - %s/4.2/5.0/
>   - Let blkdebug_parse_perm_list() initialize *dest
>   - Use bdrv_qapi_perm_to_blk_perm() to translate QAPI BlockPermission
>     values instead of blindly assuming an x -> 2^x mapping

Thanks for the review, applied to my block-next branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block-next

Max