[PATCH v3 00/12] linux-user sparc fixes

Richard Henderson posted 12 patches 6 days ago
Test asan passed
Test checkpatch failed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191106113318.10226-1-richard.henderson@linaro.org
Maintainers: Artyom Tarasenko <atar4qemu@gmail.com>, Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
linux-user/aarch64/target_cpu.h    |   7 +-
linux-user/alpha/target_cpu.h      |  16 ++++-
linux-user/arm/target_cpu.h        |   7 +-
linux-user/cris/target_cpu.h       |   7 +-
linux-user/hppa/target_cpu.h       |   7 +-
linux-user/i386/target_cpu.h       |   7 +-
linux-user/m68k/target_cpu.h       |   7 +-
linux-user/microblaze/target_cpu.h |   7 +-
linux-user/mips/target_cpu.h       |   7 +-
linux-user/nios2/target_cpu.h      |   7 +-
linux-user/openrisc/target_cpu.h   |   8 ++-
linux-user/ppc/target_cpu.h        |   7 +-
linux-user/riscv/target_cpu.h      |   7 +-
linux-user/s390x/target_cpu.h      |   7 +-
linux-user/sh4/target_cpu.h        |   7 +-
linux-user/sparc/target_cpu.h      |  64 ++++++++++++------
linux-user/tilegx/target_cpu.h     |   7 +-
linux-user/xtensa/target_cpu.h     |   8 ++-
target/sparc/cpu.h                 |  33 ++++++++++
linux-user/sparc/signal.c          | 100 ++++++++++-------------------
linux-user/syscall.c               |   6 +-
tests/tcg/multiarch/linux-test.c   |   3 +-
scripts/qemu-binfmt-conf.sh        |   8 ++-
23 files changed, 238 insertions(+), 106 deletions(-)

[PATCH v3 00/12] linux-user sparc fixes

Posted by Richard Henderson 6 days ago
Changes in v3:
  * Fix checkpatch errors in patches 5 and 8.
    There's lots more style errors left to clean up in
    these files, but this is enough for now.


r~


Richard Henderson (12):
  scripts/qemu-binfmt-conf: Update for sparc64
  tests/tcg/multiarch/linux-test: Fix error check for shmat
  target/sparc: Define an enumeration for accessing env->regwptr
  linux-user/sparc: Use WREG constants in sparc/target_cpu.h
  linux-user/sparc: Begin using WREG constants in sparc/signal.c
  linux-user/sparc: Use WREG_SP constant in sparc/signal.c
  linux-user/sparc: Fix WREG usage in setup_frame
  linux-user/sparc64: Fix target_signal_frame
  linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
  linux-user: Introduce cpu_clone_regs_parent
  linux-user/sparc: Fix cpu_clone_regs_*
  linux-user/alpha: Set r20 secondary return value

 linux-user/aarch64/target_cpu.h    |   7 +-
 linux-user/alpha/target_cpu.h      |  16 ++++-
 linux-user/arm/target_cpu.h        |   7 +-
 linux-user/cris/target_cpu.h       |   7 +-
 linux-user/hppa/target_cpu.h       |   7 +-
 linux-user/i386/target_cpu.h       |   7 +-
 linux-user/m68k/target_cpu.h       |   7 +-
 linux-user/microblaze/target_cpu.h |   7 +-
 linux-user/mips/target_cpu.h       |   7 +-
 linux-user/nios2/target_cpu.h      |   7 +-
 linux-user/openrisc/target_cpu.h   |   8 ++-
 linux-user/ppc/target_cpu.h        |   7 +-
 linux-user/riscv/target_cpu.h      |   7 +-
 linux-user/s390x/target_cpu.h      |   7 +-
 linux-user/sh4/target_cpu.h        |   7 +-
 linux-user/sparc/target_cpu.h      |  64 ++++++++++++------
 linux-user/tilegx/target_cpu.h     |   7 +-
 linux-user/xtensa/target_cpu.h     |   8 ++-
 target/sparc/cpu.h                 |  33 ++++++++++
 linux-user/sparc/signal.c          | 100 ++++++++++-------------------
 linux-user/syscall.c               |   6 +-
 tests/tcg/multiarch/linux-test.c   |   3 +-
 scripts/qemu-binfmt-conf.sh        |   8 ++-
 23 files changed, 238 insertions(+), 106 deletions(-)

-- 
2.17.1


Re: [PATCH v3 00/12] linux-user sparc fixes

Posted by no-reply@patchew.org 6 days ago
Patchew URL: https://patchew.org/QEMU/20191106113318.10226-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v3 00/12] linux-user sparc fixes
Type: series
Message-id: 20191106113318.10226-1-richard.henderson@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20191106130309.6737-1-jandryuk@gmail.com -> patchew/20191106130309.6737-1-jandryuk@gmail.com
 - [tag update]      patchew/20191106141424.27244-1-edgar.iglesias@gmail.com -> patchew/20191106141424.27244-1-edgar.iglesias@gmail.com
 * [new tag]         patchew/20191106145127.23700-1-marcel.apfelbaum@gmail.com -> patchew/20191106145127.23700-1-marcel.apfelbaum@gmail.com
Switched to a new branch 'test'
33486ee linux-user/alpha: Set r20 secondary return value
4c5f970 linux-user/sparc: Fix cpu_clone_regs_*
38c0642 linux-user: Introduce cpu_clone_regs_parent
8fd10b2 linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
1c6ebcb linux-user/sparc64: Fix target_signal_frame
b1257ef linux-user/sparc: Fix WREG usage in setup_frame
5f40252 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
2e7ffe6 linux-user/sparc: Begin using WREG constants in sparc/signal.c
b87f31db linux-user/sparc: Use WREG constants in sparc/target_cpu.h
08fdb43 target/sparc: Define an enumeration for accessing env->regwptr
7e876dd tests/tcg/multiarch/linux-test: Fix error check for shmat
4dae54d scripts/qemu-binfmt-conf: Update for sparc64

=== OUTPUT BEGIN ===
1/12 Checking commit 4dae54d6afb3 (scripts/qemu-binfmt-conf: Update for sparc64)
WARNING: line over 80 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:41:
+sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'

ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:42:
+sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 1 errors, 1 warnings, 20 lines checked

Patch 1/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/12 Checking commit 7e876dd91cb5 (tests/tcg/multiarch/linux-test: Fix error check for shmat)
3/12 Checking commit 08fdb4395231 (target/sparc: Define an enumeration for accessing env->regwptr)
4/12 Checking commit b87f31db831a (linux-user/sparc: Use WREG constants in sparc/target_cpu.h)
5/12 Checking commit 2e7ffe61c512 (linux-user/sparc: Begin using WREG constants in sparc/signal.c)
6/12 Checking commit 5f4025286e2c (linux-user/sparc: Use WREG_SP constant in sparc/signal.c)
7/12 Checking commit b1257efc7c6d (linux-user/sparc: Fix WREG usage in setup_frame)
8/12 Checking commit 1c6ebcb9654b (linux-user/sparc64: Fix target_signal_frame)
9/12 Checking commit 8fd10b272322 (linux-user: Rename cpu_clone_regs to cpu_clone_regs_child)
10/12 Checking commit 38c06429fb1e (linux-user: Introduce cpu_clone_regs_parent)
11/12 Checking commit 4c5f970a3c7a (linux-user/sparc: Fix cpu_clone_regs_*)
12/12 Checking commit 33486ee24e5c (linux-user/alpha: Set r20 secondary return value)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191106113318.10226-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH v3 00/12] linux-user sparc fixes

Posted by Laurent Vivier 6 days ago
Le 06/11/2019 à 15:58, no-reply@patchew.org a écrit :
> Patchew URL: https://patchew.org/QEMU/20191106113318.10226-1-richard.henderson@linaro.org/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PATCH v3 00/12] linux-user sparc fixes
> Type: series
> Message-id: 20191106113318.10226-1-richard.henderson@linaro.org
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  - [tag update]      patchew/20191106130309.6737-1-jandryuk@gmail.com -> patchew/20191106130309.6737-1-jandryuk@gmail.com
>  - [tag update]      patchew/20191106141424.27244-1-edgar.iglesias@gmail.com -> patchew/20191106141424.27244-1-edgar.iglesias@gmail.com
>  * [new tag]         patchew/20191106145127.23700-1-marcel.apfelbaum@gmail.com -> patchew/20191106145127.23700-1-marcel.apfelbaum@gmail.com
> Switched to a new branch 'test'
> 33486ee linux-user/alpha: Set r20 secondary return value
> 4c5f970 linux-user/sparc: Fix cpu_clone_regs_*
> 38c0642 linux-user: Introduce cpu_clone_regs_parent
> 8fd10b2 linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
> 1c6ebcb linux-user/sparc64: Fix target_signal_frame
> b1257ef linux-user/sparc: Fix WREG usage in setup_frame
> 5f40252 linux-user/sparc: Use WREG_SP constant in sparc/signal.c
> 2e7ffe6 linux-user/sparc: Begin using WREG constants in sparc/signal.c
> b87f31db linux-user/sparc: Use WREG constants in sparc/target_cpu.h
> 08fdb43 target/sparc: Define an enumeration for accessing env->regwptr
> 7e876dd tests/tcg/multiarch/linux-test: Fix error check for shmat
> 4dae54d scripts/qemu-binfmt-conf: Update for sparc64
> 
> === OUTPUT BEGIN ===
> 1/12 Checking commit 4dae54d6afb3 (scripts/qemu-binfmt-conf: Update for sparc64)
> WARNING: line over 80 characters
> #36: FILE: scripts/qemu-binfmt-conf.sh:41:
> +sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'
> 
> ERROR: line over 90 characters
> #37: FILE: scripts/qemu-binfmt-conf.sh:42:
> +sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
> 

All magic and mask are like this in scripts/qemu-binfmt-conf.sh, these
errors can be ignored.

Thanks,
Laurent


Re: [PATCH v3 00/12] linux-user sparc fixes

Posted by Laurent Vivier 6 days ago
Le 06/11/2019 à 12:33, Richard Henderson a écrit :
> Changes in v3:
>   * Fix checkpatch errors in patches 5 and 8.
>     There's lots more style errors left to clean up in
>     these files, but this is enough for now.

I've updated my pull request with this series in place of the previous one.

Thanks,
Laurent

> 
> r~
> 
> 
> Richard Henderson (12):
>   scripts/qemu-binfmt-conf: Update for sparc64
>   tests/tcg/multiarch/linux-test: Fix error check for shmat
>   target/sparc: Define an enumeration for accessing env->regwptr
>   linux-user/sparc: Use WREG constants in sparc/target_cpu.h
>   linux-user/sparc: Begin using WREG constants in sparc/signal.c
>   linux-user/sparc: Use WREG_SP constant in sparc/signal.c
>   linux-user/sparc: Fix WREG usage in setup_frame
>   linux-user/sparc64: Fix target_signal_frame
>   linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
>   linux-user: Introduce cpu_clone_regs_parent
>   linux-user/sparc: Fix cpu_clone_regs_*
>   linux-user/alpha: Set r20 secondary return value
> 
>  linux-user/aarch64/target_cpu.h    |   7 +-
>  linux-user/alpha/target_cpu.h      |  16 ++++-
>  linux-user/arm/target_cpu.h        |   7 +-
>  linux-user/cris/target_cpu.h       |   7 +-
>  linux-user/hppa/target_cpu.h       |   7 +-
>  linux-user/i386/target_cpu.h       |   7 +-
>  linux-user/m68k/target_cpu.h       |   7 +-
>  linux-user/microblaze/target_cpu.h |   7 +-
>  linux-user/mips/target_cpu.h       |   7 +-
>  linux-user/nios2/target_cpu.h      |   7 +-
>  linux-user/openrisc/target_cpu.h   |   8 ++-
>  linux-user/ppc/target_cpu.h        |   7 +-
>  linux-user/riscv/target_cpu.h      |   7 +-
>  linux-user/s390x/target_cpu.h      |   7 +-
>  linux-user/sh4/target_cpu.h        |   7 +-
>  linux-user/sparc/target_cpu.h      |  64 ++++++++++++------
>  linux-user/tilegx/target_cpu.h     |   7 +-
>  linux-user/xtensa/target_cpu.h     |   8 ++-
>  target/sparc/cpu.h                 |  33 ++++++++++
>  linux-user/sparc/signal.c          | 100 ++++++++++-------------------
>  linux-user/syscall.c               |   6 +-
>  tests/tcg/multiarch/linux-test.c   |   3 +-
>  scripts/qemu-binfmt-conf.sh        |   8 ++-
>  23 files changed, 238 insertions(+), 106 deletions(-)
>