disas/libvixl/vixl/invalset.h | 2 +- docs/interop/pr-helper.rst | 2 +- docs/specs/ppc-spapr-hotplug.txt | 2 +- docs/specs/ppc-xive.rst | 2 +- docs/specs/tpm.txt | 2 +- hw/misc/grlib_ahb_apb_pnp.c | 12 ++++++++++++ include/hw/xen/interface/io/blkif.h | 2 +- qom/object.c | 10 ++++------ scripts/dump-guest-memory.py | 2 +- 9 files changed, 23 insertions(+), 13 deletions(-)
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +0000) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-request for you to fetch changes up to a37a36a11b584e083b1c578f1d60e6e0f7878d5f: global: Squash 'the the' (2019-11-05 15:06:09 +0100) ---------------------------------------------------------------- Trivial fixes (20191105) ---------------------------------------------------------------- Dr. David Alan Gilbert (1): global: Squash 'the the' Greg Kurz (1): qom: Fix error message in object_class_property_add() Philippe Mathieu-Daudé (2): hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses disas/libvixl/vixl/invalset.h | 2 +- docs/interop/pr-helper.rst | 2 +- docs/specs/ppc-spapr-hotplug.txt | 2 +- docs/specs/ppc-xive.rst | 2 +- docs/specs/tpm.txt | 2 +- hw/misc/grlib_ahb_apb_pnp.c | 12 ++++++++++++ include/hw/xen/interface/io/blkif.h | 2 +- qom/object.c | 10 ++++------ scripts/dump-guest-memory.py | 2 +- 9 files changed, 23 insertions(+), 13 deletions(-) -- 2.21.0
Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] Trivial branch patches Type: series Message-id: 20191105144247.10301-1-laurent@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 85ac453 global: Squash 'the the' 9dd7da4 qom: Fix error message in object_class_property_add() 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers === OUTPUT BEGIN === 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add()) WARNING: line over 80 characters #31: FILE: qom/object.c:1109: + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", WARNING: line over 80 characters #43: FILE: qom/object.c:1141: + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", total: 0 errors, 2 warnings, 22 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') ERROR: do not use C99 // comments #26: FILE: disas/libvixl/vixl/invalset.h:105: + // Note that this does not mean the backing storage is empty: it can still total: 1 errors, 0 warnings, 56 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Greg, Dave, could you fix that? Thanks, Laurent Le 05/11/2019 à 16:48, no-reply@patchew.org a écrit : > Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PULL 0/4] Trivial branch patches > Type: series > Message-id: 20191105144247.10301-1-laurent@vivier.eu > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Switched to a new branch 'test' > 85ac453 global: Squash 'the the' > 9dd7da4 qom: Fix error message in object_class_property_add() > 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses > bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers > > === OUTPUT BEGIN === > 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) > 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) > 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add()) > WARNING: line over 80 characters > #31: FILE: qom/object.c:1109: > + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", > > WARNING: line over 80 characters > #43: FILE: qom/object.c:1141: > + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", > > total: 0 errors, 2 warnings, 22 lines checked > > Patch 3/4 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') > ERROR: do not use C99 // comments > #26: FILE: disas/libvixl/vixl/invalset.h:105: > + // Note that this does not mean the backing storage is empty: it can still > > total: 1 errors, 0 warnings, 56 lines checked > > Patch 4/4 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
On Tue, 5 Nov 2019 16:56:11 +0100 Laurent Vivier <laurent@vivier.eu> wrote: > Greg, Dave, > > could you fix that? > > Thanks, > Laurent > > Le 05/11/2019 à 16:48, no-reply@patchew.org a écrit : > > Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Subject: [PULL 0/4] Trivial branch patches > > Type: series > > Message-id: 20191105144247.10301-1-laurent@vivier.eu > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > Switched to a new branch 'test' > > 85ac453 global: Squash 'the the' > > 9dd7da4 qom: Fix error message in object_class_property_add() > > 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses > > bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers > > > > === OUTPUT BEGIN === > > 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) > > 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) > > 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add()) > > WARNING: line over 80 characters > > #31: FILE: qom/object.c:1109: > > + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", > > > > WARNING: line over 80 characters > > #43: FILE: qom/object.c:1141: > > + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", > > As mentioned in the changelog, this is deliberate. AFAIK better grep-ability has precedence over the 80 characters rule when it comes to error messages. Maybe we should teach checkpatch about that ? Cheers, -- Greg > > total: 0 errors, 2 warnings, 22 lines checked > > > > Patch 3/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') > > ERROR: do not use C99 // comments > > #26: FILE: disas/libvixl/vixl/invalset.h:105: > > + // Note that this does not mean the backing storage is empty: it can still > > > > total: 1 errors, 0 warnings, 56 lines checked > > > > Patch 4/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > > > === OUTPUT END === > > > > Test command exited with code: 1 > > > > > > The full log is available at > > http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testing.checkpatch/?type=message. > > --- > > Email generated automatically by Patchew [https://patchew.org/]. > > Please send your feedback to patchew-devel@redhat.com > > >
* Laurent Vivier (laurent@vivier.eu) wrote: > Greg, Dave, > > could you fix that? > > Thanks, > Laurent > > Le 05/11/2019 à 16:48, no-reply@patchew.org a écrit : > > Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more information: > > > > Subject: [PULL 0/4] Trivial branch patches > > Type: series > > Message-id: 20191105144247.10301-1-laurent@vivier.eu > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > git rev-parse base > /dev/null || exit 0 > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > git config --local diff.algorithm histogram > > ./scripts/checkpatch.pl --mailback base.. > > === TEST SCRIPT END === > > > > Switched to a new branch 'test' > > 85ac453 global: Squash 'the the' > > 9dd7da4 qom: Fix error message in object_class_property_add() > > 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses > > bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers > > > > === OUTPUT BEGIN === > > 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) > > 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) > > 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add()) > > WARNING: line over 80 characters > > #31: FILE: qom/object.c:1109: > > + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", > > > > WARNING: line over 80 characters > > #43: FILE: qom/object.c:1141: > > + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", > > > > total: 0 errors, 2 warnings, 22 lines checked > > > > Patch 3/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') > > ERROR: do not use C99 // comments > > #26: FILE: disas/libvixl/vixl/invalset.h:105: > > + // Note that this does not mean the backing storage is empty: it can still That one is a false positive; libvixl is written in C++ ! Dave > > total: 1 errors, 0 warnings, 56 lines checked > > > > Patch 4/4 has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > > > === OUTPUT END === > > > > Test command exited with code: 1 > > > > > > The full log is available at > > http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testing.checkpatch/?type=message. > > --- > > Email generated automatically by Patchew [https://patchew.org/]. > > Please send your feedback to patchew-devel@redhat.com > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Le 05/11/2019 à 17:03, Dr. David Alan Gilbert a écrit : > * Laurent Vivier (laurent@vivier.eu) wrote: >> Greg, Dave, >> >> could you fix that? >> >> Thanks, >> Laurent >> >> Le 05/11/2019 à 16:48, no-reply@patchew.org a écrit : >>> Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ >>> >>> >>> >>> Hi, >>> >>> This series seems to have some coding style problems. See output below for >>> more information: >>> >>> Subject: [PULL 0/4] Trivial branch patches >>> Type: series >>> Message-id: 20191105144247.10301-1-laurent@vivier.eu >>> >>> === TEST SCRIPT BEGIN === >>> #!/bin/bash >>> git rev-parse base > /dev/null || exit 0 >>> git config --local diff.renamelimit 0 >>> git config --local diff.renames True >>> git config --local diff.algorithm histogram >>> ./scripts/checkpatch.pl --mailback base.. >>> === TEST SCRIPT END === >>> >>> Switched to a new branch 'test' >>> 85ac453 global: Squash 'the the' >>> 9dd7da4 qom: Fix error message in object_class_property_add() >>> 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses >>> bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers >>> >>> === OUTPUT BEGIN === >>> 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) >>> 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) >>> 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add()) >>> WARNING: line over 80 characters >>> #31: FILE: qom/object.c:1109: >>> + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", >>> >>> WARNING: line over 80 characters >>> #43: FILE: qom/object.c:1141: >>> + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", >>> >>> total: 0 errors, 2 warnings, 22 lines checked >>> >>> Patch 3/4 has style problems, please review. If any of these errors >>> are false positives report them to the maintainer, see >>> CHECKPATCH in MAINTAINERS. >>> 4/4 Checking commit 85ac453d1520 (global: Squash 'the the') >>> ERROR: do not use C99 // comments >>> #26: FILE: disas/libvixl/vixl/invalset.h:105: >>> + // Note that this does not mean the backing storage is empty: it can still > > That one is a false positive; libvixl is written in C++ ! OK, thank you. Laurent
Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] Trivial branch patches Type: series Message-id: 20191105144247.10301-1-laurent@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 0102c79 global: Squash 'the the' 9c583b0 qom: Fix error message in object_class_property_add() 299eefd hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses c931231 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers === OUTPUT BEGIN === 1/4 Checking commit c93123187df2 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers) 2/4 Checking commit 299eefd37522 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses) 3/4 Checking commit 9c583b04fdb1 (qom: Fix error message in object_class_property_add()) WARNING: line over 80 characters #31: FILE: qom/object.c:1109: + error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')", WARNING: line over 80 characters #43: FILE: qom/object.c:1141: + error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')", total: 0 errors, 2 warnings, 22 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 0102c79a3068 (global: Squash 'the the') ERROR: do not use C99 // comments #26: FILE: disas/libvixl/vixl/invalset.h:105: + // Note that this does not mean the backing storage is empty: it can still total: 1 errors, 0 warnings, 56 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191105144247.10301-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.