qemu-deprecated.texi | 5 + include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h | 1 + include/sysemu/sysemu.h | 4 + bootdevice.c | 147 +++++++-- hw/block/virtio-blk.c | 6 + hw/ide/qdev.c | 10 +- hw/nvram/fw_cfg.c | 14 +- hw/scsi/scsi-bus.c | 16 + hw/scsi/scsi-disk.c | 12 + tests/hd-geo-test.c | 551 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/qemu-iotests/051.pc.out | 6 +- 13 files changed, 753 insertions(+), 43 deletions(-)
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- John Snow (1): IDE: deprecate ide-drive Sam Eiderman (8): block: Refactor macros - fix tabbing block: Support providing LCHS from user bootdevice: Add interface to gather LCHS scsi: Propagate unrealize() callback to scsi-hd bootdevice: Gather LCHS from all relevant devices bootdevice: Refactor get_boot_devices_list bootdevice: FW_CFG interface for LCHS values hd-geo-test: Add tests for lchs override qemu-deprecated.texi | 5 + include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h | 1 + include/sysemu/sysemu.h | 4 + bootdevice.c | 147 +++++++-- hw/block/virtio-blk.c | 6 + hw/ide/qdev.c | 10 +- hw/nvram/fw_cfg.c | 14 +- hw/scsi/scsi-bus.c | 16 + hw/scsi/scsi-disk.c | 12 + tests/hd-geo-test.c | 551 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/qemu-iotests/051.pc.out | 6 +- 13 files changed, 753 insertions(+), 43 deletions(-) -- 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > > hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > > ---------------------------------------------------------------- > Pull request > Hi -- this passed the merge tests but it looks like you forgot to add your signed-off by line as the submaintainer to Sam's patches. Could you fix that up and resend, please? thanks -- PMM -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: >> >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) >> >> ---------------------------------------------------------------- >> Pull request >> > > Hi -- this passed the merge tests but it looks like you forgot > to add your signed-off by line as the submaintainer to Sam's > patches. Could you fix that up and resend, please? > > thanks > -- PMM > Haha. I re-applied them to grab Phil's SOBs and that dropped mine. OK, re-spinning. (Note to self: add a check to git-publish --pull that looks for my SOB.) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: >> >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) >> >> ---------------------------------------------------------------- >> Pull request >> > > Hi -- this passed the merge tests but it looks like you forgot > to add your signed-off by line as the submaintainer to Sam's > patches. Could you fix that up and resend, please? > > thanks > -- PMM > I bit myself twice with this now: adding --signoff to a pull request signs the messages that get sent to list, but not the ones that get staged. Could always be a bug in my local copy, but I'm documenting it on the list, in case I don't get time to look at this in the next 24h. --js
On Thu, Oct 31, 2019 at 11:54:42AM -0400, John Snow wrote: > On 10/31/19 11:02 AM, Peter Maydell wrote: > > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: > >> > >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > >> > >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) > >> > >> are available in the Git repository at: > >> > >> https://github.com/jnsnow/qemu.git tags/ide-pull-request > >> > >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > >> > >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > >> > >> ---------------------------------------------------------------- > >> Pull request > >> > > > > Hi -- this passed the merge tests but it looks like you forgot > > to add your signed-off by line as the submaintainer to Sam's > > patches. Could you fix that up and resend, please? > > > > thanks > > -- PMM > > > > I bit myself twice with this now: adding --signoff to a pull request > signs the messages that get sent to list, but not the ones that get staged. > > Could always be a bug in my local copy, but I'm documenting it on the > list, in case I don't get time to look at this in the next 24h. Reported on GitHub, so we don't forget to look at it: https://github.com/stefanha/git-publish/issues/76 -- Eduardo
On Thu, Oct 31, 2019 at 5:07 PM John Snow <jsnow@redhat.com> wrote: > On 10/31/19 11:02 AM, Peter Maydell wrote: > > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: > >> > >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > >> > >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) > >> > >> are available in the Git repository at: > >> > >> https://github.com/jnsnow/qemu.git tags/ide-pull-request > >> > >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > >> > >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > >> > >> ---------------------------------------------------------------- > >> Pull request > >> > > > > Hi -- this passed the merge tests but it looks like you forgot > > to add your signed-off by line as the submaintainer to Sam's > > patches. Could you fix that up and resend, please? > > > > thanks > > -- PMM > > > > I bit myself twice with this now: adding --signoff to a pull request > signs the messages that get sent to list, but not the ones that get staged. > > Could always be a bug in my local copy, but I'm documenting it on the > list, in case I don't get time to look at this in the next 24h. Do you mean Signed-off-by is only added to emails that are sent and not to the actual commits in your repo? This is how git-format-patch(1) --signoff works. git-publish does not modify local commits either. Some people would probably be surprised if git-publish modified their commit history. I'm not sure what the best solution here is, aside from introducing a separate signoff option called --apply-signoff or similar so there is no confusion. Stefan
On Tue, Nov 05, 2019 at 09:17:42PM +0100, Stefan Hajnoczi wrote: > On Thu, Oct 31, 2019 at 5:07 PM John Snow <jsnow@redhat.com> wrote: > > On 10/31/19 11:02 AM, Peter Maydell wrote: > > > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: > > >> > > >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > >> > > >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) > > >> > > >> are available in the Git repository at: > > >> > > >> https://github.com/jnsnow/qemu.git tags/ide-pull-request > > >> > > >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > > >> > > >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > > >> > > >> ---------------------------------------------------------------- > > >> Pull request > > >> > > > > > > Hi -- this passed the merge tests but it looks like you forgot > > > to add your signed-off by line as the submaintainer to Sam's > > > patches. Could you fix that up and resend, please? > > > > > > thanks > > > -- PMM > > > > > > > I bit myself twice with this now: adding --signoff to a pull request > > signs the messages that get sent to list, but not the ones that get staged. > > > > Could always be a bug in my local copy, but I'm documenting it on the > > list, in case I don't get time to look at this in the next 24h. > > Do you mean Signed-off-by is only added to emails that are sent and > not to the actual commits in your repo? > > This is how git-format-patch(1) --signoff works. git-publish does not > modify local commits either. > > Some people would probably be surprised if git-publish modified their > commit history. > > I'm not sure what the best solution here is, aside from introducing a > separate signoff option called --apply-signoff or similar so there is > no confusion. I would make git-publish error out if --signoff and --pull-request are used simultaneously. I can't think of a justification for having the email contents not match the git tag contents in a pull request. -- Eduardo
On Tue, Nov 5, 2019 at 9:22 PM Eduardo Habkost <ehabkost@redhat.com> wrote: > On Tue, Nov 05, 2019 at 09:17:42PM +0100, Stefan Hajnoczi wrote: > > On Thu, Oct 31, 2019 at 5:07 PM John Snow <jsnow@redhat.com> wrote: > > > On 10/31/19 11:02 AM, Peter Maydell wrote: > > > > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote: > > > >> > > > >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > > >> > > > >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) > > > >> > > > >> are available in the Git repository at: > > > >> > > > >> https://github.com/jnsnow/qemu.git tags/ide-pull-request > > > >> > > > >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > > > >> > > > >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > > > >> > > > >> ---------------------------------------------------------------- > > > >> Pull request > > > >> > > > > > > > > Hi -- this passed the merge tests but it looks like you forgot > > > > to add your signed-off by line as the submaintainer to Sam's > > > > patches. Could you fix that up and resend, please? > > > > > > > > thanks > > > > -- PMM > > > > > > > > > > I bit myself twice with this now: adding --signoff to a pull request > > > signs the messages that get sent to list, but not the ones that get staged. > > > > > > Could always be a bug in my local copy, but I'm documenting it on the > > > list, in case I don't get time to look at this in the next 24h. > > > > Do you mean Signed-off-by is only added to emails that are sent and > > not to the actual commits in your repo? > > > > This is how git-format-patch(1) --signoff works. git-publish does not > > modify local commits either. > > > > Some people would probably be surprised if git-publish modified their > > commit history. > > > > I'm not sure what the best solution here is, aside from introducing a > > separate signoff option called --apply-signoff or similar so there is > > no confusion. > > I would make git-publish error out if --signoff and > --pull-request are used simultaneously. I can't think of a > justification for having the email contents not match the git tag > contents in a pull request. Sounds good! Stefan
Patchew URL: https://patchew.org/QEMU/20191031105904.12194-1-jsnow@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [libvirt] [PULL 0/9] Ide patches
Type: series
Message-id: 20191031105904.12194-1-jsnow@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
d278ccf hd-geo-test: Add tests for lchs override
28807d7 bootdevice: FW_CFG interface for LCHS values
11f27f1 bootdevice: Refactor get_boot_devices_list
e032fef bootdevice: Gather LCHS from all relevant devices
74eb334 scsi: Propagate unrealize() callback to scsi-hd
e211495 bootdevice: Add interface to gather LCHS
a683977 block: Support providing LCHS from user
071ac63 block: Refactor macros - fix tabbing
90e6789 IDE: deprecate ide-drive
=== OUTPUT BEGIN ===
1/9 Checking commit 90e67898e3b9 (IDE: deprecate ide-drive)
2/9 Checking commit 071ac63ed092 (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
total: 1 errors, 0 warnings, 37 lines checked
Patch 2/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit a68397755180 (block: Support providing LCHS from user)
4/9 Checking commit e21149531919 (bootdevice: Add interface to gather LCHS)
5/9 Checking commit 74eb33489f71 (scsi: Propagate unrealize() callback to scsi-hd)
6/9 Checking commit e032fefe3098 (bootdevice: Gather LCHS from all relevant devices)
7/9 Checking commit 11f27f1f9e10 (bootdevice: Refactor get_boot_devices_list)
8/9 Checking commit 28807d78bb01 (bootdevice: FW_CFG interface for LCHS values)
9/9 Checking commit d278ccfd1965 (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#607: FILE: tests/hd-geo-test.c:965:
+ "skipping hd-geo/override/* tests");
total: 0 errors, 1 warnings, 578 lines checked
Patch 9/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191031105904.12194-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.