Crypto luks patches

[PULL 0/4] Crypto luks patches

Daniel P. Berrangé posted 4 patches 4 years, 5 months ago

Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191028154914.84821-1-berrange@redhat.com

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>

configure                       | 40 ++++++++++++++
crypto/Makefile.objs            |  2 +-
crypto/cipher-gcrypt.c          | 97 ++++++++++++++++++++++-----------
crypto/cipher-nettle.c          | 18 ++++++
tests/Makefile.include          |  2 +-
tests/benchmark-crypto-cipher.c | 39 ++++++++-----
tests/benchmark-crypto-hash.c   | 17 +++---
7 files changed, 159 insertions(+), 56 deletions(-)

Expand all Fold all

[PULL 0/4] Crypto luks patches

Posted by Daniel P. Berrangé 4 years, 5 months ago

The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d:

  Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100)

are available in the Git repository at:

  https://github.com/berrange/qemu tags/crypto-luks-pull-request

for you to fetch changes up to dc2207af2de162005f7e9e534850d07232290cee:

  crypto: add support for nettle's native XTS impl (2019-10-28 16:45:07 +0100)

----------------------------------------------------------------
crypto: improve performance of ciphers in XTS mode

Currently QEMU uses its own XTS cipher mode, however, this has
relatively poor performance.

Gcrypt now includes its own XTS cipher which is at least x2 faster than
what we get with QEMU's on Fedora/RHEL hosts. With gcrypt git master, a
further x5-6 speed up is seen.

This is essential for QEMU's LUKS performance to be viable.

----------------------------------------------------------------

Daniel P. Berrangé (4):
  tests: allow filtering crypto cipher benchmark tests
  tests: benchmark crypto with fixed data size, not time period
  crypto: add support for gcrypt's native XTS impl
  crypto: add support for nettle's native XTS impl

 configure                       | 40 ++++++++++++++
 crypto/Makefile.objs            |  2 +-
 crypto/cipher-gcrypt.c          | 97 ++++++++++++++++++++++-----------
 crypto/cipher-nettle.c          | 18 ++++++
 tests/Makefile.include          |  2 +-
 tests/benchmark-crypto-cipher.c | 39 ++++++++-----
 tests/benchmark-crypto-hash.c   | 17 +++---
 7 files changed, 159 insertions(+), 56 deletions(-)

-- 
2.23.0

Re: [PULL 0/4] Crypto luks patches

Posted by Peter Maydell 4 years, 5 months ago

On Mon, 28 Oct 2019 at 15:58, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d:
>
>   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26 10:13:48 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/berrange/qemu tags/crypto-luks-pull-request
>
> for you to fetch changes up to dc2207af2de162005f7e9e534850d07232290cee:
>
>   crypto: add support for nettle's native XTS impl (2019-10-28 16:45:07 +0100)
>
> ----------------------------------------------------------------
> crypto: improve performance of ciphers in XTS mode
>
> Currently QEMU uses its own XTS cipher mode, however, this has
> relatively poor performance.
>
> Gcrypt now includes its own XTS cipher which is at least x2 faster than
> what we get with QEMU's on Fedora/RHEL hosts. With gcrypt git master, a
> further x5-6 speed up is seen.
>
> This is essential for QEMU's LUKS performance to be viable.
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM