Since 2008 the tcg/LICENSE file has not changed: it claims that
everything under tcg/ is BSD-licensed.

This is not true and hasn't been true for years: in 2013 we
accepted the tcg/aarch64 target code under a GPLv2-or-later
license statement. We also have generic vector optimisation
code under the LGPL2.1-or-later, and the TCI backend is
GPLv2-or-later. Further, many of the files are not BSD
licensed but MIT licensed.

We don't really consider the tcg subdirectory to be a distinct
part of QEMU anyway.

This patchset adds explicit licensing/copyright comments to
the three files which were missing them, removes the
inaccurate tcg/LICENSE file, and updates the top-level
LICENSE file to be more accurate about the current state
of the licenses used in the code in tcg/.

If we want a policy that tcg/ code has a restricted
permitted set of licenses, then we really need to have
this enforced by checkpatch -- history demonstrates that
just writing it in tcg/LICENSE does not prevent code under
other licenses getting in. In the v1 email thread nobody
seemed to be very strongly arguing for this, though, and
at this point we would need to make an active effort to
track down contributors and get relicensing statements.
If anybody wants to push that effort now would be a good
time to volunteer :-)

Note on the licensing for the tcg-target.opc.h files:
 * I've used the same license as the rest of the relevant
   backend, which is to say GPL2-or-later for tcg/aarch64
   and MIT for tcg/i386 and tcg/ppc.
 * In all 3 cases, the only people who've made contributions
   to the files are Richard Henderson and (for aarch64) Alex Bennée

Richard, Alex -- an acked-by for the relevant patches would
be nice (or if you intended a different license for the
contributions than I have assumed please say so!)

v1->v2 changes:
 * note the presence of MIT licensed code as well
 * 3 new patches adding copyright/licensing to files
   that were missing it

thanks
-- PMM

Peter Maydell (4):
  tcg/aarch64/tcg-target.opc.h: Add copyright/license
  tcg/i386/tcg-target.opc.h: Add copyright/license
  tcg/ppc/tcg-target.opc.h: Add copyright/license
  tcg/LICENSE: Remove out of date claim about TCG subdirectory licensing

 tcg/aarch64/tcg-target.opc.h | 15 ++++++++++++---
 tcg/i386/tcg-target.opc.h    | 28 +++++++++++++++++++++++++---
 tcg/ppc/tcg-target.opc.h     | 20 ++++++++++++++++++++
 LICENSE                      |  5 +++--
 tcg/LICENSE                  |  3 ---
 5 files changed, 60 insertions(+), 11 deletions(-)
 delete mode 100644 tcg/LICENSE

-- 
2.20.1

On 25.10.19 17:58, Peter Maydell wrote:
> Since 2008 the tcg/LICENSE file has not changed: it claims that
> everything under tcg/ is BSD-licensed.
>
> This is not true and hasn't been true for years: in 2013 we
> accepted the tcg/aarch64 target code under a GPLv2-or-later
> license statement. We also have generic vector optimisation
> code under the LGPL2.1-or-later, and the TCI backend is
> GPLv2-or-later. Further, many of the files are not BSD
> licensed but MIT licensed.
>
> We don't really consider the tcg subdirectory to be a distinct
> part of QEMU anyway.
>
> This patchset adds explicit licensing/copyright comments to
> the three files which were missing them, removes the
> inaccurate tcg/LICENSE file, and updates the top-level
> LICENSE file to be more accurate about the current state
> of the licenses used in the code in tcg/.
>
> If we want a policy that tcg/ code has a restricted
> permitted set of licenses, then we really need to have
> this enforced by checkpatch -- history demonstrates that
> just writing it in tcg/LICENSE does not prevent code under
> other licenses getting in. In the v1 email thread nobody
> seemed to be very strongly arguing for this, though, and
> at this point we would need to make an active effort to
> track down contributors and get relicensing statements.
> If anybody wants to push that effort now would be a good
> time to volunteer :-)
>
> Note on the licensing for the tcg-target.opc.h files:
>   * I've used the same license as the rest of the relevant
>     backend, which is to say GPL2-or-later for tcg/aarch64
>     and MIT for tcg/i386 and tcg/ppc.
>   * In all 3 cases, the only people who've made contributions
>     to the files are Richard Henderson and (for aarch64) Alex Bennée
>
> Richard, Alex -- an acked-by for the relevant patches would
> be nice (or if you intended a different license for the
> contributions than I have assumed please say so!)


Thanks for cleaning up the license mess :)

Reviewed-by: Alexander Graf <agraf@csgraf.de>

Alex

On 10/25/19 5:58 PM, Peter Maydell wrote:
> Since 2008 the tcg/LICENSE file has not changed: it claims that
> everything under tcg/ is BSD-licensed.
> 
> This is not true and hasn't been true for years: in 2013 we
> accepted the tcg/aarch64 target code under a GPLv2-or-later
> license statement. We also have generic vector optimisation
> code under the LGPL2.1-or-later, and the TCI backend is
> GPLv2-or-later. Further, many of the files are not BSD
> licensed but MIT licensed.
> 
> We don't really consider the tcg subdirectory to be a distinct
> part of QEMU anyway.
> 
> This patchset adds explicit licensing/copyright comments to
> the three files which were missing them, removes the
> inaccurate tcg/LICENSE file, and updates the top-level
> LICENSE file to be more accurate about the current state
> of the licenses used in the code in tcg/.
> 
> If we want a policy that tcg/ code has a restricted
> permitted set of licenses, then we really need to have
> this enforced by checkpatch -- history demonstrates that
> just writing it in tcg/LICENSE does not prevent code under
> other licenses getting in. In the v1 email thread nobody
> seemed to be very strongly arguing for this, though, and
> at this point we would need to make an active effort to
> track down contributors and get relicensing statements.
> If anybody wants to push that effort now would be a good
> time to volunteer :-)
> 
> Note on the licensing for the tcg-target.opc.h files:
>  * I've used the same license as the rest of the relevant
>    backend, which is to say GPL2-or-later for tcg/aarch64
>    and MIT for tcg/i386 and tcg/ppc.
>  * In all 3 cases, the only people who've made contributions
>    to the files are Richard Henderson and (for aarch64) Alex Bennée
> 
> Richard, Alex -- an acked-by for the relevant patches would
> be nice (or if you intended a different license for the
> contributions than I have assumed please say so!)
> 
> v1->v2 changes:
>  * note the presence of MIT licensed code as well
>  * 3 new patches adding copyright/licensing to files
>    that were missing it
> 
> thanks
> -- PMM
> 
> Peter Maydell (4):
>   tcg/aarch64/tcg-target.opc.h: Add copyright/license
>   tcg/i386/tcg-target.opc.h: Add copyright/license
>   tcg/ppc/tcg-target.opc.h: Add copyright/license
>   tcg/LICENSE: Remove out of date claim about TCG subdirectory licensing

Queued.


r~

On 10/25/19 11:58 AM, Peter Maydell wrote:
> Since 2008 the tcg/LICENSE file has not changed: it claims that
> everything under tcg/ is BSD-licensed.
> 
> This is not true and hasn't been true for years: in 2013 we
> accepted the tcg/aarch64 target code under a GPLv2-or-later
> license statement. We also have generic vector optimisation
> code under the LGPL2.1-or-later, and the TCI backend is
> GPLv2-or-later. Further, many of the files are not BSD
> licensed but MIT licensed.
> 
> We don't really consider the tcg subdirectory to be a distinct
> part of QEMU anyway.
> 
> This patchset adds explicit licensing/copyright comments to
> the three files which were missing them, removes the
> inaccurate tcg/LICENSE file, and updates the top-level
> LICENSE file to be more accurate about the current state
> of the licenses used in the code in tcg/.
> 
> If we want a policy that tcg/ code has a restricted
> permitted set of licenses, then we really need to have
> this enforced by checkpatch -- history demonstrates that
> just writing it in tcg/LICENSE does not prevent code under
> other licenses getting in. In the v1 email thread nobody
> seemed to be very strongly arguing for this, though, and
> at this point we would need to make an active effort to
> track down contributors and get relicensing statements.
> If anybody wants to push that effort now would be a good
> time to volunteer :-)
> 
> Note on the licensing for the tcg-target.opc.h files:
>  * I've used the same license as the rest of the relevant
>    backend, which is to say GPL2-or-later for tcg/aarch64
>    and MIT for tcg/i386 and tcg/ppc.
>  * In all 3 cases, the only people who've made contributions
>    to the files are Richard Henderson and (for aarch64) Alex Bennée
> 
> Richard, Alex -- an acked-by for the relevant patches would
> be nice (or if you intended a different license for the
> contributions than I have assumed please say so!)

No, I had no intention to put things under a different license.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

for the lot.  Since I'm having to re-spin the last tcg pull for a win32
failure, I'll include this as well.


r~