The following changes since commit bad76ac319556dab2497429d473b49a237672e1c:

Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-10-25 14:17:08 +0100)

https://github.com/rth7680/qemu.git tags/pull-tcg-20191025

for you to fetch changes up to 0ed1bfb046b740b70eed2cf3581e01768703b185:

translate-all: Remove tb_alloc (2019-10-25 10:15:25 -0400)

Improvements for TARGET_PAGE_BITS_VARY

Fix for TCI ld16u_i64.

Fix for segv on icount execute from i/o memory.

Two misc cleanups.

Alex Bennée (1):

cputlb: ensure _cmmu helper functions follow the naming standard

Clement Deschamps (1):

translate-all: fix uninitialized tb->orig_tb

Richard Henderson (8):

exec: Split out variable page size support to exec-vary.c

configure: Detect compiler support for __attribute__((alias))

exec: Use const alias for TARGET_PAGE_BITS_VARY

exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG

exec: Promote TARGET_PAGE_MASK to target_long

exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY

cputlb: Fix tlb_vaddr_to_host

translate-all: Remove tb_alloc

Stefan Weil (1):

tci: Add implementation for INDEX_op_ld16u_i64

The next patch will play a trick with "const" that will

confuse the compiler about the uses of target_page_bits

within exec.c. Moving everything to a new file prevents

this confusion.

No functional change so far.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Makefile.target | 2 +-

include/qemu-common.h | 6 +++++

exec-vary.c | 57 +++++++++++++++++++++++++++++++++++++++++++

exec.c | 34 --------------------------

4 files changed, 64 insertions(+), 35 deletions(-)

create mode 100644 exec-vary.c

diff --git a/Makefile.target b/Makefile.target

--- a/Makefile.target

+++ b/Makefile.target

@@ -XXX,XX +XXX,XX @@ obj-y += trace/

#########################################################

# cpu emulator library

-obj-y += exec.o

+obj-y += exec.o exec-vary.o

obj-y += accel/

obj-$(CONFIG_TCG) += tcg/tcg.o tcg/tcg-op.o tcg/tcg-op-vec.o tcg/tcg-op-gvec.o

obj-$(CONFIG_TCG) += tcg/tcg-common.o tcg/optimize.o

diff --git a/include/qemu-common.h b/include/qemu-common.h

index XXXXXXX..XXXXXXX 100644

--- a/include/qemu-common.h

+++ b/include/qemu-common.h

@@ -XXX,XX +XXX,XX @@ void cpu_exec_step_atomic(CPUState *cpu);

*/

bool set_preferred_target_page_bits(int bits);

+/**

+ * finalize_target_page_bits:

+ * Commit the final value set by set_preferred_target_page_bits.

+ */

+void finalize_target_page_bits(void);

+

/**

* Sends a (part of) iovec down a socket, yielding when the socket is full, or

* Receives data into a (part of) iovec from a socket,

diff --git a/exec-vary.c b/exec-vary.c

new file mode 100644

index XXXXXXX..XXXXXXX

--- /dev/null

+++ b/exec-vary.c

@@ -XXX,XX +XXX,XX @@

+/*

+ * Variable page size handling

+ *

+ * Copyright (c) 2003 Fabrice Bellard

+ *

+ * This library is free software; you can redistribute it and/or

+ * modify it under the terms of the GNU Lesser General Public

+ * License as published by the Free Software Foundation; either

+ * version 2 of the License, or (at your option) any later version.

+ *

+ * This library is distributed in the hope that it will be useful,

+ * but WITHOUT ANY WARRANTY; without even the implied warranty of

+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

+ * Lesser General Public License for more details.

+ *

+ * You should have received a copy of the GNU Lesser General Public

+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.

+ */

+

+#include "qemu/osdep.h"

+#include "qemu-common.h"

+#include "exec/exec-all.h"

+

+#ifdef TARGET_PAGE_BITS_VARY

+int target_page_bits;

+bool target_page_bits_decided;

+#endif

+

+bool set_preferred_target_page_bits(int bits)

+ /*

+ * The target page size is the lowest common denominator for all

+ * the CPUs in the system, so we can only make it smaller, never

+ * larger. And we can't make it smaller once we've committed to

+ * a particular size.

+ */

+#ifdef TARGET_PAGE_BITS_VARY

+ assert(bits >= TARGET_PAGE_BITS_MIN);

+ if (target_page_bits == 0 || target_page_bits > bits) {

+ if (target_page_bits_decided) {

+ return false;

+ }

+ target_page_bits = bits;

+ }

+#endif

+ return true;

+void finalize_target_page_bits(void)

+{

+#ifdef TARGET_PAGE_BITS_VARY

+ if (target_page_bits == 0) {

+ target_page_bits = TARGET_PAGE_BITS_MIN;

+ }

+ target_page_bits_decided = true;

+#endif

+}

diff --git a/exec.c b/exec.c

--- a/exec.c

+++ b/exec.c

@@ -XXX,XX +XXX,XX @@ AddressSpace address_space_memory;

static MemoryRegion io_mem_unassigned;

-#ifdef TARGET_PAGE_BITS_VARY

-int target_page_bits;

-bool target_page_bits_decided;

-#endif

-

CPUTailQ cpus = QTAILQ_HEAD_INITIALIZER(cpus);

/* current CPU in the current thread. It is only valid inside

@@ -XXX,XX +XXX,XX @@ int use_icount;

uintptr_t qemu_host_page_size;

intptr_t qemu_host_page_mask;

-bool set_preferred_target_page_bits(int bits)

-{

- /* The target page size is the lowest common denominator for all

- * the CPUs in the system, so we can only make it smaller, never

- * larger. And we can't make it smaller once we've committed to

- * a particular size.

- */

-#ifdef TARGET_PAGE_BITS_VARY

- assert(bits >= TARGET_PAGE_BITS_MIN);

- if (target_page_bits == 0 || target_page_bits > bits) {

- if (target_page_bits_decided) {

- return false;

- }

- target_page_bits = bits;

- }

-#endif

- return true;

-}

-

#if !defined(CONFIG_USER_ONLY)

-static void finalize_target_page_bits(void)

-{

-#ifdef TARGET_PAGE_BITS_VARY

- if (target_page_bits == 0) {

- target_page_bits = TARGET_PAGE_BITS_MIN;

- }

- target_page_bits_decided = true;

-#endif

-}

-

typedef struct PhysPageEntry PhysPageEntry;

struct PhysPageEntry {

2.17.1

Using uintptr_t instead of target_ulong meant that, for 64-bit guest

and 32-bit host, we truncated the guest address comparator and so may

not hit the tlb when we should.

Fixes: 4811e9095c0

Reviewed-by: David Hildenbrand <david@redhat.com>

accel/tcg/cputlb.c | 2 +-

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c

--- a/accel/tcg/cputlb.c

+++ b/accel/tcg/cputlb.c

@@ -XXX,XX +XXX,XX @@ void *tlb_vaddr_to_host(CPUArchState *env, abi_ptr addr,

MMUAccessType access_type, int mmu_idx)

{

CPUTLBEntry *entry = tlb_entry(env, mmu_idx, addr);

- uintptr_t tlb_addr, page;

+ target_ulong tlb_addr, page;

size_t elt_ofs;

switch (access_type) {

2.17.1

Since 2ac01d6dafab, this function does only two things: assert a

lock is held, and call tcg_tb_alloc. It is used exactly once,

and its user has already done the assert.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Clement Deschamps <clement.deschamps@greensocs.com>

accel/tcg/translate-all.c | 20 ++------------------

1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c

--- a/accel/tcg/translate-all.c

+++ b/accel/tcg/translate-all.c

@@ -XXX,XX +XXX,XX @@ void tcg_exec_init(unsigned long tb_size)

#endif

}

-/*

- * Allocate a new translation block. Flush the translation buffer if

- * too many translation blocks or too much generated code.

- */

-static TranslationBlock *tb_alloc(target_ulong pc)

-{

- TranslationBlock *tb;

-

- assert_memory_lock();

-

- tb = tcg_tb_alloc(tcg_ctx);

- if (unlikely(tb == NULL)) {

- return NULL;

- }

- return tb;

-}

-

/* call with @p->lock held */

static inline void invalidate_page_bitmap(PageDesc *p)

{

@@ -XXX,XX +XXX,XX @@ TranslationBlock *tb_gen_code(CPUState *cpu,

TCGProfile *prof = &tcg_ctx->prof;

int64_t ti;

#endif

+

assert_memory_lock();

phys_pc = get_page_addr_code(env, pc);

@@ -XXX,XX +XXX,XX @@ TranslationBlock *tb_gen_code(CPUState *cpu,

}

buffer_overflow:

- tb = tb_alloc(pc);

+ tb = tcg_tb_alloc(tcg_ctx);

if (unlikely(!tb)) {

/* flush must be done */

tb_flush(cpu);

2.17.1

From: Alex Bennée <alex.bennee@linaro.org>

We document this in docs/devel/load-stores.rst so lets follow it. The

32 bit and 64 bit access functions have historically not included the

sign so we leave those as is. We also introduce some signed helpers

which are used for loading immediate values in the translator.

Fixes: 282dffc8

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20191021150910.23216-1-alex.bennee@linaro.org>

include/exec/cpu_ldst_template.h | 4 ++--

tcg/tcg.h | 20 ++++++++++++++------

accel/tcg/cputlb.c | 24 +++++++++++++++++++++---

target/cris/translate_v10.inc.c | 3 +--

4 files changed, 38 insertions(+), 13 deletions(-)

diff --git a/include/exec/cpu_ldst_template.h b/include/exec/cpu_ldst_template.h

--- a/include/exec/cpu_ldst_template.h

+++ b/include/exec/cpu_ldst_template.h

#ifdef SOFTMMU_CODE_ACCESS

#define ADDR_READ addr_code

#define MMUSUFFIX _cmmu

-#define URETSUFFIX SUFFIX

-#define SRETSUFFIX SUFFIX

+#define URETSUFFIX USUFFIX

+#define SRETSUFFIX glue(s, SUFFIX)

#else

#define ADDR_READ addr_read

#define MMUSUFFIX _mmu

diff --git a/tcg/tcg.h b/tcg/tcg.h

index XXXXXXX..XXXXXXX 100644

--- a/tcg/tcg.h

+++ b/tcg/tcg.h

@@ -XXX,XX +XXX,XX @@ void helper_be_stl_mmu(CPUArchState *env, target_ulong addr, uint32_t val,

void helper_be_stq_mmu(CPUArchState *env, target_ulong addr, uint64_t val,

TCGMemOpIdx oi, uintptr_t retaddr);

-uint8_t helper_ret_ldb_cmmu(CPUArchState *env, target_ulong addr,

+uint8_t helper_ret_ldub_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr);

-uint16_t helper_le_ldw_cmmu(CPUArchState *env, target_ulong addr,

+int8_t helper_ret_ldsb_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr);

+uint16_t helper_le_lduw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr);

+int16_t helper_le_ldsw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr);

uint32_t helper_le_ldl_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr);

uint64_t helper_le_ldq_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr);

-uint16_t helper_be_ldw_cmmu(CPUArchState *env, target_ulong addr,

- TCGMemOpIdx oi, uintptr_t retaddr);

+uint16_t helper_be_lduw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr);

+int16_t helper_be_ldsw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr);

uint32_t helper_be_ldl_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr);

uint64_t helper_be_ldq_cmmu(CPUArchState *env, target_ulong addr,

@@ -XXX,XX +XXX,XX @@ uint64_t helper_be_ldq_cmmu(CPUArchState *env, target_ulong addr,

# define helper_ret_stw_mmu helper_be_stw_mmu

# define helper_ret_stl_mmu helper_be_stl_mmu

# define helper_ret_stq_mmu helper_be_stq_mmu

-# define helper_ret_ldw_cmmu helper_be_ldw_cmmu

+# define helper_ret_lduw_cmmu helper_be_lduw_cmmu

+# define helper_ret_ldsw_cmmu helper_be_ldsw_cmmu

# define helper_ret_ldl_cmmu helper_be_ldl_cmmu

# define helper_ret_ldq_cmmu helper_be_ldq_cmmu

#else

@@ -XXX,XX +XXX,XX @@ uint64_t helper_be_ldq_cmmu(CPUArchState *env, target_ulong addr,

# define helper_ret_stw_mmu helper_le_stw_mmu

# define helper_ret_stl_mmu helper_le_stl_mmu

# define helper_ret_stq_mmu helper_le_stq_mmu

-# define helper_ret_ldw_cmmu helper_le_ldw_cmmu

+# define helper_ret_lduw_cmmu helper_le_lduw_cmmu

+# define helper_ret_ldsw_cmmu helper_le_ldsw_cmmu

# define helper_ret_ldl_cmmu helper_le_ldl_cmmu

# define helper_ret_ldq_cmmu helper_le_ldq_cmmu

#endif

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c

index XXXXXXX..XXXXXXX 100644

--- a/accel/tcg/cputlb.c

+++ b/accel/tcg/cputlb.c

@@ -XXX,XX +XXX,XX @@ static uint64_t full_ldub_cmmu(CPUArchState *env, target_ulong addr,

return load_helper(env, addr, oi, retaddr, MO_8, true, full_ldub_cmmu);

-uint8_t helper_ret_ldb_cmmu(CPUArchState *env, target_ulong addr,

+uint8_t helper_ret_ldub_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

return full_ldub_cmmu(env, addr, oi, retaddr);

+int8_t helper_ret_ldsb_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr)

+{

+ return (int8_t) full_ldub_cmmu(env, addr, oi, retaddr);

+}

+

static uint64_t full_le_lduw_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

@@ -XXX,XX +XXX,XX @@ static uint64_t full_le_lduw_cmmu(CPUArchState *env, target_ulong addr,

full_le_lduw_cmmu);

}

-uint16_t helper_le_ldw_cmmu(CPUArchState *env, target_ulong addr,

+uint16_t helper_le_lduw_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

return full_le_lduw_cmmu(env, addr, oi, retaddr);

}

+int16_t helper_le_ldsw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr)

+{

+ return (int16_t) full_le_lduw_cmmu(env, addr, oi, retaddr);

+}

+

static uint64_t full_be_lduw_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

@@ -XXX,XX +XXX,XX @@ static uint64_t full_be_lduw_cmmu(CPUArchState *env, target_ulong addr,

full_be_lduw_cmmu);

}

-uint16_t helper_be_ldw_cmmu(CPUArchState *env, target_ulong addr,

+uint16_t helper_be_lduw_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

return full_be_lduw_cmmu(env, addr, oi, retaddr);

}

+int16_t helper_be_ldsw_cmmu(CPUArchState *env, target_ulong addr,

+ TCGMemOpIdx oi, uintptr_t retaddr)

+{

+ return (int16_t) full_be_lduw_cmmu(env, addr, oi, retaddr);

+}

+

static uint64_t full_le_ldul_cmmu(CPUArchState *env, target_ulong addr,

TCGMemOpIdx oi, uintptr_t retaddr)

{

diff --git a/target/cris/translate_v10.inc.c b/target/cris/translate_v10.inc.c

index XXXXXXX..XXXXXXX 100644

--- a/target/cris/translate_v10.inc.c

+++ b/target/cris/translate_v10.inc.c

@@ -XXX,XX +XXX,XX @@ static unsigned int dec10_ind(CPUCRISState *env, DisasContext *dc)

case CRISV10_IND_BCC_M:

cris_cc_mask(dc, 0);

- imm = cpu_ldsw_code(env, dc->pc + 2);

- simm = (int16_t)imm;

+ simm = cpu_ldsw_code(env, dc->pc + 2);

simm += 4;

LOG_DIS("bcc_m: b%s %x\n", cc_name(dc->cond), dc->pc + simm);

2.17.1