[v3] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

[PATCH v3 03/33] sysbus: remove outdated comment

Marc-André Lureau posted 33 patches 6 years, 3 months ago

Diff against v2 v4 v5 v6
Download mbox

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Paolo Bonzini <pbonzini@redhat.com>, Jason Wang <jasowang@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Paul Burton <pburton@wavecomp.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, KONRAD Frederic <frederic.konrad@adacore.com>, Peter Maydell <peter.maydell@linaro.org>, Corey Minyard <cminyard@mvista.com>, Richard Henderson <rth@twiddle.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Magnus Damm <magnus.damm@gmail.com>, BALATON Zoltan <balaton@eik.bme.hu>, Fabien Chouteau <chouteau@adacore.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Hervé Poussineau" <hpoussin@reactos.org>, Eduardo Habkost <ehabkost@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

There is a newer version of this series

Expand all Fold all

[PATCH v3 03/33] sysbus: remove outdated comment

Posted by Marc-André Lureau 6 years, 3 months ago

The init callback is no more since commit
817a17fc60f44e29a1944b60d32f45ea127f0cf9 ("core/sysbus: remove the
SysBusDeviceClass::init path")

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 include/hw/sysbus.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index 2eb0484388..c4a1c0adfa 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -24,10 +24,6 @@ typedef struct SysBusDevice SysBusDevice;
 
 /**
  * SysBusDeviceClass:
- * @init: Callback function invoked when the #DeviceState.realized property
- * is changed to %true. Deprecated, new types inheriting directly from
- * TYPE_SYS_BUS_DEVICE should use #DeviceClass.realize instead, new leaf
- * types should consult their respective parent type.
  *
  * SysBusDeviceClass is not overriding #DeviceClass.realize, so derived
  * classes overriding it are not required to invoke its implementation.
-- 
2.23.0.606.g08da6496b6

Re: [PATCH v3 03/33] sysbus: remove outdated comment

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

On 10/23/19 7:31 PM, Marc-André Lureau wrote:
> The init callback is no more since commit
> 817a17fc60f44e29a1944b60d32f45ea127f0cf9 ("core/sysbus: remove the
> SysBusDeviceClass::init path")
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   include/hw/sysbus.h | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
> index 2eb0484388..c4a1c0adfa 100644
> --- a/include/hw/sysbus.h
> +++ b/include/hw/sysbus.h
> @@ -24,10 +24,6 @@ typedef struct SysBusDevice SysBusDevice;
>   
>   /**
>    * SysBusDeviceClass:
> - * @init: Callback function invoked when the #DeviceState.realized property
> - * is changed to %true. Deprecated, new types inheriting directly from
> - * TYPE_SYS_BUS_DEVICE should use #DeviceClass.realize instead, new leaf
> - * types should consult their respective parent type.
>    *
>    * SysBusDeviceClass is not overriding #DeviceClass.realize, so derived
>    * classes overriding it are not required to invoke its implementation.
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>