On Wed, Oct 23, 2019 at 11:04:09AM +0100, Stefan Hajnoczi wrote:
> v4:
> * Introduce bool d->features_negotiated so that tests can negotiate a
> 0 feature bit set in Legacy mode [Thomas]
> * Make the FEATURES_OK code change in qvirtio_set_driver_ok() clearer and
> mention it in the commit description [Thomas]
> * Fix indentation in qvring_init() [Thomas]
> v3:
> * Now implements VIRTIO 1.0 fully (vring, device initialization).
> This required several new patches to address the following issues:
> 1. Tests that do not negotiate features (non-compliant!)
> 2. Tests that access configuration space before feature negotiation
> (non-compliant!)
> 3. Tests that set up virtqueues before feature negotiation (non-compliant!)
> 4. vring accesses require byte-swapping when VIRTIO 1.0 is used with a
> big-endian guest because the qtest_readX/writeX() API automatically
> converts to guest-endian
> 5. VIRTIO 1.0 has an additional FEATURES_OK step during Device
> Initialization
> * Change uint8_t bar_idx to int [Thomas]
> * Document qpci_find_capability() [Thomas]
> * Every commit tested with arm, ppc64, and x86_64 targets using:
> git rebase -i origin/master -x 'make tests/qos-test &&
> QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/qos-test &&
> QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qos-test'
> QTEST_QEMU_BINARY=arm-softmmu/qemu-system-arm tests/qos-test'
> v2:
> * Fix checkpatch.pl issues, except MAINTAINERS file warning. libqos already
> has maintainers and the new virtio-pci-modern.[ch] files don't need extra
> entries since they are already covered by the existing libqos/ entry.
>
> New VIRTIO devices are Non-Transitional. This means they only expose the
> VIRTIO 1.0 interface, not the Legacy interface.
>
> The libqos only supports Legacy and Transitional devices (in Legacy mode).
> This patch series adds VIRTIO 1.0 support so that tests can run against
> Non-Transitional devices too.
Very nice, thanks!
I'll queue this up in my tree.
> The virtio-fs device is Non-Transitional, so this is a prerequisite for
> virtio-fs qos tests.
>
> Stefan Hajnoczi (16):
> tests/virtio-blk-test: read config space after feature negotiation
> libqos: read QVIRTIO_MMIO_VERSION register
> libqos: extend feature bits to 64-bit
> virtio-scsi-test: add missing feature negotiation
> tests/virtio-blk-test: set up virtqueue after feature negotiation
> libqos: add missing virtio-9p feature negotiation
> libqos: enforce Device Initialization order
> libqos: implement VIRTIO 1.0 FEATURES_OK step
> libqos: access VIRTIO 1.0 vring in little-endian
> libqos: add iteration support to qpci_find_capability()
> libqos: pass full QVirtQueue to set_queue_address()
> libqos: add MSI-X callbacks to QVirtioPCIDevice
> libqos: expose common virtqueue setup/cleanup functions
> libqos: make the virtio-pci BAR index configurable
> libqos: extract Legacy virtio-pci.c code
> libqos: add VIRTIO PCI 1.0 support
>
> tests/Makefile.include | 1 +
> tests/libqos/pci.h | 2 +-
> tests/libqos/virtio-mmio.h | 1 +
> tests/libqos/virtio-pci-modern.h | 17 ++
> tests/libqos/virtio-pci.h | 34 ++-
> tests/libqos/virtio.h | 19 +-
> tests/libqos/pci.c | 30 ++-
> tests/libqos/virtio-9p.c | 6 +
> tests/libqos/virtio-mmio.c | 38 ++-
> tests/libqos/virtio-net.c | 6 +-
> tests/libqos/virtio-pci-modern.c | 443 +++++++++++++++++++++++++++++++
> tests/libqos/virtio-pci.c | 105 +++++---
> tests/libqos/virtio.c | 160 ++++++++---
> tests/virtio-blk-test.c | 66 +++--
> tests/virtio-scsi-test.c | 8 +
> 15 files changed, 802 insertions(+), 134 deletions(-)
> create mode 100644 tests/libqos/virtio-pci-modern.h
> create mode 100644 tests/libqos/virtio-pci-modern.c
>
> --
> 2.21.0