audio: fix missing break

[PATCH] audio: fix missing break

Paolo Bonzini posted 1 patch 4 years, 5 months ago

Download mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191023082431.30780-1-pbonzini@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

audio/paaudio.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] audio: fix missing break

Posted by Paolo Bonzini 4 years, 5 months ago

Reported by Coverity (CID 1406449).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 audio/paaudio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/audio/paaudio.c b/audio/paaudio.c
index df541a72d3..55a91f8980 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -385,6 +385,7 @@ static pa_stream *qpa_simple_new (
         map.map[5] = PA_CHANNEL_POSITION_REAR_RIGHT;
         map.map[6] = PA_CHANNEL_POSITION_SIDE_LEFT;
         map.map[7] = PA_CHANNEL_POSITION_SIDE_RIGHT;
+        break;
 
     default:
         dolog("Internal error: unsupported channel count %d\n", ss->channels);
-- 
2.21.0

Re: [PATCH] audio: fix missing break

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

On 10/23/19 10:24 AM, Paolo Bonzini wrote:
> Reported by Coverity (CID 1406449).

Gerd sent the same patch earlier:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg05923.html

But your description is better.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   audio/paaudio.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/audio/paaudio.c b/audio/paaudio.c
> index df541a72d3..55a91f8980 100644
> --- a/audio/paaudio.c
> +++ b/audio/paaudio.c
> @@ -385,6 +385,7 @@ static pa_stream *qpa_simple_new (
>           map.map[5] = PA_CHANNEL_POSITION_REAR_RIGHT;
>           map.map[6] = PA_CHANNEL_POSITION_SIDE_LEFT;
>           map.map[7] = PA_CHANNEL_POSITION_SIDE_RIGHT;
> +        break;
>   
>       default:
>           dolog("Internal error: unsupported channel count %d\n", ss->channels);
>