[PATCH v1 16/19] iotests: Test 183 does not work on macOS and OpenBSD

Alex Bennée posted 19 patches 6 years, 3 months ago
Maintainers: Fam Zheng <fam@euphon.net>, Max Reitz <mreitz@redhat.com>, Brad Smith <brad@comstyle.com>, Kamil Rytarowski <kamil@netbsd.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Kevin Wolf <kwolf@redhat.com>
[PATCH v1 16/19] iotests: Test 183 does not work on macOS and OpenBSD
Posted by Alex Bennée 6 years, 3 months ago
From: Thomas Huth <thuth@redhat.com>

In the long term, we might want to add test 183 to the "auto" group
(but it still fails occasionally, so we cannot do that yet). However,
when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd
target, it currently always fails with an "Timeout waiting for return
on handle 0" error.

Let's mark it as supported only on systems where the test is working
fine (i.e. Linux, FreeBSD and NetBSD).

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20191022072135.11188-4-thuth@redhat.com>
---
 tests/qemu-iotests/183 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183
index 04fb344d08e..ab5a7089549 100755
--- a/tests/qemu-iotests/183
+++ b/tests/qemu-iotests/183
@@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 . ./common.filter
 . ./common.qemu
 
+_supported_os Linux FreeBSD NetBSD
 _supported_fmt qcow2 raw qed quorum
 _supported_proto file
 
-- 
2.20.1


Re: [PATCH v1 16/19] iotests: Test 183 does not work on macOS and OpenBSD
Posted by Philippe Mathieu-Daudé 6 years, 3 months ago
On 10/22/19 9:17 PM, Alex Bennée wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> In the long term, we might want to add test 183 to the "auto" group
> (but it still fails occasionally, so we cannot do that yet). However,
> when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd
> target, it currently always fails with an "Timeout waiting for return
> on handle 0" error.
> 
> Let's mark it as supported only on systems where the test is working
> fine (i.e. Linux, FreeBSD and NetBSD).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20191022072135.11188-4-thuth@redhat.com>
> ---
>   tests/qemu-iotests/183 | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183
> index 04fb344d08e..ab5a7089549 100755
> --- a/tests/qemu-iotests/183
> +++ b/tests/qemu-iotests/183
> @@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   . ./common.filter
>   . ./common.qemu
>   
> +_supported_os Linux FreeBSD NetBSD
>   _supported_fmt qcow2 raw qed quorum
>   _supported_proto file
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>