testing/next before softfreeze

[PATCH v1 15/19] iotests: Test 041 only works on certain systems

Posted by Alex Bennée 6 years, 3 months ago

From: Thomas Huth <thuth@redhat.com>

041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS.
Let's mark it as only supported on the systems where we know that it is
working fine.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20191022072135.11188-3-thuth@redhat.com>
---
 tests/qemu-iotests/041 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 8568426311e..0326888c980 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -1123,4 +1123,5 @@ class TestOrphanedSource(iotests.QMPTestCase):
 
 if __name__ == '__main__':
     iotests.main(supported_fmts=['qcow2', 'qed'],
-                 supported_protocols=['file'])
+                 supported_protocols=['file'],
+                 supported_platforms=['linux', 'freebsd', 'netbsd', 'openbsd'])
-- 
2.20.1

Re: [PATCH v1 15/19] iotests: Test 041 only works on certain systems

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

On 10/22/19 9:17 PM, Alex Bennée wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> 041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS.
> Let's mark it as only supported on the systems where we know that it is
> working fine.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20191022072135.11188-3-thuth@redhat.com>
> ---
>   tests/qemu-iotests/041 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index 8568426311e..0326888c980 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -1123,4 +1123,5 @@ class TestOrphanedSource(iotests.QMPTestCase):
>   
>   if __name__ == '__main__':
>       iotests.main(supported_fmts=['qcow2', 'qed'],
> -                 supported_protocols=['file'])
> +                 supported_protocols=['file'],
> +                 supported_platforms=['linux', 'freebsd', 'netbsd', 'openbsd'])
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>