hw/i386/pc.c | 36 +++++++++++++++++++++++++++++++++++- hw/i386/pc_piix.c | 23 ++--------------------- hw/i386/pc_q35.c | 28 ++++------------------------ include/hw/i386/pc.h | 3 ++- 4 files changed, 43 insertions(+), 47 deletions(-)
These are few patches extracted from the previous too big series: hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth), no logical changes: $ git backport-diff -u pc_split_i440fx_piix-v1 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/5:[----] [-C] 'hw/i386/pc: Extract pc_gsi_create()' 002/5:[----] [--] 'hw/i386/pc: Reduce gsi_handler scope' 003/5:[----] [--] 'hw/i386/pc: Move gsi_state creation code' 004/5:[----] [--] 'hw/i386/pc: Extract pc_i8259_create()' 005/5:[----] [--] 'hw/i386/pc: Remove kvm_i386.h include' Based-on: <20191018134754.16362-1-philmd@redhat.com> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge [v2] https://mid.mail-archive.com/20191018134754.16362-1-philmd@redhat.com Philippe Mathieu-Daudé (5): hw/i386/pc: Extract pc_gsi_create() hw/i386/pc: Reduce gsi_handler scope hw/i386/pc: Move gsi_state creation code hw/i386/pc: Extract pc_i8259_create() hw/i386/pc: Remove kvm_i386.h include hw/i386/pc.c | 36 +++++++++++++++++++++++++++++++++++- hw/i386/pc_piix.c | 23 ++--------------------- hw/i386/pc_q35.c | 28 ++++------------------------ include/hw/i386/pc.h | 3 ++- 4 files changed, 43 insertions(+), 47 deletions(-) -- 2.21.0
On 18/10/19 15:59, Philippe Mathieu-Daudé wrote: > These are few patches extracted from the previous too big series: > hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html > > Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth), > no logical changes: I queued this, but neither I nor patchew got patch 5. I just got it from the PIIX3/i440FX series. paolo > $ git backport-diff -u pc_split_i440fx_piix-v1 > Key: > [----] : patches are identical > [####] : number of functional differences between upstream/downstream patch > [down] : patch is downstream-only > The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively > > 001/5:[----] [-C] 'hw/i386/pc: Extract pc_gsi_create()' > 002/5:[----] [--] 'hw/i386/pc: Reduce gsi_handler scope' > 003/5:[----] [--] 'hw/i386/pc: Move gsi_state creation code' > 004/5:[----] [--] 'hw/i386/pc: Extract pc_i8259_create()' > 005/5:[----] [--] 'hw/i386/pc: Remove kvm_i386.h include' > > Based-on: <20191018134754.16362-1-philmd@redhat.com> > hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge [v2] > https://mid.mail-archive.com/20191018134754.16362-1-philmd@redhat.com > > Philippe Mathieu-Daudé (5): > hw/i386/pc: Extract pc_gsi_create() > hw/i386/pc: Reduce gsi_handler scope > hw/i386/pc: Move gsi_state creation code > hw/i386/pc: Extract pc_i8259_create() > hw/i386/pc: Remove kvm_i386.h include > > hw/i386/pc.c | 36 +++++++++++++++++++++++++++++++++++- > hw/i386/pc_piix.c | 23 ++--------------------- > hw/i386/pc_q35.c | 28 ++++------------------------ > include/hw/i386/pc.h | 3 ++- > 4 files changed, 43 insertions(+), 47 deletions(-) >
On 10/22/19 6:55 PM, Paolo Bonzini wrote: > On 18/10/19 15:59, Philippe Mathieu-Daudé wrote: >> These are few patches extracted from the previous too big series: >> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html >> >> Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth), >> no logical changes: > > I queued this, but neither I nor patchew got patch 5. I just got it > from the PIIX3/i440FX series. Odd... Yes this is the same patch resent with no change. Thanks for noticing this and carrying about finding it! > > paolo > >> $ git backport-diff -u pc_split_i440fx_piix-v1 >> Key: >> [----] : patches are identical >> [####] : number of functional differences between upstream/downstream patch >> [down] : patch is downstream-only >> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively >> >> 001/5:[----] [-C] 'hw/i386/pc: Extract pc_gsi_create()' >> 002/5:[----] [--] 'hw/i386/pc: Reduce gsi_handler scope' >> 003/5:[----] [--] 'hw/i386/pc: Move gsi_state creation code' >> 004/5:[----] [--] 'hw/i386/pc: Extract pc_i8259_create()' >> 005/5:[----] [--] 'hw/i386/pc: Remove kvm_i386.h include' >> >> Based-on: <20191018134754.16362-1-philmd@redhat.com> >> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge [v2] >> https://mid.mail-archive.com/20191018134754.16362-1-philmd@redhat.com >> >> Philippe Mathieu-Daudé (5): >> hw/i386/pc: Extract pc_gsi_create() >> hw/i386/pc: Reduce gsi_handler scope >> hw/i386/pc: Move gsi_state creation code >> hw/i386/pc: Extract pc_i8259_create() >> hw/i386/pc: Remove kvm_i386.h include >> >> hw/i386/pc.c | 36 +++++++++++++++++++++++++++++++++++- >> hw/i386/pc_piix.c | 23 ++--------------------- >> hw/i386/pc_q35.c | 28 ++++------------------------ >> include/hw/i386/pc.h | 3 ++- >> 4 files changed, 43 insertions(+), 47 deletions(-) >> >
Hi Paolo, On 10/22/19 7:32 PM, Philippe Mathieu-Daudé wrote: > On 10/22/19 6:55 PM, Paolo Bonzini wrote: >> On 18/10/19 15:59, Philippe Mathieu-Daudé wrote: >>> These are few patches extracted from the previous too big series: >>> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge >>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html >>> >>> Dropped "Move kvm_i8259_init() declaration to sysemu/kvm.h" (thuth), >>> no logical changes: >> >> I queued this, but neither I nor patchew got patch 5. I just got it >> from the PIIX3/i440FX series. In the patch 'hw/i386: Introduce the microvm machine type' Sergio uses gsi_handler(), so you need to drop 'hw/i386/pc: Reduce gsi_handler scope' to keep microvm building. > Odd... Yes this is the same patch resent with no change. Thanks for > noticing this and carrying about finding it! > >> >> paolo >> >>> $ git backport-diff -u pc_split_i440fx_piix-v1 >>> Key: >>> [----] : patches are identical >>> [####] : number of functional differences between upstream/downstream >>> patch >>> [down] : patch is downstream-only >>> The flags [FC] indicate (F)unctional and (C)ontextual differences, >>> respectively >>> >>> 001/5:[----] [-C] 'hw/i386/pc: Extract pc_gsi_create()' >>> 002/5:[----] [--] 'hw/i386/pc: Reduce gsi_handler scope' >>> 003/5:[----] [--] 'hw/i386/pc: Move gsi_state creation code' >>> 004/5:[----] [--] 'hw/i386/pc: Extract pc_i8259_create()' >>> 005/5:[----] [--] 'hw/i386/pc: Remove kvm_i386.h include' >>> >>> Based-on: <20191018134754.16362-1-philmd@redhat.com> >>> hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge [v2] >>> https://mid.mail-archive.com/20191018134754.16362-1-philmd@redhat.com >>> >>> Philippe Mathieu-Daudé (5): >>> hw/i386/pc: Extract pc_gsi_create() >>> hw/i386/pc: Reduce gsi_handler scope >>> hw/i386/pc: Move gsi_state creation code >>> hw/i386/pc: Extract pc_i8259_create() >>> hw/i386/pc: Remove kvm_i386.h include >>> >>> hw/i386/pc.c | 36 +++++++++++++++++++++++++++++++++++- >>> hw/i386/pc_piix.c | 23 ++--------------------- >>> hw/i386/pc_q35.c | 28 ++++------------------------ >>> include/hw/i386/pc.h | 3 ++- >>> 4 files changed, 43 insertions(+), 47 deletions(-) >>> >>
On 26/10/19 16:55, Philippe Mathieu-Daudé wrote: > In the patch 'hw/i386: Introduce the microvm machine type' > Sergio uses gsi_handler(), so you need to drop 'hw/i386/pc: > Reduce gsi_handler scope' to keep microvm building. Indeed, and I also have patches on top to move those out of pc.c (otherwise you cannot build CONFIG_MICROVM without either i440fx or q35). Paolo
© 2016 - 2025 Red Hat, Inc.