image-fuzzer: Port to Python 3

[PATCH 02/10] image-fuzzer: Write bytes instead of string to image file

Posted by Eduardo Habkost 6 years, 3 months ago

This is necessary for Python 3 compatibility.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/image-fuzzer/qcow2/layout.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
index c57418fa15..fe273d4143 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -518,7 +518,7 @@ class Image(object):
         rounded = (size + self.cluster_size - 1) & ~(self.cluster_size - 1)
         if rounded > size:
             image_file.seek(rounded - 1)
-            image_file.write("\0")
+            image_file.write(b'\x00')
         image_file.close()
 
     @staticmethod
-- 
2.21.0

Re: [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

On 10/16/19 9:24 PM, Eduardo Habkost wrote:
> This is necessary for Python 3 compatibility.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   tests/image-fuzzer/qcow2/layout.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
> index c57418fa15..fe273d4143 100644
> --- a/tests/image-fuzzer/qcow2/layout.py
> +++ b/tests/image-fuzzer/qcow2/layout.py
> @@ -518,7 +518,7 @@ class Image(object):
>           rounded = (size + self.cluster_size - 1) & ~(self.cluster_size - 1)
>           if rounded > size:
>               image_file.seek(rounded - 1)
> -            image_file.write("\0")
> +            image_file.write(b'\x00')
>           image_file.close()
>   
>       @staticmethod
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>