blockdev: Use error_report() in hmp_commit()

[PATCH] blockdev: Use error_report() in hmp_commit()

Kevin Wolf posted 1 patch 4 years, 6 months ago

Download mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191015123932.12214-1-kwolf@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>

blockdev.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH] blockdev: Use error_report() in hmp_commit()

Posted by Kevin Wolf 4 years, 6 months ago

Instead of using monitor_printf() to report errors, hmp_commit() should
use error_report() like other places do.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index f89e48fc79..e2358966c3 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1088,11 +1088,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict)
 
         blk = blk_by_name(device);
         if (!blk) {
-            monitor_printf(mon, "Device '%s' not found\n", device);
+            error_report("Device '%s' not found", device);
             return;
         }
         if (!blk_is_available(blk)) {
-            monitor_printf(mon, "Device '%s' has no medium\n", device);
+            error_report("Device '%s' has no medium", device);
             return;
         }
 
@@ -1105,8 +1105,7 @@ void hmp_commit(Monitor *mon, const QDict *qdict)
         aio_context_release(aio_context);
     }
     if (ret < 0) {
-        monitor_printf(mon, "'commit' error for '%s': %s\n", device,
-                       strerror(-ret));
+        error_report("'commit' error for '%s': %s", device, strerror(-ret));
     }
 }
 
-- 
2.20.1

Re: [PATCH] blockdev: Use error_report() in hmp_commit()

Posted by Philippe Mathieu-Daudé 4 years, 6 months ago

On 10/15/19 2:39 PM, Kevin Wolf wrote:
> Instead of using monitor_printf() to report errors, hmp_commit() should
> use error_report() like other places do.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   blockdev.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/blockdev.c b/blockdev.c
> index f89e48fc79..e2358966c3 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1088,11 +1088,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict)
>   
>           blk = blk_by_name(device);
>           if (!blk) {
> -            monitor_printf(mon, "Device '%s' not found\n", device);
> +            error_report("Device '%s' not found", device);
>               return;
>           }
>           if (!blk_is_available(blk)) {
> -            monitor_printf(mon, "Device '%s' has no medium\n", device);
> +            error_report("Device '%s' has no medium", device);
>               return;
>           }
>   
> @@ -1105,8 +1105,7 @@ void hmp_commit(Monitor *mon, const QDict *qdict)
>           aio_context_release(aio_context);
>       }
>       if (ret < 0) {
> -        monitor_printf(mon, "'commit' error for '%s': %s\n", device,
> -                       strerror(-ret));
> +        error_report("'commit' error for '%s': %s", device, strerror(-ret));
>       }
>   }
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] blockdev: Use error_report() in hmp_commit()

Posted by Eric Blake 4 years, 6 months ago

On 10/15/19 7:39 AM, Kevin Wolf wrote:
> Instead of using monitor_printf() to report errors, hmp_commit() should
> use error_report() like other places do.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   blockdev.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org