[PULL v2 00/19] Bitmaps patches

John Snow posted 19 patches 4 years, 6 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191014192909.16044-1-jsnow@redhat.com
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Juan Quintela <quintela@redhat.com>, John Snow <jsnow@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>
There is a newer version of this series
qemu-deprecated.texi           |  20 ++-
qapi/block-core.json           |   6 +-
block/qcow2.h                  |  19 +--
include/block/block.h          |   2 +-
include/block/block_int.h      |  20 +--
include/block/dirty-bitmap.h   |  34 ++--
include/qemu/hbitmap.h         |   5 +
block.c                        |  79 +++------
block/backup.c                 |   8 +-
block/block-copy.c             |   2 +-
block/dirty-bitmap.c           | 290 +++++++++++++++++++--------------
block/mirror.c                 |   4 +-
block/qcow2-bitmap.c           | 212 +++++++++++++++---------
block/qcow2.c                  |  22 ++-
blockdev.c                     |  40 ++---
migration/block-dirty-bitmap.c |  11 +-
migration/block.c              |   4 +-
tests/test-hbitmap.c           |   2 +-
util/hbitmap.c                 |   4 +
MAINTAINERS                    |   3 +-
tests/qemu-iotests/165         |  57 ++++++-
tests/qemu-iotests/165.out     |   4 +-
tests/qemu-iotests/260         |  89 ++++++++++
tests/qemu-iotests/260.out     |  52 ++++++
tests/qemu-iotests/group       |   1 +
25 files changed, 623 insertions(+), 367 deletions(-)
create mode 100755 tests/qemu-iotests/260
create mode 100644 tests/qemu-iotests/260.out
[PULL v2 00/19] Bitmaps patches
Posted by John Snow 4 years, 6 months ago
The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35:

  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 16:09:52 +0100)

are available in the Git repository at:

  https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request

for you to fetch changes up to b2ca29ee390743c42a6062d44ee3b10fb51f9fa6:

  dirty-bitmaps: remove deprecated autoload parameter (2019-10-14 15:28:17 -0400)

----------------------------------------------------------------
Pull request

----------------------------------------------------------------

John Snow (2):
  MAINTAINERS: Add Vladimir as a reviewer for bitmaps
  dirty-bitmaps: remove deprecated autoload parameter

Vladimir Sementsov-Ogievskiy (17):
  util/hbitmap: strict hbitmap_reset
  block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c
  block/dirty-bitmap: return int from
    bdrv_remove_persistent_dirty_bitmap
  block/qcow2: proper locking on bitmap add/remove paths
  block/dirty-bitmap: drop meta
  block/dirty-bitmap: add bs link
  block/dirty-bitmap: drop BdrvDirtyBitmap.mutex
  block/dirty-bitmap: refactor bdrv_dirty_bitmap_next
  block: switch reopen queue from QSIMPLEQ to QTAILQ
  block: reverse order for reopen commits
  iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW
  block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
  block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()
  block/qcow2-bitmap: do not remove bitmaps on reopen-ro
  iotests: add test 260 to check bitmap life after snapshot + commit
  block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw
  qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit

 qemu-deprecated.texi           |  20 ++-
 qapi/block-core.json           |   6 +-
 block/qcow2.h                  |  19 +--
 include/block/block.h          |   2 +-
 include/block/block_int.h      |  20 +--
 include/block/dirty-bitmap.h   |  34 ++--
 include/qemu/hbitmap.h         |   5 +
 block.c                        |  79 +++------
 block/backup.c                 |   8 +-
 block/block-copy.c             |   2 +-
 block/dirty-bitmap.c           | 290 +++++++++++++++++++--------------
 block/mirror.c                 |   4 +-
 block/qcow2-bitmap.c           | 212 +++++++++++++++---------
 block/qcow2.c                  |  22 ++-
 blockdev.c                     |  40 ++---
 migration/block-dirty-bitmap.c |  11 +-
 migration/block.c              |   4 +-
 tests/test-hbitmap.c           |   2 +-
 util/hbitmap.c                 |   4 +
 MAINTAINERS                    |   3 +-
 tests/qemu-iotests/165         |  57 ++++++-
 tests/qemu-iotests/165.out     |   4 +-
 tests/qemu-iotests/260         |  89 ++++++++++
 tests/qemu-iotests/260.out     |  52 ++++++
 tests/qemu-iotests/group       |   1 +
 25 files changed, 623 insertions(+), 367 deletions(-)
 create mode 100755 tests/qemu-iotests/260
 create mode 100644 tests/qemu-iotests/260.out

-- 
2.21.0


Re: [libvirt] [PULL v2 00/19] Bitmaps patches
Posted by Peter Maydell 4 years, 6 months ago
On Mon, 14 Oct 2019 at 20:29, John Snow <jsnow@redhat.com> wrote:
>
> The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35:
>
>   Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 16:09:52 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
>
> for you to fetch changes up to b2ca29ee390743c42a6062d44ee3b10fb51f9fa6:
>
>   dirty-bitmaps: remove deprecated autoload parameter (2019-10-14 15:28:17 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------

Hi; this pullreq fails on some hosts on the newly added iotest 260
with an "AF_UNIX path too long" error:
https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04063.html

Max tells me that this is a known problem (a fix is in the works)
but that for the moment we've chosen not to add any python based
tests to the 'auto' group, so that this AF_UNIX issue doesn't
affect "make check". Could you respin the pullreq with the
new iotest(s?) not in the 'auto' group, please?

thanks
-- PMM

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [PULL v2 00/19] Bitmaps patches
Posted by John Snow 4 years, 6 months ago

On 10/17/19 7:07 AM, Peter Maydell wrote:
> On Mon, 14 Oct 2019 at 20:29, John Snow <jsnow@redhat.com> wrote:
>>
>> The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35:
>>
>>   Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 16:09:52 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
>>
>> for you to fetch changes up to b2ca29ee390743c42a6062d44ee3b10fb51f9fa6:
>>
>>   dirty-bitmaps: remove deprecated autoload parameter (2019-10-14 15:28:17 -0400)
>>
>> ----------------------------------------------------------------
>> Pull request
>>
>> ----------------------------------------------------------------
> 
> Hi; this pullreq fails on some hosts on the newly added iotest 260
> with an "AF_UNIX path too long" error:
> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04063.html
> 
> Max tells me that this is a known problem (a fix is in the works)
> but that for the moment we've chosen not to add any python based
> tests to the 'auto' group, so that this AF_UNIX issue doesn't
> affect "make check". Could you respin the pullreq with the
> new iotest(s?) not in the 'auto' group, please?
> 
> thanks
> -- PMM
> 

Anguish and turmoil.

Alright, V3 coming up.