[v3] mirror: Do not dereference invalid pointers

[PATCH v3 0/4] mirror: Do not dereference invalid pointers

Max Reitz posted 4 patches 4 years, 6 months ago

Diff against v1 v2
Download series mbox

Test asan passed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191014153931.20699-1-mreitz@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>, John Snow <jsnow@redhat.com>

qapi/block-core.json          | 14 +++++-
block/blkdebug.c              | 91 ++++++++++++++++++++++++++++++++++-
block/mirror.c                | 13 +++--
tests/qemu-iotests/041        | 44 +++++++++++++++++
tests/qemu-iotests/041.out    |  4 +-
tests/qemu-iotests/iotests.py | 18 ++++---
6 files changed, 170 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH v3 0/4] mirror: Do not dereference invalid pointers

Posted by Max Reitz 4 years, 6 months ago

Hi,

v2’s cover letter should explain everything:

https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01079.html


v3:
- Patch 2: Use input visitor as proposed by Vladimir

git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[----] [--] 'mirror: Do not dereference invalid pointers'
002/4:[0041] [FC] 'blkdebug: Allow taking/unsharing permissions'
003/4:[----] [--] 'iotests: Add @error to wait_until_completed'
004/4:[----] [--] 'iotests: Add test for failing mirror complete'


Max Reitz (4):
  mirror: Do not dereference invalid pointers
  blkdebug: Allow taking/unsharing permissions
  iotests: Add @error to wait_until_completed
  iotests: Add test for failing mirror complete

 qapi/block-core.json          | 14 +++++-
 block/blkdebug.c              | 91 ++++++++++++++++++++++++++++++++++-
 block/mirror.c                | 13 +++--
 tests/qemu-iotests/041        | 44 +++++++++++++++++
 tests/qemu-iotests/041.out    |  4 +-
 tests/qemu-iotests/iotests.py | 18 ++++---
 6 files changed, 170 insertions(+), 14 deletions(-)

-- 
2.21.0

Re: [PATCH v3 0/4] mirror: Do not dereference invalid pointers

Posted by Max Reitz 4 years, 5 months ago

On 14.10.19 17:39, Max Reitz wrote:
> Hi,
> 
> v2’s cover letter should explain everything:
> 
> https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01079.html
> 
> 
> v3:
> - Patch 2: Use input visitor as proposed by Vladimir
> 
> git-backport-diff against v2:
> 
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> 
> 001/4:[----] [--] 'mirror: Do not dereference invalid pointers'
> 002/4:[0041] [FC] 'blkdebug: Allow taking/unsharing permissions'
> 003/4:[----] [--] 'iotests: Add @error to wait_until_completed'
> 004/4:[----] [--] 'iotests: Add test for failing mirror complete'
> 
> 
> Max Reitz (4):
>   mirror: Do not dereference invalid pointers
>   blkdebug: Allow taking/unsharing permissions
>   iotests: Add @error to wait_until_completed
>   iotests: Add test for failing mirror complete

I’ve applied patch 1 to my block branch, and I’ll send a for-next series
(for-5.0, I suppose?) for the rest.

Max